Skip to content

Calculate pcp->high based on zone sizes and active CPUs

Mel Gorman linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 24 repliesIn review 4 of 6 applied
  2. v1 RFC6 patches 14 repliesSuperseded

Changes in v2 from the cover letter

o Clarification comments
o Sanity check pcp->high during reclaim (dhansen)
o Handle vm.percpu_pagelist_high_fraction in zone_highsize (hdanton)
o Sanity check pcp->batch versus pcp->high

Patches in v2 4 of 6 applied

#Subject and filesSizeRepliesApplied
1/6mm/page_alloc: Delete vm.percpu_pagelist_fractionDocumentation/admin-guide/sysctl/vm.rst include/linux/mmzone.h kernel/sysctl.c +1 more+4 -811 reply
2/6mm/page_alloc: Disassociate the pcp->high from pcp->batchmm/page_alloc.c+42 -183 repliesApplied
3/6mm/page_alloc: Adjust pcp->high after CPU hotplug eventsinclude/linux/cpuhotplug.h mm/internal.h mm/memory_hotplug.c +1 more+31 -151 replyApplied
4/6mm/page_alloc: Scale the number of pages that are batch freedinclude/linux/mmzone.h mm/page_alloc.c+41 -31 replyApplied
5/6mm/page_alloc: Limit the number of pages on PCP lists when reclaim is activeinclude/linux/mmzone.h mm/page_alloc.c mm/vmscan.c+54 -11 replyApplied
6/6mm/page_alloc: Introduce vm.percpu_pagelist_high_fractionDocumentation/admin-guide/sysctl/vm.rst include/linux/mmzone.h kernel/sysctl.c +1 more+93 -73 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDave HansenVlastimil Babka
SeriesA-b A-b
1/6A-b A-b
2/6A-b
3/6A-b
4/6A-b A-b
5/6A-b
6/6A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/6 v2] Calculate pcp->high based on zone sizes and active CPUs

Changelog since v1
o Clarification comments
o Sanity check pcp->high during reclaim (dhansen)
o Handle vm.percpu_pagelist_high_fraction in zone_highsize (hdanton)
o Sanity check pcp->batch versus pcp->high

This series has pre-requisites in mmotm so for convenience it is also available at

https://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git mm-pcpburst-v2r3

The per-cpu page allocator (PCP) is meant to reduce contention on the zone lock but the sizing of batch and high is archaic and neither takes the zone size into account or the number of CPUs local to a zone. With larger zones and more CPUs per node, the contention is getting worse. Furthermore, the fact that vm.percpu_pagelist_fraction adjusts both batch and high values means that the sysctl can reduce zone lock contention but also increase allocation latencies.

This series disassociates pcp->high from pcp->batch and then scales pcp->high based on the size of the local zone with limited impact to reclaim and accounting for active CPUs but leaves pcp->batch static. It also adapts the number of pages that can be on the pcp list based on recent freeing patterns.

The motivation is partially to adjust to larger memory sizes but is also driven by the fact that large batches of page freeing via release_pages() often shows zone contention as a major part of the problem. Another is a bug report based on an older kernel where a multi-terabyte process can takes several minutes to exit. A workaround was to use vm.percpu_pagelist_fraction to increase the pcp->high value but testing indicated that a production workload could not use the same values because of an increase in allocation latencies. Unfortunately, I cannot reproduce this test case myself as the multi-terabyte machines are in active use but it should alleviate the problem.

The series aims to address both and partially acts as a pre-requisite. pcp only works with order-0 which is useless for SLUB (when using high orders) and THP (unconditionally). To store high-order pages on PCP, the pcp->high values need to be increased first.

 Documentation/admin-guide/sysctl/vm.rst |  29 ++--
 include/linux/cpuhotplug.h              |   2 +-
 include/linux/mmzone.h                  |   8 +-
 kernel/sysctl.c                         |   8 +-
 mm/internal.h                           |   2 +-
 mm/memory_hotplug.c                     |   4 +-
 mm/page_alloc.c                         | 196 ++++++++++++++++++------
 mm/vmscan.c                             |  35 +++++
 8 files changed, 212 insertions(+), 72 deletions(-)
Signature · 1 line
2.26.2