acpi: refactor error prone build_header() and packed structures usage in ACPI tables
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest35 patches 4 repliesIn review
- v335 patches 42 repliesSuperseded
- v2 posting 2/215 patches 21 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 posting 1/2 | 35 patches | 20 replies | Superseded | |
| v1 | 53 patches | 14 replies | Superseded |
Changes in v4 from the cover letter
1. comments fixups and diing missing comments
2. clean up spurious changes
3. rebase on top of (4be8bfcb4d hw/i386/acpi-build: Fix a typo)
4. convert build_iort:
* keep nb_nodes variable
* encode 'Memory access properties' as separate entries according to Table 13
Patches in v4 No applies recorded yet
Reviews trailers per patch
34 of 35 patches have a Reviewed-by or Acked-by.
| Patch | Eric Auger | Stefan Berger | Dongjiu Geng | Yanan Wang |
|---|---|---|---|---|
| 1/35 | R-b | T-b | T-b | |
| 2/35 | R-b | |||
| 3/35 | R-b | |||
| 4/35 | R-b | |||
| 5/35 | R-b | |||
| 6/35 | R-b | T-b | ||
| 7/35 | R-b | R-b | ||
| 8/35 | R-b | |||
| 9/35 | R-b | |||
| 10/35 | R-b | |||
| 11/35 | R-b | |||
| 12/35 | R-b | |||
| 13/35 | R-b | |||
| 14/35 | ||||
| 15/35 | R-b | T-b | ||
| 16/35 | R-b | |||
| 17/35 | R-b | |||
| 18/35 | R-b | |||
| 19/35 | R-b | |||
| 20/35 | R-b | |||
| 21/35 | R-b | |||
| 22/35 | R-b | |||
| 23/35 | R-b | |||
| 24/35 | R-b | |||
| 25/35 | R-b | |||
| 26/35 | R-b | |||
| 27/35 | R-b | |||
| 28/35 | R-b T-b | |||
| 29/35 | R-b T-b | |||
| 30/35 | R-b | |||
| 31/35 | R-b | |||
| 32/35 | R-b | |||
| 33/35 | R-b | |||
| 34/35 | R-b | |||
| 35/35 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables
v4:
1. comments fixups and diing missing comments
2. clean up spurious changes
3. rebase on top of (4be8bfcb4d hw/i386/acpi-build: Fix a typo)
4. convert build_iort:
* keep nb_nodes variable
* encode 'Memory access properties' as separate entries according to Table 13
v3:
1. s/acpi_init_table()|acpi_table_composed()/acpi_table_begin()|acpi_table_end()/
2. arm:madt fix incorrect length
3. various comment improvments
4. rewrite IORT conversion patch due to heavy conflicts with bypass iommu code merged recently
5 pick up Eric's Reviewed-By where there wasn't significant change (1)
v2:
- drop test related patches, they will be sent as a separate series
- fix bios_loader pointer initialization ordering when using TPM1.2
- extend commit message of [1/35] and add extra comment about table length patching
Highlights:
* drop pointer arithmetic in ACPI tables code
* use endian agnostic API
* simplifies review of tables. /in most cases just line by line comparision with spec/
Series replaces build_header() with acpi_table_begin()/acpi_table_end() API that hides pointer/offset arithmetic from user, to prevent errors caused by it [1].
While doing above, it was necessary to split table header from packed structure that was describing the table, which is counter-productive since it still leaves packed structure drawbacks. So that sort of forced me to rewrite tables that were composed with help of packed structures to preferred build_append_int_noprefix() API. In cases where refactoring to build_append_int_noprefix() was small, it was squashed with acpi_table_begin()/acpi_table_end() patch. Conversion reduced code size quite a bit despite me adding doc comments for every table row.
1) commits
bb9feea43179 x86: acpi: use offset instead of pointer when using build_header() 4d027afeb3a9 Virt: ACPI: fix qemu assert due to re-assigned table data address
Link to repo with this series and tests to validate it:
https://gitlab.com/imammedo/qemu/-/commits/acpi_build_header_refactoring_v4
Previous v3 revision can be found at:
https://lore.kernel.org/qemu-devel/[email protected]/T/
Igor Mammedov (35):
acpi: add helper routines to initialize ACPI tables
acpi: build_rsdt: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: build_xsdt: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: build_slit: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: build_fadt: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: build_tpm2: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: acpi_build_hest: use acpi_table_begin()/acpi_table_end() instead
of build_header()
acpi: build_mcfg: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: build_hmat: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: nvdimm_build_nfit: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: nvdimm_build_ssdt: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: vmgenid_build_acpi: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: x86: build_dsdt: use acpi_table_begin()/acpi_table_end() instead
of build_header()
acpi: build_hpet: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: build_tpm_tcpa: use acpi_table_begin()/acpi_table_end() instead
of build_header()
acpi: arm/x86: build_srat: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: use build_append_int_noprefix() API to compose SRAT table
acpi: build_dmar_q35: use acpi_table_begin()/acpi_table_end() instead
of build_header()
acpi: build_waet: use acpi_table_begin()/acpi_table_end() instead of
build_header()
acpi: build_amd_iommu: use acpi_table_begin()/acpi_table_end() instead
of build_header()
acpi: madt: arm/x86: use acpi_table_begin()/acpi_table_end() instead
of build_header()
acpi: x86: remove dead code
acpi: x86: set enabled when composing _MAT entries
acpi: x86: madt: use build_append_int_noprefix() API to compose MADT
table
acpi: arm/virt: madt: use build_append_int_noprefix() API to compose
MADT table
acpi: build_dsdt_microvm: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: arm: virt: build_dsdt: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: arm: virt: build_iort: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: arm/virt: convert build_iort() to endian agnostic
build_append_FOO() API
acpi: arm/virt: build_spcr: fix invalid cast
acpi: arm/virt: build_spcr: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: arm/virt: build_gtdt: use acpi_table_begin()/acpi_table_end()
instead of build_header()
acpi: build_facs: use build_append_int_noprefix() API to compose table
acpi: remove no longer used build_header()
acpi: AcpiGenericAddress no longer used to map/access fields of MMIO,
drop packed attribute
include/hw/acpi/acpi-defs.h | 528 +----------------------- include/hw/acpi/acpi_dev_interface.h | 3 +- include/hw/acpi/aml-build.h | 37 +- include/hw/i386/pc.h | 6 +- hw/acpi/acpi-x86-stub.c | 3 +- hw/acpi/aml-build.c | 203 ++++++---- hw/acpi/cpu.c | 17 +- hw/acpi/ghes.c | 10 +- hw/acpi/hmat.c | 14 +- hw/acpi/nvdimm.c | 64 ++- hw/acpi/pci.c | 18 +- hw/acpi/vmgenid.c | 13 +- hw/arm/virt-acpi-build.c | 577 +++++++++++++++------------ hw/i386/acpi-build.c | 294 ++++++++------ hw/i386/acpi-common.c | 160 ++++---- hw/i386/acpi-microvm.c | 13 +- 16 files changed, 801 insertions(+), 1159 deletions(-)
Signature · 1 line
2.27.0