KVM: arm64: PSCI SYSTEM_SUSPEND support
Status from this message: Applied to next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest12 patches 1 replyApplied
- v513 patches 10 repliesSuperseded
- v319 patches 27 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 11 patches | 32 replies | Superseded | |
| v1 | 6 patches | 9 replies | Superseded |
Changes in v6 from the cover letter
- Rebase to 5.18-rc5
- Collect Reiji's R-b's
- Drop the system_event helper. Since we now have variadic data returning to userspace it doesn't make much sense to roll it up into a helper. Meh.
- Put back the pointless kvm_vcpu_request() in kvm_arm_vcpu_suspend(). We'll rip out the reliance on vCPU requests for power state later on. It is entirely benign, even when a vCPU targets itself.
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | KVM: arm64: Don't depend on fallthrough to hide SYSTEM_RESET2arch/ | +5 | 0 replies | |
| 2/12 | KVM: arm64: Dedupe vCPU power off helpersarch/ arch/ arch/ | +7 | 0 replies | |
| 3/12 | KVM: arm64: Track vCPU power state using MP state valuesarch/ arch/ arch/ | +21 | 0 replies | |
| 4/12 | KVM: arm64: Rename the KVM_REQ_SLEEP handlerarch/ | +2 | 0 replies | |
| 5/12 | KVM: arm64: Return a value from check_vcpu_requests()arch/ | +14 | 0 replies | |
| 6/12 | KVM: arm64: Add support for userspace to suspend a vCPUDocumentation/ arch/ arch/ +1 more | +89 | 0 replies | |
| 7/12 | KVM: arm64: Implement PSCI SYSTEM_SUSPENDDocumentation/ arch/ arch/ +2 more | +77 | 0 replies | |
| 8/12 | selftests: KVM: Rename psci_cpu_on_test to psci_testtools/ tools/ tools/ | +2 | 0 replies | |
| 9/12 | selftests: KVM: Create helper for making SMCCC callstools/ tools/ tools/ +1 more | +58 | 0 replies | |
| 10/12 | selftests: KVM: Use KVM_SET_MP_STATE to power off vCPU in psci_testtools/ | +11 | 0 replies | |
| 11/12 | selftests: KVM: Refactor psci_test to make it amenable to new teststools/ | +60 | 0 replies | |
| 12/12 | selftests: KVM: Test SYSTEM_SUSPEND PSCI calltools/ | +69 | 0 replies |
Reviews trailers per patch
8 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Reiji Watanabe | Andrew Jones |
|---|---|---|
| 1/12 | R-b | |
| 2/12 | R-b | |
| 3/12 | R-b | |
| 4/12 | R-b | |
| 5/12 | ||
| 6/12 | ||
| 7/12 | R-b | |
| 8/12 | R-b | |
| 9/12 | R-b | |
| 10/12 | ||
| 11/12 | R-b | |
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 00/12] KVM: arm64: PSCI SYSTEM_SUSPEND support
The PSCI v1.0 specification describes a call, SYSTEM_SUSPEND, which allows software to request that the system be placed into the lowest possible power state and await a wakeup event. This call is optional in v1.0 and v1.1. KVM does not currently support this optional call.
This series adds support for the PSCI SYSTEM_SUSPEND call to KVM/arm64. For reasons best described in patch 8, it is infeasible to correctly implement PSCI SYSTEM_SUSPEND (or any system-wide event for that matter) in a split design between kernel/userspace. As such, this series cheaply exits to userspace so it can decide what to do with the call. This series also gives userspace some help to emulate suspension with a new MP state that awaits an unmasked pending interrupt.
Patches 1-5 are small reworks to more easily shoehorn the new features into the kernel.
Patch 6 stands up the new suspend MP state, allowing userspace to emulate the PSCI call.
Patch 7 actually allows userspace to enable the PSCI call, which requires explicit opt-in for the new KVM_EXIT_SYSTEM_EVENT type.
Patches 8-11 clean up the way PSCI is tested in selftests to more easily add new test cases.
Finally, the last patch actually tests that PSCI SYSTEM_SUSPEND calls within the guest result in userspace exits.
Applies cleanly to 5.18-rc5. I'm sure you're already aware of it Marc, but for the sake of everyone else there's some light conflict with Raghu's patches that you've got queued up [1].
Tested with the included selftest and a hacked up kvmtool [2] with support for the new UAPI.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/hcall-selection
[2]: https://lore.kernel.org/all/[email protected]/
v5: http://lore.kernel.org/r/[email protected]
v5 -> v6:
- Rebase to 5.18-rc5
- Collect Reiji's R-b's
- Drop the system_event helper. Since we now have variadic data returning to userspace it doesn't make much sense to roll it up into a helper. Meh.
- Put back the pointless kvm_vcpu_request() in kvm_arm_vcpu_suspend(). We'll rip out the reliance on vCPU requests for power state later on. It is entirely benign, even when a vCPU targets itself.
Oliver Upton (12):
KVM: arm64: Don't depend on fallthrough to hide SYSTEM_RESET2
KVM: arm64: Dedupe vCPU power off helpers
KVM: arm64: Track vCPU power state using MP state values
KVM: arm64: Rename the KVM_REQ_SLEEP handler
KVM: arm64: Return a value from check_vcpu_requests()
KVM: arm64: Add support for userspace to suspend a vCPU
KVM: arm64: Implement PSCI SYSTEM_SUSPEND
selftests: KVM: Rename psci_cpu_on_test to psci_test
selftests: KVM: Create helper for making SMCCC calls
selftests: KVM: Use KVM_SET_MP_STATE to power off vCPU in psci_test
selftests: KVM: Refactor psci_test to make it amenable to new tests
selftests: KVM: Test SYSTEM_SUSPEND PSCI call
Documentation/virt/kvm/api.rst | 76 ++++++- arch/arm64/include/asm/kvm_host.h | 10 +- arch/arm64/kvm/arm.c | 104 +++++++-- arch/arm64/kvm/psci.c | 65 ++++-- include/uapi/linux/kvm.h | 4 + tools/testing/selftests/kvm/.gitignore | 2 +- tools/testing/selftests/kvm/Makefile | 2 +- .../selftests/kvm/aarch64/psci_cpu_on_test.c | 121 ---------- .../testing/selftests/kvm/aarch64/psci_test.c | 213 ++++++++++++++++++ .../selftests/kvm/include/aarch64/processor.h | 22 ++ .../selftests/kvm/lib/aarch64/processor.c | 25 ++ tools/testing/selftests/kvm/steal_time.c | 13 +- 12 files changed, 480 insertions(+), 177 deletions(-) delete mode 100644 tools/testing/selftests/kvm/aarch64/psci_cpu_on_test.c create mode 100644 tools/testing/selftests/kvm/aarch64/psci_test.c
Signature · 1 line
2.36.0.464.gb9c8b46e94-goog