Skip to content

KVM: x86: Clean up RESET "emulation"

Sean Christopherson kvm lkml 2 versions – Applied

Status from this message: Queued patches 1-2 for 5.15-rc3, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 11 repliesApplied
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Add patches to drop defunct fx_init() code.
- Add patch to zero CR3 at RESET/INIT.
- Add patch to mark all regs avail/dirty at creation, not at RESET/INIT.
- Add patch to WARN if CRs are non-zero at RESET. [Vitaly]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/10KVM: x86: Mark all registers as avail/dirty at vCPU creationarch/x86/kvm/x86.c+2 -01 reply
2/10KVM: x86: Clear KVM's cached guest CR3 at RESET/INITarch/x86/kvm/x86.c+3 -03 replies
3/10KVM: x86: Do not mark all registers as avail/dirty during RESET/INITarch/x86/kvm/vmx/vmx.c arch/x86/kvm/x86.c+3 -20 replies
4/10KVM: x86: Remove defunct setting of CR0.ET for guests during vCPU createarch/x86/kvm/x86.c+0 -21 reply
5/10KVM: x86: Remove defunct setting of XCR0 for guest during vCPU createarch/x86/kvm/x86.c+1 -61 reply
6/10KVM: x86: Fold fx_init() into kvm_arch_vcpu_create()arch/x86/kvm/x86.c+4 -122 replies
7/10KVM: VMX: Drop explicit zeroing of MSR guest values at vCPU creationarch/x86/kvm/vmx/vmx.c+1 -51 reply
8/10KVM: VMX: Move RESET emulation to vmx_vcpu_reset()arch/x86/kvm/vmx/vmx.c+31 -300 replies
9/10KVM: SVM: Move RESET emulation to svm_vcpu_reset()arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h+21 -160 replies
10/10KVM: x86: WARN on non-zero CRs at RESET to detect improper initalizationarch/x86/kvm/x86.c+10 -01 reply

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by.

PatchVitaly Kuznetsov
1/10R-b
2/10R-b
3/10
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10
9/10
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] KVM: x86: Clean up RESET "emulation"

Add dedicated helpers to emulate RESET (or at least, the parts of RESET that KVM actually emulates) instead of having the relevant code scattered throughout vcpu_create() and vcpu_reset().

Vitaly's innocuous suggestion to WARN on non-zero CR0 led to a wonderful bit of git archaeology after, to my complete surprise, it fired on RESET due to fx_init() setting CR0.ET (and XCR0.FP).

v2:
- Add patches to drop defunct fx_init() code.
- Add patch to zero CR3 at RESET/INIT.
- Add patch to mark all regs avail/dirty at creation, not at RESET/INIT.
- Add patch to WARN if CRs are non-zero at RESET. [Vitaly]

v1: https://lkml.kernel.org/r/[email protected]

Sean Christopherson (10):
KVM: x86: Mark all registers as avail/dirty at vCPU creation
KVM: x86: Clear KVM's cached guest CR3 at RESET/INIT
KVM: x86: Do not mark all registers as avail/dirty during RESET/INIT
KVM: x86: Remove defunct setting of CR0.ET for guests during vCPU
create
KVM: x86: Remove defunct setting of XCR0 for guest during vCPU create
KVM: x86: Fold fx_init() into kvm_arch_vcpu_create()
KVM: VMX: Drop explicit zeroing of MSR guest values at vCPU creation
KVM: VMX: Move RESET emulation to vmx_vcpu_reset()
KVM: SVM: Move RESET emulation to svm_vcpu_reset()
KVM: x86: WARN on non-zero CRs at RESET to detect improper
initalization

 arch/x86/kvm/svm/sev.c |  6 ++--
 arch/x86/kvm/svm/svm.c | 29 ++++++++++--------
 arch/x86/kvm/svm/svm.h |  2 +-
 arch/x86/kvm/vmx/vmx.c | 68 ++++++++++++++++++++----------------------
 arch/x86/kvm/x86.c     | 44 +++++++++++++--------------
 5 files changed, 76 insertions(+), 73 deletions(-)
Signature · 1 line
2.33.0.464.g1972c5931b-goog