RFC net: stmmac: dwmac-rk: use stmmac helper functions and clean up
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: stmmac: dwmac-rk: use stmmac helper functions for pm ops and removedrivers/ | +16 | 1 reply | |
| 2/3 | net: stmmac: dwmac-rk: clean up includesdrivers/ | +5 | 1 reply | |
| 3/3 | net: stmmac: dwmac-rk: use stmmac helper functions for clock managementdrivers/ | +13 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Heiko Stuebner |
|---|---|
| 1/3 | |
| 2/3 | R-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/3] net: stmmac: dwmac-rk: use stmmac helper functions and clean up
Hi all,
This series aims to clean up the dwmac-rk glue driver by making the stmmac core responsible for clock and power management. The dwmac-rk specific code is passed to the core via callbacks. The patches have been tested successfully on a RK3568 EVB1.
With any luck, the patches fix the Ethernet regression on different RK3399 boards, which has been introduced recently in v5.14 -- but don't be disappointed if that is not the case :-)
The series is marked as RFC since the handling of the (internal) phy is not quite clear yet. Should rk_gmac_{init,exit} still consider device_may_wakeup at some point? Should the glue driver power on/off the external phy in the first place? Or will the stmmac core take care of it?
Also, I am sending this RFC to linux-rockchip exclusively on purpose as I would like to see some test results on other boards before proceeding.
As an addition, the usage of clk_bulk_* functions is envisaged but not yet implemented due to time constraints.
Looking forward to your comments!
Best regards,
Michael
Michael Riesch (3):
net: stmmac: dwmac-rk: use stmmac helper functions for pm ops and
remove
net: stmmac: dwmac-rk: clean up includes
net: stmmac: dwmac-rk: use stmmac helper functions for clock
management
.../net/ethernet/stmicro/stmmac/dwmac-rk.c | 117 +++++------------- 1 file changed, 32 insertions(+), 85 deletions(-)
Signature · 7 lines
2.17.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip