Skip to content

target/riscv: Initial support for the Sdtrig extension via M-mode CSRs

Bin Meng qemu-devel qemu-riscv 7 versions – Applied

Status from this message: Applied to riscv-to-apply.next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 1 replyApplied
  2. v47 patches 13 repliesApplied
  3. v3 posting 3/37 patches 4 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/30 of 7 patches0 repliesSuperseded
v3 posting 1/37 patches0 repliesSuperseded
v27 patches7 repliesSuperseded
v15 patches4 repliesSuperseded

Changes in v5 from the cover letter

- rebase against riscv-to-apply.next
- drop patch 1 in v4 which is already in riscv-to-apply.next
- adjust patch order to let patch 2 in v4 come later

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/6target/riscv: debug: Implement debug related TCGCPUOpstarget/riscv/cpu.c target/riscv/debug.c target/riscv/debug.h+82 -00 replies
2/6target/riscv: cpu: Add a config option for native debugtarget/riscv/cpu.c target/riscv/cpu.h+8 -10 replies
3/6target/riscv: csr: Hook debug CSR read/writetarget/riscv/cpu.c target/riscv/csr.c target/riscv/debug.c +1 more+90 -00 replies
4/6target/riscv: machine: Add debug state descriptiontarget/riscv/machine.c+32 -00 replies
5/6target/riscv: cpu: Enable native debug featuretarget/riscv/cpu.c+1 -10 replies
6/6hw/core: tcg-cpu-ops.h: Update comments of debug_check_watchpoint()include/hw/core/tcg-cpu-ops.h+1 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAlistair FrancisRichard Henderson
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] target/riscv: Initial support for the Sdtrig extension via M-mode CSRs

This adds initial support for the Sdtrig extension via the Trigger Module, as defined in the RISC-V Debug Specification [1].

Only "Address / Data Match" trigger (type 2) is implemented as of now, which is mainly used for hardware breakpoint and watchpoint. The number of type 2 triggers implemented is 2, which is the number that we can find in the SiFive U54/U74 cores.

[1] https://github.com/riscv/riscv-debug-spec/raw/master/riscv-debug-stable.pdf

Changes in v5:
- rebase against riscv-to-apply.next
- drop patch 1 in v4 which is already in riscv-to-apply.next
- adjust patch order to let patch 2 in v4 come later

Changes in v4:
- move riscv_trigger_init() call to riscv_cpu_reset()

Changes in v3:
- add riscv_trigger_init(), moved from patch #1 to this patch
- enable debug feature by default for all CPUs

Changes in v2:
- use 0 instead of GETPC()
- change the config option to 'disabled' by default
- new patch: add debug state description

Bin Meng (6):
target/riscv: debug: Implement debug related TCGCPUOps target/riscv: cpu: Add a config option for native debug target/riscv: csr: Hook debug CSR read/write target/riscv: machine: Add debug state description target/riscv: cpu: Enable native debug feature
hw/core: tcg-cpu-ops.h: Update comments of debug_check_watchpoint()

 include/hw/core/tcg-cpu-ops.h |   1 +
 target/riscv/cpu.h            |   4 +-
 target/riscv/debug.h          |   6 ++
 target/riscv/cpu.c            |  12 ++++
 target/riscv/csr.c            |  57 +++++++++++++++++++
 target/riscv/debug.c          | 102 ++++++++++++++++++++++++++++++++++
 target/riscv/machine.c        |  32 +++++++++++
 7 files changed, 213 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1