Skip to content

Update the Icicle Kit device tree

[email protected] linux-devicetree linux-gpio linux-pwm linux-riscv linux-rtc lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest11 patches 20 repliesIn review
  2. v612 patches 7 repliesApplied
  3. v512 patches 20 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v414 patches13 repliesSuperseded
v315 patches11 repliesSuperseded
v217 patches38 repliesSuperseded
v113 patches56 repliesSuperseded

Changes in v7 from the cover letter

- Dropped i2c patch, as its in i2c-next
- Added ack on gpio, reviewed-by on rtc
- Dropped child nodes from sysctrl binding entirely, added a link to the online documenation for the services the system controller can provide
- Dropped the #pwm-cells and replaced with a ref, a la Krzysztof's series

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11dt-bindings: soc/microchip: update syscontroller compatiblesDocumentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml+6 -60 replies
2/11dt-bindings: soc/microchip: add info about services to mpfs sysctrlDocumentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml+8 -32 replies
3/11dt-bindings: rtc: add bindings for microchip mpfs rtcDocumentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml+58 -05 replies
4/11dt-bindings: gpio: add bindings for microchip mpfs gpioDocumentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml+79 -00 replies
5/11dt-bindings: pwm: add microchip corepwm bindingDocumentation/devicetree/bindings/pwm/microchip,corepwm.yaml+81 -07 replies
6/11riscv: dts: microchip: use clk defines for icicle kitarch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi+14 -130 replies
7/11riscv: dts: microchip: add fpga fabric section to icicle kitarch/riscv/boot/dts/microchip/microchip-mpfs-fabric.dtsi arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi+34 -00 replies
8/11riscv: dts: microchip: refactor icicle kit device treearch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi+52 -500 replies
9/11riscv: dts: microchip: update peripherals in icicle kit device treearch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi+29 -170 replies
10/11riscv: dts: microchip: add new peripherals to icicle kit device treearch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi+213 -00 replies
11/11MAINTAINERS: update riscv/microchip entryMAINTAINERS+2 -00 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGeert UytterhoevenRob HerringPalmer DabbeltBartosz GolaszewskiLewis HanlyUwe Kleine-KönigConor DooleyPeter MaintainerAlexandre BelloniThierry Reding
SeriesA-b
1/11R-b A-b A-b
2/11R-b
3/11R-b A-b A-b
4/11R-b A-b A-b
5/11R-b Referred-by A-b Backed-by A-b Singed-off-by Singed-off-by A-b
6/11A-b
7/11A-b
8/11A-b
9/11A-b
10/11A-b
11/11A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/11] Update the Icicle Kit device tree

From: Conor Dooley <[email protected]>

This series updates the Microchip Icicle Kit device tree by adding a host of peripherals, and some updates to the memory map. In addition, the device tree has been split into a third part, which contains "soft" peripherals that are in the fpga fabric.

Several of the entries are for peripherals that have not get had their drivers upstreamed, so in those cases the dt bindings are included where appropriate in order to avoid the many "DT compatible string <x> appears un-documented" errors.

Depends on mpfs clock driver binding (on clk/next) to provide dt-bindings/clock/microchip,mpfs-clock.h for the device tree and on the other changes to the icicle/mpfs device tree from geert that are already in linux/riscv/for-next.

Additionally, the interrupt-extended warnings on the plic/clint are cleared by [1] & [2].

[1] https://lore.kernel.org/linux-riscv/[email protected]/
[2] https://lore.kernel.org/linux-riscv/[email protected]/

Changes from v6:
- Dropped i2c patch, as its in i2c-next
- Added ack on gpio, reviewed-by on rtc
- Dropped child nodes from sysctrl binding entirely, added a link to the online documenation for the services the system controller can provide
- Dropped the #pwm-cells and replaced with a ref, a la Krzysztof's series

Changes from v5:
- reworded the descriptions in the pwm binding to (hopefully) add clarity
- added -mask to the custom properties and made them 32 bit
- renamed the i2c binding to corei2c, since it is not mpfs specific
- removed the child nodes of the system controller in example/dts & will create them in the driver.
@Rob, I assume keeping them documented is the correct thing to do?
- removed the dependancy on the clock binding from the examples
- reformatted rtc interrupts as per Rob's suggestion

Changes from v4:
- dont include icicle_kit_defconfig, accidentally added in v3
- drop prescaler from mpfs-rtc & calculate the value instead
- use corei2c as a fallback device for mpfs-i2c
- drop spi dt-binding (on spi-next)
commit 2da187304e556ac59cf2dacb323cc78ded988169
- drop usb dt-binding (on usb-next)

Changes from v3:
- drop "mailbox: change mailbox-mpfs compatible string", already upstream:
commit f10b1fc0161cd99e ("mailbox: change mailbox-mpfs compatible string")
- fix copy paste error in microchip,mpfs-mailbox dt-binding
- remove whitespace in syscontroller dt entry

Changes from v2:
- dropped plic int header & corresponding defines in dts{,i}
- use $ref to drmode in mpfs-musb binding
- split changes to dts{,i} again: functional changes to existing elements now are in a new patch
- drop num-cs property in mpfs-spi binding
- dont make the system controller a simple-mfd
- move the separate bindings for rng/generic system services into the system controller binding
- added an instance corei2c as i2c2 in the fabric dtsi
- add version numbering to corepwm and corei2c compat string (-rtl-vN)

Conor Dooley (11):
dt-bindings: soc/microchip: update syscontroller compatibles
dt-bindings: soc/microchip: add info about services to mpfs sysctrl
dt-bindings: rtc: add bindings for microchip mpfs rtc
dt-bindings: gpio: add bindings for microchip mpfs gpio
dt-bindings: pwm: add microchip corepwm binding
riscv: dts: microchip: use clk defines for icicle kit
riscv: dts: microchip: add fpga fabric section to icicle kit
riscv: dts: microchip: refactor icicle kit device tree
riscv: dts: microchip: update peripherals in icicle kit device tree
riscv: dts: microchip: add new peripherals to icicle kit device tree
MAINTAINERS: update riscv/microchip entry

 .../bindings/gpio/microchip,mpfs-gpio.yaml    |  79 ++++++
 ...ilbox.yaml => microchip,mpfs-mailbox.yaml} |   6 +-
 .../bindings/pwm/microchip,corepwm.yaml       |  81 ++++++
 .../bindings/rtc/microchip,mfps-rtc.yaml      |  58 ++++
 .../microchip,mpfs-sys-controller.yaml        |  40 +++
 ...icrochip,polarfire-soc-sys-controller.yaml |  35 ---
 MAINTAINERS                                   |   2 +
 .../dts/microchip/microchip-mpfs-fabric.dtsi  |  25 ++
 .../microchip/microchip-mpfs-icicle-kit.dts   | 115 ++++++--
 .../boot/dts/microchip/microchip-mpfs.dtsi    | 254 ++++++++++++++----
 10 files changed, 591 insertions(+), 104 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
 rename Documentation/devicetree/bindings/mailbox/{microchip,polarfire-soc-mailbox.yaml => microchip,mpfs-mailbox.yaml} (82%)
 create mode 100644 Documentation/devicetree/bindings/pwm/microchip,corepwm.yaml
 create mode 100644 Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
 create mode 100644 arch/riscv/boot/dts/microchip/microchip-mpfs-fabric.dtsi
Signature · 1 line
2.35.1