Skip to content

staging: r8188eu: remove odm_interface and odm_precomp.h

Michael Straube linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest32 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32staging: r8188eu: remove ODM_SetMACReg()drivers/staging/r8188eu/hal/odm_RTL8188E.c drivers/staging/r8188eu/hal/odm_interface.c drivers/staging/r8188eu/include/odm_interface.h+11 -160 replies
2/32staging: r8188eu: remove ODM_GetMACReg()drivers/staging/r8188eu/hal/odm_RTL8188E.c drivers/staging/r8188eu/hal/odm_interface.c drivers/staging/r8188eu/include/odm_interface.h+4 -120 replies
3/32staging: r8188eu: remove ODM_GetRFReg()drivers/staging/r8188eu/hal/HalPhyRf_8188e.c drivers/staging/r8188eu/hal/odm_interface.c drivers/staging/r8188eu/include/odm_interface.h+1 -100 replies
4/32staging: r8188eu: remove ODM_SetRFReg()drivers/staging/r8188eu/hal/HalPhyRf_8188e.c drivers/staging/r8188eu/hal/odm_RegConfig8188E.c drivers/staging/r8188eu/hal/odm_interface.c +1 more+17 -280 replies
5/32staging: r8188eu: remove ODM_GetBBReg()drivers/staging/r8188eu/hal/HalPhyRf_8188e.c drivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/hal/odm_interface.c +1 more+39 -440 replies
6/32staging: r8188eu: remove ODM_SetBBReg()drivers/staging/r8188eu/hal/HalPhyRf_8188e.c drivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/hal/odm_RTL8188E.c +3 more+131 -1490 replies
7/32staging: r8188eu: clean up coding style issuesdrivers/staging/r8188eu/hal/odm_RegConfig8188E.c+1 -10 replies
8/32staging: r8188eu: remove ODM_sleep_ms()drivers/staging/r8188eu/hal/HalPhyRf_8188e.c drivers/staging/r8188eu/hal/odm_RegConfig8188E.c drivers/staging/r8188eu/hal/odm_interface.c +1 more+4 -110 replies
9/32staging: r8188eu: remove ODM_delay_us()drivers/staging/r8188eu/hal/odm_RegConfig8188E.c drivers/staging/r8188eu/hal/odm_interface.c drivers/staging/r8188eu/include/odm_interface.h+12 -190 replies
10/32staging: r8188eu: remove ODM_delay_ms()drivers/staging/r8188eu/hal/HalPhyRf_8188e.c drivers/staging/r8188eu/hal/odm_RegConfig8188E.c drivers/staging/r8188eu/hal/odm_interface.c +1 more+10 -190 replies
11/32staging: r8188eu: remove ODM_CompareMemory()drivers/staging/r8188eu/hal/HalPhyRf_8188e.c drivers/staging/r8188eu/hal/odm_interface.c drivers/staging/r8188eu/include/odm_interface.h+2 -110 replies
12/32staging: r8188eu: remove odm_interfacedrivers/staging/r8188eu/Makefile drivers/staging/r8188eu/hal/odm_interface.c drivers/staging/r8188eu/include/odm_interface.h +1 more+0 -240 replies
13/32staging: r8188eu: make odm_ConfigRFReg_8188E() staticdrivers/staging/r8188eu/hal/odm_RegConfig8188E.c drivers/staging/r8188eu/include/odm_RegConfig8188E.h+3 -60 replies
14/32staging: r8188eu: remove unused prototypesdrivers/staging/r8188eu/include/odm.h drivers/staging/r8188eu/include/odm_RTL8188E.h drivers/staging/r8188eu/include/odm_precomp.h+0 -70 replies
15/32staging: r8188eu: make odm_DIGInit() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+29 -300 replies
16/32staging: r8188eu: make odm_DIG() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+132 -1330 replies
17/32staging: r8188eu: make odm_CommonInfoSelfInit() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+8 -90 replies
18/32staging: r8188eu: make odm_CommonInfoSelfUpdate() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+26 -270 replies
19/32staging: r8188eu: make odm_RateAdaptiveMaskInit() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+9 -100 replies
20/32staging: r8188eu: make odm_RefreshRateAdaptiveMask() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+18 -342 replies
21/32staging: r8188eu: make odm_DynamicBBPowerSavingInit() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+9 -130 replies
22/32staging: r8188eu: make odm_FalseAlarmCounterStatistics() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+56 -610 replies
23/32staging: r8188eu: make odm_CCKPacketDetectionThresh() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+27 -320 replies
24/32staging: r8188eu: make odm_RSSIMonitorCheck() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+72 -770 replies
25/32staging: r8188eu: remove odm_TXPowerTrackingInit()drivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+1 -70 replies
26/32staging: r8188eu: make odm_TXPowerTrackingThermalMeterInit() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+8 -130 replies
27/32staging: r8188eu: make odm_InitHybridAntDiv() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+8 -90 replies
28/32staging: r8188eu: make odm_HwAntDiv() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+8 -90 replies
29/32staging: r8188eu: make ODM_EdcaTurboInit() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+8 -110 replies
30/32staging: r8188eu: make odm_EdcaTurboCheck() staticdrivers/staging/r8188eu/hal/odm.c drivers/staging/r8188eu/include/odm_precomp.h+77 -790 replies
31/32staging: r8188eu: remove unnecessary commentsdrivers/staging/r8188eu/hal/odm.c+0 -130 replies
32/32staging: r8188eu: remove header odm_precomp.hdrivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c drivers/staging/r8188eu/hal/HalHWImg8188E_BB.c drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c +9 more+18 -590 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/32] staging: r8188eu: remove odm_interface and odm_precomp.h

This series removes odm_interface.c, odm_interface.h and odm_precomp.h. The motivation for the removals is the ongoing effort to get grid of the hal layer.

Patches 1-11 remove all wrappers from odm_interface.c and finally remove odm_interface.c and its header file.

Patches 12-32 remove prototypes from odm_precomp.h by making the functions static and finally remove the header file.

Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (32):
staging: r8188eu: remove ODM_SetMACReg()
staging: r8188eu: remove ODM_GetMACReg()
staging: r8188eu: remove ODM_GetRFReg()
staging: r8188eu: remove ODM_SetRFReg()
staging: r8188eu: remove ODM_GetBBReg()
staging: r8188eu: remove ODM_SetBBReg()
staging: r8188eu: clean up coding style issues
staging: r8188eu: remove ODM_sleep_ms()
staging: r8188eu: remove ODM_delay_us()
staging: r8188eu: remove ODM_delay_ms()
staging: r8188eu: remove ODM_CompareMemory()
staging: r8188eu: remove odm_interface
staging: r8188eu: make odm_ConfigRFReg_8188E() static
staging: r8188eu: remove unused prototypes
staging: r8188eu: make odm_DIGInit() static
staging: r8188eu: make odm_DIG() static
staging: r8188eu: make odm_CommonInfoSelfInit() static
staging: r8188eu: make odm_CommonInfoSelfUpdate() static
staging: r8188eu: make odm_RateAdaptiveMaskInit() static
staging: r8188eu: make odm_RefreshRateAdaptiveMask() static
staging: r8188eu: make odm_DynamicBBPowerSavingInit() static
staging: r8188eu: make odm_FalseAlarmCounterStatistics() static
staging: r8188eu: make odm_CCKPacketDetectionThresh() static
staging: r8188eu: make odm_RSSIMonitorCheck() static
staging: r8188eu: remove odm_TXPowerTrackingInit()
staging: r8188eu: make odm_TXPowerTrackingThermalMeterInit() static
staging: r8188eu: make odm_InitHybridAntDiv() static
staging: r8188eu: make odm_HwAntDiv() static
staging: r8188eu: make ODM_EdcaTurboInit() static
staging: r8188eu: make odm_EdcaTurboCheck() static
staging: r8188eu: remove unnecessary comments
staging: r8188eu: remove header odm_precomp.h

 drivers/staging/r8188eu/Makefile              |   1 -
 .../r8188eu/hal/Hal8188ERateAdaptive.c        |  17 +-
 .../staging/r8188eu/hal/HalHWImg8188E_BB.c    |   1 -
 .../staging/r8188eu/hal/HalHWImg8188E_MAC.c   |   1 -
 .../staging/r8188eu/hal/HalHWImg8188E_RF.c    |   1 -
 drivers/staging/r8188eu/hal/HalPhyRf_8188e.c  | 234 +++--
 drivers/staging/r8188eu/hal/odm.c             | 890 +++++++++---------
 drivers/staging/r8188eu/hal/odm_HWConfig.c    |   2 +-
 drivers/staging/r8188eu/hal/odm_RTL8188E.c    | 118 +--
 .../staging/r8188eu/hal/odm_RegConfig8188E.c  |  58 +-
 drivers/staging/r8188eu/hal/odm_debug.c       |   2 +-
 drivers/staging/r8188eu/hal/odm_interface.c   |  63 --
 drivers/staging/r8188eu/include/odm.h         |   2 -
 .../staging/r8188eu/include/odm_RTL8188E.h    |   4 -
 .../r8188eu/include/odm_RegConfig8188E.h      |   3 -
 .../staging/r8188eu/include/odm_interface.h   |  42 -
 drivers/staging/r8188eu/include/odm_precomp.h |  54 --
 .../staging/r8188eu/include/rtl8188e_hal.h    |  11 +-
 18 files changed, 635 insertions(+), 869 deletions(-)
 delete mode 100644 drivers/staging/r8188eu/hal/odm_interface.c
 delete mode 100644 drivers/staging/r8188eu/include/odm_interface.h
 delete mode 100644 drivers/staging/r8188eu/include/odm_precomp.h
Signature · 1 line
2.34.1