staging: r8188eu: remove odm_interface and odm_precomp.h
cover staging: r8188eu: remove odm_interface and odm_precomp.h
This series removes odm_interface.c, odm_interface.h and odm_precomp.h. The motivation for the removals is the ongoing effort to get grid of the hal layer.
Patches 1-11 remove all wrappers from odm_interface.c and finally remove odm_interface.c and its header file.
Patches 12-32 remove prototypes from odm_precomp.h by making the functions static and finally remove the header file.
Tested on x86_64 with Inter-Tech DMG-02.
Michael Straube (32):
staging: r8188eu: remove ODM_SetMACReg()
staging: r8188eu: remove ODM_GetMACReg()
staging: r8188eu: remove ODM_GetRFReg()
staging: r8188eu: remove ODM_SetRFReg()
staging: r8188eu: remove ODM_GetBBReg()
staging: r8188eu: remove ODM_SetBBReg()
staging: r8188eu: clean up coding style issues
staging: r8188eu: remove ODM_sleep_ms()
staging: r8188eu: remove ODM_delay_us()
staging: r8188eu: remove ODM_delay_ms()
staging: r8188eu: remove ODM_CompareMemory()
staging: r8188eu: remove odm_interface
staging: r8188eu: make odm_ConfigRFReg_8188E() static
staging: r8188eu: remove unused prototypes
staging: r8188eu: make odm_DIGInit() static
staging: r8188eu: make odm_DIG() static
staging: r8188eu: make odm_CommonInfoSelfInit() static
staging: r8188eu: make odm_CommonInfoSelfUpdate() static
staging: r8188eu: make odm_RateAdaptiveMaskInit() static
staging: r8188eu: make odm_RefreshRateAdaptiveMask() static
staging: r8188eu: make odm_DynamicBBPowerSavingInit() static
staging: r8188eu: make odm_FalseAlarmCounterStatistics() static
staging: r8188eu: make odm_CCKPacketDetectionThresh() static
staging: r8188eu: make odm_RSSIMonitorCheck() static
staging: r8188eu: remove odm_TXPowerTrackingInit()
staging: r8188eu: make odm_TXPowerTrackingThermalMeterInit() static
staging: r8188eu: make odm_InitHybridAntDiv() static
staging: r8188eu: make odm_HwAntDiv() static
staging: r8188eu: make ODM_EdcaTurboInit() static
staging: r8188eu: make odm_EdcaTurboCheck() static
staging: r8188eu: remove unnecessary comments
staging: r8188eu: remove header odm_precomp.h
drivers/staging/r8188eu/Makefile | 1 - .../r8188eu/hal/Hal8188ERateAdaptive.c | 17 +- .../staging/r8188eu/hal/HalHWImg8188E_BB.c | 1 - .../staging/r8188eu/hal/HalHWImg8188E_MAC.c | 1 - .../staging/r8188eu/hal/HalHWImg8188E_RF.c | 1 - drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 234 +++-- drivers/staging/r8188eu/hal/odm.c | 890 +++++++++--------- drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 +- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 118 +-- .../staging/r8188eu/hal/odm_RegConfig8188E.c | 58 +- drivers/staging/r8188eu/hal/odm_debug.c | 2 +- drivers/staging/r8188eu/hal/odm_interface.c | 63 -- drivers/staging/r8188eu/include/odm.h | 2 - .../staging/r8188eu/include/odm_RTL8188E.h | 4 - .../r8188eu/include/odm_RegConfig8188E.h | 3 - .../staging/r8188eu/include/odm_interface.h | 42 - drivers/staging/r8188eu/include/odm_precomp.h | 54 -- .../staging/r8188eu/include/rtl8188e_hal.h | 11 +- 18 files changed, 635 insertions(+), 869 deletions(-) delete mode 100644 drivers/staging/r8188eu/hal/odm_interface.c delete mode 100644 drivers/staging/r8188eu/include/odm_interface.h delete mode 100644 drivers/staging/r8188eu/include/odm_precomp.h
Signature · 1 line
2.34.1
PATCH 1/32 staging: r8188eu: remove ODM_SetMACReg()
ODM_SetMACReg() is just a wrapper around rtl8188e_PHY_SetBBReg(). Remove ODM_SetMACReg() and call rtl8188e_PHY_SetBBReg() directly.
--- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 18 +++++++++++------- drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ .../staging/r8188eu/include/odm_interface.h | 3 --- 3 files changed, 11 insertions(+), 16 deletions(-)
drivers/staging/r8188eu/hal/odm_RTL8188E.c +11 -7
@@ -5,11 +5,12 @@static void odm_RX_HWAntDivInit (struct odm_dm_struct *dm_odm) { +struct adapter *adapter = dm_odm->Adapter;u32 value32;/* MAC Setting */ value32 =ODM_GetMACReg (dm_odm,ODM_REG_ANTSEL_PIN_11N , bMaskDWord); -ODM_SetMACReg (dm_odm,ODM_REG_ANTSEL_PIN_11N , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_ANTSEL_PIN_11N , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ /* Pin Settings */ ODM_SetBBReg (dm_odm,ODM_REG_PIN_CTRL_11N ,BIT (9 ) |BIT (8 ),0 );/* Reg870[8]=1'b0, Reg870[9]=1'b0 antsel antselb by HW */ ODM_SetBBReg (dm_odm,ODM_REG_RX_ANT_CTRL_11N ,BIT (10 ),0 );/* Reg864[10]=1'b0 antsel2 by HW */
@@ -26,11 +27,12 @@ static void odm_RX_HWAntDivInit(struct odm_dm_struct *dm_odm)static void odm_TRX_HWAntDivInit (struct odm_dm_struct *dm_odm) { +struct adapter *adapter = dm_odm->Adapter;u32 value32;/* MAC Setting */ value32 =ODM_GetMACReg (dm_odm,ODM_REG_ANTSEL_PIN_11N , bMaskDWord); -ODM_SetMACReg (dm_odm,ODM_REG_ANTSEL_PIN_11N , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_ANTSEL_PIN_11N , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ /* Pin Settings */ ODM_SetBBReg (dm_odm,ODM_REG_PIN_CTRL_11N ,BIT (9 ) |BIT (8 ),0 );/* Reg870[8]=1'b0, Reg870[9]=1'b0 antsel antselb by HW */ ODM_SetBBReg (dm_odm,ODM_REG_RX_ANT_CTRL_11N ,BIT (10 ),0 );/* Reg864[10]=1'b0 antsel2 by HW */
@@ -56,17 +58,18 @@ static void odm_TRX_HWAntDivInit(struct odm_dm_struct *dm_odm)static void odm_FastAntTrainingInit (struct odm_dm_struct *dm_odm) { +struct adapter *adapter = dm_odm->Adapter;u32 value32;/* MAC Setting */ value32 =ODM_GetMACReg (dm_odm,0x4c , bMaskDWord); -ODM_SetMACReg (dm_odm,0x4c , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ +rtl8188e_PHY_SetBBReg (adapter,0x4c , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ value32 =ODM_GetMACReg (dm_odm,0x7B4 , bMaskDWord); -ODM_SetMACReg (dm_odm,0x7b4 , bMaskDWord, value32 | (BIT (16 ) |BIT (17 )));/* Reg7B4[16]=1 enable antenna training, Reg7B4[17]=1 enable A2 match */ +rtl8188e_PHY_SetBBReg (adapter,0x7b4 , bMaskDWord, value32 | (BIT (16 ) |BIT (17 )));/* Reg7B4[16]=1 enable antenna training, Reg7B4[17]=1 enable A2 match */ /* Match MAC ADDR */ -ODM_SetMACReg (dm_odm,0x7b4 ,0xFFFF ,0 ); -ODM_SetMACReg (dm_odm,0x7b0 , bMaskDWord,0 ); +rtl8188e_PHY_SetBBReg (adapter,0x7b4 ,0xFFFF ,0 ); +rtl8188e_PHY_SetBBReg (adapter,0x7b0 , bMaskDWord,0 );ODM_SetBBReg (dm_odm,0x870 ,BIT (9 ) |BIT (8 ),0 );/* Reg870[8]=1'b0, Reg870[9]=1'b0 antsel antselb by HW */ ODM_SetBBReg (dm_odm,0x864 ,BIT (10 ),0 );/* Reg864[10]=1'b0 antsel2 by HW */
@@ -105,6 +108,7 @@ void ODM_AntennaDiversityInit_88E(struct odm_dm_struct *dm_odm)void ODM_UpdateRxIdleAnt_88E (struct odm_dm_struct *dm_odm,u8 Ant) {struct fast_ant_train *dm_fat_tbl = &dm_odm->DM_FatTable; +struct adapter *adapter = dm_odm->Adapter;u32 DefaultAnt, OptionalAnt;if (dm_fat_tbl->RxIdleAnt != Ant) {
@@ -120,7 +124,7 @@ void ODM_UpdateRxIdleAnt_88E(struct odm_dm_struct *dm_odm, u8 Ant)ODM_SetBBReg (dm_odm,ODM_REG_RX_ANT_CTRL_11N ,BIT (5 ) |BIT (4 ) |BIT (3 ), DefaultAnt);/* Default RX */ ODM_SetBBReg (dm_odm,ODM_REG_RX_ANT_CTRL_11N ,BIT (8 ) |BIT (7 ) |BIT (6 ), OptionalAnt);/* Optional RX */ ODM_SetBBReg (dm_odm,ODM_REG_ANTSEL_CTRL_11N ,BIT (14 ) |BIT (13 ) |BIT (12 ), DefaultAnt);/* Default TX */ -ODM_SetMACReg (dm_odm,ODM_REG_RESP_TX_11N ,BIT (6 ) |BIT (7 ), DefaultAnt);/* Resp Tx */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_RESP_TX_11N ,BIT (6 ) |BIT (7 ), DefaultAnt);/* Resp Tx */ }else if (dm_odm->AntDivType ==CGCS_RX_HW_ANTDIV ) {ODM_SetBBReg (dm_odm,ODM_REG_RX_ANT_CTRL_11N ,BIT (5 ) |BIT (4 ) |BIT (3 ), DefaultAnt);/* Default RX */ ODM_SetBBReg (dm_odm,ODM_REG_RX_ANT_CTRL_11N ,BIT (8 ) |BIT (7 ) |BIT (6 ), OptionalAnt);/* Optional RX */
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -4,12 +4,6 @@#include "../include/odm_precomp.h" /* ODM IO Relative API. */ -void ODM_SetMACReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask,u32 Data) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -rtl8188e_PHY_SetBBReg (Adapter, RegAddr, BitMask, Data); -} -u32 ODM_GetMACReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask) {struct adapter *Adapter = pDM_Odm->Adapter;
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -12,9 +12,6 @@ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);/* =========== EXtern Function Prototype */ -void ODM_SetMACReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr, -u32 BitMask,u32 Data); -u32 ODM_GetMACReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask); void ODM_SetBBReg(struct odm_dm_struct *pDM_Odm, u32 RegAddr,
Signature · 1 line
2.34.1
PATCH 2/32 staging: r8188eu: remove ODM_GetMACReg()
In reply to Michael StraubeODM_GetMACReg() is just a wrapper around rtl8188e_PHY_QueryBBReg(). Remove ODM_GetMACReg() and call rtl8188e_PHY_QueryBBReg() directly.
--- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 8 ++++---- drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ drivers/staging/r8188eu/include/odm_interface.h | 2 -- 3 files changed, 4 insertions(+), 12 deletions(-)
drivers/staging/r8188eu/hal/odm_RTL8188E.c +4 -4
@@ -9,7 +9,7 @@ static void odm_RX_HWAntDivInit(struct odm_dm_struct *dm_odm)u32 value32;/* MAC Setting */ - value32 =ODM_GetMACReg (dm_odm,ODM_REG_ANTSEL_PIN_11N , bMaskDWord); + value32 =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_ANTSEL_PIN_11N , bMaskDWord);rtl8188e_PHY_SetBBReg (adapter,ODM_REG_ANTSEL_PIN_11N , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ /* Pin Settings */ ODM_SetBBReg (dm_odm,ODM_REG_PIN_CTRL_11N ,BIT (9 ) |BIT (8 ),0 );/* Reg870[8]=1'b0, Reg870[9]=1'b0 antsel antselb by HW */
@@ -31,7 +31,7 @@ static void odm_TRX_HWAntDivInit(struct odm_dm_struct *dm_odm)u32 value32;/* MAC Setting */ - value32 =ODM_GetMACReg (dm_odm,ODM_REG_ANTSEL_PIN_11N , bMaskDWord); + value32 =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_ANTSEL_PIN_11N , bMaskDWord);rtl8188e_PHY_SetBBReg (adapter,ODM_REG_ANTSEL_PIN_11N , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ /* Pin Settings */ ODM_SetBBReg (dm_odm,ODM_REG_PIN_CTRL_11N ,BIT (9 ) |BIT (8 ),0 );/* Reg870[8]=1'b0, Reg870[9]=1'b0 antsel antselb by HW */
@@ -62,9 +62,9 @@ static void odm_FastAntTrainingInit(struct odm_dm_struct *dm_odm)u32 value32;/* MAC Setting */ - value32 =ODM_GetMACReg (dm_odm,0x4c , bMaskDWord); + value32 =rtl8188e_PHY_QueryBBReg (adapter,0x4c , bMaskDWord);rtl8188e_PHY_SetBBReg (adapter,0x4c , bMaskDWord, value32 | (BIT (23 ) |BIT (25 )));/* Reg4C[25]=1, Reg4C[23]=1 for pin output */ - value32 =ODM_GetMACReg (dm_odm,0x7B4 , bMaskDWord); + value32 =rtl8188e_PHY_QueryBBReg (adapter,0x7B4 , bMaskDWord);rtl8188e_PHY_SetBBReg (adapter,0x7b4 , bMaskDWord, value32 | (BIT (16 ) |BIT (17 )));/* Reg7B4[16]=1 enable antenna training, Reg7B4[17]=1 enable A2 match */ /* Match MAC ADDR */
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -4,12 +4,6 @@#include "../include/odm_precomp.h" /* ODM IO Relative API. */ -u32 ODM_GetMACReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -return rtl8188e_PHY_QueryBBReg (Adapter, RegAddr, BitMask); -} -void ODM_SetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask,u32 Data) {struct adapter *Adapter = pDM_Odm->Adapter;
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -12,8 +12,6 @@ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);/* =========== EXtern Function Prototype */ -u32 ODM_GetMACReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask); -void ODM_SetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask,u32 Data);
Signature · 1 line
2.34.1
PATCH 3/32 staging: r8188eu: remove ODM_GetRFReg()
In reply to Michael StraubeODM_GetRFReg() is just a wrapper around rtl8188e_PHY_QueryRFReg(). Remove ODM_GetRFReg() and call rtl8188e_PHY_QueryRFReg() directly.
--- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ drivers/staging/r8188eu/include/odm_interface.h | 3 --- 3 files changed, 1 insertion(+), 10 deletions(-)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +1 -1
@@ -137,7 +137,7 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(/* <Kordan> RFCalibrateInfo.RegA24 will be initialized when ODM HW configuring, but MP configures with para files. */ dm_odm->RFCalibrateInfo.RegA24 =0x090e1317 ; - ThermalValue = (u8 )ODM_GetRFReg (dm_odm,RF_PATH_A ,RF_T_METER_88E ,0xfc00 );/* 0x42: RF Reg[15:10] 88E */ + ThermalValue = (u8 )rtl8188e_PHY_QueryRFReg (Adapter,RF_PATH_A ,RF_T_METER_88E ,0xfc00 );/* 0x42: RF Reg[15:10] 88E */ if (is2t) rf =2 ;
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -22,12 +22,6 @@ void ODM_SetRFReg(struct odm_dm_struct *pDM_Odm, enum rf_radio_path eRFPath, u32rtl8188e_PHY_SetRFReg (Adapter, (enum rf_radio_path )eRFPath, RegAddr, BitMask, Data); } -u32 ODM_GetRFReg (struct odm_dm_struct *pDM_Odm,enum rf_radio_path eRFPath,u32 RegAddr,u32 BitMask) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -return rtl8188e_PHY_QueryRFReg (Adapter, (enum rf_radio_path )eRFPath, RegAddr, BitMask); -} -/* ODM Memory relative API. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length) {
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -20,9 +20,6 @@ u32 ODM_GetBBReg(struct odm_dm_struct *pDM_Odm, u32 RegAddr, u32 BitMask);void ODM_SetRFReg (struct odm_dm_struct *pDM_Odm,enum rf_radio_path eRFPath,u32 RegAddr,u32 BitMask,u32 Data); -u32 ODM_GetRFReg (struct odm_dm_struct *pDM_Odm,enum rf_radio_path eRFPath, -u32 RegAddr,u32 BitMask); -/* Memory Relative Function. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length);
Signature · 1 line
2.34.1
PATCH 4/32 staging: r8188eu: remove ODM_SetRFReg()
In reply to Michael StraubeODM_SetRFReg() is just a wrapper around rtl8188e_PHY_SetRFReg(). Remove ODM_SetRFReg() and call rtl8188e_PHY_SetRFReg() directly.
--- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 34 +++++++++---------- .../staging/r8188eu/hal/odm_RegConfig8188E.c | 2 +- drivers/staging/r8188eu/hal/odm_interface.c | 6 ---- .../staging/r8188eu/include/odm_interface.h | 3 -- 4 files changed, 17 insertions(+), 28 deletions(-)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +16 -18
@@ -409,14 +409,14 @@ phy_PathA_RxIQK(struct adapter *adapt)/* 1 Get TXIMR setting */ /* modify RXIQK mode table */ ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x00000000 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_WE_LUT , bRFRegOffsetMask,0x800a0 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_RCK_OS , bRFRegOffsetMask,0x30000 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_TXPA_G1 , bRFRegOffsetMask,0x0000f ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_TXPA_G2 , bRFRegOffsetMask,0xf117B ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_WE_LUT , bRFRegOffsetMask,0x800a0 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_RCK_OS , bRFRegOffsetMask,0x30000 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_TXPA_G1 , bRFRegOffsetMask,0x0000f ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_TXPA_G2 , bRFRegOffsetMask,0xf117B );/* PA,PAD off */ -ODM_SetRFReg (dm_odm,RF_PATH_A ,0xdf , bRFRegOffsetMask,0x980 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,0x56 , bRFRegOffsetMask,0x51000 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,0xdf , bRFRegOffsetMask,0x980 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,0x56 , bRFRegOffsetMask,0x51000 );ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x80800000 );
@@ -458,10 +458,10 @@ phy_PathA_RxIQK(struct adapter *adapt)/* 1 RX IQK */ /* modify RXIQK mode table */ ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x00000000 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_WE_LUT , bRFRegOffsetMask,0x800a0 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_RCK_OS , bRFRegOffsetMask,0x30000 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_TXPA_G1 , bRFRegOffsetMask,0x0000f ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_TXPA_G2 , bRFRegOffsetMask,0xf7ffa ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_WE_LUT , bRFRegOffsetMask,0x800a0 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_RCK_OS , bRFRegOffsetMask,0x30000 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_TXPA_G1 , bRFRegOffsetMask,0x0000f ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_TXPA_G2 , bRFRegOffsetMask,0xf7ffa );ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x80800000 );/* IQK setting */
@@ -492,7 +492,7 @@ phy_PathA_RxIQK(struct adapter *adapt)/* reload RF 0xdf */ ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x00000000 ); -ODM_SetRFReg (dm_odm,RF_PATH_A ,0xdf , bRFRegOffsetMask,0x180 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,0xdf , bRFRegOffsetMask,0x180 ); if (!(regeac & BIT(27)) && /* if Tx is OK, check whether Rx is OK */ (((regEA4 & 0x03FF0000) >> 16) != 0x132) &&
@@ -839,8 +839,6 @@ static void phy_LCCalibrate_8188E(struct adapter *adapt, bool is2t) {u8 tmpreg;u32 RF_Amode =0 , RF_Bmode =0 , LC_Cal; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv;/* Check continuous TX and Packet TX */ tmpreg =rtw_read8 (adapt,0xd03 );
@@ -861,18 +859,18 @@ static void phy_LCCalibrate_8188E(struct adapter *adapt, bool is2t)/* 2. Set RF mode = standby mode */ /* Path-A */ -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_AC , bMask12Bits, (RF_Amode &0x8FFFF ) |0x10000 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_AC , bMask12Bits, (RF_Amode &0x8FFFF ) |0x10000 );/* Path-B */ if (is2t) -ODM_SetRFReg (dm_odm,RF_PATH_B ,RF_AC , bMask12Bits, (RF_Bmode &0x8FFFF ) |0x10000 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_B ,RF_AC , bMask12Bits, (RF_Bmode &0x8FFFF ) |0x10000 ); }/* 3. Read RF reg18 */ LC_Cal =rtl8188e_PHY_QueryRFReg (adapt,RF_PATH_A ,RF_CHNLBW , bMask12Bits);/* 4. Set LC calibration begin bit15 */ -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_CHNLBW , bMask12Bits, LC_Cal |0x08000 ); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_CHNLBW , bMask12Bits, LC_Cal |0x08000 );ODM_sleep_ms (100 );
@@ -881,11 +879,11 @@ static void phy_LCCalibrate_8188E(struct adapter *adapt, bool is2t)/* Deal with continuous TX case */ /* Path-A */ rtw_write8 (adapt,0xd03 , tmpreg); -ODM_SetRFReg (dm_odm,RF_PATH_A ,RF_AC , bMask12Bits, RF_Amode); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_AC , bMask12Bits, RF_Amode);/* Path-B */ if (is2t) -ODM_SetRFReg (dm_odm,RF_PATH_B ,RF_AC , bMask12Bits, RF_Bmode); +rtl8188e_PHY_SetRFReg (adapt,RF_PATH_B ,RF_AC , bMask12Bits, RF_Bmode); }else {/* Deal with Packet TX case */ rtw_write8 (adapt,REG_TXPAUSE ,0x00 );
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +1 -1
@@ -20,7 +20,7 @@ void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, }else if (Addr ==0xf9 ) {ODM_delay_us (1 ); }else { -ODM_SetRFReg (pDM_Odm,RF_PATH , RegAddr, bRFRegOffsetMask, Data); +rtl8188e_PHY_SetRFReg (pDM_Odm->Adapter,RF_PATH , RegAddr, bRFRegOffsetMask, Data);/* Add 1us delay between BB/RF register setting. */ ODM_delay_us (1 ); }
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -16,12 +16,6 @@ u32 ODM_GetBBReg(struct odm_dm_struct *pDM_Odm, u32 RegAddr, u32 BitMask)return rtl8188e_PHY_QueryBBReg (Adapter, RegAddr, BitMask); } -void ODM_SetRFReg (struct odm_dm_struct *pDM_Odm,enum rf_radio_path eRFPath,u32 RegAddr,u32 BitMask,u32 Data) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -rtl8188e_PHY_SetRFReg (Adapter, (enum rf_radio_path )eRFPath, RegAddr, BitMask, Data); -} -/* ODM Memory relative API. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length) {
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -17,9 +17,6 @@ void ODM_SetBBReg(struct odm_dm_struct *pDM_Odm, u32 RegAddr,u32 ODM_GetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask); -void ODM_SetRFReg (struct odm_dm_struct *pDM_Odm,enum rf_radio_path eRFPath, -u32 RegAddr,u32 BitMask,u32 Data); -/* Memory Relative Function. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length);
Signature · 1 line
2.34.1
PATCH 5/32 staging: r8188eu: remove ODM_GetBBReg()
In reply to Michael StraubeODM_GetBBReg() is just a wrapper around rtl8188e_PHY_QueryBBReg(). Remove ODM_GetBBReg() and call rtl8188e_PHY_QueryBBReg() directly.
--- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 40 +++++++++---------- drivers/staging/r8188eu/hal/odm.c | 35 +++++++++------- drivers/staging/r8188eu/hal/odm_interface.c | 6 --- .../staging/r8188eu/include/odm_interface.h | 2 - 4 files changed, 39 insertions(+), 44 deletions(-)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +19 -21
@@ -146,7 +146,7 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(if (ThermalValue) {/* Query OFDM path A default setting */ - ele_D =ODM_GetBBReg (dm_odm, rOFDM0_XATxIQImbalance, bMaskDWord) & bMaskOFDM_D; + ele_D =rtl8188e_PHY_QueryBBReg (Adapter, rOFDM0_XATxIQImbalance, bMaskDWord) & bMaskOFDM_D;for (i =0 ; i <OFDM_TABLE_SIZE_92D ; i++) {/* find the index */ if (ele_D == (OFDMSwingTable[i] & bMaskOFDM_D)) { OFDM_index_old[0 ] = (u8 )i;
@@ -157,7 +157,7 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(/* Query OFDM path B default setting */ if (is2t) { - ele_D =ODM_GetBBReg (dm_odm, rOFDM0_XBTxIQImbalance, bMaskDWord) & bMaskOFDM_D; + ele_D =rtl8188e_PHY_QueryBBReg (Adapter, rOFDM0_XBTxIQImbalance, bMaskDWord) & bMaskOFDM_D;for (i =0 ; i <OFDM_TABLE_SIZE_92D ; i++) {/* find the index */ if (ele_D == (OFDMSwingTable[i] & bMaskOFDM_D)) { OFDM_index_old[1 ] = (u8 )i;
@@ -387,9 +387,9 @@ phy_PathA_IQK_8188E(struct adapter *adapt)ODM_delay_ms (IQK_DELAY_TIME_88E );/* Check failed */ - regeac =ODM_GetBBReg (dm_odm, rRx_Power_After_IQK_A_2, bMaskDWord); - regE94 =ODM_GetBBReg (dm_odm, rTx_Power_Before_IQK_A, bMaskDWord); - regE9C =ODM_GetBBReg (dm_odm, rTx_Power_After_IQK_A, bMaskDWord); + regeac =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_After_IQK_A_2, bMaskDWord); + regE94 =rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_Before_IQK_A, bMaskDWord); + regE9C =rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_After_IQK_A, bMaskDWord); if (!(regeac & BIT(28)) && (((regE94 & 0x03FF0000) >> 16) != 0x142) &&
@@ -441,9 +441,9 @@ phy_PathA_RxIQK(struct adapter *adapt)ODM_delay_ms (IQK_DELAY_TIME_88E );/* Check failed */ - regeac =ODM_GetBBReg (dm_odm, rRx_Power_After_IQK_A_2, bMaskDWord); - regE94 =ODM_GetBBReg (dm_odm, rTx_Power_Before_IQK_A, bMaskDWord); - regE9C =ODM_GetBBReg (dm_odm, rTx_Power_After_IQK_A, bMaskDWord); + regeac =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_After_IQK_A_2, bMaskDWord); + regE94 =rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_Before_IQK_A, bMaskDWord); + regE9C =rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_After_IQK_A, bMaskDWord); if (!(regeac & BIT(28)) && (((regE94 & 0x03FF0000) >> 16) != 0x142) &&
@@ -485,10 +485,10 @@ phy_PathA_RxIQK(struct adapter *adapt)ODM_delay_ms (IQK_DELAY_TIME_88E );/* Check failed */ - regeac =ODM_GetBBReg (dm_odm, rRx_Power_After_IQK_A_2, bMaskDWord); - regE94 =ODM_GetBBReg (dm_odm, rTx_Power_Before_IQK_A, bMaskDWord); - regE9C =ODM_GetBBReg (dm_odm, rTx_Power_After_IQK_A, bMaskDWord); - regEA4 =ODM_GetBBReg (dm_odm, rRx_Power_Before_IQK_A_2, bMaskDWord); + regeac =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_After_IQK_A_2, bMaskDWord); + regE94 =rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_Before_IQK_A, bMaskDWord); + regE9C =rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_After_IQK_A, bMaskDWord); + regEA4 =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_Before_IQK_A_2, bMaskDWord);/* reload RF 0xdf */ ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x00000000 );
@@ -512,7 +512,7 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8], uif (final_candidate ==0xFF ) {return ; }else if (iqkok) { - Oldval_0 = (ODM_GetBBReg (dm_odm, rOFDM0_XATxIQImbalance, bMaskDWord) >>22 ) &0x3FF ; + Oldval_0 = (rtl8188e_PHY_QueryBBReg (adapt, rOFDM0_XATxIQImbalance, bMaskDWord) >>22 ) &0x3FF ;X = result[final_candidate][0 ];if ((X &0x00000200 ) !=0 )
@@ -549,11 +549,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8], uvoid _PHY_SaveADDARegisters (struct adapter *adapt,u32 *ADDAReg,u32 *ADDABackup,u32 RegisterNum) {u32 i; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv;for (i =0 ; i < RegisterNum; i++) { - ADDABackup[i] =ODM_GetBBReg (dm_odm, ADDAReg[i], bMaskDWord); + ADDABackup[i] =rtl8188e_PHY_QueryBBReg (adapt, ADDAReg[i], bMaskDWord); } }
@@ -760,7 +758,7 @@ static void phy_IQCalibrate_8188E(struct adapter *adapt, s32 result[][8], u8 t)_PHY_PathADDAOn (adapt,ADDA_REG );if (t ==0 ) - dm_odm->RFCalibrateInfo.bRfPiEnable = (u8 )ODM_GetBBReg (dm_odm, rFPGA0_XA_HSSIParameter1,BIT (8 )); + dm_odm->RFCalibrateInfo.bRfPiEnable = (u8 )rtl8188e_PHY_QueryBBReg (adapt, rFPGA0_XA_HSSIParameter1,BIT (8 ));if (!dm_odm->RFCalibrateInfo.bRfPiEnable) {/* Switch BB to PI mode to do IQ Calibration. */
@@ -794,8 +792,8 @@ static void phy_IQCalibrate_8188E(struct adapter *adapt, s32 result[][8], u8 t)for (i =0 ; i < retryCount; i++) { PathAOK =phy_PathA_IQK_8188E (adapt);if (PathAOK ==0x01 ) { - result[t][0 ] = (ODM_GetBBReg (dm_odm, rTx_Power_Before_IQK_A, bMaskDWord) &0x3FF0000 ) >>16 ; - result[t][1 ] = (ODM_GetBBReg (dm_odm, rTx_Power_After_IQK_A, bMaskDWord) &0x3FF0000 ) >>16 ; + result[t][0 ] = (rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_Before_IQK_A, bMaskDWord) &0x3FF0000 ) >>16 ; + result[t][1 ] = (rtl8188e_PHY_QueryBBReg (adapt, rTx_Power_After_IQK_A, bMaskDWord) &0x3FF0000 ) >>16 ;break ; } }
@@ -803,8 +801,8 @@ static void phy_IQCalibrate_8188E(struct adapter *adapt, s32 result[][8], u8 t)for (i =0 ; i < retryCount; i++) { PathAOK =phy_PathA_RxIQK (adapt);if (PathAOK ==0x03 ) { - result[t][2 ] = (ODM_GetBBReg (dm_odm, rRx_Power_Before_IQK_A_2, bMaskDWord) &0x3FF0000 ) >>16 ; - result[t][3 ] = (ODM_GetBBReg (dm_odm, rRx_Power_After_IQK_A_2, bMaskDWord) &0x3FF0000 ) >>16 ; + result[t][2 ] = (rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_Before_IQK_A_2, bMaskDWord) &0x3FF0000 ) >>16 ; + result[t][3 ] = (rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_After_IQK_A_2, bMaskDWord) &0x3FF0000 ) >>16 ;break ; } }
drivers/staging/r8188eu/hal/odm.c +20 -15
@@ -267,8 +267,10 @@ void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value)void odm_CommonInfoSelfInit (struct odm_dm_struct *pDM_Odm) { - pDM_Odm->bCckHighPower = (bool )ODM_GetBBReg (pDM_Odm,0x824 ,BIT (9 )); - pDM_Odm->RFPathRxEnable = (u8 )ODM_GetBBReg (pDM_Odm,0xc04 ,0x0F ); +struct adapter *adapter = pDM_Odm->Adapter; + + pDM_Odm->bCckHighPower = (bool )rtl8188e_PHY_QueryBBReg (adapter,0x824 ,BIT (9 )); + pDM_Odm->RFPathRxEnable = (u8 )rtl8188e_PHY_QueryBBReg (adapter,0xc04 ,0x0F ); }void odm_CommonInfoSelfUpdate (struct odm_dm_struct *pDM_Odm)
@@ -310,8 +312,9 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI)void odm_DIGInit (struct odm_dm_struct *pDM_Odm) {struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable; +struct adapter *adapter = pDM_Odm->Adapter; - pDM_DigTable->CurIGValue = (u8 )ODM_GetBBReg (pDM_Odm,ODM_REG_IGI_A_11N ,ODM_BIT_IGI_11N ); + pDM_DigTable->CurIGValue = (u8 )rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_IGI_A_11N ,ODM_BIT_IGI_11N ); pDM_DigTable->RssiLowThresh =DM_DIG_THRESH_LOW ; pDM_DigTable->RssiHighThresh =DM_DIG_THRESH_HIGH ; pDM_DigTable->FALowThresh = DM_false_ALARM_THRESH_LOW;
@@ -475,6 +478,7 @@ void odm_FalseAlarmCounterStatistics(struct odm_dm_struct *pDM_Odm) {u32 ret_value;struct false_alarm_stats *FalseAlmCnt = &pDM_Odm->FalseAlmCnt; +struct adapter *adapter = pDM_Odm->Adapter;if (!(pDM_Odm->SupportAbility &ODM_BB_FA_CNT ))return ;
@@ -483,23 +487,23 @@ void odm_FalseAlarmCounterStatistics(struct odm_dm_struct *pDM_Odm)ODM_SetBBReg (pDM_Odm,ODM_REG_OFDM_FA_HOLDC_11N ,BIT (31 ),1 );/* hold page C counter */ ODM_SetBBReg (pDM_Odm,ODM_REG_OFDM_FA_RSTD_11N ,BIT (31 ),1 );/* hold page D counter */ - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_OFDM_FA_TYPE1_11N , bMaskDWord); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE1_11N , bMaskDWord); FalseAlmCnt->Cnt_Fast_Fsync = (ret_value &0xffff ); FalseAlmCnt->Cnt_SB_Search_fail = ((ret_value &0xffff0000 ) >>16 ); - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_OFDM_FA_TYPE2_11N , bMaskDWord); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE2_11N , bMaskDWord); FalseAlmCnt->Cnt_OFDM_CCA = (ret_value &0xffff ); FalseAlmCnt->Cnt_Parity_Fail = ((ret_value &0xffff0000 ) >>16 ); - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_OFDM_FA_TYPE3_11N , bMaskDWord); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE3_11N , bMaskDWord); FalseAlmCnt->Cnt_Rate_Illegal = (ret_value &0xffff ); FalseAlmCnt->Cnt_Crc8_fail = ((ret_value &0xffff0000 ) >>16 ); - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_OFDM_FA_TYPE4_11N , bMaskDWord); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE4_11N , bMaskDWord); FalseAlmCnt->Cnt_Mcs_fail = (ret_value &0xffff ); FalseAlmCnt->Cnt_Ofdm_fail = FalseAlmCnt->Cnt_Parity_Fail + FalseAlmCnt->Cnt_Rate_Illegal + FalseAlmCnt->Cnt_Crc8_fail + FalseAlmCnt->Cnt_Mcs_fail + FalseAlmCnt->Cnt_Fast_Fsync + FalseAlmCnt->Cnt_SB_Search_fail; - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_SC_CNT_11N , bMaskDWord); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_SC_CNT_11N , bMaskDWord); FalseAlmCnt->Cnt_BW_LSC = (ret_value &0xffff ); FalseAlmCnt->Cnt_BW_USC = ((ret_value &0xffff0000 ) >>16 );
@@ -507,12 +511,12 @@ void odm_FalseAlarmCounterStatistics(struct odm_dm_struct *pDM_Odm)ODM_SetBBReg (pDM_Odm,ODM_REG_CCK_FA_RST_11N ,BIT (12 ),1 );ODM_SetBBReg (pDM_Odm,ODM_REG_CCK_FA_RST_11N ,BIT (14 ),1 ); - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_CCK_FA_LSB_11N , bMaskByte0); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_FA_LSB_11N , bMaskByte0); FalseAlmCnt->Cnt_Cck_fail = ret_value; - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_CCK_FA_MSB_11N , bMaskByte3); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_FA_MSB_11N , bMaskByte3); FalseAlmCnt->Cnt_Cck_fail += (ret_value &0xff ) <<8 ; - ret_value =ODM_GetBBReg (pDM_Odm,ODM_REG_CCK_CCA_CNT_11N , bMaskDWord); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_CCA_CNT_11N , bMaskDWord); FalseAlmCnt->Cnt_CCK_CCA = ((ret_value &0xFF ) <<8 ) | ((ret_value &0xFF00 ) >>8 ); FalseAlmCnt->Cnt_all = (FalseAlmCnt->Cnt_Fast_Fsync +
@@ -582,14 +586,15 @@ void odm_DynamicBBPowerSavingInit(struct odm_dm_struct *pDM_Odm)void ODM_RF_Saving (struct odm_dm_struct *pDM_Odm,u8 bForceInNormal) {struct rtl_ps *pDM_PSTable = &pDM_Odm->DM_PSTable; +struct adapter *adapter = pDM_Odm->Adapter;u8 Rssi_Up_bound =30 ;u8 Rssi_Low_bound =25 ;if (pDM_PSTable->initialize ==0 ) { - pDM_PSTable->reg_874 = (ODM_GetBBReg (pDM_Odm,0x874 , bMaskDWord) &0x1CC000 ) >>14 ; - pDM_PSTable->reg_c70 = (ODM_GetBBReg (pDM_Odm,0xc70 , bMaskDWord) &BIT (3 )) >>3 ; - pDM_PSTable->reg_85c = (ODM_GetBBReg (pDM_Odm,0x85c , bMaskDWord) &0xFF000000 ) >>24 ; - pDM_PSTable->reg_a74 = (ODM_GetBBReg (pDM_Odm,0xa74 , bMaskDWord) &0xF000 ) >>12 ; + pDM_PSTable->reg_874 = (rtl8188e_PHY_QueryBBReg (adapter,0x874 , bMaskDWord) &0x1CC000 ) >>14 ; + pDM_PSTable->reg_c70 = (rtl8188e_PHY_QueryBBReg (adapter,0xc70 , bMaskDWord) &BIT (3 )) >>3 ; + pDM_PSTable->reg_85c = (rtl8188e_PHY_QueryBBReg (adapter,0x85c , bMaskDWord) &0xFF000000 ) >>24 ; + pDM_PSTable->reg_a74 = (rtl8188e_PHY_QueryBBReg (adapter,0xa74 , bMaskDWord) &0xF000 ) >>12 ; pDM_PSTable->initialize =1 ; }
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -10,12 +10,6 @@ void ODM_SetBBReg(struct odm_dm_struct *pDM_Odm, u32 RegAddr, u32 BitMask, u32 Drtl8188e_PHY_SetBBReg (Adapter, RegAddr, BitMask, Data); } -u32 ODM_GetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -return rtl8188e_PHY_QueryBBReg (Adapter, RegAddr, BitMask); -} -/* ODM Memory relative API. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length) {
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -15,8 +15,6 @@ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);void ODM_SetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask,u32 Data); -u32 ODM_GetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask); -/* Memory Relative Function. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length);
Signature · 1 line
2.34.1
PATCH 6/32 staging: r8188eu: remove ODM_SetBBReg()
In reply to Michael StraubeODM_SetBBReg() is just a wrapper around rtl8188e_PHY_SetBBReg(). Remove ODM_SetBBReg() and call rtl8188e_PHY_SetBBReg() directly.
--- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 142 ++++++++---------- drivers/staging/r8188eu/hal/odm.c | 35 ++--- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 90 +++++------ .../staging/r8188eu/hal/odm_RegConfig8188E.c | 4 +- drivers/staging/r8188eu/hal/odm_interface.c | 6 - .../staging/r8188eu/include/odm_interface.h | 3 - 6 files changed, 131 insertions(+), 149 deletions(-)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +65 -77
@@ -329,17 +329,17 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(/* wtite new elements A, C, D to regC88 and regC9C, element B is always 0 */ value32 = (ele_D <<22 ) | ((ele_C &0x3F ) <<16 ) | ele_A; -ODM_SetBBReg (dm_odm, rOFDM0_XBTxIQImbalance, bMaskDWord, value32); +rtl8188e_PHY_SetBBReg (Adapter, rOFDM0_XBTxIQImbalance, bMaskDWord, value32); value32 = (ele_C &0x000003C0 ) >>6 ; -ODM_SetBBReg (dm_odm, rOFDM0_XDTxAFE, bMaskH4Bits, value32); +rtl8188e_PHY_SetBBReg (Adapter, rOFDM0_XDTxAFE, bMaskH4Bits, value32); value32 = ((X * ele_D) >>7 ) &0x01 ; -ODM_SetBBReg (dm_odm, rOFDM0_ECCAThreshold,BIT (28 ), value32); +rtl8188e_PHY_SetBBReg (Adapter, rOFDM0_ECCAThreshold,BIT (28 ), value32); }else { -ODM_SetBBReg (dm_odm, rOFDM0_XBTxIQImbalance, bMaskDWord, OFDMSwingTable[(u8 )OFDM_index[1 ]]); -ODM_SetBBReg (dm_odm, rOFDM0_XDTxAFE, bMaskH4Bits,0x00 ); -ODM_SetBBReg (dm_odm, rOFDM0_ECCAThreshold,BIT (28 ),0x00 ); +rtl8188e_PHY_SetBBReg (Adapter, rOFDM0_XBTxIQImbalance, bMaskDWord, OFDMSwingTable[(u8 )OFDM_index[1 ]]); +rtl8188e_PHY_SetBBReg (Adapter, rOFDM0_XDTxAFE, bMaskH4Bits,0x00 ); +rtl8188e_PHY_SetBBReg (Adapter, rOFDM0_ECCAThreshold,BIT (28 ),0x00 ); } } }
@@ -365,22 +365,20 @@ phy_PathA_IQK_8188E(struct adapter *adapt) {u32 regeac, regE94, regE9C;u8 result =0x00 ; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv;/* 1 Tx IQK */ /* path-A IQK setting */ -ODM_SetBBReg (dm_odm, rTx_IQK_Tone_A, bMaskDWord,0x10008c1c ); -ODM_SetBBReg (dm_odm, rRx_IQK_Tone_A, bMaskDWord,0x30008c1c ); -ODM_SetBBReg (dm_odm, rTx_IQK_PI_A, bMaskDWord,0x8214032a ); -ODM_SetBBReg (dm_odm, rRx_IQK_PI_A, bMaskDWord,0x28160000 ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK_Tone_A, bMaskDWord,0x10008c1c ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK_Tone_A, bMaskDWord,0x30008c1c ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK_PI_A, bMaskDWord,0x8214032a ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK_PI_A, bMaskDWord,0x28160000 );/* LO calibration setting */ -ODM_SetBBReg (dm_odm, rIQK_AGC_Rsp, bMaskDWord,0x00462911 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Rsp, bMaskDWord,0x00462911 );/* One shot, path A LOK & IQK */ -ODM_SetBBReg (dm_odm, rIQK_AGC_Pts, bMaskDWord,0xf9000000 ); -ODM_SetBBReg (dm_odm, rIQK_AGC_Pts, bMaskDWord,0xf8000000 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Pts, bMaskDWord,0xf9000000 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Pts, bMaskDWord,0xf8000000 );/* delay x ms */ /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */
@@ -403,12 +401,10 @@ phy_PathA_RxIQK(struct adapter *adapt) {u32 regeac, regE94, regE9C, regEA4, u4tmp;u8 result =0x00 ; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv;/* 1 Get TXIMR setting */ /* modify RXIQK mode table */ -ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x00000000 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_IQK, bMaskDWord,0x00000000 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_WE_LUT , bRFRegOffsetMask,0x800a0 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_RCK_OS , bRFRegOffsetMask,0x30000 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_TXPA_G1 , bRFRegOffsetMask,0x0000f );
@@ -418,24 +414,24 @@ phy_PathA_RxIQK(struct adapter *adapt)rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,0xdf , bRFRegOffsetMask,0x980 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,0x56 , bRFRegOffsetMask,0x51000 ); -ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x80800000 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_IQK, bMaskDWord,0x80800000 );/* IQK setting */ -ODM_SetBBReg (dm_odm, rTx_IQK, bMaskDWord,0x01007c00 ); -ODM_SetBBReg (dm_odm, rRx_IQK, bMaskDWord,0x81004800 ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK, bMaskDWord,0x01007c00 ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK, bMaskDWord,0x81004800 );/* path-A IQK setting */ -ODM_SetBBReg (dm_odm, rTx_IQK_Tone_A, bMaskDWord,0x10008c1c ); -ODM_SetBBReg (dm_odm, rRx_IQK_Tone_A, bMaskDWord,0x30008c1c ); -ODM_SetBBReg (dm_odm, rTx_IQK_PI_A, bMaskDWord,0x82160c1f ); -ODM_SetBBReg (dm_odm, rRx_IQK_PI_A, bMaskDWord,0x28160000 ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK_Tone_A, bMaskDWord,0x10008c1c ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK_Tone_A, bMaskDWord,0x30008c1c ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK_PI_A, bMaskDWord,0x82160c1f ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK_PI_A, bMaskDWord,0x28160000 );/* LO calibration setting */ -ODM_SetBBReg (dm_odm, rIQK_AGC_Rsp, bMaskDWord,0x0046a911 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Rsp, bMaskDWord,0x0046a911 );/* One shot, path A LOK & IQK */ -ODM_SetBBReg (dm_odm, rIQK_AGC_Pts, bMaskDWord,0xf9000000 ); -ODM_SetBBReg (dm_odm, rIQK_AGC_Pts, bMaskDWord,0xf8000000 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Pts, bMaskDWord,0xf9000000 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Pts, bMaskDWord,0xf8000000 );/* delay x ms */ ODM_delay_ms (IQK_DELAY_TIME_88E );
@@ -453,32 +449,32 @@ phy_PathA_RxIQK(struct adapter *adapt)return result; u4tmp =0x80007C00 | (regE94 &0x3FF0000 ) | ((regE9C &0x3FF0000 ) >>16 ); -ODM_SetBBReg (dm_odm, rTx_IQK, bMaskDWord, u4tmp); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK, bMaskDWord, u4tmp);/* 1 RX IQK */ /* modify RXIQK mode table */ -ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x00000000 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_IQK, bMaskDWord,0x00000000 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_WE_LUT , bRFRegOffsetMask,0x800a0 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_RCK_OS , bRFRegOffsetMask,0x30000 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_TXPA_G1 , bRFRegOffsetMask,0x0000f );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_TXPA_G2 , bRFRegOffsetMask,0xf7ffa ); -ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x80800000 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_IQK, bMaskDWord,0x80800000 );/* IQK setting */ -ODM_SetBBReg (dm_odm, rRx_IQK, bMaskDWord,0x01004800 ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK, bMaskDWord,0x01004800 );/* path-A IQK setting */ -ODM_SetBBReg (dm_odm, rTx_IQK_Tone_A, bMaskDWord,0x38008c1c ); -ODM_SetBBReg (dm_odm, rRx_IQK_Tone_A, bMaskDWord,0x18008c1c ); -ODM_SetBBReg (dm_odm, rTx_IQK_PI_A, bMaskDWord,0x82160c05 ); -ODM_SetBBReg (dm_odm, rRx_IQK_PI_A, bMaskDWord,0x28160c1f ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK_Tone_A, bMaskDWord,0x38008c1c ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK_Tone_A, bMaskDWord,0x18008c1c ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK_PI_A, bMaskDWord,0x82160c05 ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK_PI_A, bMaskDWord,0x28160c1f );/* LO calibration setting */ -ODM_SetBBReg (dm_odm, rIQK_AGC_Rsp, bMaskDWord,0x0046a911 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Rsp, bMaskDWord,0x0046a911 );/* One shot, path A LOK & IQK */ -ODM_SetBBReg (dm_odm, rIQK_AGC_Pts, bMaskDWord,0xf9000000 ); -ODM_SetBBReg (dm_odm, rIQK_AGC_Pts, bMaskDWord,0xf8000000 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Pts, bMaskDWord,0xf9000000 ); +rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Pts, bMaskDWord,0xf8000000 );/* delay x ms */ /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */
@@ -491,7 +487,7 @@ phy_PathA_RxIQK(struct adapter *adapt) regEA4 =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_Before_IQK_A_2, bMaskDWord);/* reload RF 0xdf */ -ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x00000000 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_IQK, bMaskDWord,0x00000000 );rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,0xdf , bRFRegOffsetMask,0x180 ); if (!(regeac & BIT(27)) && /* if Tx is OK, check whether Rx is OK */
@@ -506,8 +502,6 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8], u {u32 Oldval_0,X ,TX0_A , reg;s32 Y ,TX0_C ; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv;if (final_candidate ==0xFF ) {return ;
@@ -518,31 +512,31 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8], uif ((X &0x00000200 ) !=0 )X =X |0xFFFFFC00 ;TX0_A = (X * Oldval_0) >>8 ; -ODM_SetBBReg (dm_odm, rOFDM0_XATxIQImbalance,0x3FF ,TX0_A ); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_XATxIQImbalance,0x3FF ,TX0_A ); -ODM_SetBBReg (dm_odm, rOFDM0_ECCAThreshold,BIT (31 ), ((X * Oldval_0 >>7 ) &0x1 )); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_ECCAThreshold,BIT (31 ), ((X * Oldval_0 >>7 ) &0x1 ));Y = result[final_candidate][1 ];if ((Y &0x00000200 ) !=0 )Y =Y |0xFFFFFC00 ;TX0_C = (Y * Oldval_0) >>8 ; -ODM_SetBBReg (dm_odm, rOFDM0_XCTxAFE,0xF0000000 , ((TX0_C &0x3C0 ) >>6 )); -ODM_SetBBReg (dm_odm, rOFDM0_XATxIQImbalance,0x003F0000 , (TX0_C &0x3F )); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_XCTxAFE,0xF0000000 , ((TX0_C &0x3C0 ) >>6 )); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_XATxIQImbalance,0x003F0000 , (TX0_C &0x3F )); -ODM_SetBBReg (dm_odm, rOFDM0_ECCAThreshold,BIT (29 ), ((Y * Oldval_0 >>7 ) &0x1 )); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_ECCAThreshold,BIT (29 ), ((Y * Oldval_0 >>7 ) &0x1 ));if (txonly)return ; reg = result[final_candidate][2 ]; -ODM_SetBBReg (dm_odm, rOFDM0_XARxIQImbalance,0x3FF , reg); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_XARxIQImbalance,0x3FF , reg); reg = result[final_candidate][3 ] &0x3F ; -ODM_SetBBReg (dm_odm, rOFDM0_XARxIQImbalance,0xFC00 , reg); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_XARxIQImbalance,0xFC00 , reg); reg = (result[final_candidate][3 ] >>6 ) &0xF ; -ODM_SetBBReg (dm_odm, rOFDM0_RxIQExtAnta,0xF0000000 , reg); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_RxIQExtAnta,0xF0000000 , reg); } }
@@ -572,11 +566,9 @@ static void _PHY_SaveMACRegisters(static void reload_adda_reg (struct adapter *adapt,u32 *ADDAReg,u32 *ADDABackup,u32 RegiesterNum) {u32 i; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv;for (i =0 ; i < RegiesterNum; i++) -ODM_SetBBReg (dm_odm, ADDAReg[i], bMaskDWord, ADDABackup[i]); +rtl8188e_PHY_SetBBReg (adapt, ADDAReg[i], bMaskDWord, ADDABackup[i]); } static void
@@ -600,13 +592,11 @@ _PHY_PathADDAOn( u32 *ADDAReg) {u32 i; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv; -ODM_SetBBReg (dm_odm, ADDAReg[0 ], bMaskDWord,0x0b1b25a0 ); +rtl8188e_PHY_SetBBReg (adapt, ADDAReg[0 ], bMaskDWord,0x0b1b25a0 );for (i =1 ; i <IQK_ADDA_REG_NUM ; i++) -ODM_SetBBReg (dm_odm, ADDAReg[i], bMaskDWord,0x0bdb25a0 ); +rtl8188e_PHY_SetBBReg (adapt, ADDAReg[i], bMaskDWord,0x0bdb25a0 ); }void
@@ -632,12 +622,10 @@ static void _PHY_PIModeSwitch( ) {u32 mode; -struct hal_data_8188e *pHalData = &adapt->haldata; -struct odm_dm_struct *dm_odm = &pHalData->odmpriv; mode = PIMode ?0x01000100 :0x01000000 ; -ODM_SetBBReg (dm_odm, rFPGA0_XA_HSSIParameter1, bMaskDWord, mode); -ODM_SetBBReg (dm_odm, rFPGA0_XB_HSSIParameter1, bMaskDWord, mode); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XA_HSSIParameter1, bMaskDWord, mode); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XB_HSSIParameter1, bMaskDWord, mode); } static bool phy_SimularityCompare_8188E(
@@ -766,28 +754,28 @@ static void phy_IQCalibrate_8188E(struct adapter *adapt, s32 result[][8], u8 t) }/* BB setting */ -ODM_SetBBReg (dm_odm, rFPGA0_RFMOD,BIT (24 ),0x00 ); -ODM_SetBBReg (dm_odm, rOFDM0_TRxPathEnable, bMaskDWord,0x03a05600 ); -ODM_SetBBReg (dm_odm, rOFDM0_TRMuxPar, bMaskDWord,0x000800e4 ); -ODM_SetBBReg (dm_odm, rFPGA0_XCD_RFInterfaceSW, bMaskDWord,0x22204000 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_RFMOD,BIT (24 ),0x00 ); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_TRxPathEnable, bMaskDWord,0x03a05600 ); +rtl8188e_PHY_SetBBReg (adapt, rOFDM0_TRMuxPar, bMaskDWord,0x000800e4 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XCD_RFInterfaceSW, bMaskDWord,0x22204000 ); -ODM_SetBBReg (dm_odm, rFPGA0_XAB_RFInterfaceSW,BIT (10 ),0x01 ); -ODM_SetBBReg (dm_odm, rFPGA0_XAB_RFInterfaceSW,BIT (26 ),0x01 ); -ODM_SetBBReg (dm_odm, rFPGA0_XA_RFInterfaceOE,BIT (10 ),0x00 ); -ODM_SetBBReg (dm_odm, rFPGA0_XB_RFInterfaceOE,BIT (10 ),0x00 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XAB_RFInterfaceSW,BIT (10 ),0x01 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XAB_RFInterfaceSW,BIT (26 ),0x01 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XA_RFInterfaceOE,BIT (10 ),0x00 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XB_RFInterfaceOE,BIT (10 ),0x00 );/* MAC settings */ _PHY_MACSettingCalibration (adapt,IQK_MAC_REG , dm_odm->RFCalibrateInfo.IQK_MAC_backup);/* Page B init */ /* AP or IQK */ -ODM_SetBBReg (dm_odm, rConfig_AntA, bMaskDWord,0x0f600000 ); +rtl8188e_PHY_SetBBReg (adapt, rConfig_AntA, bMaskDWord,0x0f600000 );/* IQ calibration setting */ -ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0x80800000 ); -ODM_SetBBReg (dm_odm, rTx_IQK, bMaskDWord,0x01007c00 ); -ODM_SetBBReg (dm_odm, rRx_IQK, bMaskDWord,0x81004800 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_IQK, bMaskDWord,0x80800000 ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK, bMaskDWord,0x01007c00 ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK, bMaskDWord,0x81004800 );for (i =0 ; i < retryCount; i++) { PathAOK =phy_PathA_IQK_8188E (adapt);
@@ -808,7 +796,7 @@ static void phy_IQCalibrate_8188E(struct adapter *adapt, s32 result[][8], u8 t) }/* Back to BB mode, load original value */ -ODM_SetBBReg (dm_odm, rFPGA0_IQK, bMaskDWord,0 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_IQK, bMaskDWord,0 );if (t !=0 ) {if (!dm_odm->RFCalibrateInfo.bRfPiEnable) {
@@ -825,11 +813,11 @@ static void phy_IQCalibrate_8188E(struct adapter *adapt, s32 result[][8], u8 t)reload_adda_reg (adapt,IQK_BB_REG_92C , dm_odm->RFCalibrateInfo.IQK_BB_backup,IQK_BB_REG_NUM );/* Restore RX initial gain */ -ODM_SetBBReg (dm_odm, rFPGA0_XA_LSSIParameter, bMaskDWord,0x00032ed3 ); +rtl8188e_PHY_SetBBReg (adapt, rFPGA0_XA_LSSIParameter, bMaskDWord,0x00032ed3 );/* load 0xe30 IQC default value */ -ODM_SetBBReg (dm_odm, rTx_IQK_Tone_A, bMaskDWord,0x01008c00 ); -ODM_SetBBReg (dm_odm, rRx_IQK_Tone_A, bMaskDWord,0x01008c00 ); +rtl8188e_PHY_SetBBReg (adapt, rTx_IQK_Tone_A, bMaskDWord,0x01008c00 ); +rtl8188e_PHY_SetBBReg (adapt, rRx_IQK_Tone_A, bMaskDWord,0x01008c00 ); } }
drivers/staging/r8188eu/hal/odm.c +18 -17
@@ -302,9 +302,10 @@ void odm_CommonInfoSelfUpdate(struct odm_dm_struct *pDM_Odm)void ODM_Write_DIG (struct odm_dm_struct *pDM_Odm,u8 CurrentIGI) {struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable; +struct adapter *adapter = pDM_Odm->Adapter;if (pDM_DigTable->CurIGValue != CurrentIGI) { -ODM_SetBBReg (pDM_Odm,ODM_REG_IGI_A_11N ,ODM_BIT_IGI_11N , CurrentIGI); +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_IGI_A_11N ,ODM_BIT_IGI_11N , CurrentIGI); pDM_DigTable->CurIGValue = CurrentIGI; } }
@@ -484,8 +485,8 @@ void odm_FalseAlarmCounterStatistics(struct odm_dm_struct *pDM_Odm)return ;/* hold ofdm counter */ -ODM_SetBBReg (pDM_Odm,ODM_REG_OFDM_FA_HOLDC_11N ,BIT (31 ),1 );/* hold page C counter */ -ODM_SetBBReg (pDM_Odm,ODM_REG_OFDM_FA_RSTD_11N ,BIT (31 ),1 );/* hold page D counter */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_OFDM_FA_HOLDC_11N ,BIT (31 ),1 );/* hold page C counter */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_OFDM_FA_RSTD_11N ,BIT (31 ),1 );/* hold page D counter */ ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE1_11N , bMaskDWord); FalseAlmCnt->Cnt_Fast_Fsync = (ret_value &0xffff );
@@ -508,8 +509,8 @@ void odm_FalseAlarmCounterStatistics(struct odm_dm_struct *pDM_Odm) FalseAlmCnt->Cnt_BW_USC = ((ret_value &0xffff0000 ) >>16 );/* hold cck counter */ -ODM_SetBBReg (pDM_Odm,ODM_REG_CCK_FA_RST_11N ,BIT (12 ),1 ); -ODM_SetBBReg (pDM_Odm,ODM_REG_CCK_FA_RST_11N ,BIT (14 ),1 ); +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_CCK_FA_RST_11N ,BIT (12 ),1 ); +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_CCK_FA_RST_11N ,BIT (14 ),1 ); ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_FA_LSB_11N , bMaskByte0); FalseAlmCnt->Cnt_Cck_fail = ret_value;
@@ -620,19 +621,19 @@ void ODM_RF_Saving(struct odm_dm_struct *pDM_Odm, u8 bForceInNormal)if (pDM_PSTable->pre_rf_state != pDM_PSTable->cur_rf_state) {if (pDM_PSTable->cur_rf_state == RF_Save) { -ODM_SetBBReg (pDM_Odm,0x874 ,0x1C0000 ,0x2 );/* Reg874[20:18]=3'b010 */ -ODM_SetBBReg (pDM_Odm,0xc70 ,BIT (3 ),0 );/* RegC70[3]=1'b0 */ -ODM_SetBBReg (pDM_Odm,0x85c ,0xFF000000 ,0x63 );/* Reg85C[31:24]=0x63 */ -ODM_SetBBReg (pDM_Odm,0x874 ,0xC000 ,0x2 );/* Reg874[15:14]=2'b10 */ -ODM_SetBBReg (pDM_Odm,0xa74 ,0xF000 ,0x3 );/* RegA75[7:4]=0x3 */ -ODM_SetBBReg (pDM_Odm,0x818 ,BIT (28 ),0x0 );/* Reg818[28]=1'b0 */ -ODM_SetBBReg (pDM_Odm,0x818 ,BIT (28 ),0x1 );/* Reg818[28]=1'b1 */ +rtl8188e_PHY_SetBBReg (adapter,0x874 ,0x1C0000 ,0x2 );/* Reg874[20:18]=3'b010 */ +rtl8188e_PHY_SetBBReg (adapter,0xc70 ,BIT (3 ),0 );/* RegC70[3]=1'b0 */ +rtl8188e_PHY_SetBBReg (adapter,0x85c ,0xFF000000 ,0x63 );/* Reg85C[31:24]=0x63 */ +rtl8188e_PHY_SetBBReg (adapter,0x874 ,0xC000 ,0x2 );/* Reg874[15:14]=2'b10 */ +rtl8188e_PHY_SetBBReg (adapter,0xa74 ,0xF000 ,0x3 );/* RegA75[7:4]=0x3 */ +rtl8188e_PHY_SetBBReg (adapter,0x818 ,BIT (28 ),0x0 );/* Reg818[28]=1'b0 */ +rtl8188e_PHY_SetBBReg (adapter,0x818 ,BIT (28 ),0x1 );/* Reg818[28]=1'b1 */ }else { -ODM_SetBBReg (pDM_Odm,0x874 ,0x1CC000 , pDM_PSTable->reg_874); -ODM_SetBBReg (pDM_Odm,0xc70 ,BIT (3 ), pDM_PSTable->reg_c70); -ODM_SetBBReg (pDM_Odm,0x85c ,0xFF000000 , pDM_PSTable->reg_85c); -ODM_SetBBReg (pDM_Odm,0xa74 ,0xF000 , pDM_PSTable->reg_a74); -ODM_SetBBReg (pDM_Odm,0x818 ,BIT (28 ),0x0 ); +rtl8188e_PHY_SetBBReg (adapter,0x874 ,0x1CC000 , pDM_PSTable->reg_874); +rtl8188e_PHY_SetBBReg (adapter,0xc70 ,BIT (3 ), pDM_PSTable->reg_c70); +rtl8188e_PHY_SetBBReg (adapter,0x85c ,0xFF000000 , pDM_PSTable->reg_85c); +rtl8188e_PHY_SetBBReg (adapter,0xa74 ,0xF000 , pDM_PSTable->reg_a74); +rtl8188e_PHY_SetBBReg (adapter,0x818 ,BIT (28 ),0x0 ); } pDM_PSTable->pre_rf_state = pDM_PSTable->cur_rf_state; }
drivers/staging/r8188eu/hal/odm_RTL8188E.c +46 -44
153 lines not on this page · raw message
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +2 -2
@@ -41,7 +41,7 @@ void odm_ConfigMAC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u8 Data)void odm_ConfigBB_AGC_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u32 Bitmask,u32 Data) { -ODM_SetBBReg (pDM_Odm, Addr, Bitmask, Data); +rtl8188e_PHY_SetBBReg (pDM_Odm->Adapter, Addr, Bitmask, Data);/* Add 1us delay between BB/RF register setting. */ ODM_delay_us (1 ); }
@@ -82,7 +82,7 @@ void odm_ConfigBB_PHY_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask }else {if (Addr ==0xa24 ) pDM_Odm->RFCalibrateInfo.RegA24 = Data; -ODM_SetBBReg (pDM_Odm, Addr, Bitmask, Data); +rtl8188e_PHY_SetBBReg (pDM_Odm->Adapter, Addr, Bitmask, Data);/* Add 1us delay between BB/RF register setting. */ ODM_delay_us (1 );
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -4,12 +4,6 @@#include "../include/odm_precomp.h" /* ODM IO Relative API. */ -void ODM_SetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr,u32 BitMask,u32 Data) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -rtl8188e_PHY_SetBBReg (Adapter, RegAddr, BitMask, Data); -} -/* ODM Memory relative API. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length) {
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -12,9 +12,6 @@ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);/* =========== EXtern Function Prototype */ -void ODM_SetBBReg (struct odm_dm_struct *pDM_Odm,u32 RegAddr, -u32 BitMask,u32 Data); -/* Memory Relative Function. */ s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length);
Signature · 1 line
2.34.1
PATCH 7/32 staging: r8188eu: clean up coding style issues
In reply to Michael StraubeClean up coding style issues in odm_ConfigRFReg_8188E() reported by checkpatch.
WARNING: please, no spaces at the start of a line
WARNING: suspect code indent for conditional statements (4, 16)
--- drivers/staging/r8188eu/hal/odm_RegConfig8188E.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +1 -1
@@ -7,7 +7,7 @@ void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data, enum rf_radio_path RF_PATH, u32 RegAddr) { - if (Addr == 0xffe) { + if (Addr == 0xffe) { ODM_sleep_ms(50); } else if (Addr == 0xfd) {ODM_delay_ms (5 );
Signature · 1 line
2.34.1
PATCH 8/32 staging: r8188eu: remove ODM_sleep_ms()
In reply to Michael StraubeODM_sleep_ms() is just a wrapper around msleep().
Remove ODM_sleep_ms() and call msleep() directly.
--- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/hal/odm_RegConfig8188E.c | 6 +++--- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm_interface.h | 2 -- 4 files changed, 4 insertions(+), 11 deletions(-)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +1 -1
@@ -858,7 +858,7 @@ static void phy_LCCalibrate_8188E(struct adapter *adapt, bool is2t)/* 4. Set LC calibration begin bit15 */ rtl8188e_PHY_SetRFReg (adapt,RF_PATH_A ,RF_CHNLBW , bMask12Bits, LC_Cal |0x08000 ); -ODM_sleep_ms (100 ); +msleep (100 );/* Restore original situation */ if ((tmpreg &0x70 ) !=0 ) {
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +3 -3
@@ -8,7 +8,7 @@ void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 RegAddr) {if (Addr ==0xffe ) { -ODM_sleep_ms (50 ); +msleep (50 ); }else if (Addr ==0xfd ) {ODM_delay_ms (5 ); }else if (Addr ==0xfc ) {
@@ -50,7 +50,7 @@ void odm_ConfigBB_PHY_REG_PG_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask, u32 Data) {if (Addr ==0xfe ) -ODM_sleep_ms (50 ); +msleep (50 );else if (Addr ==0xfd )ODM_delay_ms (5 );else if (Addr ==0xfc )
@@ -68,7 +68,7 @@ void odm_ConfigBB_PHY_REG_PG_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,void odm_ConfigBB_PHY_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u32 Bitmask,u32 Data) {if (Addr ==0xfe ) { -ODM_sleep_ms (50 ); +msleep (50 ); }else if (Addr ==0xfd ) {ODM_delay_ms (5 ); }else if (Addr ==0xfc ) {
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -20,8 +20,3 @@ void ODM_delay_us(u32 us) {udelay (us); } - -void ODM_sleep_ms (u32 ms) -{ -msleep (ms); -}
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -21,6 +21,4 @@ void ODM_delay_ms(u32 ms);void ODM_delay_us (u32 us); -void ODM_sleep_ms (u32 ms); -#endif /* __ODM_INTERFACE_H__ */
Signature · 1 line
2.34.1
PATCH 9/32 staging: r8188eu: remove ODM_delay_us()
In reply to Michael StraubeODM_delay_us() is just a wrapper around udelay().
Remove ODM_delay_us() and call udelay() directly.
--- .../staging/r8188eu/hal/odm_RegConfig8188E.c | 24 +++++++++---------- drivers/staging/r8188eu/hal/odm_interface.c | 5 ---- .../staging/r8188eu/include/odm_interface.h | 2 -- 3 files changed, 12 insertions(+), 19 deletions(-)
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +12 -12
@@ -14,15 +14,15 @@ void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, }else if (Addr ==0xfc ) {ODM_delay_ms (1 ); }else if (Addr ==0xfb ) { -ODM_delay_us (50 ); +udelay (50 ); }else if (Addr ==0xfa ) { -ODM_delay_us (5 ); +udelay (5 ); }else if (Addr ==0xf9 ) { -ODM_delay_us (1 ); +udelay (1 ); }else {rtl8188e_PHY_SetRFReg (pDM_Odm->Adapter,RF_PATH , RegAddr, bRFRegOffsetMask, Data);/* Add 1us delay between BB/RF register setting. */ -ODM_delay_us (1 ); +udelay (1 ); } }
@@ -43,7 +43,7 @@ void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask {rtl8188e_PHY_SetBBReg (pDM_Odm->Adapter, Addr, Bitmask, Data);/* Add 1us delay between BB/RF register setting. */ -ODM_delay_us (1 ); +udelay (1 ); } void odm_ConfigBB_PHY_REG_PG_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,
@@ -56,11 +56,11 @@ void odm_ConfigBB_PHY_REG_PG_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,else if (Addr ==0xfc )ODM_delay_ms (1 );else if (Addr ==0xfb ) -ODM_delay_us (50 ); +udelay (50 );else if (Addr ==0xfa ) -ODM_delay_us (5 ); +udelay (5 );else if (Addr ==0xf9 ) -ODM_delay_us (1 ); +udelay (1 );else storePwrIndexDiffRateOffset (pDM_Odm->Adapter, Addr, Bitmask, Data); }
@@ -74,17 +74,17 @@ void odm_ConfigBB_PHY_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask }else if (Addr ==0xfc ) {ODM_delay_ms (1 ); }else if (Addr ==0xfb ) { -ODM_delay_us (50 ); +udelay (50 ); }else if (Addr ==0xfa ) { -ODM_delay_us (5 ); +udelay (5 ); }else if (Addr ==0xf9 ) { -ODM_delay_us (1 ); +udelay (1 ); }else {if (Addr ==0xa24 ) pDM_Odm->RFCalibrateInfo.RegA24 = Data;rtl8188e_PHY_SetBBReg (pDM_Odm->Adapter, Addr, Bitmask, Data);/* Add 1us delay between BB/RF register setting. */ -ODM_delay_us (1 ); +udelay (1 ); } }
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -15,8 +15,3 @@ void ODM_delay_ms(u32 ms) {mdelay (ms); } - -void ODM_delay_us (u32 us) -{ -udelay (us); -}
drivers/staging/r8188eu/include/odm_interface.h +0 -2
@@ -19,6 +19,4 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2,/* ODM Timer relative API. */ void ODM_delay_ms (u32 ms); -void ODM_delay_us (u32 us); -#endif /* __ODM_INTERFACE_H__ */
Signature · 1 line
2.34.1
PATCH 10/32 staging: r8188eu: remove ODM_delay_ms()
In reply to Michael StraubeODM_delay_ms() is just a wrapper around mdelay().
Remove ODM_delay_ms() and call mdelay() directly.
--- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 8 ++++---- drivers/staging/r8188eu/hal/odm_RegConfig8188E.c | 12 ++++++------ drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ drivers/staging/r8188eu/include/odm_interface.h | 3 --- 4 files changed, 10 insertions(+), 19 deletions(-)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +4 -4
@@ -382,7 +382,7 @@ phy_PathA_IQK_8188E(struct adapter *adapt)/* delay x ms */ /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */ -ODM_delay_ms (IQK_DELAY_TIME_88E ); +mdelay (IQK_DELAY_TIME_88E );/* Check failed */ regeac =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_After_IQK_A_2, bMaskDWord);
@@ -434,7 +434,7 @@ phy_PathA_RxIQK(struct adapter *adapt)rtl8188e_PHY_SetBBReg (adapt, rIQK_AGC_Pts, bMaskDWord,0xf8000000 );/* delay x ms */ -ODM_delay_ms (IQK_DELAY_TIME_88E ); +mdelay (IQK_DELAY_TIME_88E );/* Check failed */ regeac =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_After_IQK_A_2, bMaskDWord);
@@ -478,7 +478,7 @@ phy_PathA_RxIQK(struct adapter *adapt)/* delay x ms */ /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */ -ODM_delay_ms (IQK_DELAY_TIME_88E ); +mdelay (IQK_DELAY_TIME_88E );/* Check failed */ regeac =rtl8188e_PHY_QueryBBReg (adapt, rRx_Power_After_IQK_A_2, bMaskDWord);
@@ -1000,7 +1000,7 @@ void PHY_LCCalibrate_8188E(struct adapter *adapt)return ;while (*dm_odm->pbScanInProcess && timecount < timeout) { -ODM_delay_ms (50 ); +mdelay (50 ); timecount +=50 ; }
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +6 -6
@@ -10,9 +10,9 @@ void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,if (Addr ==0xffe ) {msleep (50 ); }else if (Addr ==0xfd ) { -ODM_delay_ms (5 ); +mdelay (5 ); }else if (Addr ==0xfc ) { -ODM_delay_ms (1 ); +mdelay (1 ); }else if (Addr ==0xfb ) {udelay (50 ); }else if (Addr ==0xfa ) {
@@ -52,9 +52,9 @@ void odm_ConfigBB_PHY_REG_PG_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,if (Addr ==0xfe )msleep (50 );else if (Addr ==0xfd ) -ODM_delay_ms (5 ); +mdelay (5 );else if (Addr ==0xfc ) -ODM_delay_ms (1 ); +mdelay (1 );else if (Addr ==0xfb )udelay (50 );else if (Addr ==0xfa )
@@ -70,9 +70,9 @@ void odm_ConfigBB_PHY_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmaskif (Addr ==0xfe ) {msleep (50 ); }else if (Addr ==0xfd ) { -ODM_delay_ms (5 ); +mdelay (5 ); }else if (Addr ==0xfc ) { -ODM_delay_ms (1 ); +mdelay (1 ); }else if (Addr ==0xfb ) {udelay (50 ); }else if (Addr ==0xfa ) {
drivers/staging/r8188eu/hal/odm_interface.c +0 -6
@@ -9,9 +9,3 @@ s32 ODM_CompareMemory(struct odm_dm_struct *pDM_Odm, void *pBuf1, void *pBuf2, u {return !memcmp (pBuf1, pBuf2, length); } - -/* ODM Timer relative API. */ -void ODM_delay_ms (u32 ms) -{ -mdelay (ms); -}
drivers/staging/r8188eu/include/odm_interface.h +0 -3
@@ -16,7 +16,4 @@ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length); -/* ODM Timer relative API. */ -void ODM_delay_ms (u32 ms); -#endif /* __ODM_INTERFACE_H__ */
Signature · 1 line
2.34.1
PATCH 11/32 staging: r8188eu: remove ODM_CompareMemory()
In reply to Michael StraubeODM_CompareMemory() is just a wrapper around memcmp(). Remove ODM_CompareMemory() and call memcmp() directly.
--- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 4 ++-- drivers/staging/r8188eu/hal/odm_interface.c | 5 ----- drivers/staging/r8188eu/include/odm_interface.h | 4 ---- 3 files changed, 2 insertions(+), 11 deletions(-)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +2 -2
@@ -171,13 +171,13 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(for (i =0 ; i <CCK_TABLE_SIZE ; i++) {if (dm_odm->RFCalibrateInfo.bCCKinCH14) { -if (ODM_CompareMemory (dm_odm, (void *)&TempCCk, (void *)&CCKSwingTable_Ch14[i][2 ],4 ) ==0 ) { +if (memcmp ((void *)&TempCCk, (void *)&CCKSwingTable_Ch14[i][2 ],4 )) { CCK_index_old = (u8 )i; dm_odm->BbSwingIdxCckBase = (u8 )i;break ; } }else { -if (ODM_CompareMemory (dm_odm, (void *)&TempCCk, (void *)&CCKSwingTable_Ch1_Ch13[i][2 ],4 ) ==0 ) { +if (memcmp ((void *)&TempCCk, (void *)&CCKSwingTable_Ch1_Ch13[i][2 ],4 )) { CCK_index_old = (u8 )i; dm_odm->BbSwingIdxCckBase = (u8 )i;break ;
drivers/staging/r8188eu/hal/odm_interface.c +0 -5
@@ -4,8 +4,3 @@#include "../include/odm_precomp.h" /* ODM IO Relative API. */ -/* ODM Memory relative API. */ -s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2,u32 length) -{ -return !memcmp (pBuf1, pBuf2, length); -}
drivers/staging/r8188eu/include/odm_interface.h +0 -4
@@ -12,8 +12,4 @@ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);/* =========== EXtern Function Prototype */ -/* Memory Relative Function. */ -s32 ODM_CompareMemory (struct odm_dm_struct *pDM_Odm,void *pBuf1,void *pBuf2, -u32 length); -#endif /* __ODM_INTERFACE_H__ */
Signature · 1 line
2.34.1
PATCH 12/32 staging: r8188eu: remove odm_interface
In reply to Michael StraubeAfter previous cleanups the file odm_interface.c is emtpy now and the header odm_interface.h just contains an unused typedef. Remove both files.
--- drivers/staging/r8188eu/Makefile | 1 - drivers/staging/r8188eu/hal/odm_interface.c | 6 ------ drivers/staging/r8188eu/include/odm_interface.h | 15 --------------- drivers/staging/r8188eu/include/odm_precomp.h | 2 -- 4 files changed, 24 deletions(-) delete mode 100644 drivers/staging/r8188eu/hal/odm_interface.c delete mode 100644 drivers/staging/r8188eu/include/odm_interface.h
drivers/staging/r8188eu/Makefile +0 -1
@@ -11,7 +11,6 @@ r8188eu-y = \ hal/hal_com.o \ hal/odm.o \ hal/odm_debug.o \ - hal/odm_interface.o \ hal/odm_HWConfig.o \ hal/odm_RegConfig8188E.o \ hal/odm_RTL8188E.o \
drivers/staging/r8188eu/hal/odm_interface.c deleted +0 -6
@@ -1,6 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright(c) 2007 - 2011 Realtek Corporation. */ - -#include "../include/odm_precomp.h" -/* ODM IO Relative API. */ -
drivers/staging/r8188eu/include/odm_interface.h deleted +0 -15
@@ -1,15 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ -/* Copyright(c) 2007 - 2011 Realtek Corporation. */ - -#ifndef __ODM_INTERFACE_H__ -#define __ODM_INTERFACE_H__ - -/* 2012/02/17 MH For non-MP compile pass only. Linux does not support workitem. */ -/* Suggest HW team to use thread instead of workitem. Windows also support the feature. */ -typedef void (*RT_WORKITEM_CALL_BACK )(void *pContext); - -/* =========== Extern Variable ??? It should be forbidden. */ - -/* =========== EXtern Function Prototype */ - -#endif /* __ODM_INTERFACE_H__ */
drivers/staging/r8188eu/include/odm_precomp.h +0 -2
@@ -24,8 +24,6 @@#include "Hal8188ERateAdaptive.h" /* for RA,Power training */ #include "rtl8188e_hal.h" -#include "odm_interface.h" -#include "HalHWImg8188E_MAC.h" #include "HalHWImg8188E_RF.h" #include "HalHWImg8188E_BB.h"
Signature · 1 line
2.34.1
PATCH 13/32 staging: r8188eu: make odm_ConfigRFReg_8188E() static
In reply to Michael StraubeFunction odm_ConfigRFReg_8188E() is only used in odm_RegConfig8188E.c. Make it static.
--- drivers/staging/r8188eu/hal/odm_RegConfig8188E.c | 6 +++--- drivers/staging/r8188eu/include/odm_RegConfig8188E.h | 3 --- 2 files changed, 3 insertions(+), 6 deletions(-)
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +3 -3
@@ -3,9 +3,9 @@#include "../include/odm_precomp.h" -void odm_ConfigRFReg_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr, -u32 Data,enum rf_radio_path RF_PATH , -u32 RegAddr) +static void odm_ConfigRFReg_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr, +u32 Data,enum rf_radio_path RF_PATH , +u32 RegAddr) {if (Addr ==0xffe ) {msleep (50 );
drivers/staging/r8188eu/include/odm_RegConfig8188E.h +0 -3
@@ -4,9 +4,6 @@#ifndef __INC_ODM_REGCONFIG_H_8188E#define __INC_ODM_REGCONFIG_H_8188E -void odm_ConfigRFReg_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u32 Data, -enum rf_radio_path RF_PATH ,u32 RegAddr); -void odm_ConfigRF_RadioA_8188E (struct odm_dm_struct *pDM_Odm,u32 Addr,u32 Data);
Signature · 1 line
2.34.1
PATCH 14/32 staging: r8188eu: remove unused prototypes
In reply to Michael StraubeRemove some unused function prototypes.
--- drivers/staging/r8188eu/include/odm.h | 2 -- drivers/staging/r8188eu/include/odm_RTL8188E.h | 4 ---- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 3 files changed, 7 deletions(-)
drivers/staging/r8188eu/include/odm.h +0 -2
@@ -558,8 +558,6 @@ extern u8 CCKSwingTable_Ch14 [CCK_TABLE_SIZE][8];void ODM_Write_DIG (struct odm_dm_struct *pDM_Odm,u8 CurrentIGI);void ODM_Write_CCK_CCA_Thres (struct odm_dm_struct *pDM_Odm,u8 CurCCK_CCAThres); -void ODM_SetAntenna (struct odm_dm_struct *pDM_Odm,u8 Antenna); -void ODM_RF_Saving (struct odm_dm_struct *pDM_Odm,u8 bForceInNormal);void ODM_TXPowerTrackingCheck (struct odm_dm_struct *pDM_Odm);
drivers/staging/r8188eu/include/odm_RTL8188E.h +0 -4
@@ -25,8 +25,4 @@ void ODM_AntselStatistics_88E(struct odm_dm_struct *pDM_Odm, u8 antsel_tr_mux,void odm_FastAntTraining (struct odm_dm_struct *pDM_Odm); -void odm_FastAntTrainingCallback (struct odm_dm_struct *pDM_Odm); - -void odm_FastAntTrainingWorkItemCallback (struct odm_dm_struct *pDM_Odm); -#endif
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -36,7 +36,6 @@ void odm_RateAdaptiveMaskInit(struct odm_dm_struct *pDM_Odm);void odm_DynamicBBPowerSavingInit (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm); -void odm_SwAntDivInit_NIC (struct odm_dm_struct *pDM_Odm);void odm_CommonInfoSelfUpdate (struct odm_dm_struct *pDM_Odm);void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm);void odm_DIG (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 15/32 staging: r8188eu: make odm_DIGInit() static
In reply to Michael StraubeFunction odm_DIGInit() is used only in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 58 +++++++++---------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 29 insertions(+), 30 deletions(-)
drivers/staging/r8188eu/hal/odm.c +29 -29
@@ -142,6 +142,35 @@ u8 CCKSwingTable_Ch14[CCK_TABLE_SIZE][8] = {#define RxDefaultAnt1 0x65a9#define RxDefaultAnt2 0x569a +static void odm_DIGInit (struct odm_dm_struct *pDM_Odm) +{ +struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable; +struct adapter *adapter = pDM_Odm->Adapter; + + pDM_DigTable->CurIGValue = (u8 )rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_IGI_A_11N ,ODM_BIT_IGI_11N ); + pDM_DigTable->RssiLowThresh =DM_DIG_THRESH_LOW ; + pDM_DigTable->RssiHighThresh =DM_DIG_THRESH_HIGH ; + pDM_DigTable->FALowThresh = DM_false_ALARM_THRESH_LOW; + pDM_DigTable->FAHighThresh = DM_false_ALARM_THRESH_HIGH; + pDM_DigTable->rx_gain_range_max =DM_DIG_MAX_NIC ; + pDM_DigTable->rx_gain_range_min =DM_DIG_MIN_NIC ; + pDM_DigTable->BackoffVal =DM_DIG_BACKOFF_DEFAULT ; + pDM_DigTable->BackoffVal_range_max =DM_DIG_BACKOFF_MAX ; + pDM_DigTable->BackoffVal_range_min =DM_DIG_BACKOFF_MIN ; + pDM_DigTable->PreCCK_CCAThres =0xFF ; + pDM_DigTable->CurCCK_CCAThres =0x83 ; + pDM_DigTable->ForbiddenIGI =DM_DIG_MIN_NIC ; + pDM_DigTable->LargeFAHit =0 ; + pDM_DigTable->Recover_cnt =0 ; + pDM_DigTable->DIG_Dynamic_MIN_0 =DM_DIG_MIN_NIC ; + pDM_DigTable->DIG_Dynamic_MIN_1 =DM_DIG_MIN_NIC ; + pDM_DigTable->bMediaConnect_0 = false; + pDM_DigTable->bMediaConnect_1 = false; + +/* To Initialize pDM_Odm->bDMInitialGainEnable == false to avoid DIG error */ + pDM_Odm->bDMInitialGainEnable = true; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -310,35 +339,6 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI) } } -void odm_DIGInit (struct odm_dm_struct *pDM_Odm) -{ -struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable; -struct adapter *adapter = pDM_Odm->Adapter; - - pDM_DigTable->CurIGValue = (u8 )rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_IGI_A_11N ,ODM_BIT_IGI_11N ); - pDM_DigTable->RssiLowThresh =DM_DIG_THRESH_LOW ; - pDM_DigTable->RssiHighThresh =DM_DIG_THRESH_HIGH ; - pDM_DigTable->FALowThresh = DM_false_ALARM_THRESH_LOW; - pDM_DigTable->FAHighThresh = DM_false_ALARM_THRESH_HIGH; - pDM_DigTable->rx_gain_range_max =DM_DIG_MAX_NIC ; - pDM_DigTable->rx_gain_range_min =DM_DIG_MIN_NIC ; - pDM_DigTable->BackoffVal =DM_DIG_BACKOFF_DEFAULT ; - pDM_DigTable->BackoffVal_range_max =DM_DIG_BACKOFF_MAX ; - pDM_DigTable->BackoffVal_range_min =DM_DIG_BACKOFF_MIN ; - pDM_DigTable->PreCCK_CCAThres =0xFF ; - pDM_DigTable->CurCCK_CCAThres =0x83 ; - pDM_DigTable->ForbiddenIGI =DM_DIG_MIN_NIC ; - pDM_DigTable->LargeFAHit =0 ; - pDM_DigTable->Recover_cnt =0 ; - pDM_DigTable->DIG_Dynamic_MIN_0 =DM_DIG_MIN_NIC ; - pDM_DigTable->DIG_Dynamic_MIN_1 =DM_DIG_MIN_NIC ; - pDM_DigTable->bMediaConnect_0 = false; - pDM_DigTable->bMediaConnect_1 = false; - -/* To Initialize pDM_Odm->bDMInitialGainEnable == false to avoid DIG error */ - pDM_Odm->bDMInitialGainEnable = true; -} -void odm_DIG (struct odm_dm_struct *pDM_Odm) {struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -31,7 +31,6 @@#include "odm_RegConfig8188E.h" #include "odm_RTL8188E.h" -void odm_DIGInit (struct odm_dm_struct *pDM_Odm);void odm_RateAdaptiveMaskInit (struct odm_dm_struct *pDM_Odm);void odm_DynamicBBPowerSavingInit (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 16/32 staging: r8188eu: make odm_DIG() static
In reply to Michael StraubeFunction odm_DIG() is used only in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 264 +++++++++--------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 132 insertions(+), 133 deletions(-)
drivers/staging/r8188eu/hal/odm.c +132 -132
@@ -171,6 +171,138 @@ static void odm_DIGInit(struct odm_dm_struct *pDM_Odm) pDM_Odm->bDMInitialGainEnable = true; } +static void odm_DIG (struct odm_dm_struct *pDM_Odm) +{ +struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable; +struct false_alarm_stats *pFalseAlmCnt = &pDM_Odm->FalseAlmCnt; +u8 DIG_Dynamic_MIN; +u8 DIG_MaxOfMin; +bool FirstConnect, FirstDisConnect; +u8 dm_dig_max, dm_dig_min; +u8 CurrentIGI = pDM_DigTable->CurIGValue; + +if (!(pDM_Odm->SupportAbility &ODM_BB_FA_CNT )) +return ; + +if (*pDM_Odm->pbScanInProcess) +return ; + +/* add by Neil Chen to avoid PSD is processing */ +if (!pDM_Odm->bDMInitialGainEnable) +return ; + + DIG_Dynamic_MIN = pDM_DigTable->DIG_Dynamic_MIN_0; + FirstConnect = (pDM_Odm->bLinked) && (!pDM_DigTable->bMediaConnect_0); + FirstDisConnect = (!pDM_Odm->bLinked) && (pDM_DigTable->bMediaConnect_0); + +/* 1 Boundary Decision */ + dm_dig_max =DM_DIG_MAX_NIC ; + dm_dig_min =DM_DIG_MIN_NIC ; + DIG_MaxOfMin =DM_DIG_MAX_AP ; + +if (pDM_Odm->bLinked) { +/* 2 8723A Series, offset need to be 10 */ +/* 2 Modify DIG upper bound */ +if ((pDM_Odm->RSSI_Min +20 ) > dm_dig_max) + pDM_DigTable->rx_gain_range_max = dm_dig_max; +else if ((pDM_Odm->RSSI_Min +20 ) < dm_dig_min) + pDM_DigTable->rx_gain_range_max = dm_dig_min; +else + pDM_DigTable->rx_gain_range_max = pDM_Odm->RSSI_Min +20 ; +/* 2 Modify DIG lower bound */ +if (pDM_Odm->bOneEntryOnly) { +if (pDM_Odm->RSSI_Min < dm_dig_min) + DIG_Dynamic_MIN = dm_dig_min; +else if (pDM_Odm->RSSI_Min > DIG_MaxOfMin) + DIG_Dynamic_MIN = DIG_MaxOfMin; +else + DIG_Dynamic_MIN = pDM_Odm->RSSI_Min; + }else if (pDM_Odm->SupportAbility &ODM_BB_ANT_DIV ) { +/* 1 Lower Bound for 88E AntDiv */ +if (pDM_Odm->AntDivType ==CG_TRX_HW_ANTDIV ) + DIG_Dynamic_MIN = (u8 )pDM_DigTable->AntDiv_RSSI_max; + }else { + DIG_Dynamic_MIN = dm_dig_min; + } + }else { + pDM_DigTable->rx_gain_range_max = dm_dig_max; + DIG_Dynamic_MIN = dm_dig_min; + } + +/* 1 Modify DIG lower bound, deal with abnormally large false alarm */ +if (pFalseAlmCnt->Cnt_all >10000 ) { +if (pDM_DigTable->LargeFAHit !=3 ) + pDM_DigTable->LargeFAHit++; +if (pDM_DigTable->ForbiddenIGI < CurrentIGI) { + pDM_DigTable->ForbiddenIGI = CurrentIGI; + pDM_DigTable->LargeFAHit =1 ; + } + +if (pDM_DigTable->LargeFAHit >=3 ) { +if ((pDM_DigTable->ForbiddenIGI +1 ) > pDM_DigTable->rx_gain_range_max) + pDM_DigTable->rx_gain_range_min = pDM_DigTable->rx_gain_range_max; +else + pDM_DigTable->rx_gain_range_min = (pDM_DigTable->ForbiddenIGI +1 ); + pDM_DigTable->Recover_cnt =3600 ;/* 3600=2hr */ + } + + }else { +/* Recovery mechanism for IGI lower bound */ +if (pDM_DigTable->Recover_cnt !=0 ) { + pDM_DigTable->Recover_cnt--; + }else { +if (pDM_DigTable->LargeFAHit <3 ) { +if ((pDM_DigTable->ForbiddenIGI -1 ) < DIG_Dynamic_MIN) {/* DM_DIG_MIN) */ + pDM_DigTable->ForbiddenIGI = DIG_Dynamic_MIN;/* DM_DIG_MIN; */ + pDM_DigTable->rx_gain_range_min = DIG_Dynamic_MIN;/* DM_DIG_MIN; */ + }else { + pDM_DigTable->ForbiddenIGI--; + pDM_DigTable->rx_gain_range_min = (pDM_DigTable->ForbiddenIGI +1 ); + } + }else { + pDM_DigTable->LargeFAHit =0 ; + } + } + } + +/* 1 Adjust initial gain by false alarm */ +if (pDM_Odm->bLinked) { +if (FirstConnect) { + CurrentIGI = pDM_Odm->RSSI_Min; + }else { +if (pFalseAlmCnt->Cnt_all >DM_DIG_FA_TH2 ) + CurrentIGI = CurrentIGI +4 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+2; */ +else if (pFalseAlmCnt->Cnt_all >DM_DIG_FA_TH1 ) + CurrentIGI = CurrentIGI +2 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+1; */ +else if (pFalseAlmCnt->Cnt_all <DM_DIG_FA_TH0 ) + CurrentIGI = CurrentIGI -2 ;/* pDM_DigTable->CurIGValue =pDM_DigTable->PreIGValue-1; */ + } + }else { +if (FirstDisConnect) { + CurrentIGI = pDM_DigTable->rx_gain_range_min; + }else { +/* 2012.03.30 LukeLee: enable DIG before link but with very high thresholds */ +if (pFalseAlmCnt->Cnt_all >10000 ) + CurrentIGI = CurrentIGI +2 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+2; */ +else if (pFalseAlmCnt->Cnt_all >8000 ) + CurrentIGI = CurrentIGI +1 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+1; */ +else if (pFalseAlmCnt->Cnt_all <500 ) + CurrentIGI = CurrentIGI -1 ;/* pDM_DigTable->CurIGValue =pDM_DigTable->PreIGValue-1; */ + } + } +/* 1 Check initial gain by upper/lower bound */ +if (CurrentIGI > pDM_DigTable->rx_gain_range_max) + CurrentIGI = pDM_DigTable->rx_gain_range_max; +if (CurrentIGI < pDM_DigTable->rx_gain_range_min) + CurrentIGI = pDM_DigTable->rx_gain_range_min; + +/* 2 High power RSSI threshold */ + +ODM_Write_DIG (pDM_Odm, CurrentIGI);/* ODM_Write_DIG(pDM_Odm, pDM_DigTable->CurIGValue); */ + pDM_DigTable->bMediaConnect_0 = pDM_Odm->bLinked; + pDM_DigTable->DIG_Dynamic_MIN_0 = DIG_Dynamic_MIN; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -339,138 +471,6 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI) } } -void odm_DIG (struct odm_dm_struct *pDM_Odm) -{ -struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable; -struct false_alarm_stats *pFalseAlmCnt = &pDM_Odm->FalseAlmCnt; -u8 DIG_Dynamic_MIN; -u8 DIG_MaxOfMin; -bool FirstConnect, FirstDisConnect; -u8 dm_dig_max, dm_dig_min; -u8 CurrentIGI = pDM_DigTable->CurIGValue; - -if (!(pDM_Odm->SupportAbility &ODM_BB_FA_CNT )) -return ; - -if (*pDM_Odm->pbScanInProcess) -return ; - -/* add by Neil Chen to avoid PSD is processing */ -if (!pDM_Odm->bDMInitialGainEnable) -return ; - - DIG_Dynamic_MIN = pDM_DigTable->DIG_Dynamic_MIN_0; - FirstConnect = (pDM_Odm->bLinked) && (!pDM_DigTable->bMediaConnect_0); - FirstDisConnect = (!pDM_Odm->bLinked) && (pDM_DigTable->bMediaConnect_0); - -/* 1 Boundary Decision */ - dm_dig_max =DM_DIG_MAX_NIC ; - dm_dig_min =DM_DIG_MIN_NIC ; - DIG_MaxOfMin =DM_DIG_MAX_AP ; - -if (pDM_Odm->bLinked) { -/* 2 8723A Series, offset need to be 10 */ -/* 2 Modify DIG upper bound */ -if ((pDM_Odm->RSSI_Min +20 ) > dm_dig_max) - pDM_DigTable->rx_gain_range_max = dm_dig_max; -else if ((pDM_Odm->RSSI_Min +20 ) < dm_dig_min) - pDM_DigTable->rx_gain_range_max = dm_dig_min; -else - pDM_DigTable->rx_gain_range_max = pDM_Odm->RSSI_Min +20 ; -/* 2 Modify DIG lower bound */ -if (pDM_Odm->bOneEntryOnly) { -if (pDM_Odm->RSSI_Min < dm_dig_min) - DIG_Dynamic_MIN = dm_dig_min; -else if (pDM_Odm->RSSI_Min > DIG_MaxOfMin) - DIG_Dynamic_MIN = DIG_MaxOfMin; -else - DIG_Dynamic_MIN = pDM_Odm->RSSI_Min; - }else if (pDM_Odm->SupportAbility &ODM_BB_ANT_DIV ) { -/* 1 Lower Bound for 88E AntDiv */ -if (pDM_Odm->AntDivType ==CG_TRX_HW_ANTDIV ) - DIG_Dynamic_MIN = (u8 )pDM_DigTable->AntDiv_RSSI_max; - }else { - DIG_Dynamic_MIN = dm_dig_min; - } - }else { - pDM_DigTable->rx_gain_range_max = dm_dig_max; - DIG_Dynamic_MIN = dm_dig_min; - } - -/* 1 Modify DIG lower bound, deal with abnormally large false alarm */ -if (pFalseAlmCnt->Cnt_all >10000 ) { -if (pDM_DigTable->LargeFAHit !=3 ) - pDM_DigTable->LargeFAHit++; -if (pDM_DigTable->ForbiddenIGI < CurrentIGI) { - pDM_DigTable->ForbiddenIGI = CurrentIGI; - pDM_DigTable->LargeFAHit =1 ; - } - -if (pDM_DigTable->LargeFAHit >=3 ) { -if ((pDM_DigTable->ForbiddenIGI +1 ) > pDM_DigTable->rx_gain_range_max) - pDM_DigTable->rx_gain_range_min = pDM_DigTable->rx_gain_range_max; -else - pDM_DigTable->rx_gain_range_min = (pDM_DigTable->ForbiddenIGI +1 ); - pDM_DigTable->Recover_cnt =3600 ;/* 3600=2hr */ - } - - }else { -/* Recovery mechanism for IGI lower bound */ -if (pDM_DigTable->Recover_cnt !=0 ) { - pDM_DigTable->Recover_cnt--; - }else { -if (pDM_DigTable->LargeFAHit <3 ) { -if ((pDM_DigTable->ForbiddenIGI -1 ) < DIG_Dynamic_MIN) {/* DM_DIG_MIN) */ - pDM_DigTable->ForbiddenIGI = DIG_Dynamic_MIN;/* DM_DIG_MIN; */ - pDM_DigTable->rx_gain_range_min = DIG_Dynamic_MIN;/* DM_DIG_MIN; */ - }else { - pDM_DigTable->ForbiddenIGI--; - pDM_DigTable->rx_gain_range_min = (pDM_DigTable->ForbiddenIGI +1 ); - } - }else { - pDM_DigTable->LargeFAHit =0 ; - } - } - } - -/* 1 Adjust initial gain by false alarm */ -if (pDM_Odm->bLinked) { -if (FirstConnect) { - CurrentIGI = pDM_Odm->RSSI_Min; - }else { -if (pFalseAlmCnt->Cnt_all >DM_DIG_FA_TH2 ) - CurrentIGI = CurrentIGI +4 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+2; */ -else if (pFalseAlmCnt->Cnt_all >DM_DIG_FA_TH1 ) - CurrentIGI = CurrentIGI +2 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+1; */ -else if (pFalseAlmCnt->Cnt_all <DM_DIG_FA_TH0 ) - CurrentIGI = CurrentIGI -2 ;/* pDM_DigTable->CurIGValue =pDM_DigTable->PreIGValue-1; */ - } - }else { -if (FirstDisConnect) { - CurrentIGI = pDM_DigTable->rx_gain_range_min; - }else { -/* 2012.03.30 LukeLee: enable DIG before link but with very high thresholds */ -if (pFalseAlmCnt->Cnt_all >10000 ) - CurrentIGI = CurrentIGI +2 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+2; */ -else if (pFalseAlmCnt->Cnt_all >8000 ) - CurrentIGI = CurrentIGI +1 ;/* pDM_DigTable->CurIGValue = pDM_DigTable->PreIGValue+1; */ -else if (pFalseAlmCnt->Cnt_all <500 ) - CurrentIGI = CurrentIGI -1 ;/* pDM_DigTable->CurIGValue =pDM_DigTable->PreIGValue-1; */ - } - } -/* 1 Check initial gain by upper/lower bound */ -if (CurrentIGI > pDM_DigTable->rx_gain_range_max) - CurrentIGI = pDM_DigTable->rx_gain_range_max; -if (CurrentIGI < pDM_DigTable->rx_gain_range_min) - CurrentIGI = pDM_DigTable->rx_gain_range_min; - -/* 2 High power RSSI threshold */ - -ODM_Write_DIG (pDM_Odm, CurrentIGI);/* ODM_Write_DIG(pDM_Odm, pDM_DigTable->CurIGValue); */ - pDM_DigTable->bMediaConnect_0 = pDM_Odm->bLinked; - pDM_DigTable->DIG_Dynamic_MIN_0 = DIG_Dynamic_MIN; -} -/* 3============================================================ */ /* 3 FASLE ALARM CHECK */ /* 3============================================================ */
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -37,7 +37,6 @@ void odm_TXPowerTrackingInit(struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_CommonInfoSelfUpdate (struct odm_dm_struct *pDM_Odm);void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm); -void odm_DIG (struct odm_dm_struct *pDM_Odm);void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm);void odm_CommonInfoSelfInit (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 17/32 staging: r8188eu: make odm_CommonInfoSelfInit() static
In reply to Michael StraubeFunction odm_CommonInfoSelfInit() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 16 ++++++++-------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 8 insertions(+), 9 deletions(-)
drivers/staging/r8188eu/hal/odm.c +8 -8
@@ -303,6 +303,14 @@ static void odm_DIG(struct odm_dm_struct *pDM_Odm) pDM_DigTable->DIG_Dynamic_MIN_0 = DIG_Dynamic_MIN; } +static void odm_CommonInfoSelfInit (struct odm_dm_struct *pDM_Odm) +{ +struct adapter *adapter = pDM_Odm->Adapter; + + pDM_Odm->bCckHighPower = (bool )rtl8188e_PHY_QueryBBReg (adapter,0x824 ,BIT (9 )); + pDM_Odm->RFPathRxEnable = (u8 )rtl8188e_PHY_QueryBBReg (adapter,0xc04 ,0x0F ); +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -426,14 +434,6 @@ void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value) } } -void odm_CommonInfoSelfInit (struct odm_dm_struct *pDM_Odm) -{ -struct adapter *adapter = pDM_Odm->Adapter; - - pDM_Odm->bCckHighPower = (bool )rtl8188e_PHY_QueryBBReg (adapter,0x824 ,BIT (9 )); - pDM_Odm->RFPathRxEnable = (u8 )rtl8188e_PHY_QueryBBReg (adapter,0xc04 ,0x0F ); -} -void odm_CommonInfoSelfUpdate (struct odm_dm_struct *pDM_Odm) {u8 EntryCnt =0 ;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -39,7 +39,6 @@ void odm_CommonInfoSelfUpdate(struct odm_dm_struct *pDM_Odm);void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm);void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm); -void odm_CommonInfoSelfInit (struct odm_dm_struct *pDM_Odm);void odm_RSSIMonitorCheck (struct odm_dm_struct *pDM_Odm);void odm_RefreshRateAdaptiveMask (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 18/32 staging: r8188eu: make odm_CommonInfoSelfUpdate() static
In reply to Michael StraubeFunction odm_CommonInfoSelfUpdate() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 52 +++++++++---------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 26 insertions(+), 27 deletions(-)
drivers/staging/r8188eu/hal/odm.c +26 -26
@@ -311,6 +311,32 @@ static void odm_CommonInfoSelfInit(struct odm_dm_struct *pDM_Odm) pDM_Odm->RFPathRxEnable = (u8 )rtl8188e_PHY_QueryBBReg (adapter,0xc04 ,0x0F ); } +static void odm_CommonInfoSelfUpdate (struct odm_dm_struct *pDM_Odm) +{ +u8 EntryCnt =0 ; +u8 i; +struct sta_info *pEntry; + +if (*pDM_Odm->pBandWidth ==ODM_BW40M ) { +if (*pDM_Odm->pSecChOffset ==1 ) + pDM_Odm->ControlChannel = *pDM_Odm->pChannel -2 ; +else if (*pDM_Odm->pSecChOffset ==2 ) + pDM_Odm->ControlChannel = *pDM_Odm->pChannel +2 ; + }else { + pDM_Odm->ControlChannel = *pDM_Odm->pChannel; + } + +for (i =0 ; i <ODM_ASSOCIATE_ENTRY_NUM ; i++) { + pEntry = pDM_Odm->pODM_StaInfo[i]; +if (IS_STA_VALID (pEntry)) + EntryCnt++; + } +if (EntryCnt ==1 ) + pDM_Odm->bOneEntryOnly = true; +else + pDM_Odm->bOneEntryOnly = false; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -434,32 +460,6 @@ void ODM_CmnInfoUpdate(struct odm_dm_struct *pDM_Odm, u32 CmnInfo, u64 Value) } } -void odm_CommonInfoSelfUpdate (struct odm_dm_struct *pDM_Odm) -{ -u8 EntryCnt =0 ; -u8 i; -struct sta_info *pEntry; - -if (*pDM_Odm->pBandWidth ==ODM_BW40M ) { -if (*pDM_Odm->pSecChOffset ==1 ) - pDM_Odm->ControlChannel = *pDM_Odm->pChannel -2 ; -else if (*pDM_Odm->pSecChOffset ==2 ) - pDM_Odm->ControlChannel = *pDM_Odm->pChannel +2 ; - }else { - pDM_Odm->ControlChannel = *pDM_Odm->pChannel; - } - -for (i =0 ; i <ODM_ASSOCIATE_ENTRY_NUM ; i++) { - pEntry = pDM_Odm->pODM_StaInfo[i]; -if (IS_STA_VALID (pEntry)) - EntryCnt++; - } -if (EntryCnt ==1 ) - pDM_Odm->bOneEntryOnly = true; -else - pDM_Odm->bOneEntryOnly = false; -} -void ODM_Write_DIG (struct odm_dm_struct *pDM_Odm,u8 CurrentIGI) {struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -35,7 +35,6 @@ void odm_RateAdaptiveMaskInit(struct odm_dm_struct *pDM_Odm);void odm_DynamicBBPowerSavingInit (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm); -void odm_CommonInfoSelfUpdate (struct odm_dm_struct *pDM_Odm);void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm);void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 19/32 staging: r8188eu: make odm_RateAdaptiveMaskInit() static
In reply to Michael StraubeFunction odm_RateAdaptiveMaskInit() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 18 +++++++++--------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 9 insertions(+), 10 deletions(-)
drivers/staging/r8188eu/hal/odm.c +9 -9
@@ -337,6 +337,15 @@ static void odm_CommonInfoSelfUpdate(struct odm_dm_struct *pDM_Odm) pDM_Odm->bOneEntryOnly = false; } +static void odm_RateAdaptiveMaskInit (struct odm_dm_struct *pDM_Odm) +{ +struct odm_rate_adapt *pOdmRA = &pDM_Odm->RateAdaptive; + + pOdmRA->RATRState =DM_RATR_STA_INIT ; + pOdmRA->HighRSSIThresh =50 ; + pOdmRA->LowRSSIThresh =20 ; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -646,15 +655,6 @@ void ODM_RF_Saving(struct odm_dm_struct *pDM_Odm, u8 bForceInNormal)/* 3 Rate Adaptive */ /* 3============================================================ */ -void odm_RateAdaptiveMaskInit (struct odm_dm_struct *pDM_Odm) -{ -struct odm_rate_adapt *pOdmRA = &pDM_Odm->RateAdaptive; - - pOdmRA->RATRState =DM_RATR_STA_INIT ; - pOdmRA->HighRSSIThresh =50 ; - pOdmRA->LowRSSIThresh =20 ; -} -u32 ODM_Get_Rate_Bitmap (struct odm_dm_struct *pDM_Odm,u32 macid,u32 ra_mask,u8 rssi_level) {struct sta_info *pEntry;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -31,7 +31,6 @@#include "odm_RegConfig8188E.h" #include "odm_RTL8188E.h" -void odm_RateAdaptiveMaskInit (struct odm_dm_struct *pDM_Odm);void odm_DynamicBBPowerSavingInit (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 20/32 staging: r8188eu: make odm_RefreshRateAdaptiveMask() static
In reply to Michael StraubeFunction odm_RefreshRateAdaptiveMask() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 51 +++++++------------ drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 18 insertions(+), 34 deletions(-)
drivers/staging/r8188eu/hal/odm.c +18 -33
@@ -346,6 +346,24 @@ static void odm_RateAdaptiveMaskInit(struct odm_dm_struct *pDM_Odm) pOdmRA->LowRSSIThresh =20 ; } +static void odm_RefreshRateAdaptiveMask (struct odm_dm_struct *pDM_Odm) +{ +u8 i; +struct adapter *pAdapter = pDM_Odm->Adapter; + +if (pAdapter->bDriverStopped) +return ; + +for (i =0 ; i <ODM_ASSOCIATE_ENTRY_NUM ; i++) { +struct sta_info *pstat = pDM_Odm->pODM_StaInfo[i]; + +if (IS_STA_VALID (pstat)) { +if (ODM_RAStateCheck (pDM_Odm, pstat->rssi_stat.UndecoratedSmoothedPWDB, false, &pstat->rssi_level)) +rtw_hal_update_ra_mask (pAdapter, i, pstat->rssi_level); + } + } +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -703,39 +721,6 @@ u32 ODM_Get_Rate_Bitmap(struct odm_dm_struct *pDM_Odm, u32 macid, u32 ra_mask, ureturn rate_bitmap; } -/*----------------------------------------------------------------------------- -* Function: odm_RefreshRateAdaptiveMask() -* -* Overview: Update rate table mask according to rssi -* -* Input: NONE -* -* Output: NONE -* -* Return: NONE -* -* Revised History: -* When Who Remark -* 05/27/2009 hpfan Create Version 0. -* -*---------------------------------------------------------------------------*/ -void odm_RefreshRateAdaptiveMask (struct odm_dm_struct *pDM_Odm) -{ -u8 i; -struct adapter *pAdapter = pDM_Odm->Adapter; - -if (pAdapter->bDriverStopped) -return ; - -for (i =0 ; i <ODM_ASSOCIATE_ENTRY_NUM ; i++) { -struct sta_info *pstat = pDM_Odm->pODM_StaInfo[i]; -if (IS_STA_VALID (pstat)) { -if (ODM_RAStateCheck (pDM_Odm, pstat->rssi_stat.UndecoratedSmoothedPWDB, false, &pstat->rssi_level)) -rtw_hal_update_ra_mask (pAdapter, i, pstat->rssi_level); - } - } -} -/* Return Value: bool */ /* - true: RATRState is changed. */ bool ODM_RAStateCheck (struct odm_dm_struct *pDM_Odm,s32 RSSI ,bool bForceUpdate,u8 *pRATRState)
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -38,7 +38,6 @@ void odm_FalseAlarmCounterStatistics(struct odm_dm_struct *pDM_Odm);void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm);void odm_RSSIMonitorCheck (struct odm_dm_struct *pDM_Odm); -void odm_RefreshRateAdaptiveMask (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm);void odm_InitHybridAntDiv (struct odm_dm_struct *pDM_Odm);void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
Re: [PATCH 20/32] staging: r8188eu: make odm_RefreshRateAdaptiveMask() static
drivers/staging/r8188eu/hal/odm.c static void odm_RateAdaptiveMaskInit(struct odm_dm_struct *pDM_Odm) · line 359
Quoted 11 lines · Michael Straube
drivers/staging/r8188eu/hal/odm.c +11
-0+static void odm_RefreshRateAdaptiveMask (struct odm_dm_struct *pDM_Odm) +{ +u8 i; +struct adapter *pAdapter = pDM_Odm->Adapter; + +if (pAdapter->bDriverStopped) +return ; + +for (i =0 ; i <ODM_ASSOCIATE_ENTRY_NUM ; i++) { +struct sta_info *pstat = pDM_Odm->pODM_StaInfo[i]; +
Michael, people don't thank you enough for all the clean up work on this driver. This is not a "please resend" level issue, and also Greg already applied the patch so resending is impossible.
But, you added a blank line here after the declaration to make checkpatch happy. When you're moving functions around could you just leave them exactly as-is? I have a script to help me review moving code and it helps me if the functions stay exactly the same.
Anyway, thanks again for your cleanup work on this driver.
drivers/staging/r8188eu/hal/odm.c static void odm_RateAdaptiveMaskInit(struct odm_dm_struct *pDM_Odm) · line 365
Quoted 6 lines
drivers/staging/r8188eu/hal/odm.c +6
-0+if (IS_STA_VALID (pstat)) { +if (ODM_RAStateCheck (pDM_Odm, pstat->rssi_stat.UndecoratedSmoothedPWDB, false, &pstat->rssi_level)) +rtw_hal_update_ra_mask (pAdapter, i, pstat->rssi_level); + } + } +}
regards,
dan carpenter
Re: [PATCH 20/32] staging: r8188eu: make odm_RefreshRateAdaptiveMask() static
Quoted 3 lines · Dan Carpenter
But, you added a blank line here after the declaration to make checkpatch When you're moving functions around could you just leave them exactly as-is?
Sure, I'll do.
Thanks,
Michael
PATCH 21/32 staging: r8188eu: make odm_DynamicBBPowerSavingInit() static
In reply to Michael StraubeFunction odm_DynamicBBPowerSavingInit() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 21 ++++++++----------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 9 insertions(+), 13 deletions(-)
drivers/staging/r8188eu/hal/odm.c +9 -12
@@ -364,6 +364,15 @@ static void odm_RefreshRateAdaptiveMask(struct odm_dm_struct *pDM_Odm) } } +static void odm_DynamicBBPowerSavingInit (struct odm_dm_struct *pDM_Odm) +{ +struct rtl_ps *pDM_PSTable = &pDM_Odm->DM_PSTable; + + pDM_PSTable->pre_rf_state =RF_MAX ; + pDM_PSTable->cur_rf_state =RF_MAX ; + pDM_PSTable->initialize =0 ; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -599,18 +608,6 @@ void ODM_Write_CCK_CCA_Thres(struct odm_dm_struct *pDM_Odm, u8 CurCCK_CCAThres) pDM_DigTable->CurCCK_CCAThres = CurCCK_CCAThres; } -/* 3============================================================ */ -/* 3 BB Power Save */ -/* 3============================================================ */ -void odm_DynamicBBPowerSavingInit (struct odm_dm_struct *pDM_Odm) -{ -struct rtl_ps *pDM_PSTable = &pDM_Odm->DM_PSTable; - - pDM_PSTable->pre_rf_state =RF_MAX ; - pDM_PSTable->cur_rf_state =RF_MAX ; - pDM_PSTable->initialize =0 ; -} -void ODM_RF_Saving (struct odm_dm_struct *pDM_Odm,u8 bForceInNormal) {struct rtl_ps *pDM_PSTable = &pDM_Odm->DM_PSTable;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -31,7 +31,6 @@#include "odm_RegConfig8188E.h" #include "odm_RTL8188E.h" -void odm_DynamicBBPowerSavingInit (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 22/32 staging: r8188eu: make odm_FalseAlarmCounterStatistics() static
In reply to Michael StraubeFunction odm_FalseAlarmCounterStatistics() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 116 +++++++++--------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 56 insertions(+), 61 deletions(-)
drivers/staging/r8188eu/hal/odm.c +56 -60
@@ -373,6 +373,62 @@ static void odm_DynamicBBPowerSavingInit(struct odm_dm_struct *pDM_Odm) pDM_PSTable->initialize =0 ; } +static void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm) +{ +u32 ret_value; +struct false_alarm_stats *FalseAlmCnt = &pDM_Odm->FalseAlmCnt; +struct adapter *adapter = pDM_Odm->Adapter; + +if (!(pDM_Odm->SupportAbility &ODM_BB_FA_CNT )) +return ; + +/* hold ofdm counter */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_OFDM_FA_HOLDC_11N ,BIT (31 ),1 );/* hold page C counter */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_OFDM_FA_RSTD_11N ,BIT (31 ),1 );/* hold page D counter */ + + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE1_11N , bMaskDWord); + FalseAlmCnt->Cnt_Fast_Fsync = (ret_value &0xffff ); + FalseAlmCnt->Cnt_SB_Search_fail = ((ret_value &0xffff0000 ) >>16 ); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE2_11N , bMaskDWord); + FalseAlmCnt->Cnt_OFDM_CCA = (ret_value &0xffff ); + FalseAlmCnt->Cnt_Parity_Fail = ((ret_value &0xffff0000 ) >>16 ); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE3_11N , bMaskDWord); + FalseAlmCnt->Cnt_Rate_Illegal = (ret_value &0xffff ); + FalseAlmCnt->Cnt_Crc8_fail = ((ret_value &0xffff0000 ) >>16 ); + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE4_11N , bMaskDWord); + FalseAlmCnt->Cnt_Mcs_fail = (ret_value &0xffff ); + + FalseAlmCnt->Cnt_Ofdm_fail = FalseAlmCnt->Cnt_Parity_Fail + FalseAlmCnt->Cnt_Rate_Illegal + + FalseAlmCnt->Cnt_Crc8_fail + FalseAlmCnt->Cnt_Mcs_fail + + FalseAlmCnt->Cnt_Fast_Fsync + FalseAlmCnt->Cnt_SB_Search_fail; + + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_SC_CNT_11N , bMaskDWord); + FalseAlmCnt->Cnt_BW_LSC = (ret_value &0xffff ); + FalseAlmCnt->Cnt_BW_USC = ((ret_value &0xffff0000 ) >>16 ); + +/* hold cck counter */ +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_CCK_FA_RST_11N ,BIT (12 ),1 ); +rtl8188e_PHY_SetBBReg (adapter,ODM_REG_CCK_FA_RST_11N ,BIT (14 ),1 ); + + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_FA_LSB_11N , bMaskByte0); + FalseAlmCnt->Cnt_Cck_fail = ret_value; + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_FA_MSB_11N , bMaskByte3); + FalseAlmCnt->Cnt_Cck_fail += (ret_value &0xff ) <<8 ; + + ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_CCA_CNT_11N , bMaskDWord); + FalseAlmCnt->Cnt_CCK_CCA = ((ret_value &0xFF ) <<8 ) | ((ret_value &0xFF00 ) >>8 ); + + FalseAlmCnt->Cnt_all = (FalseAlmCnt->Cnt_Fast_Fsync + + FalseAlmCnt->Cnt_SB_Search_fail + + FalseAlmCnt->Cnt_Parity_Fail + + FalseAlmCnt->Cnt_Rate_Illegal + + FalseAlmCnt->Cnt_Crc8_fail + + FalseAlmCnt->Cnt_Mcs_fail + + FalseAlmCnt->Cnt_Cck_fail); + + FalseAlmCnt->Cnt_CCA_all = FalseAlmCnt->Cnt_OFDM_CCA + FalseAlmCnt->Cnt_CCK_CCA; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -507,66 +563,6 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI) } } -/* 3============================================================ */ -/* 3 FASLE ALARM CHECK */ -/* 3============================================================ */ - -void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm) -{ -u32 ret_value; -struct false_alarm_stats *FalseAlmCnt = &pDM_Odm->FalseAlmCnt; -struct adapter *adapter = pDM_Odm->Adapter; - -if (!(pDM_Odm->SupportAbility &ODM_BB_FA_CNT )) -return ; - -/* hold ofdm counter */ -rtl8188e_PHY_SetBBReg (adapter,ODM_REG_OFDM_FA_HOLDC_11N ,BIT (31 ),1 );/* hold page C counter */ -rtl8188e_PHY_SetBBReg (adapter,ODM_REG_OFDM_FA_RSTD_11N ,BIT (31 ),1 );/* hold page D counter */ - - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE1_11N , bMaskDWord); - FalseAlmCnt->Cnt_Fast_Fsync = (ret_value &0xffff ); - FalseAlmCnt->Cnt_SB_Search_fail = ((ret_value &0xffff0000 ) >>16 ); - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE2_11N , bMaskDWord); - FalseAlmCnt->Cnt_OFDM_CCA = (ret_value &0xffff ); - FalseAlmCnt->Cnt_Parity_Fail = ((ret_value &0xffff0000 ) >>16 ); - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE3_11N , bMaskDWord); - FalseAlmCnt->Cnt_Rate_Illegal = (ret_value &0xffff ); - FalseAlmCnt->Cnt_Crc8_fail = ((ret_value &0xffff0000 ) >>16 ); - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_OFDM_FA_TYPE4_11N , bMaskDWord); - FalseAlmCnt->Cnt_Mcs_fail = (ret_value &0xffff ); - - FalseAlmCnt->Cnt_Ofdm_fail = FalseAlmCnt->Cnt_Parity_Fail + FalseAlmCnt->Cnt_Rate_Illegal + - FalseAlmCnt->Cnt_Crc8_fail + FalseAlmCnt->Cnt_Mcs_fail + - FalseAlmCnt->Cnt_Fast_Fsync + FalseAlmCnt->Cnt_SB_Search_fail; - - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_SC_CNT_11N , bMaskDWord); - FalseAlmCnt->Cnt_BW_LSC = (ret_value &0xffff ); - FalseAlmCnt->Cnt_BW_USC = ((ret_value &0xffff0000 ) >>16 ); - -/* hold cck counter */ -rtl8188e_PHY_SetBBReg (adapter,ODM_REG_CCK_FA_RST_11N ,BIT (12 ),1 ); -rtl8188e_PHY_SetBBReg (adapter,ODM_REG_CCK_FA_RST_11N ,BIT (14 ),1 ); - - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_FA_LSB_11N , bMaskByte0); - FalseAlmCnt->Cnt_Cck_fail = ret_value; - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_FA_MSB_11N , bMaskByte3); - FalseAlmCnt->Cnt_Cck_fail += (ret_value &0xff ) <<8 ; - - ret_value =rtl8188e_PHY_QueryBBReg (adapter,ODM_REG_CCK_CCA_CNT_11N , bMaskDWord); - FalseAlmCnt->Cnt_CCK_CCA = ((ret_value &0xFF ) <<8 ) | ((ret_value &0xFF00 ) >>8 ); - - FalseAlmCnt->Cnt_all = (FalseAlmCnt->Cnt_Fast_Fsync + - FalseAlmCnt->Cnt_SB_Search_fail + - FalseAlmCnt->Cnt_Parity_Fail + - FalseAlmCnt->Cnt_Rate_Illegal + - FalseAlmCnt->Cnt_Crc8_fail + - FalseAlmCnt->Cnt_Mcs_fail + - FalseAlmCnt->Cnt_Cck_fail); - - FalseAlmCnt->Cnt_CCA_all = FalseAlmCnt->Cnt_OFDM_CCA + FalseAlmCnt->Cnt_CCK_CCA; -} -/* 3============================================================ */ /* 3 CCK Packet Detect Threshold */ /* 3============================================================ */
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -33,7 +33,6 @@void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm); -void odm_FalseAlarmCounterStatistics (struct odm_dm_struct *pDM_Odm);void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm);void odm_RSSIMonitorCheck (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 23/32 staging: r8188eu: make odm_CCKPacketDetectionThresh() static
In reply to Michael StraubeFunction odm_CCKPacketDetectionThresh() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 58 +++++++++---------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 27 insertions(+), 32 deletions(-)
drivers/staging/r8188eu/hal/odm.c +27 -31
@@ -429,6 +429,33 @@ static void odm_FalseAlarmCounterStatistics(struct odm_dm_struct *pDM_Odm) FalseAlmCnt->Cnt_CCA_all = FalseAlmCnt->Cnt_OFDM_CCA + FalseAlmCnt->Cnt_CCK_CCA; } +static void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm) +{ +u8 CurCCK_CCAThres; +struct false_alarm_stats *FalseAlmCnt = &pDM_Odm->FalseAlmCnt; + +if (!(pDM_Odm->SupportAbility & (ODM_BB_CCK_PD |ODM_BB_FA_CNT ))) +return ; +if (pDM_Odm->bLinked) { +if (pDM_Odm->RSSI_Min >25 ) { + CurCCK_CCAThres =0xcd ; + }else if ((pDM_Odm->RSSI_Min <=25 ) && (pDM_Odm->RSSI_Min >10 )) { + CurCCK_CCAThres =0x83 ; + }else { +if (FalseAlmCnt->Cnt_Cck_fail >1000 ) + CurCCK_CCAThres =0x83 ; +else + CurCCK_CCAThres =0x40 ; + } + }else { +if (FalseAlmCnt->Cnt_Cck_fail >1000 ) + CurCCK_CCAThres =0x83 ; +else + CurCCK_CCAThres =0x40 ; + } +ODM_Write_CCK_CCA_Thres (pDM_Odm, CurCCK_CCAThres); +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -563,37 +590,6 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI) } } -/* 3============================================================ */ -/* 3 CCK Packet Detect Threshold */ -/* 3============================================================ */ - -void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm) -{ -u8 CurCCK_CCAThres; -struct false_alarm_stats *FalseAlmCnt = &pDM_Odm->FalseAlmCnt; - -if (!(pDM_Odm->SupportAbility & (ODM_BB_CCK_PD |ODM_BB_FA_CNT ))) -return ; -if (pDM_Odm->bLinked) { -if (pDM_Odm->RSSI_Min >25 ) { - CurCCK_CCAThres =0xcd ; - }else if ((pDM_Odm->RSSI_Min <=25 ) && (pDM_Odm->RSSI_Min >10 )) { - CurCCK_CCAThres =0x83 ; - }else { -if (FalseAlmCnt->Cnt_Cck_fail >1000 ) - CurCCK_CCAThres =0x83 ; -else - CurCCK_CCAThres =0x40 ; - } - }else { -if (FalseAlmCnt->Cnt_Cck_fail >1000 ) - CurCCK_CCAThres =0x83 ; -else - CurCCK_CCAThres =0x40 ; - } -ODM_Write_CCK_CCA_Thres (pDM_Odm, CurCCK_CCAThres); -} -void ODM_Write_CCK_CCA_Thres (struct odm_dm_struct *pDM_Odm,u8 CurCCK_CCAThres) {struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -33,7 +33,6 @@void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm); -void odm_CCKPacketDetectionThresh (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm);void odm_RSSIMonitorCheck (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 24/32 staging: r8188eu: make odm_RSSIMonitorCheck() static
In reply to Michael StraubeFunction odm_RSSIMonitorCheck() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 148 +++++++++--------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 72 insertions(+), 77 deletions(-)
drivers/staging/r8188eu/hal/odm.c +72 -76
@@ -456,6 +456,78 @@ static void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm)ODM_Write_CCK_CCA_Thres (pDM_Odm, CurCCK_CCAThres); } +static void FindMinimumRSSI (struct adapter *pAdapter) +{ +struct hal_data_8188e *pHalData = &pAdapter->haldata; +struct dm_priv *pdmpriv = &pHalData->dmpriv; +struct mlme_priv *pmlmepriv = &pAdapter->mlmepriv; + +/* 1 1.Determine the minimum RSSI */ +if (!check_fwstate (pmlmepriv, _FW_LINKED) && + pdmpriv->EntryMinUndecoratedSmoothedPWDB ==0 ) + pdmpriv->MinUndecoratedPWDBForDM =0 ; + + pdmpriv->MinUndecoratedPWDBForDM = pdmpriv->EntryMinUndecoratedSmoothedPWDB; +} + +static void odm_RSSIMonitorCheck (struct odm_dm_struct *pDM_Odm) +{ +struct adapter *Adapter = pDM_Odm->Adapter; +struct hal_data_8188e *pHalData = &Adapter->haldata; +struct dm_priv *pdmpriv = &pHalData->dmpriv; +int i; +int tmpEntryMaxPWDB =0 , tmpEntryMinPWDB =0xff ; +u8 sta_cnt =0 ; +u32 PWDB_rssi[NUM_STA ] = {0 };/* 0~15]:MACID, [16~31]:PWDB_rssi */ +struct sta_info *psta; + +if (!(pDM_Odm->SupportAbility &ODM_BB_RSSI_MONITOR )) +return ; + +if (!check_fwstate (&Adapter->mlmepriv, _FW_LINKED)) +return ; + +for (i =0 ; i <ODM_ASSOCIATE_ENTRY_NUM ; i++) { + psta = pDM_Odm->pODM_StaInfo[i]; +if (IS_STA_VALID (psta) && + (psta->state &WIFI_ASOC_STATE ) && + !is_broadcast_ether_addr (psta->hwaddr) && +memcmp (psta->hwaddr,myid (&Adapter->eeprompriv),ETH_ALEN )) { +if (psta->rssi_stat.UndecoratedSmoothedPWDB < tmpEntryMinPWDB) + tmpEntryMinPWDB = psta->rssi_stat.UndecoratedSmoothedPWDB; + +if (psta->rssi_stat.UndecoratedSmoothedPWDB > tmpEntryMaxPWDB) + tmpEntryMaxPWDB = psta->rssi_stat.UndecoratedSmoothedPWDB; +if (psta->rssi_stat.UndecoratedSmoothedPWDB != (-1 )) + PWDB_rssi[sta_cnt++] = (psta->mac_id | (psta->rssi_stat.UndecoratedSmoothedPWDB <<16 )); + } + } + +for (i =0 ; i < sta_cnt; i++) { +if (PWDB_rssi[i] != (0 )) { +if (pHalData->fw_ractrl) { +/* Report every sta's RSSI to FW */ + }else { +ODM_RA_SetRSSI_8188E ( + &pHalData->odmpriv, (PWDB_rssi[i] &0xFF ), (u8)((PWDB_rssi[i] >>16 ) &0xFF )); + } + } + } + +if (tmpEntryMaxPWDB !=0 )/* If associated entry is found */ + pdmpriv->EntryMaxUndecoratedSmoothedPWDB = tmpEntryMaxPWDB; +else + pdmpriv->EntryMaxUndecoratedSmoothedPWDB =0 ; + +if (tmpEntryMinPWDB !=0xff )/* If associated entry is found */ + pdmpriv->EntryMinUndecoratedSmoothedPWDB = tmpEntryMinPWDB; +else + pdmpriv->EntryMinUndecoratedSmoothedPWDB =0 ; + +FindMinimumRSSI (Adapter); +ODM_CmnInfoUpdate (&pHalData->odmpriv,ODM_CMNINFO_RSSI_MIN , pdmpriv->MinUndecoratedPWDBForDM); +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -753,82 +825,6 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdatereturn false; } -/* 3============================================================ */ -/* 3 RSSI Monitor */ -/* 3============================================================ */ - -static void FindMinimumRSSI (struct adapter *pAdapter) -{ -struct hal_data_8188e *pHalData = &pAdapter->haldata; -struct dm_priv *pdmpriv = &pHalData->dmpriv; -struct mlme_priv *pmlmepriv = &pAdapter->mlmepriv; - -/* 1 1.Determine the minimum RSSI */ -if (!check_fwstate (pmlmepriv, _FW_LINKED) && - pdmpriv->EntryMinUndecoratedSmoothedPWDB ==0 ) - pdmpriv->MinUndecoratedPWDBForDM =0 ; - - pdmpriv->MinUndecoratedPWDBForDM = pdmpriv->EntryMinUndecoratedSmoothedPWDB; -} - -void odm_RSSIMonitorCheck (struct odm_dm_struct *pDM_Odm) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -struct hal_data_8188e *pHalData = &Adapter->haldata; -struct dm_priv *pdmpriv = &pHalData->dmpriv; -int i; -int tmpEntryMaxPWDB =0 , tmpEntryMinPWDB =0xff ; -u8 sta_cnt =0 ; -u32 PWDB_rssi[NUM_STA ] = {0 };/* 0~15]:MACID, [16~31]:PWDB_rssi */ -struct sta_info *psta; - -if (!(pDM_Odm->SupportAbility &ODM_BB_RSSI_MONITOR )) -return ; - -if (!check_fwstate (&Adapter->mlmepriv, _FW_LINKED)) -return ; - -for (i =0 ; i <ODM_ASSOCIATE_ENTRY_NUM ; i++) { - psta = pDM_Odm->pODM_StaInfo[i]; -if (IS_STA_VALID (psta) && - (psta->state &WIFI_ASOC_STATE ) && - !is_broadcast_ether_addr (psta->hwaddr) && -memcmp (psta->hwaddr,myid (&Adapter->eeprompriv),ETH_ALEN )) { -if (psta->rssi_stat.UndecoratedSmoothedPWDB < tmpEntryMinPWDB) - tmpEntryMinPWDB = psta->rssi_stat.UndecoratedSmoothedPWDB; - -if (psta->rssi_stat.UndecoratedSmoothedPWDB > tmpEntryMaxPWDB) - tmpEntryMaxPWDB = psta->rssi_stat.UndecoratedSmoothedPWDB; -if (psta->rssi_stat.UndecoratedSmoothedPWDB != (-1 )) - PWDB_rssi[sta_cnt++] = (psta->mac_id | (psta->rssi_stat.UndecoratedSmoothedPWDB <<16 )); - } - } - -for (i =0 ; i < sta_cnt; i++) { -if (PWDB_rssi[i] != (0 )) { -if (pHalData->fw_ractrl) { -/* Report every sta's RSSI to FW */ - }else { -ODM_RA_SetRSSI_8188E ( - &pHalData->odmpriv, (PWDB_rssi[i] &0xFF ), (u8)((PWDB_rssi[i] >>16 ) &0xFF )); - } - } - } - -if (tmpEntryMaxPWDB !=0 )/* If associated entry is found */ - pdmpriv->EntryMaxUndecoratedSmoothedPWDB = tmpEntryMaxPWDB; -else - pdmpriv->EntryMaxUndecoratedSmoothedPWDB =0 ; - -if (tmpEntryMinPWDB !=0xff )/* If associated entry is found */ - pdmpriv->EntryMinUndecoratedSmoothedPWDB = tmpEntryMinPWDB; -else - pdmpriv->EntryMinUndecoratedSmoothedPWDB =0 ; - -FindMinimumRSSI (Adapter); -ODM_CmnInfoUpdate (&pHalData->odmpriv,ODM_CMNINFO_RSSI_MIN , pdmpriv->MinUndecoratedPWDBForDM); -} -/* 3============================================================ */ /* 3 Tx Power Tracking */ /* 3============================================================ */
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -34,7 +34,6 @@void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm); -void odm_RSSIMonitorCheck (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm);void odm_InitHybridAntDiv (struct odm_dm_struct *pDM_Odm);void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 25/32 staging: r8188eu: remove odm_TXPowerTrackingInit()
In reply to Michael Straubeodm_TXPowerTrackingInit() is just a wrapper around odm_TXPowerTrackingThermalMeterInit(). Remove it.
--- drivers/staging/r8188eu/hal/odm.c | 7 +------ drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-)
drivers/staging/r8188eu/hal/odm.c +1 -6
@@ -539,7 +539,7 @@ void ODM_DMInit(struct odm_dm_struct *pDM_Odm)odm_RateAdaptiveMaskInit (pDM_Odm);odm_DynamicBBPowerSavingInit (pDM_Odm); -odm_TXPowerTrackingInit (pDM_Odm); +odm_TXPowerTrackingThermalMeterInit (pDM_Odm);ODM_EdcaTurboInit (pDM_Odm);ODM_RAInfo_Init_all (pDM_Odm); if ((pDM_Odm->AntDivType == CG_TRX_HW_ANTDIV) ||
@@ -829,11 +829,6 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate/* 3 Tx Power Tracking */ /* 3============================================================ */ -void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm) -{ -odm_TXPowerTrackingThermalMeterInit (pDM_Odm); -} -void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm) { pDM_Odm->RFCalibrateInfo.bTXPowerTracking = true;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -31,7 +31,6 @@#include "odm_RegConfig8188E.h" #include "odm_RTL8188E.h" -void odm_TXPowerTrackingInit (struct odm_dm_struct *pDM_Odm);void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm);void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 26/32 staging: r8188eu: make odm_TXPowerTrackingThermalMeterInit() static
In reply to Michael StraubeFunction odm_TXPowerTrackingThermalMeterInit() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 20 ++++++++----------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 8 insertions(+), 13 deletions(-)
drivers/staging/r8188eu/hal/odm.c +8 -12
@@ -528,6 +528,14 @@ static void odm_RSSIMonitorCheck(struct odm_dm_struct *pDM_Odm)ODM_CmnInfoUpdate (&pHalData->odmpriv,ODM_CMNINFO_RSSI_MIN , pdmpriv->MinUndecoratedPWDBForDM); } +static void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm) +{ + pDM_Odm->RFCalibrateInfo.bTXPowerTracking = true; + pDM_Odm->RFCalibrateInfo.TXPowercount =0 ; + pDM_Odm->RFCalibrateInfo.bTXPowerTrackingInit = false; + pDM_Odm->RFCalibrateInfo.TxPowerTrackControl = true; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -825,18 +833,6 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdatereturn false; } -/* 3============================================================ */ -/* 3 Tx Power Tracking */ -/* 3============================================================ */ - -void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm) -{ - pDM_Odm->RFCalibrateInfo.bTXPowerTracking = true; - pDM_Odm->RFCalibrateInfo.TXPowercount =0 ; - pDM_Odm->RFCalibrateInfo.bTXPowerTrackingInit = false; - pDM_Odm->RFCalibrateInfo.TxPowerTrackControl = true; -} -void ODM_TXPowerTrackingCheck (struct odm_dm_struct *pDM_Odm) {struct adapter *Adapter = pDM_Odm->Adapter;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -33,7 +33,6 @@void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm); -void odm_TXPowerTrackingThermalMeterInit (struct odm_dm_struct *pDM_Odm);void odm_InitHybridAntDiv (struct odm_dm_struct *pDM_Odm);void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm);
Signature · 1 line
2.34.1
PATCH 27/32 staging: r8188eu: make odm_InitHybridAntDiv() static
In reply to Michael StraubeFunction odm_InitHybridAntDiv() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 16 ++++++++-------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 8 insertions(+), 9 deletions(-)
drivers/staging/r8188eu/hal/odm.c +8 -8
@@ -536,6 +536,14 @@ static void odm_TXPowerTrackingThermalMeterInit(struct odm_dm_struct *pDM_Odm) pDM_Odm->RFCalibrateInfo.TxPowerTrackControl = true; } +static void odm_InitHybridAntDiv (struct odm_dm_struct *pDM_Odm) +{ +if (!(pDM_Odm->SupportAbility &ODM_BB_ANT_DIV )) +return ; + +ODM_AntennaDiversityInit_88E (pDM_Odm); +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -851,14 +859,6 @@ void ODM_TXPowerTrackingCheck(struct odm_dm_struct *pDM_Odm) } } -void odm_InitHybridAntDiv (struct odm_dm_struct *pDM_Odm) -{ -if (!(pDM_Odm->SupportAbility &ODM_BB_ANT_DIV )) -return ; - -ODM_AntennaDiversityInit_88E (pDM_Odm); -} -void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm) {if (!(pDM_Odm->SupportAbility &ODM_BB_ANT_DIV ))
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -33,7 +33,6 @@void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm); -void odm_InitHybridAntDiv (struct odm_dm_struct *pDM_Odm);void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm);#endif /* __ODM_PRECOMP_H__ */
Signature · 1 line
2.34.1
PATCH 28/32 staging: r8188eu: make odm_HwAntDiv() static
In reply to Michael StraubeFunction odm_HwAntDiv() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 16 ++++++++-------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 8 insertions(+), 9 deletions(-)
drivers/staging/r8188eu/hal/odm.c +8 -8
@@ -544,6 +544,14 @@ static void odm_InitHybridAntDiv(struct odm_dm_struct *pDM_Odm)ODM_AntennaDiversityInit_88E (pDM_Odm); } +static void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm) +{ +if (!(pDM_Odm->SupportAbility &ODM_BB_ANT_DIV )) +return ; + +ODM_AntennaDiversity_88E (pDM_Odm); +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -859,14 +867,6 @@ void ODM_TXPowerTrackingCheck(struct odm_dm_struct *pDM_Odm) } } -void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm) -{ -if (!(pDM_Odm->SupportAbility &ODM_BB_ANT_DIV )) -return ; - -ODM_AntennaDiversity_88E (pDM_Odm); -} -/* EDCA Turbo */ void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm) {
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -33,6 +33,5 @@void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm); -void odm_HwAntDiv (struct odm_dm_struct *pDM_Odm);#endif /* __ODM_PRECOMP_H__ */
Signature · 1 line
2.34.1
PATCH 29/32 staging: r8188eu: make ODM_EdcaTurboInit() static
In reply to Michael StraubeFunction ODM_EdcaTurboInit() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 18 ++++++++---------- drivers/staging/r8188eu/include/odm_precomp.h | 1 - 2 files changed, 8 insertions(+), 11 deletions(-)
drivers/staging/r8188eu/hal/odm.c +8 -10
@@ -552,6 +552,14 @@ static void odm_HwAntDiv(struct odm_dm_struct *pDM_Odm)ODM_AntennaDiversity_88E (pDM_Odm); } +static void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm) +{ +struct adapter *Adapter = pDM_Odm->Adapter; + pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA = false; + pDM_Odm->DM_EDCA_Table.bIsCurRDLState = false; + Adapter->recvpriv.bIsAnyNonBEPkts = false; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -867,16 +875,6 @@ void ODM_TXPowerTrackingCheck(struct odm_dm_struct *pDM_Odm) } } -/* EDCA Turbo */ -void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm) -{ -struct adapter *Adapter = pDM_Odm->Adapter; - pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA = false; - pDM_Odm->DM_EDCA_Table.bIsCurRDLState = false; - Adapter->recvpriv.bIsAnyNonBEPkts = false; - -}/* ODM_InitEdcaTurbo */ -void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm) {struct adapter *Adapter = pDM_Odm->Adapter;
drivers/staging/r8188eu/include/odm_precomp.h +0 -1
@@ -31,7 +31,6 @@#include "odm_RegConfig8188E.h" #include "odm_RTL8188E.h" -void ODM_EdcaTurboInit (struct odm_dm_struct *pDM_Odm);void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm);#endif /* __ODM_PRECOMP_H__ */
Signature · 1 line
2.34.1
PATCH 30/32 staging: r8188eu: make odm_EdcaTurboCheck() static
In reply to Michael StraubeFunction odm_EdcaTurboCheck() is only used in odm.c. Make it static.
--- drivers/staging/r8188eu/hal/odm.c | 154 +++++++++--------- drivers/staging/r8188eu/include/odm_precomp.h | 2 - 2 files changed, 77 insertions(+), 79 deletions(-)
drivers/staging/r8188eu/hal/odm.c +77 -77
@@ -560,6 +560,83 @@ static void ODM_EdcaTurboInit(struct odm_dm_struct *pDM_Odm) Adapter->recvpriv.bIsAnyNonBEPkts = false; } +static void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm) +{ +struct adapter *Adapter = pDM_Odm->Adapter; +u32 trafficIndex; +u32 edca_param; +u64 cur_tx_bytes =0 ; +u64 cur_rx_bytes =0 ; +u8 bbtchange = false; +struct hal_data_8188e *pHalData = &Adapter->haldata; +struct xmit_priv *pxmitpriv = &Adapter->xmitpriv; +struct recv_priv *precvpriv = &Adapter->recvpriv; +struct registry_priv *pregpriv = &Adapter->registrypriv; +struct mlme_ext_priv *pmlmeext = &Adapter->mlmeextpriv; +struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; + +if (!(pDM_Odm->SupportAbility &ODM_MAC_EDCA_TURBO )) +return ; + +if (pregpriv->wifi_spec ==1 ) + goto dm_CheckEdcaTurbo_EXIT; + +if (pmlmeinfo->assoc_AP_vendor >=HT_IOT_PEER_MAX ) + goto dm_CheckEdcaTurbo_EXIT; + +/* Check if the status needs to be changed. */ +if ((bbtchange) || (!precvpriv->bIsAnyNonBEPkts)) { + cur_tx_bytes = pxmitpriv->tx_bytes - pxmitpriv->last_tx_bytes; + cur_rx_bytes = precvpriv->rx_bytes - precvpriv->last_rx_bytes; + +/* traffic, TX or RX */ +if ((pmlmeinfo->assoc_AP_vendor ==HT_IOT_PEER_RALINK ) || + (pmlmeinfo->assoc_AP_vendor ==HT_IOT_PEER_ATHEROS )) { +if (cur_tx_bytes > (cur_rx_bytes <<2 )) { +/* Uplink TP is present. */ + trafficIndex =UP_LINK ; + }else { +/* Balance TP is present. */ + trafficIndex =DOWN_LINK ; + } + }else { +if (cur_rx_bytes > (cur_tx_bytes <<2 )) { +/* Downlink TP is present. */ + trafficIndex =DOWN_LINK ; + }else { +/* Balance TP is present. */ + trafficIndex =UP_LINK ; + } + } + +if ((pDM_Odm->DM_EDCA_Table.prv_traffic_idx != trafficIndex) || (!pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA)) { +if ((pmlmeinfo->assoc_AP_vendor ==HT_IOT_PEER_CISCO ) && (pmlmeext->cur_wireless_mode &WIRELESS_11_24N )) + edca_param = EDCAParam[pmlmeinfo->assoc_AP_vendor][trafficIndex]; +else + edca_param = EDCAParam[HT_IOT_PEER_UNKNOWN ][trafficIndex]; + +rtw_write32 (Adapter,REG_EDCA_BE_PARAM , edca_param); + + pDM_Odm->DM_EDCA_Table.prv_traffic_idx = trafficIndex; + } + + pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA = true; + }else { +/* Turn Off EDCA turbo here. */ +/* Restore original EDCA according to the declaration of AP. */ +if (pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA) { +rtw_write32 (Adapter,REG_EDCA_BE_PARAM , pHalData->AcParam_BE); + pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA = false; + } + } + +dm_CheckEdcaTurbo_EXIT: +/* Set variables for next time. */ + precvpriv->bIsAnyNonBEPkts = false; + pxmitpriv->last_tx_bytes = pxmitpriv->tx_bytes; + precvpriv->last_rx_bytes = precvpriv->rx_bytes; +} +/* 3 Export Interface */ /* 2011/09/21 MH Add to describe different team necessary resource allocate?? */
@@ -874,80 +951,3 @@ void ODM_TXPowerTrackingCheck(struct odm_dm_struct *pDM_Odm) pDM_Odm->RFCalibrateInfo.TM_Trigger =0 ; } } - -void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm) -{ -struct adapter *Adapter = pDM_Odm->Adapter; -u32 trafficIndex; -u32 edca_param; -u64 cur_tx_bytes =0 ; -u64 cur_rx_bytes =0 ; -u8 bbtchange = false; -struct hal_data_8188e *pHalData = &Adapter->haldata; -struct xmit_priv *pxmitpriv = &Adapter->xmitpriv; -struct recv_priv *precvpriv = &Adapter->recvpriv; -struct registry_priv *pregpriv = &Adapter->registrypriv; -struct mlme_ext_priv *pmlmeext = &Adapter->mlmeextpriv; -struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; - -if (!(pDM_Odm->SupportAbility &ODM_MAC_EDCA_TURBO )) -return ; - -if (pregpriv->wifi_spec ==1 ) - goto dm_CheckEdcaTurbo_EXIT; - -if (pmlmeinfo->assoc_AP_vendor >=HT_IOT_PEER_MAX ) - goto dm_CheckEdcaTurbo_EXIT; - -/* Check if the status needs to be changed. */ -if ((bbtchange) || (!precvpriv->bIsAnyNonBEPkts)) { - cur_tx_bytes = pxmitpriv->tx_bytes - pxmitpriv->last_tx_bytes; - cur_rx_bytes = precvpriv->rx_bytes - precvpriv->last_rx_bytes; - -/* traffic, TX or RX */ -if ((pmlmeinfo->assoc_AP_vendor ==HT_IOT_PEER_RALINK ) || - (pmlmeinfo->assoc_AP_vendor ==HT_IOT_PEER_ATHEROS )) { -if (cur_tx_bytes > (cur_rx_bytes <<2 )) { -/* Uplink TP is present. */ - trafficIndex =UP_LINK ; - }else { -/* Balance TP is present. */ - trafficIndex =DOWN_LINK ; - } - }else { -if (cur_rx_bytes > (cur_tx_bytes <<2 )) { -/* Downlink TP is present. */ - trafficIndex =DOWN_LINK ; - }else { -/* Balance TP is present. */ - trafficIndex =UP_LINK ; - } - } - -if ((pDM_Odm->DM_EDCA_Table.prv_traffic_idx != trafficIndex) || (!pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA)) { -if ((pmlmeinfo->assoc_AP_vendor ==HT_IOT_PEER_CISCO ) && (pmlmeext->cur_wireless_mode &WIRELESS_11_24N )) - edca_param = EDCAParam[pmlmeinfo->assoc_AP_vendor][trafficIndex]; -else - edca_param = EDCAParam[HT_IOT_PEER_UNKNOWN ][trafficIndex]; - -rtw_write32 (Adapter,REG_EDCA_BE_PARAM , edca_param); - - pDM_Odm->DM_EDCA_Table.prv_traffic_idx = trafficIndex; - } - - pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA = true; - }else { -/* Turn Off EDCA turbo here. */ -/* Restore original EDCA according to the declaration of AP. */ -if (pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA) { -rtw_write32 (Adapter,REG_EDCA_BE_PARAM , pHalData->AcParam_BE); - pDM_Odm->DM_EDCA_Table.bCurrentTurboEDCA = false; - } - } - -dm_CheckEdcaTurbo_EXIT: -/* Set variables for next time. */ - precvpriv->bIsAnyNonBEPkts = false; - pxmitpriv->last_tx_bytes = pxmitpriv->tx_bytes; - precvpriv->last_rx_bytes = precvpriv->rx_bytes; -}
drivers/staging/r8188eu/include/odm_precomp.h +0 -2
@@ -31,6 +31,4 @@#include "odm_RegConfig8188E.h" #include "odm_RTL8188E.h" -void odm_EdcaTurboCheck (struct odm_dm_struct *pDM_Odm); -#endif /* __ODM_PRECOMP_H__ */
Signature · 1 line
2.34.1
PATCH 31/32 staging: r8188eu: remove unnecessary comments
In reply to Michael StraubeRemove some unnecessary comments in odm.c.
--- drivers/staging/r8188eu/hal/odm.c | 13 ------------- 1 file changed, 13 deletions(-)
drivers/staging/r8188eu/hal/odm.c +0 -13
@@ -1,8 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -/* include files */ -#include "../include/odm_precomp.h" /* avoid to warn in FreeBSD ==> To DO modify */
@@ -637,8 +635,6 @@ static void odm_EdcaTurboCheck(struct odm_dm_struct *pDM_Odm) precvpriv->last_rx_bytes = precvpriv->rx_bytes; } -/* 3 Export Interface */ -/* 2011/09/21 MH Add to describe different team necessary resource allocate?? */ void ODM_DMInit (struct odm_dm_struct *pDM_Odm) {
@@ -696,7 +692,6 @@ void ODM_CmnInfoInit(struct odm_dm_struct *pDM_Odm, enum odm_common_info_def Cmncase ODM_CMNINFO_RF_ANTENNA_TYPE : pDM_Odm->AntDivType = (u8 )Value;break ; -/* To remove the compiler warning, must add an empty default statement to handle the other values. */ default :/* do nothing */ break ;
@@ -734,7 +729,6 @@ void ODM_CmnInfoHook(struct odm_dm_struct *pDM_Odm, enum odm_common_info_def Cmncase ODM_CMNINFO_POWER_SAVING : pDM_Odm->pbPowerSaving = (bool *)pValue;break ; -/* To remove the compiler warning, must add an empty default statement to handle the other values. */ default :/* do nothing */ break ;
@@ -836,13 +830,6 @@ void ODM_RF_Saving(struct odm_dm_struct *pDM_Odm, u8 bForceInNormal) } } -/* 3============================================================ */ -/* 3 RATR MASK */ -/* 3============================================================ */ -/* 3============================================================ */ -/* 3 Rate Adaptive */ -/* 3============================================================ */ -u32 ODM_Get_Rate_Bitmap (struct odm_dm_struct *pDM_Odm,u32 macid,u32 ra_mask,u8 rssi_level) {struct sta_info *pEntry;
Signature · 1 line
2.34.1
PATCH 32/32 staging: r8188eu: remove header odm_precomp.h
In reply to Michael StraubeAfter previous cleanups the header odm_precomp.h only contains includes and one unused define now. Remove the header and adjust the includes in affected files.
--- .../r8188eu/hal/Hal8188ERateAdaptive.c | 17 ++-------- .../staging/r8188eu/hal/HalHWImg8188E_BB.c | 1 - .../staging/r8188eu/hal/HalHWImg8188E_MAC.c | 1 - .../staging/r8188eu/hal/HalHWImg8188E_RF.c | 1 - drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +- drivers/staging/r8188eu/hal/odm.c | 2 +- drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 +- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +- .../staging/r8188eu/hal/odm_RegConfig8188E.c | 2 +- drivers/staging/r8188eu/hal/odm_debug.c | 2 +- drivers/staging/r8188eu/include/odm_precomp.h | 34 ------------------- .../staging/r8188eu/include/rtl8188e_hal.h | 11 +++++- 12 files changed, 18 insertions(+), 59 deletions(-) delete mode 100644 drivers/staging/r8188eu/include/odm_precomp.h
drivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c +2 -15
@@ -1,20 +1,7 @@// SPDX-License-Identifier: GPL-2.0 -/* Copyright (c) Realtek Semiconductor Corp. -Module Name: -RateAdaptive.c +/* Copyright (c) Realtek Semiconductor Corp. */ -Abstract: -Implement Rate Adaptive functions for common operations. - -Major Change History: -When Who What ----------- --------------- ------------------------------- -2011-08-12 Page Create. - ---*/ -#include "../include/odm_precomp.h" - -/* Rate adaptive parameters */ +#include "../include/drv_types.h" static u8 RETRY_PENALTY [PERENTRY ][RETRYSIZE +1 ] = { {5 ,4 ,3 ,2 ,0 ,3 },/* 92 , idx = 0 */
drivers/staging/r8188eu/hal/HalHWImg8188E_BB.c +0 -1
@@ -1,7 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" #include "../include/rtw_iol.h" #define read_next_pair (array, v1, v2, i) \
drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c +0 -1
@@ -1,7 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" #include "../include/rtw_iol.h" static bool Checkcondition (const u32 condition,const u32 hex)
drivers/staging/r8188eu/hal/HalHWImg8188E_RF.c +0 -1
@@ -1,7 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" #include "../include/rtw_iol.h" static bool CheckCondition (const u32 Condition,const u32 Hex)
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c +1 -1
@@ -1,7 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" +#include "../include/drv_types.h" /*---------------------------Define Local Constant---------------------------*/ /* 2010/04/25 MH Define the max tx power tracking tx agc power. */
drivers/staging/r8188eu/hal/odm.c +1 -1
@@ -1,7 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" +#include "../include/drv_types.h" /* avoid to warn in FreeBSD ==> To DO modify */ static u32 EDCAParam[HT_IOT_PEER_MAX ][3 ] = {
drivers/staging/r8188eu/hal/odm_HWConfig.c +1 -1
@@ -1,7 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" +#include "../include/drv_types.h" #define READ_AND_CONFIG READ_AND_CONFIG_MP
drivers/staging/r8188eu/hal/odm_RTL8188E.c +1 -1
@@ -1,7 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" +#include "../include/drv_types.h" static void odm_RX_HWAntDivInit (struct odm_dm_struct *dm_odm) {
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c +1 -1
@@ -1,7 +1,7 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" +#include "../include/drv_types.h" static void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data, enum rf_radio_path RF_PATH,
drivers/staging/r8188eu/hal/odm_debug.c +1 -1
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2011 Realtek Corporation. */ -#include "../include/odm_precomp.h" +#include "../include/rtw_debug.h" u32 GlobalDebugLevel;
drivers/staging/r8188eu/include/odm_precomp.h deleted +0 -34
@@ -1,34 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ -/* Copyright(c) 2007 - 2011 Realtek Corporation. i*/ - -#ifndef __ODM_PRECOMP_H__ -#define __ODM_PRECOMP_H__ - -#include "odm_types.h" - -#define TEST_FALG___ 1 - -/* 2 Config Flags and Structs - defined by each ODM Type */ - -#include "osdep_service.h" -#include "drv_types.h" -#include "hal_intf.h" - -/* 2 OutSrc Header Files */ - -#include "odm.h" -#include "odm_HWConfig.h" -#include "odm_RegDefine11N.h" - -#include "HalPhyRf_8188e.h" /* for IQK,LCK,Power-tracking */ -#include "Hal8188ERateAdaptive.h" /* for RA,Power training */ -#include "rtl8188e_hal.h" - -#include "HalHWImg8188E_MAC.h" -#include "HalHWImg8188E_RF.h" -#include "HalHWImg8188E_BB.h" - -#include "odm_RegConfig8188E.h" -#include "odm_RTL8188E.h" - -#endif /* __ODM_PRECOMP_H__ */
drivers/staging/r8188eu/include/rtl8188e_hal.h +10 -1
@@ -14,8 +14,17 @@#include "rtl8188e_xmit.h" #include "rtl8188e_cmd.h" #include "rtw_efuse.h" -#include "odm_precomp.h" +#include "odm_types.h" #include "odm.h" +#include "odm_HWConfig.h" +#include "odm_RegDefine11N.h" +#include "HalPhyRf_8188e.h" +#include "Hal8188ERateAdaptive.h" +#include "HalHWImg8188E_MAC.h" +#include "HalHWImg8188E_RF.h" +#include "HalHWImg8188E_BB.h" +#include "odm_RegConfig8188E.h" +#include "odm_RTL8188E.h" /* RTL8188E Power Configuration CMDs for USB/SDIO interfaces */ #define Rtl8188E_NIC_PWR_ON_FLOW rtl8188E_power_on_flow
Signature · 1 line
2.34.1