Add support for Imagis touchscreens
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest2 patches 0 repliesNew
- v92 patches 1 replySuperseded
- v82 patches 0 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 2 patches | 1 reply | Superseded | |
| v6 | 2 patches | 2 replies | Superseded | |
| v5 | 2 patches | 5 replies | Superseded | |
| v4 | 2 patches | 1 reply | Superseded | |
| v3 | 2 patches | 2 replies | Superseded | |
| v2 | 2 patches | 3 replies | Superseded | |
| v1 | 0 of 2 patches | 0 replies | Superseded |
Changes in v10 from the cover letter
- check for error before sleeping
- duplicate msleep in imagis_start
- return 0 since error can only be 0 in imagis_start
- move poweroff action below imagis_power_off
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | dt-bindings: input/touchscreen: bindings for ImagisDocumentation/ Documentation/ | +76 | 0 replies | |
| 2/2 | Input: add Imagis touchscreen driverMAINTAINERS drivers/ drivers/ +1 more | +349 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski | Rob Herring | Jeff LaBundy |
|---|---|---|---|
| 1/2 | R-b | A-b | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v10 0/2] Add support for Imagis touchscreens
Add support for Imagis touchscreens, used on various mobile devices such as Samsung Galaxy J5 (2015), J3 (2015), J5 (2016).
v2: rebase on top of the correct tree
v3:
- prefix all defines as IST3038C
- use two tabs for all defines
- add missing <linux/regulator/consumer.h> header
- drop ADDR_LEN and DATA_LEN defines; use sizeof(reg_be) instead
- use __be32 type for reg_be
- add a comment about i2c read not being successful on first try
- use "ret" instead of "res" in read_reg function
- don't use the internal __cpu_to_be32 function, use cpu_to_be32 instead
- use "error" instead of "ret" in interrupt handler
- pass the slot state directly, without ternary operator
- drop the dev_err in init_input_dev function
- reorder the functions in _probe so that the chipid command is read as fast as possible
- don't use imagis_start in probe
- initialize the irq after the chip is powered
- save the return value in imagis_resume
- drop WIDTH_MAJOR since only TOUCH_MAJOR is reported
- the "chip detected" message is now dev_dbg
- reorder headers so they are in alphabetic order
- use GENMASK to generate masks for getting the X and Y coordinates and touch area
- drop *_pressure from device tree bindings since the driver doesn't support reporting pressure
- fix the typo with i2c address in device treee bindings (48 instead of 50)
- add IRQF_NO_AUTOEN flag to avoid unbalanced irq enable
v4:
- alphabetically order MAINTAINERS entry
- alphabetically order Kconfig and Makefile
- drop the error message in init_regulators
- disable regulators on probe error
- drop IRQF_TRIGGER_FALLING
- @ is not optional (device tree bindings)
- don't use items for compatible
- add maxItems property to reg, drop the comment
v5:
- compatible enum is not an item of the list, drop "-"
v6:
- add _MS suffix to the delay define, drop the comment
- change the reason for retry comment
- add imagis_power_off and imagis_power_on functions to turn regulators on and off
- use imagis_power_on/off in imagis_start and imagis_stop as well as in probe function
- use error instead of ret in calls to functions which only return 0 or -errno
- include linux/bits.h
- proper indentation in Kconfig
- drop the dev_dbg chip id message
- MODULE_DEVICE_TABLE(of, ...);
- no extra tabs in i2c_driver struct
- save the return value in imagis_suspend
v7:
- initialize ret with 0 in _suspend and _resume (kernel test robot)
- use a separate ret_be variable to avoid casting to __be32 (kernel test robot) v8:
- use poweroff action
- power_off returns void
- ret -> error
- combine dev declaration and assignment
- use same style for error everywhere
- return devm_regulator_bulk_get() directly
v9:
- don't return in power_off (forgot to commit)
v10:
- check for error before sleeping
- duplicate msleep in imagis_start
- return 0 since error can only be 0 in imagis_start
- move poweroff action below imagis_power_off
Markuss Broks (2):
dt-bindings: input/touchscreen: bindings for Imagis
Input: add Imagis touchscreen driver
.../input/touchscreen/imagis,ist3038c.yaml | 74 ++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 6 + drivers/input/touchscreen/Kconfig | 10 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/imagis.c | 348 ++++++++++++++++++ 6 files changed, 441 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml create mode 100644 drivers/input/touchscreen/imagis.c
Signature · 1 line
2.20.1