KVM: x86 SRCU bug fix and SRCU hardening
Status from this message: Queued, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | KVM: x86: Don't re-acquire SRCU lock in complete_emulated_io()arch/ | +1 | 1 reply | |
| 2/3 | KVM: RISC-V: Use kvm_vcpu.srcu_idx, drop RISC-V's unnecessary copyarch/ arch/ arch/ | +10 | 0 replies | |
| 3/3 | KVM: Add helpers to wrap vcpu->srcu_idx and yell if it's abusedarch/ arch/ arch/ +8 more | +71 | 4 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Maxim Levitsky | Fabiano Rosas |
|---|---|---|
| 1/3 | R-b | |
| 2/3 | ||
| 3/3 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] KVM: x86 SRCU bug fix and SRCU hardening
Fix an x86 bug where KVM overwrites vcpu->srcu_idx and can leak an SRCU lock due to unlocking the wrong index, ultimately causing a hang if/when KVM attempts to synchronize.
Switch RISC-V to the generic vcpu->srcu_idx, for reasons unknown it has its own copy and ignores the generic one.
Add helpers with rudimentary detection of illegal vcpu->srcu_idx usage, the x86 bug would have been incredibly painful to debug had I not known what to look for (found by a selftest with very specific behavior... that we recently modified with respect to SRCU).
Non-x86 changes are compile tested only.
Sean Christopherson (3):
KVM: x86: Don't re-acquire SRCU lock in complete_emulated_io()
KVM: RISC-V: Use kvm_vcpu.srcu_idx, drop RISC-V's unnecessary copy
KVM: Add helpers to wrap vcpu->srcu_idx and yell if it's abused
arch/powerpc/kvm/book3s_64_mmu_radix.c | 9 ++++--- arch/powerpc/kvm/book3s_hv_nested.c | 16 ++++++------ arch/powerpc/kvm/book3s_rtas.c | 4 +-- arch/powerpc/kvm/powerpc.c | 4 +-- arch/riscv/include/asm/kvm_host.h | 3 --- arch/riscv/kvm/vcpu.c | 16 ++++++------ arch/riscv/kvm/vcpu_exit.c | 4 +-- arch/s390/kvm/interrupt.c | 4 +-- arch/s390/kvm/kvm-s390.c | 8 +++--- arch/s390/kvm/vsie.c | 4 +-- arch/x86/kvm/x86.c | 35 +++++++++++--------------- include/linux/kvm_host.h | 24 +++++++++++++++++- 12 files changed, 72 insertions(+), 59 deletions(-)
base-commit: 150866cd0ec871c765181d145aa0912628289c8a
Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog