Skip to content

iommu/vt-d: Force snooping improvement

Lu Baolu linux-iommu lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 2 repliesIn review
  2. v34 patches 2 repliesSuperseded
  3. v24 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches14 repliesSuperseded

Changes in v4 from the cover letter

- Flush caches after changing PGSNP bit in the right way.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iommu/vt-d: Block force-snoop domain attaching if no SC supportdrivers/iommu/intel/iommu.c+3 -00 replies
2/4iommu/vt-d: Check domain force_snooping against attached devicesdrivers/iommu/intel/iommu.c drivers/iommu/intel/pasid.c drivers/iommu/intel/pasid.h +1 more+95 -32 replies
3/4iommu/vt-d: Remove domain_update_iommu_snooping()drivers/iommu/intel/iommu.c+1 -330 replies
4/4iommu/vt-d: Remove hard coding PGSNP bit in PASID entriesdrivers/iommu/intel/pasid.c+0 -30 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJason GunthorpeKevin Tian
1/4R-b R-b
2/4R-b
3/4R-b R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] iommu/vt-d: Force snooping improvement

Hi folks,

Previously, the IOMMU capability of enforcing cache coherency was queried through iommu_capable(IOMMU_CAP_CACHE_COHERENCY). This is a global capability, hence the IOMMU driver reports support for this capability only when all IOMMUs in the system has this support.

Commit 6043257b1de06 ("iommu: Introduce the domain op enforce_cache_coherency()") converts this into a per-domain test-and-set option, and the previous iommu_capable(IOMMU_CAP_CACHE_COHERENCY) is deprecated.

This is a follow-up series which improves the Intel IOMMU driver to support the per-domain scheme better.

Best regards,
baolu

Change log:
v4:
- Flush caches after changing PGSNP bit in the right way.

v3:
- https://lore.kernel.org/linux-iommu/[email protected]/
- Hold the device_domain_lock when check and set force snooping.
- Refind the commit messages.

v2:
- https://lore.kernel.org/linux-iommu/[email protected]/
- Check whether force_snooping has already been set in intel_iommu_enforce_cache_coherency().
- Set PGSNP pasid bit field during domain attaching if forcing_snooping
is set.
- Remove redundant list_empty() checks.
- Add dmar_domain->set_pte_snp and set it if force snooping is enforced
on a domain with 2nd-level translation.

v1:
- https://lore.kernel.org/linux-iommu/[email protected]
- Initial post.

Lu Baolu (4):
iommu/vt-d: Block force-snoop domain attaching if no SC support iommu/vt-d: Check domain force_snooping against attached devices iommu/vt-d: Remove domain_update_iommu_snooping() iommu/vt-d: Remove hard coding PGSNP bit in PASID entries

 include/linux/intel-iommu.h |  1 +
 drivers/iommu/intel/pasid.h |  2 +
 drivers/iommu/intel/iommu.c | 90 ++++++++++++++++++++++---------------
 drivers/iommu/intel/pasid.c | 45 +++++++++++++++++--
 4 files changed, 99 insertions(+), 39 deletions(-)
Signature · 1 line
2.25.1