Skip to content

hw/sd: Rework models for eMMC support

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest25 patches 12 repliesIn review
  2. v11 patch 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25hw/sd/sdcard: Return ILLEGAL for CMD19/CMD23 prior SD spec v3.01hw/sd/sd.c+2 -20 replies
2/25hw/sd: When card is in wrong state, log which state it ishw/sd/sd.c+9 -30 replies
3/25hw/sd: When card is in wrong state, log which spec version is usedhw/sd/sd.c+16 -21 reply
4/25hw/sd: Move proto_name to SDProto structurehw/sd/sd.c include/hw/sd/sd.h+29 -80 replies
5/25hw/sd: Introduce sd_cmd_handler typehw/sd/sd.c+13 -00 replies
6/25hw/sd: Add sd_cmd_illegal() handlerhw/sd/sd.c+26 -360 replies
7/25hw/sd: Add sd_cmd_unimplemented() handlerhw/sd/sd.c+12 -90 replies
8/25hw/sd: Add sd_cmd_GO_IDLE_STATE() handlerhw/sd/sd.c+12 -120 replies
9/25hw/sd: Add sd_cmd_SEND_OP_CMD() handlerhw/sd/sd.c hw/sd/sdmmc-internal.c+10 -100 replies
10/25hw/sd: Add sd_cmd_ALL_SEND_CID() handlerhw/sd/sd.c+12 -110 replies
11/25hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handlerhw/sd/sd.c+15 -130 replies
12/25hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handlerhw/sd/sd.c+17 -110 replies
13/25hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handlerhw/sd/sd.c+16 -141 reply
14/25hw/sd: Basis for eMMC supporthw/sd/sd.c include/hw/sd/sd.h+45 -03 replies
15/25hw/sd: Add sd_emmc_cmd_SEND_OP_CMD() handlerhw/sd/sd.c+7 -00 replies
16/25hw/sd: Add sd_emmc_cmd_ALL_SEND_CID() handlerhw/sd/sd.c+12 -00 replies
17/25hw/sd: Add sd_emmc_cmd_SEND_RELATIVE_ADDR() handlerhw/sd/sd.c+20 -00 replies
18/25hw/sd: Add sd_emmc_cmd_APP_CMD() handlerhw/sd/sd.c+6 -00 replies
19/25hw/sd: add sd_emmc_cmd_SEND_TUNING_BLOCK() handlerhw/sd/sd.c+12 -00 replies
20/25hw/sd: Add CMD21 tuning sequencehw/sd/sd.c+39 -00 replies
21/25hw/sd: Add mmc switch function supporthw/sd/sd.c+52 -00 replies
22/25hw/sd: Add sd_emmc_cmd_SEND_EXT_CSD() handlerhw/sd/sd.c hw/sd/sdmmc-internal.h include/hw/sd/sd.h+198 -11 reply
23/25hw/sd: Support boot area in emmc imagehw/sd/sd.c include/hw/sd/sd.h+40 -00 replies
24/25hw/sd: Subtract bootarea size from blkhw/sd/sd.c+5 -00 replies
25/25hw/sd: Add boot config supporthw/sd/sd.c+10 -00 replies

Reviews trailers per patch

11 of 25 patches have a Reviewed-by or Acked-by.

PatchBin MengPhilippe Mathieu-DaudéCédric Le Goater
1/25R-b
2/25R-b
3/25R-b
4/25R-b
5/25R-b
6/25R-b
7/25
8/25R-b
9/25
10/25R-b
11/25R-b
12/25R-b
13/25R-b
14/25
15/25
16/25
17/25
18/25
19/25
20/25
21/25
22/25
23/25
24/25
25/25

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/25] hw/sd: Rework models for eMMC support

From: Philippe Mathieu-Daudé <[email protected]>

Rebase/respin of Cédric RFC:
https://lore.kernel.org/qemu-devel/[email protected]/
(sorry it took me so long guys...)

Pushed at https://gitlab.com/philmd/qemu/-/commits/emmc-v2

I plan to queue patches 1-12 via sdmmc-next later this week.

Cédric, if you are happy with this series, it should be easy to rebase your other patches on top and address the comments I left on the RFC :)

Regards,

Phil.

Cédric Le Goater (6):
hw/sd: Add sd_emmc_cmd_SEND_OP_CMD() handler hw/sd: Add sd_emmc_cmd_ALL_SEND_CID() handler hw/sd: Add sd_emmc_cmd_SEND_RELATIVE_ADDR() handler hw/sd: Add sd_emmc_cmd_APP_CMD() handler hw/sd: add sd_emmc_cmd_SEND_TUNING_BLOCK() handler hw/sd: Add sd_emmc_cmd_SEND_EXT_CSD() handler

Joel Stanley (4):
hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handler
hw/sd: Support boot area in emmc image
hw/sd: Subtract bootarea size from blk
hw/sd: Add boot config support

Philippe Mathieu-Daudé (13):
hw/sd/sdcard: Return ILLEGAL for CMD19/CMD23 prior SD spec v3.01 hw/sd: When card is in wrong state, log which state it is hw/sd: When card is in wrong state, log which spec version is used hw/sd: Move proto_name to SDProto structure
hw/sd: Introduce sd_cmd_handler type
hw/sd: Add sd_cmd_illegal() handler
hw/sd: Add sd_cmd_unimplemented() handler
hw/sd: Add sd_cmd_GO_IDLE_STATE() handler
hw/sd: Add sd_cmd_SEND_OP_CMD() handler
hw/sd: Add sd_cmd_ALL_SEND_CID() handler
hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler
hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handler
hw/sd: Basis for eMMC support

Sai Pavan Boddu (2):
hw/sd: Add CMD21 tuning sequence
hw/sd: Add mmc switch function support

 hw/sd/sd.c             | 645 +++++++++++++++++++++++++++++++++--------
 hw/sd/sdmmc-internal.c |   2 +-
 hw/sd/sdmmc-internal.h |  97 +++++++
 include/hw/sd/sd.h     |   7 +
 4 files changed, 627 insertions(+), 124 deletions(-)
Signature · 1 line
2.36.1