Make block-backend-io.h API more consistent
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest18 patches 3 repliesIn review
- v118 patches 45 repliesSuperseded
Changes in v2 from the cover letter
- Avoid using variables named 'len' or similar to hold return values from blk_{pread,pwrite}(), as they don't return a length anymore.
- Drop variables in_ret and out_ret in qemu-img.c:img_dd().
- Initialize buf in test_sync_op_blk_pwritev_part().
- Keep blk_co_copy_range() in the "I/O API functions" section of include/sysemu/block-backend-io.h.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | block: Make blk_{pread, pwrite}() return 0 on successblock.c block/ block/ +9 more | +49 | 1 reply | |
| 2/18 | block: Add a 'flags' param to blk_pread()block.c block/ block/ +24 more | +52 | 0 replies | |
| 3/18 | block: Change blk_{pread,pwrite}() param orderblock.c block/ block/ +35 more | +150 | 0 replies | |
| 4/18 | block: Make 'bytes' param of blk_{pread, pwrite}() an int64_tblock/ include/ | +6 | 0 replies | |
| 5/18 | block: Make blk_co_pwrite() take a const bufferinclude/ | +1 | 0 replies | |
| 6/18 | block: Implement blk_{pread, pwrite}() using generated_co_wrapperblock/ block/ block/ +1 more | +7 | 0 replies | |
| 7/18 | block: Add blk_{preadv,pwritev}()include/ tests/ | +47 | 0 replies | |
| 8/18 | block: Add blk_[co_]preadv_part()block/ block/ include/ +1 more | +49 | 0 replies | |
| 9/18 | block: Export blk_pwritev_part() in block-backend-io.hblock/ block/ include/ +1 more | +23 | 0 replies | |
| 10/18 | block: Change blk_pwrite_compressed() param orderblock/ include/ qemu-img.c +1 more | +6 | 0 replies | |
| 11/18 | block: Add blk_co_pwrite_compressed()block/ include/ tests/ | +27 | 0 replies | |
| 12/18 | block: Implement blk_pwrite_zeroes() using generated_co_wrapperblock/ include/ tests/ | +20 | 0 replies | |
| 13/18 | block: Implement blk_pdiscard() using generated_co_wrapperblock/ block/ include/ | +2 | 0 replies | |
| 14/18 | block: Implement blk_flush() using generated_co_wrapperblock/ block/ include/ | +1 | 0 replies | |
| 15/18 | block: Add blk_co_ioctl()block/ block/ include/ | +8 | 0 replies | |
| 16/18 | block: Add blk_co_truncate()block/ include/ tests/ | +24 | 0 replies | |
| 17/18 | block: Reorganize some declarations in block-backend-io.hblock/ include/ | +54 | 1 reply | |
| 18/18 | block: Remove remaining unused symbols in coroutines.hblock/ block/ | +3 | 0 replies |
Reviews trailers per patch
All 18 patches have a Reviewed-by or Acked-by.
| Patch | Paolo Bonzini | Greg Kurz | Hanna Reitz | Eric Blake |
|---|---|---|---|---|
| 1/18 | R-b | |||
| 2/18 | R-b | R-b | R-b | |
| 3/18 | R-b | R-b | ||
| 4/18 | R-b | R-b | ||
| 5/18 | R-b | R-b | ||
| 6/18 | R-b | |||
| 7/18 | R-b | R-b | ||
| 8/18 | R-b | R-b | ||
| 9/18 | R-b | R-b | ||
| 10/18 | R-b | R-b | ||
| 11/18 | R-b | R-b | ||
| 12/18 | R-b | R-b | ||
| 13/18 | R-b | R-b | ||
| 14/18 | R-b | R-b | ||
| 15/18 | R-b | R-b | ||
| 16/18 | R-b | R-b | ||
| 17/18 | R-b | R-b | ||
| 18/18 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 00/18] Make block-backend-io.h API more consistent
Adjust existing pairs of non-coroutine and coroutine functions to share the same calling convention, and add non-coroutine/coroutine counterparts where they don't exist.
Also make the non-coroutine versions generated_co_wrappers.
This series sits on top of "[PATCH v5 00/10] Implement bdrv_{pread,pwrite,pwrite_sync,pwrite_zeroes}() using generated_co_wrapper":
https://lore.kernel.org/qemu-devel/[email protected]/
Based-on: <[email protected]>
v2:
- Avoid using variables named 'len' or similar to hold return values from blk_{pread,pwrite}(), as they don't return a length anymore.
- Drop variables in_ret and out_ret in qemu-img.c:img_dd().
- Initialize buf in test_sync_op_blk_pwritev_part().
- Keep blk_co_copy_range() in the "I/O API functions" section of include/sysemu/block-backend-io.h.
Alberto Faria (18):
block: Make blk_{pread,pwrite}() return 0 on success
block: Add a 'flags' param to blk_pread()
block: Change blk_{pread,pwrite}() param order
block: Make 'bytes' param of blk_{pread,pwrite}() an int64_t
block: Make blk_co_pwrite() take a const buffer
block: Implement blk_{pread,pwrite}() using generated_co_wrapper
block: Add blk_{preadv,pwritev}()
block: Add blk_[co_]preadv_part()
block: Export blk_pwritev_part() in block-backend-io.h
block: Change blk_pwrite_compressed() param order
block: Add blk_co_pwrite_compressed()
block: Implement blk_pwrite_zeroes() using generated_co_wrapper
block: Implement blk_pdiscard() using generated_co_wrapper
block: Implement blk_flush() using generated_co_wrapper
block: Add blk_co_ioctl()
block: Add blk_co_truncate()
block: Reorganize some declarations in block-backend-io.h
block: Remove remaining unused symbols in coroutines.h
block.c | 10 +- block/block-backend.c | 150 ++++++++++++------------------ block/commit.c | 4 +- block/coroutines.h | 44 --------- block/crypto.c | 2 +- block/export/fuse.c | 4 +- block/meson.build | 1 + block/parallels.c | 2 +- block/qcow.c | 14 +-- block/qcow2.c | 4 +- block/qed.c | 8 +- block/vdi.c | 4 +- block/vhdx.c | 20 ++-- block/vmdk.c | 10 +- block/vpc.c | 12 +-- hw/arm/allwinner-h3.c | 2 +- hw/arm/aspeed.c | 2 +- hw/block/block.c | 2 +- hw/block/fdc.c | 20 ++-- hw/block/hd-geometry.c | 2 +- hw/block/m25p80.c | 2 +- hw/block/nand.c | 47 +++++----- hw/block/onenand.c | 32 +++---- hw/block/pflash_cfi01.c | 4 +- hw/block/pflash_cfi02.c | 4 +- hw/ide/atapi.c | 4 +- hw/misc/mac_via.c | 6 +- hw/misc/sifive_u_otp.c | 14 +-- hw/nvram/eeprom_at24c.c | 8 +- hw/nvram/spapr_nvram.c | 16 ++-- hw/nvram/xlnx-bbram.c | 4 +- hw/nvram/xlnx-efuse.c | 4 +- hw/ppc/pnv_pnor.c | 6 +- hw/sd/sd.c | 4 +- include/sysemu/block-backend-io.h | 97 +++++++++++-------- migration/block.c | 8 +- nbd/server.c | 8 +- qemu-img.c | 41 ++++---- qemu-io-cmds.c | 20 ++-- tests/unit/test-block-iothread.c | 141 ++++++++++++++++++++++++++-- 40 files changed, 431 insertions(+), 356 deletions(-)
Signature · 1 line
2.36.1