Skip to content

Make block-backend-io.h API more consistent

Alberto Faria qemu-arm qemu-devel qemu-riscv 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 3 repliesIn review
  2. v118 patches 45 repliesSuperseded

Changes in v2 from the cover letter

- Avoid using variables named 'len' or similar to hold return values from blk_{pread,pwrite}(), as they don't return a length anymore.
- Drop variables in_ret and out_ret in qemu-img.c:img_dd().
- Initialize buf in test_sync_op_blk_pwritev_part().
- Keep blk_co_copy_range() in the "I/O API functions" section of include/sysemu/block-backend-io.h.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18block: Make blk_{pread, pwrite}() return 0 on successblock.c block/block-backend.c block/qcow.c +9 more+49 -511 reply
2/18block: Add a 'flags' param to blk_pread()block.c block/block-backend.c block/commit.c +24 more+52 -500 replies
3/18block: Change blk_{pread,pwrite}() param orderblock.c block/block-backend.c block/commit.c +35 more+150 -1490 replies
4/18block: Make 'bytes' param of blk_{pread, pwrite}() an int64_tblock/block-backend.c include/sysemu/block-backend-io.h+6 -60 replies
5/18block: Make blk_co_pwrite() take a const bufferinclude/sysemu/block-backend-io.h+1 -10 replies
6/18block: Implement blk_{pread, pwrite}() using generated_co_wrapperblock/block-backend.c block/coroutines.h block/meson.build +1 more+7 -310 replies
7/18block: Add blk_{preadv,pwritev}()include/sysemu/block-backend-io.h tests/unit/test-block-iothread.c+47 -10 replies
8/18block: Add blk_[co_]preadv_part()block/block-backend.c block/coroutines.h include/sysemu/block-backend-io.h +1 more+49 -120 replies
9/18block: Export blk_pwritev_part() in block-backend-io.hblock/block-backend.c block/coroutines.h include/sysemu/block-backend-io.h +1 more+23 -190 replies
10/18block: Change blk_pwrite_compressed() param orderblock/block-backend.c include/sysemu/block-backend-io.h qemu-img.c +1 more+6 -60 replies
11/18block: Add blk_co_pwrite_compressed()block/block-backend.c include/sysemu/block-backend-io.h tests/unit/test-block-iothread.c+27 -60 replies
12/18block: Implement blk_pwrite_zeroes() using generated_co_wrapperblock/block-backend.c include/sysemu/block-backend-io.h tests/unit/test-block-iothread.c+20 -100 replies
13/18block: Implement blk_pdiscard() using generated_co_wrapperblock/block-backend.c block/coroutines.h include/sysemu/block-backend-io.h+2 -160 replies
14/18block: Implement blk_flush() using generated_co_wrapperblock/block-backend.c block/coroutines.h include/sysemu/block-backend-io.h+1 -140 replies
15/18block: Add blk_co_ioctl()block/block-backend.c block/coroutines.h include/sysemu/block-backend-io.h+8 -100 replies
16/18block: Add blk_co_truncate()block/block-backend.c include/sysemu/block-backend-io.h tests/unit/test-block-iothread.c+24 -50 replies
17/18block: Reorganize some declarations in block-backend-io.hblock/block-backend.c include/sysemu/block-backend-io.h+54 -451 reply
18/18block: Remove remaining unused symbols in coroutines.hblock/block-backend.c block/coroutines.h+3 -220 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchPaolo BonziniGreg KurzHanna ReitzEric Blake
1/18R-b
2/18R-b R-b R-b
3/18R-b R-b
4/18R-b R-b
5/18R-b R-b
6/18R-b
7/18R-b R-b
8/18R-b R-b
9/18R-b R-b
10/18R-b R-b
11/18R-b R-b
12/18R-b R-b
13/18R-b R-b
14/18R-b R-b
15/18R-b R-b
16/18R-b R-b
17/18R-b R-b
18/18R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/18] Make block-backend-io.h API more consistent

Adjust existing pairs of non-coroutine and coroutine functions to share the same calling convention, and add non-coroutine/coroutine counterparts where they don't exist.

Also make the non-coroutine versions generated_co_wrappers.

This series sits on top of "[PATCH v5 00/10] Implement bdrv_{pread,pwrite,pwrite_sync,pwrite_zeroes}() using generated_co_wrapper":

    https://lore.kernel.org/qemu-devel/[email protected]/

Based-on: <[email protected]>

v2:
- Avoid using variables named 'len' or similar to hold return values from blk_{pread,pwrite}(), as they don't return a length anymore.
- Drop variables in_ret and out_ret in qemu-img.c:img_dd().
- Initialize buf in test_sync_op_blk_pwritev_part().
- Keep blk_co_copy_range() in the "I/O API functions" section of include/sysemu/block-backend-io.h.

Alberto Faria (18):
block: Make blk_{pread,pwrite}() return 0 on success
block: Add a 'flags' param to blk_pread()
block: Change blk_{pread,pwrite}() param order
block: Make 'bytes' param of blk_{pread,pwrite}() an int64_t
block: Make blk_co_pwrite() take a const buffer
block: Implement blk_{pread,pwrite}() using generated_co_wrapper
block: Add blk_{preadv,pwritev}()
block: Add blk_[co_]preadv_part()
block: Export blk_pwritev_part() in block-backend-io.h
block: Change blk_pwrite_compressed() param order
block: Add blk_co_pwrite_compressed()
block: Implement blk_pwrite_zeroes() using generated_co_wrapper
block: Implement blk_pdiscard() using generated_co_wrapper
block: Implement blk_flush() using generated_co_wrapper
block: Add blk_co_ioctl()
block: Add blk_co_truncate()
block: Reorganize some declarations in block-backend-io.h
block: Remove remaining unused symbols in coroutines.h

 block.c                           |  10 +-
 block/block-backend.c             | 150 ++++++++++++------------------
 block/commit.c                    |   4 +-
 block/coroutines.h                |  44 ---------
 block/crypto.c                    |   2 +-
 block/export/fuse.c               |   4 +-
 block/meson.build                 |   1 +
 block/parallels.c                 |   2 +-
 block/qcow.c                      |  14 +--
 block/qcow2.c                     |   4 +-
 block/qed.c                       |   8 +-
 block/vdi.c                       |   4 +-
 block/vhdx.c                      |  20 ++--
 block/vmdk.c                      |  10 +-
 block/vpc.c                       |  12 +--
 hw/arm/allwinner-h3.c             |   2 +-
 hw/arm/aspeed.c                   |   2 +-
 hw/block/block.c                  |   2 +-
 hw/block/fdc.c                    |  20 ++--
 hw/block/hd-geometry.c            |   2 +-
 hw/block/m25p80.c                 |   2 +-
 hw/block/nand.c                   |  47 +++++-----
 hw/block/onenand.c                |  32 +++----
 hw/block/pflash_cfi01.c           |   4 +-
 hw/block/pflash_cfi02.c           |   4 +-
 hw/ide/atapi.c                    |   4 +-
 hw/misc/mac_via.c                 |   6 +-
 hw/misc/sifive_u_otp.c            |  14 +--
 hw/nvram/eeprom_at24c.c           |   8 +-
 hw/nvram/spapr_nvram.c            |  16 ++--
 hw/nvram/xlnx-bbram.c             |   4 +-
 hw/nvram/xlnx-efuse.c             |   4 +-
 hw/ppc/pnv_pnor.c                 |   6 +-
 hw/sd/sd.c                        |   4 +-
 include/sysemu/block-backend-io.h |  97 +++++++++++--------
 migration/block.c                 |   8 +-
 nbd/server.c                      |   8 +-
 qemu-img.c                        |  41 ++++----
 qemu-io-cmds.c                    |  20 ++--
 tests/unit/test-block-iothread.c  | 141 ++++++++++++++++++++++++++--
 40 files changed, 431 insertions(+), 356 deletions(-)
Signature · 1 line
2.36.1