Skip to content

pseries-wdt: initial support for H_WATCHDOG-based watchdog timers

Scott Cheloha linux-watchdog linuxppc-dev 3 versions – Applied

Status from this message: Applied to powerpc/next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesApplied
  2. v24 patches 19 repliesSuperseded
  3. v14 patches 7 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return codearch/powerpc/include/asm/hvcall.h+3 -10 replies
2/4powerpc/pseries: add FW_FEATURE_WATCHDOG flagarch/powerpc/include/asm/firmware.h arch/powerpc/platforms/pseries/firmware.c+3 -10 replies
3/4powerpc/pseries: register pseries-wdt device with platform busarch/powerpc/platforms/pseries/setup.c+13 -00 replies
4/4watchdog/pseries-wdt: initial support for H_WATCHDOG-based watchdog timersDocumentation/watchdog/watchdog-parameters.rst drivers/watchdog/Kconfig drivers/watchdog/Makefile +1 more+260 -04 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchGuenter Roeck
1/4
2/4
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] pseries-wdt: initial support for H_WATCHDOG-based watchdog timers

PAPR v2.12 defines a new hypercall, H_WATCHDOG. This patch series adds support for this hypercall to powerpc/pseries kernels and introduces a new watchdog driver, "pseries-wdt", for the virtual timers exposed by the hypercall.

This series is preceded by the following:

RFC v1: https://lore.kernel.org/linux-watchdog/[email protected]/
RFC v2: https://lore.kernel.org/linux-watchdog/[email protected]/
PATCH v1: https://lore.kernel.org/linux-watchdog/[email protected]/
PATCH v2: https://lore.kernel.org/linux-watchdog/[email protected]/

Changes of note from PATCH v2:

- Don't keep a pointer to the platform device at registration time. We don't use the pointer for anything and we cannot hotplug the "device".

- Drop the GETFIELD() and SETFIELD() macros: Michael Ellerman really doesn't like them. Use plain integer constants and custom bitfield extraction macros for the capability output instead.

(After making the change I can see the upside to plain constants.)

- Actually use PSERIES_WDTQ_MAX_NUMBER(): check that the hypervisor gave us at least one timer to work with.

- Use MSEC_PER_SEC in a few places instead of the literal 1000 to show the reader what we're doing.

- Use "reverse xmas tree" sorting for automatic variable declarations.

- Note where the max_timeout of (UINT_MAX / 1000) comes from.

- Nix email addresses from the MODULE_AUTHOR() macros, they tend to rot.