Skip to content

Introduce Nuvoton Arbel NPCM8XX BMC SoC

Tomer Maimon linux-clk linux-devicetree lkml openbmc 32 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v28 Latest3 patches 7 repliesApplied
  2. v27 posting 2/23 patches 6 repliesSuperseded
  3. v27 posting 1/23 patches 0 repliesSuperseded
Earlier versions · 29
VersionPostedPatchesRepliesStatus
v263 patches4 repliesSuperseded
v253 patches4 repliesSuperseded
v244 patches6 repliesSuperseded
v233 patches11 repliesSuperseded
v228 patches25 repliesSuperseded
v21 posting 2/21 patch4 repliesSuperseded
v21 posting 1/21 patch0 repliesSuperseded
v201 patch2 repliesSuperseded
v19 posting 2/21 patch1 replySuperseded
v19 posting 1/21 patch1 replySuperseded
v181 patch0 repliesSuperseded
v171 patch0 repliesSuperseded
v16 posting 2/21 patch2 repliesSuperseded
v16 posting 1/21 patch5 repliesSuperseded
v151 patch4 repliesSuperseded
v141 patch4 repliesSuperseded
v131 patch2 repliesSuperseded
v121 patch1 replySuperseded
v111 patch2 repliesSuperseded
v101 patch0 repliesSuperseded
v916 patches0 repliesSuperseded
v816 patches16 repliesSuperseded
v716 patches5 repliesSuperseded
v617 patches3 repliesSuperseded
v518 patches2 repliesSuperseded
v418 patches6 repliesSuperseded
v318 patches12 repliesSuperseded
v220 patches43 repliesSuperseded
v119 patches45 repliesSuperseded

Patches in v28 Applied

#Subject and filesSizeRepliesApplied
1/3dt-bindings: reset: npcm: add clock propertiesDocumentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml+18 -01 reply
2/3reset: npcm: register npcm8xx clock auxiliary bus devicedrivers/reset/Kconfig drivers/reset/reset-npcm.c include/soc/nuvoton/clock-npcm8xx.h+95 -25 replies
3/3clk: npcm8xx: add clock controllerdrivers/clk/Kconfig drivers/clk/Makefile drivers/clk/clk-npcm8xx.c+439 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBenjamin FairStephen BoydRob HerringPhilipp Zabel
1/3R-b
2/3T-b R-b
3/3T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v28 thread

Cover letter [PATCH v28 0/3] Introduce Nuvoton Arbel NPCM8XX BMC SoC

This patchset adds clock support for the Nuvoton Arbel NPCM8XX Board Management controller (BMC) SoC family.

The NPCM8xx clock controller is created using the auxiliary device framework and set up in the npcm reset driver since the NPCM8xx clock is using the same register region.

This patchset cover letter is based from the initial support for NPCM8xx BMC to keep tracking the version history.

This patchset was tested on the Arbel NPCM8XX evaluation board.

All patches have been reviewed by the maintainers, the clock driver can be applied :-)

Addressed comments from:
Philipp Zabel: https://www.spinics.net/lists/linux-clk/msg103946.html

Changes since version 27:
- Use inline function in container_of.
- fix missing return in the probe function.

No Changes in version 26:

Changes since version 25:
- Add select AUXILIARY_BUS to npcm_reset kconfig.
- Include <linux/auxiliary_bus.h> and <linux/slab.h> in reset and clock driver.

Changes since version 24:
- Keep clock npcm8xx dt-binding to avoid ABI break.
- Fix kfree parameter.
- Correct reference.
- Modify commit message.

Changes since version 23:
- NPCM8xx clock controller using the auxiliary device framework.
- Add NPCM8xx clock controller aux device registration support in npcm reset driver.
- Remove unused nuvoton,npcm845 clk bindings.
- Remove all string #define

Changes since version 22:
- Modify commit message to explain broken ABI in dt-binding
- Using regmap parenet regmap memory therefore remove use of npcm8xx rst-clock patch.
- Leave npcm7xx rst node as is

Changes since version 21:
- Since using regmap instead of ioremap replace reg to syscon property in dt-bindings and dts.
- Add reference clock property to the dt-bindings and dts.
- Using .index instead of .name in clk_parent_data structures.
- Using string where any macros are used once.

Changes since version 20:
- Using regmap instead of ioremap.
the clock and reset modules are sharing the same memory region and cause failure when using devm_platform_ioremap_resource function, this version uses regmap to handle shared reset and clock memory region, in case it is approved I will modify the reset driver to use the regmap as well.
- Using clk_hw instead of clk_parent_data structre.
- Divider clock definition to one line

Changes since version 19:
- Remove unnecessary free command.
- Defining pr_fmt().
- Using dev_err_probe.
- Return zero in the end of the probe function.

Changes since version 18:
- NPCM8XX clock driver did not changed from version 18 only build and tested under kernel 6.6-rc1.

Changes since version 17:
- NPCM8XX clock driver did not changed from version 17 only build and tested under kernel 6.5-rc3.

Changes since version 16:
- NPCM8XX clock driver
- Using devm_kzalloc instead kzalloc.
- Remove unnecessary parenthesis.
- Modify incorrect spelling.

Changes since version 15:
- NPCM8XX clock driver
- Remove unused regs parameter from npcm8xx_pll_data structure.
- Using index and clk_hw parameters to set the clock parent in the clock structures.

Changes since version 14:
- NPCM8XX clock driver
- Remove unnecessary register definitions.
- Remove the internal reference clock, instead use the external DT reference clock.
- rearrange the driver.
- using .names parameter in DT to define clock (refclk).

Changes since version 13:
- NPCM8XX clock driver
- Remove unnecessary definitions and add module.h define
- Use in clk_parent_data struct.fw_name and .name.
- Add module_exit function.
- Add const to divider clock names.
- Add MODULE_DESCRIPTION and MODULE_LICENSE

Changes since version 12:
- NPCM8XX clock driver
- Use clk_parent_data in mux and div clock structure.
- Add const to mux tables.
- Using devm_clk_hw_register_fixed_rate function.
- use only .name clk_parent_data instead .name and .fw_name.
- Modify mask values in mux clocks.

Changes since version 11:
- NPCM8XX clock driver
- Modify Kconfig help.
- Modify loop variable to unsigned int.

Changes since version 11:
- NPCM8XX clock driver
- Modify Kconfig help.
- Modify loop variable to unsigned int.

Changes since version 10:
- NPCM8XX clock driver
- Fix const warning.

Changes since version 9:
- NPCM8XX clock driver
- Move configuration place.
- Using clk_parent_data instead of parent_name
- using devm_ioremap instead of ioremap. deeply sorry, I know we had a long discussion on what should the driver use, from other examples (also in other clock drivers) I see the combination of platform_get_resource and devm_ioremap are commonly used and it answer the reset and clock needs.

Changes since version 8:
- NPCM8XX clock driver
- Move configuration place.
- Add space before and aftre '{' '}'.
- Handle devm_of_clk_add_hw_provider function error.

Changes since version 7:
- NPCM8XX clock driver
- The clock and reset registers using the same memory region, due to it the clock driver should claim the ioremap directly without checking the memory region.

Changes since version 5:
- NPCM8XX clock driver
- Remove refclk if devm_of_clk_add_hw_provider function failed.

Changes since version 4:
- NPCM8XX clock driver
- Use the same quote in the dt-binding file.

Changes since version 3:
- NPCM8XX clock driver
- Rename NPCM8xx clock dt-binding header file.
- Remove unused structures.
- Improve Handling the clocks registration.

Changes since version 2:
- NPCM8XX clock driver
- Add debug new line.
- Add 25M fixed rate clock.
- Remove unused clocks and clock name from dt-binding.

Changes since version 1:
- NPCM8XX clock driver
- Modify dt-binding.
- Remove unsed definition and include.
- Include alphabetically.
- Use clock devm.

Tomer Maimon (3):
dt-bindings: reset: npcm: add clock properties
reset: npcm: register npcm8xx clock auxiliary bus device
clk: npcm8xx: add clock controller

 .../bindings/reset/nuvoton,npcm750-reset.yaml |  18 +
 drivers/clk/Kconfig                           |   8 +
 drivers/clk/Makefile                          |   1 +
 drivers/clk/clk-npcm8xx.c                     | 430 ++++++++++++++++++
 drivers/reset/Kconfig                         |   1 +
 drivers/reset/reset-npcm.c                    |  78 +++-
 include/soc/nuvoton/clock-npcm8xx.h           |  18 +
 7 files changed, 552 insertions(+), 2 deletions(-)
 create mode 100644 drivers/clk/clk-npcm8xx.c
 create mode 100644 include/soc/nuvoton/clock-npcm8xx.h
Signature · 1 line
2.34.1