Skip to content

xsm: refactor and optimize policy loading

Daniel P. Smith xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 15 repliesIn review
  2. v33 patches 11 repliesSuperseded
  3. v23 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch7 repliesSuperseded

Changes in v4 from the cover letter

* rewroked xsm_{multiboot,dt}_init() to support flask=late
* applied the correct types to the policy_buffer for DT
* change type from array to pointer on xsm_multiboot_policy_init()

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xsm: only search for a policy file when neededxen/xsm/xsm_core.c+14 -22 replies
2/3xsm: consolidate loading the policy bufferxen/include/xsm/xsm.h xen/xsm/xsm_core.c xen/xsm/xsm_policy.c+54 -339 replies
3/3xsm: properly handle error from XSM initxen/arch/arm/setup.c xen/arch/x86/setup.c xen/xsm/xsm_core.c+23 -184 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJan BeulichBertrand MarquisJason Andryuk
1/3R-b R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/3] xsm: refactor and optimize policy loading

This series was born out of some cleanup work done while crafting the hyperlaunch boot modules patch series. The primary purpose of this series was to stop walking all boot modules when it was not necessary, but the scope creeped during review.

Changes in v4:
* rewroked xsm_{multiboot,dt}_init() to support flask=late
* applied the correct types to the policy_buffer for DT
* change type from array to pointer on xsm_multiboot_policy_init()

Changes in v3:
* added arm Rb for patch #3
* mainly a resend due to fubar on sending v2

Changes in v2:
* changed init_policy to policy_file_required
* split the patch into a series
* corrected casting of policy buffer
* use IS_ENABLED() instead of #ifdef sequence
* moved #ifdef inside of braces for xsm_dt_policy_init()
* addressed lack of error handling of xsm{mb,dt}_init()

Daniel P. Smith (3):
xsm: only search for a policy file when needed
xsm: consolidate loading the policy buffer
xsm: properly handle error from XSM init

 xen/arch/arm/setup.c  | 10 ++---
 xen/arch/x86/setup.c  |  9 ++++-
 xen/include/xsm/xsm.h |  2 +-
 xen/xsm/xsm_core.c    | 89 ++++++++++++++++++++++++-------------------
 xen/xsm/xsm_policy.c  | 34 ++++++++++++++---
 5 files changed, 91 insertions(+), 53 deletions(-)
Signature · 1 line
2.20.1