Skip to content

arm: rockchip: add support for the radxa rock3 board

Michael Riesch barebox 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3HACK: add device trees for rk3568dts/src/arm64/rockchip/rk3568.dtsi dts/src/arm64/rockchip/rk356x.dtsi+96 -10 replies
2/3HACK: add device tree for radxa rock3 model adts/src/arm64/rockchip/rk3568-rock-3a.dts+562 -00 replies
3/3arm: rockchip: add support for the radxa rock3 boardDocumentation/boards/rockchip.rst arch/arm/boards/Makefile arch/arm/boards/radxa-rock3/.gitignore +8 more+167 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] arm: rockchip: add support for the radxa rock3 board

Hi all,

This series aims to add support for the Radxa ROCK3 Model A single board computer featuring the Rockchip RK3568 SoC.

The first two patches mock the dts sync from the Linux kernel and introduce the device tree for the board (will appear in Linux v5.19-rc1). These patches can be dropped of course and are added only for convenience.

There are a few open issues that are somewhat shared by all RK356x boards:

- The RAM size is defined in the device tree and limited to 2 GB. This is correct for the 2 GB version lying around on my desk, but it should be noted that there are also 4 GB and 8 GB versions of this board available.

- The eMMC controller seems to require the "no-sd" property in the device tree, which is not present in the mainline version. The quick fix is to provide this property in the barebox dts.

- RFC: The "rk3568_start" method in the low-level board code seems to be shared by all RK356x boards. Can it be refactored and made non-static? If yes, what would be a reasonable location for the new function?

- Of course the IO domain bits are board specific. In the long run they should be replaced anyway by a proper iodomain driver. For the time being I believe they could remain in the ENTRY_FUNCTION.

Apart from these issues (which are not exactly critical) barebox works just fine on this neat little board.

Looking forward to your comments!

Best regards,
Michael

Michael Riesch (3):
HACK: add device trees for rk3568
HACK: add device tree for radxa rock3 model a
arm: rockchip: add support for the radxa rock3 board

 Documentation/boards/rockchip.rst         |   1 +
 arch/arm/boards/Makefile                  |   1 +
 arch/arm/boards/radxa-rock3/.gitignore    |   1 +
 arch/arm/boards/radxa-rock3/Makefile      |   3 +
 arch/arm/boards/radxa-rock3/board.c       |  48 ++
 arch/arm/boards/radxa-rock3/lowlevel.c    |  44 ++
 arch/arm/configs/rockchip_v8_defconfig    |   1 +
 arch/arm/dts/Makefile                     |   1 +
 arch/arm/dts/rk3568-rock-3a.dts           |  54 +++
 arch/arm/mach-rockchip/Kconfig            |   6 +
 dts/src/arm64/rockchip/rk3568-rock-3a.dts | 562 ++++++++++++++++++++++
 dts/src/arm64/rockchip/rk3568.dtsi        |  23 +
 dts/src/arm64/rockchip/rk356x.dtsi        |  74 ++-
 images/Makefile.rockchip                  |   7 +
 14 files changed, 825 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boards/radxa-rock3/.gitignore
 create mode 100644 arch/arm/boards/radxa-rock3/Makefile
 create mode 100644 arch/arm/boards/radxa-rock3/board.c
 create mode 100644 arch/arm/boards/radxa-rock3/lowlevel.c
 create mode 100644 arch/arm/dts/rk3568-rock-3a.dts
 create mode 100644 dts/src/arm64/rockchip/rk3568-rock-3a.dts
Signature · 7 lines
2.30.2


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox