Skip to content

Check codeSigning extended key usage extension

Lee, Chun-Yi keyrings linux-crypto lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest posting 2/24 patches 8 repliesIn review
  2. v9 posting 1/24 patches 0 repliesSuperseded

Changes in v9 from the cover letter

- Rename the eku element in public_key structure to ext_key_usage.
- Fix selftest.c

Patches in v9 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4X.509: Add CodeSigning extended key usage parsingcrypto/asymmetric_keys/x509_cert_parser.c include/crypto/public_key.h include/linux/oid_registry.h+31 -02 replies
2/4PKCS#7: Check codeSigning EKU for kernel module and kexec pe verificationcerts/blacklist.c certs/system_keyring.c crypto/asymmetric_keys/Kconfig +4 more+63 -112 replies
3/4modsign: Add codeSigning EKU to the defaultcerts/default_x509.genkey+1 -00 replies
4/4Documentation/admin-guide/module-signing.rst: add openssl command option example for CodeSign EKUDocumentation/admin-guide/module-signing.rst+6 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.

Read the v9 thread

Cover letter [PATCH v9 0/4] Check codeSigning extended key usage extension

NIAP PP_OS certification requests that OS need to validate the CodeSigning extended key usage extension field for integrity verifiction of exectable code:

    https://www.niap-ccevs.org/MMO/PP/-442-/
        FIA_X509_EXT.1.1

This patchset adds the logic for parsing the codeSigning EKU extension field in X.509. And checking the CodeSigning EKU when verifying signature of kernel module or kexec PE binary in PKCS#7.

v9:
- Rename the eku element in public_key structure to ext_key_usage.
- Fix selftest.c

v8:
- Fixed the bug of is_key_on_revocation_list() when CONFIG_SYSTEM_REVOCATION_LIST is not set.

v7:
- Fixed the broken function call in is_key_on_revocation_list(). (be found by kernel test robot)
- Use a general name check_eku_by_usage() instead of check_codesign_eku().

v6:
- Add more length checking when parsing extKeyUsage and EKU's OID blob.
- Add 'usage' parameter to the comment of pkcs7_validate_trust function.

v5:
Fixed the wording in module-signing.rst.

v4:
Fixed the wording in patch description.

v3:
- Add codeSigning EKU to x509.genkey key generation config.
- Add openssl command option example for generating CodeSign EKU to module-signing.rst document.

v2:
Changed the help wording in the Kconfig.

Lee, Chun-Yi (4):
X.509: Add CodeSigning extended key usage parsing PKCS#7: Check codeSigning EKU for kernel module and kexec pe
verification
modsign: Add codeSigning EKU when generating X.509 key generation
config
Documentation/admin-guide/module-signing.rst: add openssl command
option example for CodeSign EKU

 Documentation/admin-guide/module-signing.rst |  6 +++
 certs/blacklist.c                            |  5 ++-
 certs/default_x509.genkey                    |  1 +
 certs/system_keyring.c                       |  4 +-
 crypto/asymmetric_keys/Kconfig               |  9 ++++
 crypto/asymmetric_keys/pkcs7_trust.c         | 43 ++++++++++++++++++--
 crypto/asymmetric_keys/selftest.c            |  2 +-
 crypto/asymmetric_keys/x509_cert_parser.c    | 25 ++++++++++++
 include/crypto/pkcs7.h                       |  4 +-
 include/crypto/public_key.h                  |  1 +
 include/keys/system_keyring.h                |  7 +++-
 include/linux/oid_registry.h                 |  5 +++
 12 files changed, 101 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.2