Skip to content

RFC address deprecated warnings

Mimi Zohar linux-integrity 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest11 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11travis: use the distro OpenSSL version on jammy.travis.yml+1 -11 reply
2/11travis: update dist=focal.travis.yml+1 -11 reply
3/11Update configure.ac to address a couple of obsolete warningsacinclude.m4 configure.ac m4/manpage-docbook-xsl.m4+2 -61 reply
4/11Deprecate IMA signature version 1configure.ac src/Makefile.am src/evmctl.c +2 more+62 -124 replies
5/11Replace the low level SHA1 calls when calculating the TPM 1.2 PCRssrc/evmctl.c+59 -61 reply
6/11Replace the low level HMAC calls when calculating the EVM HMACsrc/evmctl.c+32 -251 reply
7/11Add missing EVP_MD_CTX_free() call in calc_evm_hash()src/evmctl.c+40 -171 reply
8/11Deprecate use of OpenSSL 3 "engine" supportconfigure.ac src/Makefile.am src/evmctl.c +5 more+74 -36 replies
9/11Fix potential use after free in read_tpm_banks()src/evmctl.c+1 -01 reply
10/11Limit the file hash algorithm name lengthsrc/evmctl.c+1 -11 reply
11/11Missing template data size lower bounds checkingsrc/evmctl.c+4 -01 reply

Reviews trailers per patch

10 of 11 patches have a Reviewed-by or Acked-by.

PatchPetr Vorel
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH ima-evm-utils 00/11] address deprecated warnings

Between travis/ci and OpenSSL v3 a large number of deprecated warnings are being emitted when compiling ima-evm-utils. Start addressing these deprecated warnings by replacing the low level SHA1 and HMAC calls with the EVP_ functions. IMA signature version 1 also uses low level calls, but instead of fixing it, deprecate it as nobody should be using it anyway.

OpenSSL v3 deprecates "engine" support, causing a lot of warnings. Since turning off engine support affects PKCS11 and Streebog, define a "--enable-engine" configuration option.

In addition address some static analysis warnings and other cleanup.

Mimi Zohar (11):
travis: use the distro OpenSSL version on jammy
travis: update dist=focal
Update configure.ac to address a couple of obsolete warnings Deprecate IMA signature version 1
Replace the low level SHA1 calls when calculating the TPM 1.2 PCRs Replace the low level HMAC calls when calculating the EVM HMAC Add missing EVP_MD_CTX_free() call in calc_evm_hash() Deprecate use of OpenSSL 3 "engine" support
Fix potential use after free in read_tpm_banks()
Limit the file hash algorithm name length
Missing template data size lower bounds checking

 .travis.yml               |   4 +-
 acinclude.m4              |   2 +-
 configure.ac              |  25 ++++-
 m4/manpage-docbook-xsl.m4 |   2 +-
 src/Makefile.am           |  18 ++++
 src/evmctl.c              | 219 ++++++++++++++++++++++++++++----------
 src/imaevm.h              |   2 +
 src/libimaevm.c           |  29 ++++-
 tests/functions.sh        |  11 +-
 tests/ima_hash.test       |   9 ++
 tests/sign_verify.test    |  28 +++--
 11 files changed, 277 insertions(+), 72 deletions(-)
Signature · 1 line
2.31.1