drm/ast: Convert ast driver to SHMEM
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 0 repliesNew
- v18 patches 7 repliesSuperseded
Changes in v2 from the cover letter
* additional fixes for BMC output (Jocelyn)
* fix typos in commit messages (Jocelyn)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | drm/ast: Acquire I/O-register lock in atomic_commit_tail functiondrivers/ | +16 | 0 replies | |
| 2/8 | drm/ast: Call drm_atomic_helper_check_plane_state() unconditionallydrivers/ | +15 | 0 replies | |
| 3/8 | drm/ast: Do not call drm_atomic_add_affected_planes()drivers/ | +2 | 0 replies | |
| 4/8 | drm/ast: Remove cursor double bufferingdrivers/ drivers/ | +35 | 0 replies | |
| 5/8 | drm/ast: Rename struct ast_cursor_plane to struct ast_planedrivers/ drivers/ | +20 | 0 replies | |
| 6/8 | drm/ast: Style cleanups in plane codedrivers/ | +45 | 0 replies | |
| 7/8 | drm/ast: Convert ast to SHMEMdrivers/ drivers/ drivers/ +3 more | +129 | 0 replies | |
| 8/8 | drm/ast: Avoid reprogramming primary-plane scanout addressdrivers/ | +13 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Jocelyn Falempe | Javier Martinez Canillas |
|---|---|---|
| 1/8 | R-b T-b | |
| 2/8 | R-b T-b | |
| 3/8 | R-b T-b | R-b |
| 4/8 | R-b T-b | |
| 5/8 | R-b T-b | |
| 6/8 | R-b T-b | |
| 7/8 | R-b T-b | |
| 8/8 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/8] drm/ast: Convert ast driver to SHMEM
This patchset converts ast to GEM SHMEM helpers. Fixes problems with memory allocation and BMC scanout updates.
Patches 1 to 3 are fixes for various minor problems in the ast driver. We should merge them even without SHMEM support.
Patches 4 to 6 prepare the driver for the conversion. The cursor double buffering is not required and prevents reuse among the plane code. Style issues are being fixed separately from the conversion.
The conversion itself is in patch 7. Not only does it fix problems with memory allocation, it also brings back several high-res display modes that got lost during the ast driver's conversion to atomic modesetting. There was an earlier RFC patch of this code that had issues with rendering performance. [1] We've meanwhile improved in these area and performance was acceptable on the test systems.
With SHMEM in place, the scanout address for the primary plane does not have to be changed often. Patch 8 fixes a performance problem where the BMC output freezes for several seconds after reprogramming the scanout address or scanline offset.
Tested on AST 2100 and 2300 with fbdev emulation, weston, and Gnome in X11 and Wayland mode.
v2:
* additional fixes for BMC output (Jocelyn)
* fix typos in commit messages (Jocelyn)
[1] https://lore.kernel.org/dri-devel/[email protected]/
Thomas Zimmermann (8):
drm/ast: Acquire I/O-register lock in atomic_commit_tail function drm/ast: Call drm_atomic_helper_check_plane_state() unconditionally drm/ast: Do not call drm_atomic_add_affected_planes() drm/ast: Remove cursor double buffering
drm/ast: Rename struct ast_cursor_plane to struct ast_plane drm/ast: Style cleanups in plane code
drm/ast: Convert ast to SHMEM
drm/ast: Avoid reprogramming primary-plane scanout address
drivers/gpu/drm/ast/Kconfig | 4 +- drivers/gpu/drm/ast/ast_drv.c | 4 +- drivers/gpu/drm/ast/ast_drv.h | 34 +-- drivers/gpu/drm/ast/ast_main.c | 5 +- drivers/gpu/drm/ast/ast_mm.c | 14 +- drivers/gpu/drm/ast/ast_mode.c | 404 ++++++++++++++++----------------- 6 files changed, 222 insertions(+), 243 deletions(-)
base-commit: 74e2443e7681e4d442b45f551ddf12d09a6f00c3
Signature · 1 line
2.37.3