Skip to content

can: kvaser_usb: Fixes and improvements

Jimmy Assarsson linux-can 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest11 patches 3 repliesIn review

Changes in v5 from the cover letter

- Split series [1], since v4 got rejected [2].
This part only contains non-critical fixes and improvements.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11can: kvaser_usb: Fix possible completions during init_completiondrivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+4 -42 replies
2/11can: kvaser_usb: kvaser_usb_leaf: Get capabilities from devicedrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+143 -10 replies
3/11can: kvaser_usb: kvaser_usb_leaf: Rename {leaf,usbcan}_cmd_error_event to {leaf,usbcan}_cmd_can_error_eventdrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+19 -190 replies
4/11can: kvaser_usb: kvaser_usb_leaf: Handle CMD_ERROR_EVENTdrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+99 -00 replies
5/11can: kvaser_usb_leaf: Set Warning state even without bus errorsdrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+8 -120 replies
6/11can: kvaser_usb_leaf: Fix improved state not being reporteddrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+81 -30 replies
7/11can: kvaser_usb_leaf: Fix wrong CAN state after stoppingdrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+4 -00 replies
8/11can: kvaser_usb_leaf: Ignore stale bus-off after startdrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+30 -10 replies
9/11can: kvaser_usb_leaf: Fix bogus restart eventsdrivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+3 -30 replies
10/11can: kvaser_usb: Add struct kvaser_usb_busparamsdrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+27 -311 reply
11/11can: kvaser_usb: Compare requested bittiming parameters with actual parameters in do_set_{,data}_bittimingdrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c +1 more+284 -410 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by.

PatchJimmy AssarssonAnssi Hannula
1/11T-b
2/11T-b
3/11T-b
4/11T-b
5/11T-b
6/11T-b
7/11T-b
8/11T-b
9/11T-b
10/11T-b
11/11T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH can-next v5 00/11] can: kvaser_usb: Fixes and improvements

Changes in v5:
- Split series [1], since v4 got rejected [2].
This part only contains non-critical fixes and improvements.

Note: This series depend on changes in [3]

[1]
https://lore.kernel.org/linux-can/[email protected]
[2]
https://lore.kernel.org/linux-can/[email protected]
[3]
https://lore.kernel.org/linux-can/[email protected]/T/#m77a503db16c46024601e0d41fed60a806b02c15f

Anssi Hannula (6):
can: kvaser_usb: Fix possible completions during init_completion
can: kvaser_usb_leaf: Set Warning state even without bus errors
can: kvaser_usb_leaf: Fix improved state not being reported
can: kvaser_usb_leaf: Fix wrong CAN state after stopping
can: kvaser_usb_leaf: Ignore stale bus-off after start
can: kvaser_usb_leaf: Fix bogus restart events

Jimmy Assarsson (5):
can: kvaser_usb: kvaser_usb_leaf: Get capabilities from device
can: kvaser_usb: kvaser_usb_leaf: Rename {leaf,usbcan}_cmd_error_event
to {leaf,usbcan}_cmd_can_error_event
can: kvaser_usb: kvaser_usb_leaf: Handle CMD_ERROR_EVENT
can: kvaser_usb: Add struct kvaser_usb_busparams
can: kvaser_usb: Compare requested bittiming parameters with actual
parameters in do_set_{,data}_bittiming

 drivers/net/can/usb/kvaser_usb/kvaser_usb.h   |  30 +-
 .../net/can/usb/kvaser_usb/kvaser_usb_core.c  | 115 ++++-
 .../net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 164 ++++--
 .../net/can/usb/kvaser_usb/kvaser_usb_leaf.c  | 468 ++++++++++++++++--
 4 files changed, 682 insertions(+), 95 deletions(-)
Signature · 1 line
2.38.0