Skip to content

cleanup: Tweak and re-run return_directly.cocci

Markus Armbruster qemu-devel qemu-riscv virtio-fs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v22 patches 13 repliesSuperseded
  3. v11 patch 14 repliesSuperseded

Changes in v3 from the cover letter

* Rebased onto Greg's "[PATCH] 9pfs: Fix some return statements in the synth backend", which replaces my change to hw/9pfs/9p-synth.c in PATCH 1/3, along with a paragraph on checkpatch.pl in the commit message.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3cleanup: Tweak and re-run return_directly.coccihw/char/sifive_uart.c hw/ppc/ppc4xx_sdram.c hw/rdma/vmw/pvrdma_cmd.c +23 more+66 -1940 replies
2/3block/vmdk: Simplify vmdk_co_create() to return directlyblock/vmdk.c+11 -171 reply
3/3ppc4xx_sdram: Simplify sdram_ddr_size() to return directlyhw/ppc/ppc4xx_sdram.c+3 -71 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéDr. David Alan GilbertPeter MaydellBALATON ZoltanJuan Quintela
1/3R-b A-b
2/3R-b R-b R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] cleanup: Tweak and re-run return_directly.cocci

v3:
* Rebased onto Greg's "[PATCH] 9pfs: Fix some return statements in the synth backend", which replaces my change to hw/9pfs/9p-synth.c in PATCH 1/3, along with a paragraph on checkpatch.pl in the commit message.

v2:
* Changes to imported files dropped [Philippe, Max]
* Handwritten change to vmdk_co_create() split off as PATCH 2/2 [Peter]
* New PATCH 3/2 [Zoltan]

Markus Armbruster (3):
cleanup: Tweak and re-run return_directly.cocci block/vmdk: Simplify vmdk_co_create() to return directly
ppc4xx_sdram: Simplify sdram_ddr_size() to return directly

 scripts/coccinelle/return_directly.cocci |  5 +--
 include/hw/pci/pci.h                     |  7 +--
 target/avr/cpu.h                         |  4 +-
 block/vmdk.c                             | 28 +++++-------
 hw/char/sifive_uart.c                    |  4 +-
 hw/ppc/ppc4xx_sdram.c                    | 15 ++-----
 hw/rdma/vmw/pvrdma_cmd.c                 | 57 +++++++++---------------
 hw/virtio/vhost-user.c                   |  6 +--
 migration/dirtyrate.c                    | 10 +----
 migration/tls.c                          |  6 +--
 replay/replay-time.c                     |  5 +--
 semihosting/console.c                    |  4 +-
 softmmu/memory.c                         | 11 +----
 softmmu/physmem.c                        |  9 +---
 target/loongarch/cpu.c                   |  4 +-
 target/mips/tcg/dsp_helper.c             | 15 ++-----
 target/riscv/debug.c                     |  6 +--
 target/riscv/vector_helper.c             | 28 +++---------
 tests/bench/benchmark-crypto-akcipher.c  |  6 +--
 tests/qtest/erst-test.c                  |  5 +--
 tests/qtest/hexloader-test.c             |  6 +--
 tests/qtest/pvpanic-pci-test.c           |  6 +--
 tests/qtest/pvpanic-test.c               |  6 +--
 tests/qtest/test-filter-mirror.c         |  6 +--
 tests/qtest/virtio-ccw-test.c            |  6 +--
 tests/tcg/multiarch/sha512.c             |  9 +---
 tools/virtiofsd/fuse_lowlevel.c          | 24 +++-------
 27 files changed, 80 insertions(+), 218 deletions(-)
Signature · 1 line
2.37.3