Skip to content

hw/nvme: fix broken shadow doorbells on some platforms

Klaus Jensen qemu-devel qemu-riscv 4 versions – Applied

Status from this message: Applied to nvme-next. Thansk for the reviews!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 5 repliesApplied
  2. v34 patches 3 repliesSuperseded
  3. v23 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch3 repliesSuperseded

Changes in v4 from the cover letter

- screwed up the rebase (Philippe)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4hw/nvme: use QOM accessorshw/nvme/ctrl.c+48 -410 replies
2/4hw/nvme: rename shadow doorbell related trace eventshw/nvme/ctrl.c hw/nvme/trace-events+11 -81 reply
3/4hw/nvme: fix missing endian conversions for doorbell buffershw/nvme/ctrl.c+13 -62 replies
4/4hw/nvme: fix missing cq eventidx updatehw/nvme/ctrl.c+10 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéKeith Busch
1/4R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] hw/nvme: fix broken shadow doorbells on some platforms

From: Klaus Jensen <[email protected]>

Guenter reports that hw/nvme is broken on riscv64[1] and big endian platforms[2].

This is a regression since 7.1, so this does not warrent an rc5 for 7.2. I'm sure Guenter can carry this patch in his tree, and maybe we can get this out in a stable release.

On riscv, the issue is a missing cq eventidx update. I really wonder why this issue only shows up on riscv64. We have not observed this on other platforms (yet).

Further, Guenter also reported problems on big-endian platforms. The issue here is missing endian conversions which patch 3 addresses. This also requires a fix for the Linux kernel that I am posting separately (can't link to it, chicken and egg problem).

[1]: https://lore.kernel.org/qemu-devel/[email protected]/
[2]: https://lore.kernel.org/qemu-devel/[email protected]/

v4:
- screwed up the rebase (Philippe)

v3:
- add patch to fix big-endian platforms

v2:
- use QOM accessor (Philippe)
- added some cleanup patches in front

Klaus Jensen (4):
hw/nvme: use QOM accessors
hw/nvme: rename shadow doorbell related trace events hw/nvme: fix missing endian conversions for doorbell buffers hw/nvme: fix missing cq eventidx update

 hw/nvme/ctrl.c       | 121 ++++++++++++++++++++++++++-----------------
 hw/nvme/trace-events |   8 +--
 2 files changed, 78 insertions(+), 51 deletions(-)
Signature · 1 line
2.38.1