hw: Remove implicit sysbus_mmio_map() from pflash APIs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest21 patches 22 repliesIn review
- v120 patches 23 repliesSuperseded
Changes in v2 from the cover letter
- Do not introduce pflash_cfi_create(), directly open-code pflash_cfi_register() before removing it (Peter)
- Added R-b tags
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | hw/block: Rename TYPE_PFLASH_CFI02 'width' property as 'device-width'hw/ | +2 | 10 replies | |
| 2/21 | hw/block: Pass DeviceState to pflash_cfi01_get_blk()hw/ hw/ hw/ +2 more | +8 | 0 replies | |
| 3/21 | hw/block: Use pflash_cfi01_get_blk() in pflash_cfi01_legacy_drive()hw/ hw/ hw/ +3 more | +8 | 0 replies | |
| 4/21 | hw/block: Pass DeviceState to pflash_cfi01_get_memory()hw/ hw/ hw/ +3 more | +9 | 2 replies | |
| 5/21 | hw/arm: Use generic DeviceState instead of PFlashCFI01hw/ hw/ hw/ +1 more | +16 | 0 replies | |
| 6/21 | hw/loongarch: Use generic DeviceState instead of PFlashCFI01hw/ include/ | +5 | 0 replies | |
| 7/21 | hw/riscv: Use generic DeviceState instead of PFlashCFI01hw/ include/ | +6 | 1 reply | |
| 8/21 | hw/i386: Use generic DeviceState instead of PFlashCFI01hw/ include/ | +8 | 0 replies | |
| 9/21 | hw/xtensa: Use generic DeviceState instead of PFlashCFI01hw/ | +4 | 0 replies | |
| 10/21 | hw/sh4: Open-code pflash_cfi02_register()hw/ | +17 | 3 replies | |
| 11/21 | hw/arm/digic: Open-code pflash_cfi02_register()hw/ | +20 | 1 reply | |
| 12/21 | hw/arm/musicpal: Open-code pflash_cfi02_register()hw/ | +15 | 1 reply | |
| 13/21 | hw/arm/xilinx_zynq: Open-code pflash_cfi02_register()hw/ | +15 | 1 reply | |
| 14/21 | hw/block: Remove unused pflash_cfi02_register()hw/ include/ | +0 | 0 replies | |
| 15/21 | hw/block: Make PFlashCFI02 QOM declaration internalhw/ include/ | +3 | 0 replies | |
| 16/21 | hw/arm: Open-code pflash_cfi01_register()hw/ hw/ hw/ +3 more | +102 | 1 reply | |
| 17/21 | hw/microblaze: Open-code pflash_cfi01_register()hw/ hw/ | +24 | 0 replies | |
| 18/21 | hw/mips: Open-code pflash_cfi01_register()hw/ | +10 | 0 replies | |
| 19/21 | hw/ppc: Open-code pflash_cfi01_register()hw/ hw/ | +26 | 1 reply | |
| 20/21 | hw/block: Remove unused pflash_cfi01_register()hw/ include/ | +0 | 0 replies | |
| 21/21 | hw/block: Make PFlashCFI01 QOM declaration internalhw/ include/ | +2 | 0 replies |
Reviews trailers per patch
17 of 21 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Henrique Barboza | Bin Meng | BALATON Zoltan | Alistair Francis | Peter Maydell |
|---|---|---|---|---|---|
| 1/21 | |||||
| 2/21 | R-b | ||||
| 3/21 | R-b | ||||
| 4/21 | R-b | ||||
| 5/21 | R-b | ||||
| 6/21 | R-b | ||||
| 7/21 | R-b | R-b | R-b | ||
| 8/21 | R-b | ||||
| 9/21 | R-b | ||||
| 10/21 | R-b | ||||
| 11/21 | R-b | ||||
| 12/21 | R-b | ||||
| 13/21 | R-b | ||||
| 14/21 | R-b | ||||
| 15/21 | R-b | ||||
| 16/21 | |||||
| 17/21 | |||||
| 18/21 | |||||
| 19/21 | R-b | ||||
| 20/21 | R-b | ||||
| 21/21 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v2 00/21] hw: Remove implicit sysbus_mmio_map() from pflash APIs
Since v1:
- Do not introduce pflash_cfi_create(), directly open-code pflash_cfi_register() before removing it (Peter)
- Added R-b tags
Paving the road toward heterogeneous QEMU, the limitations of having a single machine sysbus become more apparent.
The sysbus_mmio_map() API forces the caller to map a sysbus device to an address on the system bus (system bus here is the root MemoryRegion returned by get_system_memory() ).
This is not practical when each core has its own address space and group of cores have access to a part of the peripherals.
Experimenting with the PFLASH devices. Here the fix is quite easy: open-code the pflash_cfi_register() functions.
Since we were touching the PFLASH API, we restricted the PFlashCFI0X structures to their models. The API now deals with a generic qdev pointer (DeviceState*).
Please review,
Phil.
Based-on: <[email protected]>
"hw/arm: Cleanups before pflash refactor"
Based-on: <[email protected]>
"hw/misc: Cleanups around PFLASH use"
Philippe Mathieu-Daudé (21):
hw/block: Rename TYPE_PFLASH_CFI02 'width' property as 'device-width' hw/block: Pass DeviceState to pflash_cfi01_get_blk() hw/block: Use pflash_cfi01_get_blk() in pflash_cfi01_legacy_drive() hw/block: Pass DeviceState to pflash_cfi01_get_memory() hw/arm: Use generic DeviceState instead of PFlashCFI01 hw/loongarch: Use generic DeviceState instead of PFlashCFI01 hw/riscv: Use generic DeviceState instead of PFlashCFI01 hw/i386: Use generic DeviceState instead of PFlashCFI01 hw/xtensa: Use generic DeviceState instead of PFlashCFI01 hw/sh4: Open-code pflash_cfi02_register()
hw/arm/digic: Open-code pflash_cfi02_register() hw/arm/musicpal: Open-code pflash_cfi02_register() hw/arm/xilinx_zynq: Open-code pflash_cfi02_register() hw/block: Remove unused pflash_cfi02_register()
hw/block: Make PFlashCFI02 QOM declaration internal hw/arm: Open-code pflash_cfi01_register()
hw/microblaze: Open-code pflash_cfi01_register()
hw/mips: Open-code pflash_cfi01_register()
hw/ppc: Open-code pflash_cfi01_register()
hw/block: Remove unused pflash_cfi01_register()
hw/block: Make PFlashCFI01 QOM declaration internal
hw/arm/collie.c | 16 ++++++--- hw/arm/digic_boards.c | 26 ++++++++++---- hw/arm/gumstix.c | 32 +++++++++++++---- hw/arm/mainstone.c | 19 +++++++--- hw/arm/musicpal.c | 21 +++++++---- hw/arm/omap_sx1.c | 31 +++++++++++----- hw/arm/sbsa-ref.c | 8 ++--- hw/arm/versatilepb.c | 18 +++++++--- hw/arm/vexpress.c | 10 +++--- hw/arm/virt.c | 6 ++-- hw/arm/xilinx_zynq.c | 20 ++++++++--- hw/arm/z2.c | 17 +++++++-- hw/block/pflash_cfi01.c | 45 ++++++------------------ hw/block/pflash_cfi02.c | 40 ++------------------- hw/i386/pc_sysfw.c | 6 ++-- hw/loongarch/virt.c | 9 +++-- hw/microblaze/petalogix_ml605_mmu.c | 18 ++++++---- hw/microblaze/petalogix_s3adsp1800_mmu.c | 16 ++++++--- hw/mips/malta.c | 18 ++++++---- hw/ppc/e500.c | 2 +- hw/ppc/sam460ex.c | 19 +++++++--- hw/ppc/virtex_ml507.c | 15 ++++++-- hw/riscv/virt.c | 7 ++-- hw/sh4/r2d.c | 21 ++++++++--- hw/xtensa/xtfpga.c | 6 ++-- include/hw/arm/virt.h | 3 +- include/hw/block/flash.h | 37 ++----------------- include/hw/i386/pc.h | 3 +- include/hw/loongarch/virt.h | 3 +- include/hw/riscv/virt.h | 3 +- 30 files changed, 276 insertions(+), 219 deletions(-)
Signature · 1 line
2.38.1