Skip to content

KVM: Standardize on "int" return types instead of "long"

Thomas Huth kvm kvm-riscv kvmarm lkml 2 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 7 repliesApplied
  2. v17 patches 14 repliesSuperseded

Changes in v2 from the cover letter

- Remove KVM_GET_NR_MMU_PAGES ioctl instead of trying to work-around the problem (the ioctl is not used in any userspace app anyway)
- Add check for INT_MAX to the arm64 patch
- Added Reviewed-bys from v1

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6KVM: PPC: Standardize on "int" return types in the powerpc KVM codearch/powerpc/include/asm/kvm_ppc.h arch/powerpc/kvm/book3s_64_mmu_hv.c arch/powerpc/kvm/book3s_64_vio.c +2 more+21 -210 replies
2/6KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys()arch/s390/kvm/kvm-s390.c+2 -20 replies
3/6KVM: x86: Remove the KVM_GET_NR_MMU_PAGES ioctlarch/x86/kvm/x86.c include/uapi/linux/kvm.h tools/include/uapi/linux/kvm.h+2 -101 reply
4/6KVM: arm64: Limit length in kvm_vm_ioctl_mte_copy_tags() to INT_MAXDocumentation/virt/kvm/api.rst arch/arm64/include/asm/kvm_host.h arch/arm64/kvm/guest.c+10 -53 replies
5/6KVM: Standardize on "int" return types instead of "long" in kvm_main.cvirt/kvm/kvm_main.c+2 -20 replies
6/6KVM: Change return type of kvm_arch_vm_ioctl() to "int"arch/arm64/kvm/arm.c arch/mips/kvm/mips.c arch/powerpc/kvm/powerpc.c +4 more+9 -152 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchNicholas PigginClaudio ImbrendaSteven PriceSean ChristophersonCornelia HuckGavin ShanAnup Patel
1/6R-b
2/6R-b
3/6R-b
4/6R-b R-b R-b
5/6
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] KVM: Standardize on "int" return types instead of "long"

KVM functions use "long" return values for functions that are wired up to "struct file_operations", but otherwise use "int" return values for functions that can return 0/-errno in order to avoid unintentional divergences between 32-bit and 64-bit kernels. Some related functions that are not part of a "struct file_operations" still use "long", though, which can cause confusion or even subtle problems (see the x86 and the arm64 patches). Thus let's standardize on using "int" for return values in these functions to avoid such problems in the future.

v2:
- Remove KVM_GET_NR_MMU_PAGES ioctl instead of trying to work-around the problem (the ioctl is not used in any userspace app anyway)
- Add check for INT_MAX to the arm64 patch
- Added Reviewed-bys from v1

Thomas Huth (6):
KVM: PPC: Standardize on "int" return types in the powerpc KVM code
KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys()
KVM: x86: Remove the KVM_GET_NR_MMU_PAGES ioctl
KVM: arm64: Limit length in kvm_vm_ioctl_mte_copy_tags() to INT_MAX
KVM: Standardize on "int" return types instead of "long" in kvm_main.c
KVM: Change return type of kvm_arch_vm_ioctl() to "int"

 Documentation/virt/kvm/api.rst      |  3 ++-
 arch/arm64/include/asm/kvm_host.h   |  4 ++--
 arch/arm64/kvm/arm.c                |  3 +--
 arch/arm64/kvm/guest.c              |  8 ++++++--
 arch/mips/kvm/mips.c                |  4 ++--
 arch/powerpc/include/asm/kvm_ppc.h  | 14 +++++++-------
 arch/powerpc/kvm/book3s_64_mmu_hv.c | 14 +++++++-------
 arch/powerpc/kvm/book3s_64_vio.c    |  4 ++--
 arch/powerpc/kvm/book3s_hv.c        |  6 +++---
 arch/powerpc/kvm/book3s_pr.c        |  4 ++--
 arch/powerpc/kvm/powerpc.c          |  5 ++---
 arch/riscv/kvm/vm.c                 |  3 +--
 arch/s390/kvm/kvm-s390.c            |  7 +++----
 arch/x86/kvm/x86.c                  | 11 +----------
 include/linux/kvm_host.h            |  3 +--
 include/uapi/linux/kvm.h            |  2 +-
 tools/include/uapi/linux/kvm.h      |  2 +-
 virt/kvm/kvm_main.c                 |  4 ++--
 18 files changed, 46 insertions(+), 55 deletions(-)
Signature · 1 line
2.31.1