Skip to content

clk: Add kunit tests for fixed rate and parent data

Stephen Boyd linux-clk linux-devicetree linux-kselftest linux-patches lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 10 repliesIn review
  2. v211 patches 11 repliesSuperseded
  3. v18 patches 51 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11of: Add KUnit test to confirm DTB is loadeddrivers/of/.kunitconfig drivers/of/Kconfig drivers/of/Makefile +1 more+48 -00 replies
2/11of: Add test managed wrappers for of_overlay_apply()/of_node_put()Documentation/dev-tools/kunit/api/index.rst Documentation/dev-tools/kunit/api/of.rst drivers/of/Makefile +2 more+245 -02 replies
3/11dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friendsDocumentation/devicetree/bindings/vendor-prefixes.yaml+2 -01 reply
4/11dt-bindings: test: Add KUnit empty node bindingDocumentation/devicetree/bindings/test/test,empty.yaml+30 -01 reply
5/11of: Add a KUnit test for overlays and test managed APIsdrivers/of/.kunitconfig drivers/of/Kconfig drivers/of/Makefile +2 more+132 -04 replies
6/11platform: Add test managed platform_device/driver APIsDocumentation/dev-tools/kunit/api/index.rst Documentation/dev-tools/kunit/api/platformdevice.rst drivers/base/test/Makefile +3 more+388 -00 replies
7/11dt-bindings: kunit: Add fixed rate clk consumer testDocumentation/devicetree/bindings/test/test,clk-fixed-rate.yaml+35 -01 reply
8/11clk: Add test managed clk provider/consumer APIsDocumentation/dev-tools/kunit/api/clk.rst Documentation/dev-tools/kunit/api/index.rst drivers/clk/Makefile +2 more+272 -00 replies
9/11clk: Add KUnit tests for clk fixed rate basic typedrivers/clk/.kunitconfig drivers/clk/Kconfig drivers/clk/Makefile +3 more+412 -00 replies
10/11dt-bindings: clk: Add KUnit clk_parent_data testDocumentation/devicetree/bindings/clock/test,clk-parent-data.yaml+47 -01 reply
11/11clk: Add KUnit tests for clks registered with struct clk_parent_datadrivers/clk/Makefile drivers/clk/clk_parent_data_test.h drivers/clk/clk_test.c +1 more+498 -20 replies

Reviews trailers per patch

4 of 11 patches have a Reviewed-by or Acked-by.

PatchRob Herring
1/11
2/11
3/11R-b
4/11R-b
5/11
6/11
7/11R-b
8/11
9/11
10/11R-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/11] clk: Add kunit tests for fixed rate and parent data

This patch series adds unit tests for the clk fixed rate basic type and the clk registration functions that use struct clk_parent_data. To get there, we add support for loading device tree overlays onto the live DTB along with probing platform drivers to bind to device nodes in the overlays. With this series, we're able to exercise some of the code in the common clk framework that uses devicetree lookups to find parents and the fixed rate clk code that scans device tree directly and creates clks. Please review.

I Cced everyone to all the patches so they get the full context. I'm hoping I can take the whole pile through the clk tree as they almost all depend on each other.

Changes from v2 (https://lore.kernel.org/r/[email protected]):
* Overlays don't depend on __symbols__ node
* Depend on Frank's always create root node if CONFIG_OF series[1]
* Added kernel-doc to KUnit API doc
* Fixed some kernel-doc on functions
* More test cases for fixed rate clk

Changes from v1 (https://lore.kernel.org/r/[email protected]):
* Don't depend on UML, use unittest data approach to attach nodes
* Introduce overlay loading API for KUnit
* Move platform_device KUnit code to drivers/base/test
* Use #define macros for constants shared between unit tests and overlays
* Settle on "test" as a vendor prefix
* Make KUnit wrappers have "_kunit" postfix

Stephen Boyd (11):
of: Add KUnit test to confirm DTB is loaded
of: Add test managed wrappers for of_overlay_apply()/of_node_put()
dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friends
dt-bindings: test: Add KUnit empty node binding
of: Add a KUnit test for overlays and test managed APIs
platform: Add test managed platform_device/driver APIs
dt-bindings: kunit: Add fixed rate clk consumer test
clk: Add test managed clk provider/consumer APIs
clk: Add KUnit tests for clk fixed rate basic type
dt-bindings: clk: Add KUnit clk_parent_data test
clk: Add KUnit tests for clks registered with struct clk_parent_data

 Documentation/dev-tools/kunit/api/clk.rst     |  10 +
 Documentation/dev-tools/kunit/api/index.rst   |  22 +
 Documentation/dev-tools/kunit/api/of.rst      |  13 +
 .../dev-tools/kunit/api/platformdevice.rst    |  10 +
 .../bindings/clock/test,clk-parent-data.yaml  |  47 ++
 .../bindings/test/test,clk-fixed-rate.yaml    |  35 ++
 .../devicetree/bindings/test/test,empty.yaml  |  30 ++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 drivers/base/test/Makefile                    |   3 +
 drivers/base/test/platform_kunit-test.c       | 140 ++++++
 drivers/base/test/platform_kunit.c            | 215 ++++++++
 drivers/clk/.kunitconfig                      |   3 +
 drivers/clk/Kconfig                           |   7 +
 drivers/clk/Makefile                          |   9 +-
 drivers/clk/clk-fixed-rate_test.c             | 374 ++++++++++++++
 drivers/clk/clk-fixed-rate_test.h             |   8 +
 drivers/clk/clk_kunit.c                       | 224 +++++++++
 drivers/clk/clk_parent_data_test.h            |  10 +
 drivers/clk/clk_test.c                        | 459 +++++++++++++++++-
 drivers/clk/kunit_clk_fixed_rate_test.dtso    |  19 +
 drivers/clk/kunit_clk_parent_data_test.dtso   |  28 ++
 drivers/of/.kunitconfig                       |   5 +
 drivers/of/Kconfig                            |  19 +
 drivers/of/Makefile                           |   4 +
 drivers/of/kunit_overlay_test.dtso            |   9 +
 drivers/of/of_kunit.c                         | 125 +++++
 drivers/of/of_test.c                          |  34 ++
 drivers/of/overlay_test.c                     | 110 +++++
 include/kunit/clk.h                           |  28 ++
 include/kunit/of.h                            |  94 ++++
 include/kunit/platform_device.h               |  15 +
 31 files changed, 2109 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/dev-tools/kunit/api/clk.rst
 create mode 100644 Documentation/dev-tools/kunit/api/of.rst
 create mode 100644 Documentation/dev-tools/kunit/api/platformdevice.rst
 create mode 100644 Documentation/devicetree/bindings/clock/test,clk-parent-data.yaml
 create mode 100644 Documentation/devicetree/bindings/test/test,clk-fixed-rate.yaml
 create mode 100644 Documentation/devicetree/bindings/test/test,empty.yaml
 create mode 100644 drivers/base/test/platform_kunit-test.c
 create mode 100644 drivers/base/test/platform_kunit.c
 create mode 100644 drivers/clk/clk-fixed-rate_test.c
 create mode 100644 drivers/clk/clk-fixed-rate_test.h
 create mode 100644 drivers/clk/clk_kunit.c
 create mode 100644 drivers/clk/clk_parent_data_test.h
 create mode 100644 drivers/clk/kunit_clk_fixed_rate_test.dtso
 create mode 100644 drivers/clk/kunit_clk_parent_data_test.dtso
 create mode 100644 drivers/of/.kunitconfig
 create mode 100644 drivers/of/kunit_overlay_test.dtso
 create mode 100644 drivers/of/of_kunit.c
 create mode 100644 drivers/of/of_test.c
 create mode 100644 drivers/of/overlay_test.c
 create mode 100644 include/kunit/clk.h
 create mode 100644 include/kunit/of.h
 create mode 100644 include/kunit/platform_device.h

[1] https://lore.kernel.org/r/[email protected]

base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
prerequisite-patch-id: 33517b96dd0768ab9c265f5721629786354ee320
prerequisite-patch-id: 909221815eeca0a2b0cdd385c76f57e185fb9e33

Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git