Skip to content

arm64: dts: qcom: sa8775p: add basic PMIC support

Bartosz Golaszewski linux-arm-msm linux-devicetree linux-gpio lkml 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 22 repliesApplied
  2. v215 patches 17 repliesSuperseded
  3. v114 patches 17 repliesApplied

Changes in v3 from the cover letter

- add GPIO line names for the PMIC GPIOs on sa8775p-ride
- add missing GPIO chips to the PMIC .dtsi
- add missing thermal zones and alerts
- add regulators (driver support and regulator settings for sa8775p-ride)
- add missing PDC mappings
- squash patches 7 and 8 to avoid adding code without users
- dropped Krzysztof's Ack from patch 3 as it now extends the max number of mappings so most likely needs a second look

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/18arm64: dts: qcom: sa8775p: pad reg properties to 8 digitsarch/arm64/boot/dts/qcom/sa8775p.dtsi+6 -60 replies
2/18arm64: dts: qcom: sa8775p: sort soc nodes by reg propertyarch/arm64/boot/dts/qcom/sa8775p.dtsi+197 -1970 replies
3/18dt-bindings: interrupt-controller: qcom-pdc: add compatible for sa8775pDocumentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml+2 -17 replies
4/18arm64: dts: qcom: sa8775p: add the pdc nodearch/arm64/boot/dts/qcom/sa8775p.dtsi+47 -01 reply
5/18arm64: dts: qcom: sa8775p: add the spmi nodearch/arm64/boot/dts/qcom/sa8775p.dtsi+22 -00 replies
6/18dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654auDocumentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml+1 -03 replies
7/18arm64: dts: qcom: sa8775p: add support for the on-board PMICsarch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi arch/arm64/boot/dts/qcom/sa8775p-ride.dts+38 -00 replies
8/18arm64: dts: qcom: sa8775p: add the Power On device nodearch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi+8 -00 replies
9/18arm64: dts: qcom: sa8775p: pmic: add the power keyarch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi+7 -00 replies
10/18arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN inputarch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi+7 -00 replies
11/18arm64: dts: qcom: sa8775p: pmic: add thermal zonesarch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi+112 -01 reply
12/18dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpioDocumentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml+2 -03 replies
13/18pinctrl: qcom: spmi-gpio: add support for pmm8654au-gpiodrivers/pinctrl/qcom/pinctrl-spmi-gpio.c+1 -01 reply
14/18arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodesarch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi+40 -01 reply
15/18arm64: dts: qcom: sa8775p-ride: set gpio-line-names for PMIC GPIOsarch/arm64/boot/dts/qcom/sa8775p-ride.dts+51 -01 reply
16/18dt-bindings: regulator: qcom,rpmh: add compatible for pmm8654au RPMHDocumentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml+14 -01 reply
17/18regulator: qcom-rpmh: add support for pmm8654au regulatorsdrivers/regulator/qcom-rpmh-regulator.c+55 -01 reply
18/18arm64: dts: qcom: sa8775p-ride: add PMIC regulatorsarch/arm64/boot/dts/qcom/sa8775p-ride.dts+233 -01 reply

Reviews trailers per patch

16 of 18 patches have a Reviewed-by or Acked-by.

PatchKonrad DybcioRob HerringKrzysztof KozlowskiLinus Walleij
1/18R-b
2/18R-b
3/18A-b
4/18R-b
5/18R-b
6/18A-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18A-b A-b
13/18R-b A-b
14/18R-b
15/18R-b
16/18
17/18R-b
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/18] arm64: dts: qcom: sa8775p: add basic PMIC support

From: Bartosz Golaszewski <[email protected]>

This adds support for a number of PMIC functionalities on sa8775p. The PMIC used on the reference board is pm8654au which is another variant of the SPMI PMIC from Qualcomm with an automotive twist.

v2 -> v3:
- add GPIO line names for the PMIC GPIOs on sa8775p-ride
- add missing GPIO chips to the PMIC .dtsi
- add missing thermal zones and alerts
- add regulators (driver support and regulator settings for sa8775p-ride)
- add missing PDC mappings
- squash patches 7 and 8 to avoid adding code without users
- dropped Krzysztof's Ack from patch 3 as it now extends the max number of mappings so most likely needs a second look

v1 -> v2:
- improve DT coding style where needed
- don't disable the power button in PMIC's .dtsi
- add debounce time for pwrkey and resin inputs
- use the official PMIC's name in DT labels
- add reg-names property for the PON node
- add patches that tidy up the dtsi before the PMIC stuff

Bartosz Golaszewski (18):
arm64: dts: qcom: sa8775p: pad reg properties to 8 digits
arm64: dts: qcom: sa8775p: sort soc nodes by reg property
dt-bindings: interrupt-controller: qcom-pdc: add compatible for

    sa8775p
  arm64: dts: qcom: sa8775p: add the pdc node
  arm64: dts: qcom: sa8775p: add the spmi node
  dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au
  arm64: dts: qcom: sa8775p: add support for the on-board PMICs
  arm64: dts: qcom: sa8775p: add the Power On device node
  arm64: dts: qcom: sa8775p: pmic: add the power key
  arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN
    input
  arm64: dts: qcom: sa8775p: pmic: add thermal zones
  dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for
    pmm8654au-gpio

pinctrl: qcom: spmi-gpio: add support for pmm8654au-gpio
arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes
arm64: dts: qcom: sa8775p-ride: set gpio-line-names for PMIC GPIOs
dt-bindings: regulator: qcom,rpmh: add compatible for pmm8654au RPMH
regulator: qcom-rpmh: add support for pmm8654au regulators
arm64: dts: qcom: sa8775p-ride: add PMIC regulators

 .../interrupt-controller/qcom,pdc.yaml        |   3 +-
 .../bindings/mfd/qcom,spmi-pmic.yaml          |   1 +
 .../bindings/pinctrl/qcom,pmic-gpio.yaml      |   2 +
 .../regulator/qcom,rpmh-regulator.yaml        |  14 +
 arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi   | 211 ++++++++
 arch/arm64/boot/dts/qcom/sa8775p-ride.dts     | 285 +++++++++++
 arch/arm64/boot/dts/qcom/sa8775p.dtsi         | 465 ++++++++++--------
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c      |   1 +
 drivers/regulator/qcom-rpmh-regulator.c       |  55 +++
 9 files changed, 838 insertions(+), 199 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
Signature · 1 line
2.37.2