Skip to content

s390x: Add support for running guests without MSO/MSL

Nico Boehr kvm linux-s390 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest8 patches 3 repliesIn review
  2. v78 patches 16 repliesSuperseded
  3. v68 patches 10 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v56 patches29 repliesSuperseded
v46 patches1 replySuperseded
v36 patches19 repliesSuperseded
v26 patches8 repliesSuperseded
v14 patches15 repliesSuperseded

Changes in v8 from the cover letter

---
* pick up several r-bs
* fix kerneldoc style (thanks Claudio)
* assert no pgm int code is there before entering SIE (thanks Janosch)
* do not reference future commit (thanks Janosch)
* check fauling address in TEID (thanks Claudio)
* test_page -> test_pages (thanks Claudio)
* add memory barriers (thanks Heiko)

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8lib: s390x: introduce bitfield for PSW masklib/s390x/asm/arch_def.h s390x/selftest.c+58 -10 replies
2/8s390x: add function to set DAT mode for all interruptslib/s390x/asm/arch_def.h lib/s390x/asm/interrupt.h lib/s390x/interrupt.c +1 more+46 -60 replies
3/8s390x: sie: switch to home space mode before entering SIElib/s390x/asm/arch_def.h lib/s390x/sie.c+27 -00 replies
4/8s390x: lib: don't forward PSW when handling exception in SIElib/s390x/interrupt.c+1 -00 replies
5/8s390x: lib: sie: don't reenter SIE on pgm intlib/s390x/asm/interrupt.h lib/s390x/asm/mem.h lib/s390x/sie.c+21 -11 reply
6/8s390x: add test source dir to include pathss390x/Makefile+1 -10 replies
7/8s390x: add a test for SIE without MSO/MSLs390x/Makefile s390x/sie-dat.c s390x/snippets/c/sie-dat.c +2 more+175 -02 replies
8/8lib: s390x: interrupt: remove TEID_ASCE defineslib/s390x/asm/interrupt.h+0 -50 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJanosch FrankClaudio ImbrendaThomas Huth
1/8R-b R-b R-b
2/8R-b R-b R-b
3/8R-b R-b R-b
4/8R-b R-b
5/8R-b R-b R-b
6/8R-b R-b R-b
7/8R-b R-b R-b
8/8R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [kvm-unit-tests PATCH v8 0/8] s390x: Add support for running guests without MSO/MSL

v8:
---
* pick up several r-bs
* fix kerneldoc style (thanks Claudio)
* assert no pgm int code is there before entering SIE (thanks Janosch)
* do not reference future commit (thanks Janosch)
* check fauling address in TEID (thanks Claudio)
* test_page -> test_pages (thanks Claudio)
* add memory barriers (thanks Heiko)

v7:
---
* pick up r-bs
* fixup unneeded linebreak (thanks Janosch)
* remove outdated comments (thanks Janosch)
* remove unneeded includes (thanks Janosch)

v6:
---
* add commit "s390x: add test source dir to include paths" and share define with number of pages between snippet and test (Thomas)
* add commit "lib: s390x: interrupt: remove TEID_ASCE defines"
* rename dat -> use_dat (thanks Thomas)
* remove IRQ_DAT_ON/_OFF defines (thanks Thomas)
* add a comment to explain why we switch to home space when entering SIE (thanks Thomas)
* clarify register_ext_cleanup_func() doesn't touch address space mode when DAT is off (thanks Thomas)
* convert address space defines to enum (thanks Thomas)
* switch bitfield member to uint64_t (thanks Claudio)
* upercase hex number
* in selftest, set the bitfield value to a define and then assert on the bitfield (thanks Thomas)

v5:
---
* fix a big oopsie in irq_set_dat_mode() which caused parts of lowcore being overwritten (thanks Claudio)

v4:
---
- add static assert for PSW bitfield (Janosch, Claudio)
- remove unneeded includes (Janosch)
- move variable decls to function start (Janosch)
- remove unneeded imports (Janosch)
- lowerocase hex (Janosch)
- remove unneeded attr (Janosch)
- tyop :-) fixes (Janosch)

v3:
---
* introduce bitfield for the PSW to make handling less clumsy
* some variable renames (Claudio)
* remove unneeded barriers (Claudio)
* remove rebase leftover sie_had_pgm_int (Claudio)
* move read_pgm_int_code to header (Claudio)
* squash include fix commit into the one causing the issue (Claudio)

v2:
---
* add function to change DAT/AS mode for all irq handlers (Janosch, Claudio)
* instead of a new flag in PROG0C, check the pgm int code in lowcore (Janosch)
* fix indents, comments (Nina)

Right now, all SIE tests in kvm-unit-tests (i.e. where kvm-unit-test is the hypervisor) run using MSO/MSL.

This is convenient, because it's simple. But it also comes with disadvantages, for example some features are unavailabe with MSO/MSL.

This series adds support for running guests without MSO/MSL with dedicated guest page tables for the GPA->HPA translation.

Since SIE implicitly uses the primary space mode for the guest, the host can't run in the primary space mode, too. To avoid moving all tests to the home space mode, only switch to home space mode when it is actually needed.

This series also comes with various bugfixes that were caught while develoing this.

Nico Boehr (8):
lib: s390x: introduce bitfield for PSW mask
s390x: add function to set DAT mode for all interrupts
s390x: sie: switch to home space mode before entering SIE
s390x: lib: don't forward PSW when handling exception in SIE
s390x: lib: sie: don't reenter SIE on pgm int
s390x: add test source dir to include paths
s390x: add a test for SIE without MSO/MSL
lib: s390x: interrupt: remove TEID_ASCE defines

 lib/s390x/asm/arch_def.h   |  36 ++++++++++--
 lib/s390x/asm/interrupt.h  |  21 +++++--
 lib/s390x/asm/mem.h        |   1 +
 lib/s390x/interrupt.c      |  36 ++++++++++++
 lib/s390x/mmu.c            |   5 +-
 lib/s390x/sie.c            |  33 ++++++++++-
 s390x/Makefile             |   4 +-
 s390x/selftest.c           |  34 ++++++++++++
 s390x/sie-dat.c            | 111 +++++++++++++++++++++++++++++++++++++
 s390x/snippets/c/sie-dat.c |  57 +++++++++++++++++++
 s390x/snippets/c/sie-dat.h |   2 +
 s390x/unittests.cfg        |   3 +
 12 files changed, 329 insertions(+), 14 deletions(-)
 create mode 100644 s390x/sie-dat.c
 create mode 100644 s390x/snippets/c/sie-dat.c
 create mode 100644 s390x/snippets/c/sie-dat.h
Signature · 1 line
2.41.0