Skip to content

Interrupt cleanup and future-proofing

Matt Roper intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 3 repliesIn review
  2. v18 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/xe/irq: Drop gen3_ prefixesdrivers/gpu/drm/xe/xe_irq.c+20 -220 replies
2/8drm/xe/irq: Add helpers to find ISR/IIR/IMR/IER registersdrivers/gpu/drm/xe/regs/xe_regs.h drivers/gpu/drm/xe/xe_irq.c+22 -211 reply
3/8drm/xe/irq: Drop IRQ_INIT and IRQ_RESET macrosdrivers/gpu/drm/xe/xe_irq.c+32 -311 reply
4/8drm/xe/irq: Drop unnecessary GEN11_ and GEN12_ register prefixesdrivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/regs/xe_regs.h drivers/gpu/drm/xe/xe_display.c +2 more+86 -871 reply
5/8drm/xe/irq: Rename and clarify top-level interrupt handling routinesdrivers/gpu/drm/xe/xe_irq.c+24 -220 replies
6/8drm/xe/irq: Drop remaining "gen11_" prefix from IRQ functionsdrivers/gpu/drm/xe/xe_irq.c+22 -240 replies
7/8drm/xe/irq: Drop commented-out code for non-existent media enginesdrivers/gpu/drm/xe/xe_irq.c+0 -120 replies
8/8drm/xe/irq: Don't clobber display interrupts on multi-tile platformsdrivers/gpu/drm/xe/xe_irq.c+11 -30 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchLucas De Marchi
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-xe] [PATCH v2 0/8] Interrupt cleanup and future-proofing

A lot of the interrupt code in the Xe driver was copied directly from i915. Since Xe only supports Xe_LP and later platforms, there's some cleanup and simplification that can be done.

Also fix one mistake that would have become a bug in the future if we ever wind up with a multi-tile platform that also supports display.

Cc Lucas De Marchi <[email protected]>

Matt Roper (8):
drm/xe/irq: Drop gen3_ prefixes
drm/xe/irq: Add helpers to find ISR/IIR/IMR/IER registers drm/xe/irq: Drop IRQ_INIT and IRQ_RESET macros drm/xe/irq: Drop unnecessary GEN11_ and GEN12_ register prefixes drm/xe/irq: Rename and clarify top-level interrupt handling routines drm/xe/irq: Drop remaining "gen11_" prefix from IRQ functions drm/xe/irq: Drop commented-out code for non-existent media engines drm/xe/irq: Don't clobber display interrupts on multi-tile platforms

 drivers/gpu/drm/xe/regs/xe_gt_regs.h |  42 ++--
 drivers/gpu/drm/xe/regs/xe_regs.h    |  25 +--
 drivers/gpu/drm/xe/xe_display.c      |   4 +-
 drivers/gpu/drm/xe/xe_guc.c          |   6 +-
 drivers/gpu/drm/xe/xe_irq.c          | 288 ++++++++++++++-------------
 5 files changed, 180 insertions(+), 185 deletions(-)
Signature · 1 line
2.39.2