Skip to content

target/riscv, KVM: fixes and enhancements

Daniel Henrique Barboza qemu-devel qemu-riscv 9 versions – Applied

Status from this message: Applied to riscv-to-apply.next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest20 patches 15 repliesApplied
  2. v820 patches 6 repliesSuperseded
  3. v720 patches 5 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v620 patches17 repliesSuperseded
v519 patches9 repliesSuperseded
v419 patches1 replySuperseded
v319 patches11 repliesSuperseded
v218 patches17 repliesSuperseded
v116 patches31 repliesSuperseded

Changes in v9 from the cover letter

- patch 2:
- fix device-tree binding link in commit message
- patch 14:
- use EINVAL instead of ENOENT
v8 link: https://lore.kernel.org/qemu-devel/20230706-38ab9f9705448bb10413f1af@orel/T/#m1c889304847598789db313f3e0854ed0d41ce60c

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/20target/riscv: skip features setup for KVM CPUstarget/riscv/cpu.c+25 -101 reply
2/20hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not sethw/riscv/virt.c+7 -70 replies
3/20target/riscv/cpu.c: restrict 'mvendorid' valuetarget/riscv/cpu.c+37 -10 replies
4/20target/riscv/cpu.c: restrict 'mimpid' valuetarget/riscv/cpu.c+32 -20 replies
5/20target/riscv/cpu.c: restrict 'marchid' valuetarget/riscv/cpu.c+53 -70 replies
6/20target/riscv: use KVM scratch CPUs to init KVM propertiestarget/riscv/cpu.c target/riscv/kvm.c target/riscv/kvm_riscv.h+92 -00 replies
7/20target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids()target/riscv/kvm.c+16 -00 replies
8/20target/riscv: handle mvendorid/marchid/mimpid for KVM CPUstarget/riscv/kvm.c+31 -00 replies
9/20linux-headers: Update to v6.4-rc1include/standard-headers/linux/const.h include/standard-headers/linux/virtio_blk.h include/standard-headers/linux/virtio_config.h +11 more+149 -160 replies
10/20target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPUtarget/riscv/kvm.c+23 -110 replies
11/20target/riscv/cpu: add misa_ext_info_arr[]target/riscv/cpu.c target/riscv/cpu.h+88 -291 reply
12/20target/riscv: add KVM specific MISA propertiestarget/riscv/cpu.c target/riscv/kvm.c+83 -01 reply
13/20target/riscv/kvm.c: update KVM MISA bitstarget/riscv/kvm.c+40 -01 reply
14/20target/riscv/kvm.c: add multi-letter extension KVM propertiestarget/riscv/cpu.c target/riscv/kvm.c+127 -04 replies
15/20target/riscv/cpu.c: add satp_mode properties earliertarget/riscv/cpu.c+2 -41 reply
16/20target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext()target/riscv/cpu.c+1 -21 reply
17/20target/riscv/cpu.c: create KVM mock propertiestarget/riscv/cpu.c+36 -01 reply
18/20target/riscv: update multi-letter extension KVM propertiestarget/riscv/kvm.c+27 -01 reply
19/20target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helpertarget/riscv/kvm.c+7 -41 reply
20/20target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVMtarget/riscv/kvm.c+70 -01 reply

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchAndrew JonesAlistair FrancisPhilippe Mathieu-Daudé
1/20R-b R-b
2/20R-b R-b R-b
3/20R-b R-b
4/20R-b R-b
5/20R-b R-b
6/20R-b A-b
7/20R-b A-b
8/20R-b A-b
9/20A-b
10/20R-b A-b
11/20R-b R-b R-b
12/20R-b R-b
13/20R-b A-b
14/20R-b A-b
15/20R-b R-b R-b
16/20R-b R-b
17/20R-b R-b
18/20R-b R-b
19/20R-b R-b
20/20R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [PATCH v9 00/20] target/riscv, KVM: fixes and enhancements

Hi,

In this version we dialed back from our design decision in patch 14, returning to the design we've been using since the first version. The rationale behind is that we can't get rid of EINVAL since it will break extension for all other KVM versions prior to this one where we're adding the first version of the KVM specific capabilities. We'll switch later on for get-reg-list when it's available, but for now we're stuck with EINVAL. Drew provided a detailed explanation here:

https://lore.kernel.org/qemu-devel/20230706-38ab9f9705448bb10413f1af@orel/T/#m75a5323e76518c02598758fdd6a8943951812875

As a bonus I also fixed the device-tree binding link satp in patch 2 like Connor suggested.

I believe we're ready to go.

Patches missing review: 14

Changes from v8:
- patch 2:
- fix device-tree binding link in commit message
- patch 14:
- use EINVAL instead of ENOENT
v8 link: https://lore.kernel.org/qemu-devel/20230706-38ab9f9705448bb10413f1af@orel/T/#m1c889304847598789db313f3e0854ed0d41ce60c

Daniel Henrique Barboza (20):
target/riscv: skip features setup for KVM CPUs hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set target/riscv/cpu.c: restrict 'mvendorid' value target/riscv/cpu.c: restrict 'mimpid' value target/riscv/cpu.c: restrict 'marchid' value
target/riscv: use KVM scratch CPUs to init KVM properties target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids() target/riscv: handle mvendorid/marchid/mimpid for KVM CPUs
linux-headers: Update to v6.4-rc1
target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU target/riscv/cpu: add misa_ext_info_arr[]
target/riscv: add KVM specific MISA properties target/riscv/kvm.c: update KVM MISA bits target/riscv/kvm.c: add multi-letter extension KVM properties target/riscv/cpu.c: add satp_mode properties earlier target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext() target/riscv/cpu.c: create KVM mock properties target/riscv: update multi-letter extension KVM properties target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM

 hw/riscv/virt.c                               |  14 +-
 include/standard-headers/linux/const.h        |   2 +-
 include/standard-headers/linux/virtio_blk.h   |  18 +-
 .../standard-headers/linux/virtio_config.h    |   6 +
 include/standard-headers/linux/virtio_net.h   |   1 +
 linux-headers/asm-arm64/kvm.h                 |  33 ++
 linux-headers/asm-riscv/kvm.h                 |  53 +-
 linux-headers/asm-riscv/unistd.h              |   9 +
 linux-headers/asm-s390/unistd_32.h            |   1 +
 linux-headers/asm-s390/unistd_64.h            |   1 +
 linux-headers/asm-x86/kvm.h                   |   3 +
 linux-headers/linux/const.h                   |   2 +-
 linux-headers/linux/kvm.h                     |  12 +-
 linux-headers/linux/psp-sev.h                 |   7 +
 linux-headers/linux/userfaultfd.h             |  17 +-
 target/riscv/cpu.c                            | 341 ++++++++++--
 target/riscv/cpu.h                            |   7 +-
 target/riscv/kvm.c                            | 499 +++++++++++++++++-
 target/riscv/kvm_riscv.h                      |   1 +
 19 files changed, 940 insertions(+), 87 deletions(-)
Signature · 1 line
2.41.0