misc: Enforce .[ch].inc extension for re-included .c/.h files
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 2 repliesIn review
- v15 patches 13 repliesSuperseded
Changes in v2 from the cover letter
- addressed Richard's easy review comments
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | hw/remote/proxy: Remove dubious 'event_notifier-posix.c' includehw/ | +0 | 1 reply | |
| 2/5 | tests/tcg/aarch64: Rename bti-crt.inc.c -> bti-crt.c.inctests/ tests/ tests/ | +2 | 0 replies | |
| 3/5 | target/arm: Rename helper template headers as '.h.inc'target/ target/ target/ +2 more | +4 | 0 replies | |
| 4/5 | target/i386: Rename helper template headers as '.h.inc'target/ target/ target/ +3 more | +11 | 0 replies | |
| 5/5 | target: Bulk rename 'helper.h' -> 'helper.h.inc' for all targetsinclude/ include/ target/ +41 more | +23 | 1 reply |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson | Alex Bennée |
|---|---|---|
| 1/5 | ||
| 2/5 | R-b | R-b |
| 3/5 | R-b | |
| 4/5 | R-b | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] misc: Enforce .[ch].inc extension for re-included .c/.h files
Since v1:
- addressed Richard's easy review comments
Richard, this is what I had before looking at removing exec/helper*. Posting in case it is useful enough before getting there.
--
Follow the convention to use the .inc extension for .c/.h files re-included, as docummented in Coding Style since commit 6a0057aa22:
If you do use template header files they should be named with the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are being included for expansion.
Most of the codebase already uses this extension:
$ git ls-files | fgrep .inc | wc -l
155Rename some files left over.
Philippe Mathieu-Daudé (5):
hw/remote/proxy: Remove dubious 'event_notifier-posix.c' include tests/tcg/aarch64: Rename bti-crt.inc.c -> bti-crt.c.inc target/arm: Rename helper template headers as '.h.inc' target/i386: Rename helper template headers as '.h.inc'
target: Bulk rename 'helper.h' -> 'helper.h.inc' for all targets
include/exec/helper-gen.h | 2 +-
include/exec/helper-proto.h | 2 +-
target/alpha/{helper.h => tcg/helper.h.inc} | 0
target/arm/tcg/{helper-a64.h => helper-a64.h.inc} | 0
target/arm/tcg/{helper-mve.h => helper-mve.h.inc} | 0
target/arm/tcg/{helper-sme.h => helper-sme.h.inc} | 0
target/arm/tcg/{helper-sve.h => helper-sve.h.inc} | 0
target/arm/{helper.h => tcg/helper.h.inc} | 8 ++++----
target/avr/{helper.h => tcg/helper.h.inc} | 0
target/cris/{helper.h => tcg/helper.h.inc} | 0
target/hexagon/{helper.h => tcg/helper.h.inc} | 0
target/hppa/{helper.h => tcg/helper.h.inc} | 0
.../{cc_helper_template.h => cc_helper_template.h.inc} | 0
target/i386/{helper.h => tcg/helper.h.inc} | 6 +++---
.../i386/{ops_sse_header.h => tcg/ops_sse_header.h.inc} | 0
.../shift_helper_template.h.inc} | 0
target/loongarch/{helper.h => tcg/helper.h.inc} | 0
target/m68k/{helper.h => tcg/helper.h.inc} | 0
target/microblaze/{helper.h => tcg/helper.h.inc} | 0
target/mips/{helper.h => tcg/helper.h.inc} | 0
target/nios2/{helper.h => tcg/helper.h.inc} | 0
target/openrisc/{helper.h => tcg/helper.h.inc} | 0
target/ppc/{helper.h => tcg/helper.h.inc} | 0
target/riscv/{helper.h => tcg/helper.h.inc} | 0
target/rx/{helper.h => tcg/helper.h.inc} | 0
target/s390x/{helper.h => tcg/helper.h.inc} | 0
target/sh4/{helper.h => tcg/helper.h.inc} | 0
target/sparc/{helper.h => tcg/helper.h.inc} | 0
target/tricore/{helper.h => tcg/helper.h.inc} | 0
target/xtensa/{helper.h => tcg/helper.h.inc} | 0
hw/remote/proxy.c | 1 -
target/alpha/translate.c | 2 +-
target/arm/tcg/translate.c | 2 +-
target/avr/translate.c | 2 +-
target/cris/translate.c | 2 +-
target/hexagon/translate.c | 2 +-
target/hppa/translate.c | 2 +-
target/i386/tcg/cc_helper.c | 8 ++++----
target/i386/tcg/int_helper.c | 8 ++++----
target/i386/tcg/translate.c | 2 +-
target/loongarch/translate.c | 2 +-
target/m68k/translate.c | 2 +-
target/microblaze/translate.c | 2 +-
target/mips/tcg/translate.c | 2 +-
target/nios2/translate.c | 2 +-
target/openrisc/translate.c | 2 +-
target/ppc/translate.c | 2 +-
target/riscv/translate.c | 2 +-
target/rx/translate.c | 2 +-
target/s390x/tcg/translate.c | 2 +-
target/sh4/translate.c | 2 +-
target/sparc/translate.c | 2 +-
target/tricore/translate.c | 2 +-
target/xtensa/translate.c | 2 +-
tests/tcg/aarch64/bti-1.c | 2 +-
tests/tcg/aarch64/bti-3.c | 2 +-
tests/tcg/aarch64/{bti-crt.inc.c => bti-crt.c.inc} | 0
57 files changed, 40 insertions(+), 41 deletions(-)
rename target/alpha/{helper.h => tcg/helper.h.inc} (100%)
rename target/arm/tcg/{helper-a64.h => helper-a64.h.inc} (100%)
rename target/arm/tcg/{helper-mve.h => helper-mve.h.inc} (100%)
rename target/arm/tcg/{helper-sme.h => helper-sme.h.inc} (100%)
rename target/arm/tcg/{helper-sve.h => helper-sve.h.inc} (100%)
rename target/arm/{helper.h => tcg/helper.h.inc} (99%)
rename target/avr/{helper.h => tcg/helper.h.inc} (100%)
rename target/cris/{helper.h => tcg/helper.h.inc} (100%)
rename target/hexagon/{helper.h => tcg/helper.h.inc} (100%)
rename target/hppa/{helper.h => tcg/helper.h.inc} (100%)
rename target/i386/tcg/{cc_helper_template.h => cc_helper_template.h.inc} (100%)
rename target/i386/{helper.h => tcg/helper.h.inc} (98%)
rename target/i386/{ops_sse_header.h => tcg/ops_sse_header.h.inc} (100%)
rename target/i386/{shift_helper_template.h => tcg/shift_helper_template.h.inc} (100%)
rename target/loongarch/{helper.h => tcg/helper.h.inc} (100%)
rename target/m68k/{helper.h => tcg/helper.h.inc} (100%)
rename target/microblaze/{helper.h => tcg/helper.h.inc} (100%)
rename target/mips/{helper.h => tcg/helper.h.inc} (100%)
rename target/nios2/{helper.h => tcg/helper.h.inc} (100%)
rename target/openrisc/{helper.h => tcg/helper.h.inc} (100%)
rename target/ppc/{helper.h => tcg/helper.h.inc} (100%)
rename target/riscv/{helper.h => tcg/helper.h.inc} (100%)
rename target/rx/{helper.h => tcg/helper.h.inc} (100%)
rename target/s390x/{helper.h => tcg/helper.h.inc} (100%)
rename target/sh4/{helper.h => tcg/helper.h.inc} (100%)
rename target/sparc/{helper.h => tcg/helper.h.inc} (100%)
rename target/tricore/{helper.h => tcg/helper.h.inc} (100%)
rename target/xtensa/{helper.h => tcg/helper.h.inc} (100%)
rename tests/tcg/aarch64/{bti-crt.inc.c => bti-crt.c.inc} (100%)Signature · 1 line
2.38.1