Skip to content

virtio_net: add per queue interrupt coalescing support

Gavin Li bpf lkml netdev 6 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 0 repliesApplied 3/3
  2. v43 patches 6 repliesSuperseded
  3. v34 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v24 patches6 repliesSuperseded
v1 posting 2/24 patches2 repliesSuperseded
v1 posting 1/24 patches13 repliesSuperseded

Changes in v5 from the cover letter

- Addressed the comment From Paolo Abeni
- Update comment for the range of queues to be updated according to current code
---
virtio_net: enable per queue interrupt coalesce feature

Patches in v5 All 3 applied

#Subject and filesSizeRepliesApplied
1/3virtio_net: extract interrupt coalescing settings to a structuredrivers/net/virtio_net.c+19 -160 repliesApplied
2/3virtio_net: support per queue interrupt coalesce commanddrivers/net/virtio_net.c include/uapi/linux/virtio_net.h+155 -80 repliesApplied
3/3virtio_net: enable per queue interrupt coalesce featuredrivers/net/virtio_net.c+3 -00 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDragos TatuleaJiri PirkoJason WangMichael S. TsirkinHeng Qi
1/3R-b R-b A-b A-b R-b
2/3R-b R-b A-b A-b R-b
3/3R-b R-b A-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH net-next V5 0/3] virtio_net: add per queue interrupt coalescing support

Currently, coalescing parameters are grouped for all transmit and receive virtqueues. This patch series add support to set or get the parameters for a specified virtqueue.

When the traffic between virtqueues is unbalanced, for example, one virtqueue is busy and another virtqueue is idle, then it will be very useful to control coalescing parameters at the virtqueue granularity.

Example command:

$ ethtool -Q eth5 queue_mask 0x1 --coalesce tx-packets 10
Would set max_packets=10 to VQ 1.
$ ethtool -Q eth5 queue_mask 0x1 --coalesce rx-packets 10
Would set max_packets=10 to VQ 0.
$ ethtool -Q eth5 queue_mask 0x1 --show-coalesce
 Queue: 0
 Adaptive RX: off  TX: off
 stats-block-usecs: 0
 sample-interval: 0
 pkt-rate-low: 0
 pkt-rate-high: 0

rx-usecs: 222
rx-frames: 0
rx-usecs-irq: 0
rx-frames-irq: 256

tx-usecs: 222
tx-frames: 0
tx-usecs-irq: 0
tx-frames-irq: 256

rx-usecs-low: 0
rx-frame-low: 0
tx-usecs-low: 0
tx-frame-low: 0

rx-usecs-high: 0
rx-frame-high: 0
tx-usecs-high: 0
tx-frame-high: 0

Gavin Li (3):
virtio_net: extract interrupt coalescing settings to a structure
virtio_net: support per queue interrupt coalesce command
---
changelog:
v1->v2
- Addressed the comment from Xuan Zhuo
- Allocate memory from heap instead of using stack memory for control vq messages
v2->v3
- Addressed the comment from Heng Qi
- Use control_buf for control vq messages
v3->v4
- Addressed the comment from Michael S. Tsirkin
- Refactor set_coalesce of both per queue and global config that were littered with if/else branches
v4->v5
- Addressed the comment From Paolo Abeni
- Update comment for the range of queues to be updated according to current code
---
virtio_net: enable per queue interrupt coalesce feature

 drivers/net/virtio_net.c        | 187 ++++++++++++++++++++++++++++----
 include/uapi/linux/virtio_net.h |  14 +++
 2 files changed, 177 insertions(+), 24 deletions(-)
Signature · 1 line
2.39.1