Skip to content

Enable loading local and third party keys on PowerVM guest

Nayna Jain linux-integrity linux-security-module linuxppc-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 11 repliesIn review
  2. v36 patches 5 repliesSuperseded
  3. v26 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches6 repliesSuperseded

Changes in v4 from the cover letter

* Fixed build error reported by Nageswara R Sastry <[email protected]>, as part of his testing of patches.
* Included Jarkko's and Mimi's feedback

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6integrity: PowerVM support for loading CA keys on machine keyringsecurity/integrity/platform_certs/keyring_handler.c security/integrity/platform_certs/keyring_handler.h security/integrity/platform_certs/load_powerpc.c+30 -02 replies
2/6integrity: ignore keys failing CA restrictions on non-UEFI platformsecurity/integrity/platform_certs/machine_keyring.c+1 -11 reply
3/6integrity: remove global variable from machine_keyring.csecurity/integrity/platform_certs/machine_keyring.c+2 -21 reply
4/6integrity: check whether imputed trust is enabledsecurity/integrity/digsig.c security/integrity/integrity.h security/integrity/platform_certs/keyring_handler.c +1 more+22 -61 reply
5/6integrity: PowerVM machine keyring enablementsecurity/integrity/Kconfig+3 -11 reply
6/6integrity: PowerVM support for loading third party code signing keyscerts/system_keyring.c include/keys/system_keyring.h security/integrity/platform_certs/keyring_handler.c +2 more+64 -05 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchMimi ZoharJarkko SakkinenNageswara R Sastry
1/6Reviewed-and-tested-by R-b T-b
2/6Reviewed-and-tested-by A-b T-b
3/6Reviewed-and-tested-by R-b T-b
4/6Reviewed-off-by T-b
5/6Reviewed-and-tested-by R-b T-b
6/6Reviewed-and-tested-by R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/6] Enable loading local and third party keys on PowerVM guest

On a secure boot enabled PowerVM guest, local and third party code signing keys are needed to verify signed applications, configuration files, and kernel modules.

Loading these keys onto either the .secondary_trusted_keys or .ima keyrings requires the certificates be signed by keys on the .builtin_trusted_keys, .machine or .secondary_trusted_keys keyrings.

Keys on the .builtin_trusted_keys keyring are trusted because of the chain of trust from secure boot up to and including the linux kernel. Keys on the .machine keyring that derive their trust from an entity such as a security officer, administrator, system owner, or machine owner are said to have "imputed trust." The type of certificates and the mechanism for loading them onto the .machine keyring is platform dependent.

Userspace may load certificates onto the .secondary_trusted_keys or .ima keyrings. However, keys may also need to be loaded by the kernel if they are needed for verification in early boot time. On PowerVM guest, third party code signing keys are loaded from the moduledb variable in the Platform KeyStore(PKS) onto the .secondary_trusted_keys.

The purpose of this patch set is to allow loading of local and third party code signing keys on PowerVM.

Changelog:

v4:

* Fixed build error reported by Nageswara R Sastry <[email protected]>, as part of his testing of patches.
* Included Jarkko's and Mimi's feedback

v3:

* Included Jarkko's feedback for Patch 6/6.

v2:

* Patch 5/6: Update CA restriction to allow only key signing CA's.
* Rebase on Jarkko's master tree - https://kernel.googlesource.com/pub/scm/linux/kernel/git/jarkko/linux-tpmdd
* Tested after reverting cfa7522f280aa95 because of build failure due to
this commit.

Nayna Jain (6):
integrity: PowerVM support for loading CA keys on machine keyring
integrity: ignore keys failing CA restrictions on non-UEFI platform
integrity: remove global variable from machine_keyring.c
integrity: check whether imputed trust is enabled
integrity: PowerVM machine keyring enablement
integrity: PowerVM support for loading third party code signing keys

 certs/system_keyring.c                        | 30 ++++++++++++++++
 include/keys/system_keyring.h                 |  4 +++
 security/integrity/Kconfig                    |  4 ++-
 security/integrity/digsig.c                   |  2 +-
 security/integrity/integrity.h                |  5 +--
 .../platform_certs/keyring_handler.c          | 19 ++++++++++-
 .../platform_certs/keyring_handler.h          | 10 ++++++
 .../integrity/platform_certs/load_powerpc.c   | 34 +++++++++++++++++++
 .../platform_certs/machine_keyring.c          | 22 +++++++++---
 9 files changed, 121 insertions(+), 9 deletions(-)
Signature · 1 line
2.31.1