Skip to content

Enable vdpa net migration with features depending on CVQ

Eugenio Pérez qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v25 patches 8 repliesSuperseded
  3. v17 patches 3 repliesSuperseded

Changes in v3 from the cover letter

* Fix subject typo and expand message of patch ("vdpa: move vhost_vdpa_set_vring_ready to the caller").

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5vdpa: use first queue SVQ state for CVQ defaultnet/vhost-vdpa.c+1 -10 replies
2/5vdpa: export vhost_vdpa_set_vring_readyhw/virtio/trace-events hw/virtio/vhost-vdpa.c include/hw/virtio/vhost-vdpa.h+15 -130 replies
3/5vdpa: rename vhost_vdpa_net_load to vhost_vdpa_net_cvq_loadnet/vhost-vdpa.c+2 -20 replies
4/5vdpa: move vhost_vdpa_set_vring_ready to the callerhw/virtio/vdpa-dev.c hw/virtio/vhost-vdpa.c net/vhost-vdpa.c+42 -211 reply
5/5vdpa: remove net cvq migration blockernet/vhost-vdpa.c+0 -120 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJason WangLei Yang
SeriesT-b
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] Enable vdpa net migration with features depending on CVQ

At this moment the migration of net features that depends on CVQ is not possible, as there is no reliable way to restore the device state like mac address, number of enabled queues, etc to the destination. This is mainly caused because the device must only read CVQ, and process all the commands before resuming the dataplane.

This series lift that requirement, sending the VHOST_VDPA_SET_VRING_ENABLE ioctl for dataplane vqs only after the device has processed all commands.
---
v3:
* Fix subject typo and expand message of patch ("vdpa: move vhost_vdpa_set_vring_ready to the caller").

v2:
* Factor out VRING_ENABLE ioctls from vhost_vdpa_dev_start to the caller, instead of providing a callback to know if it must be called or not.
* at https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg05447.html

RFC:
* Enable vqs early in case CVQ cannot be shadowed.
* at https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg01325.html

Eugenio Pérez (5):
vdpa: use first queue SVQ state for CVQ default
vdpa: export vhost_vdpa_set_vring_ready
vdpa: rename vhost_vdpa_net_load to vhost_vdpa_net_cvq_load
vdpa: move vhost_vdpa_set_vring_ready to the caller
vdpa: remove net cvq migration blocker

 include/hw/virtio/vhost-vdpa.h |  1 +
 hw/virtio/vdpa-dev.c           |  3 ++
 hw/virtio/vhost-vdpa.c         | 22 +++++-----
 net/vhost-vdpa.c               | 75 +++++++++++++++++++---------------
 hw/virtio/trace-events         |  2 +-
 5 files changed, 57 insertions(+), 46 deletions(-)
Signature · 1 line
2.39.3