Small fixes and cleanups (ov2740 and ccs)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest19 patches 6 repliesIn review
- v613 patches 2 repliesSuperseded
- v513 patches 0 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 12 patches | 6 replies | Superseded | |
| v3 | 12 patches | 12 replies | Superseded | |
| v2 | 12 patches | 15 replies | Superseded | |
| v1 | 7 patches | 25 replies | Superseded |
Changes in v7 from the cover letter
- New patch: In scope of the CCS driver, revert the patch moving CCS to use pm_runtime_get_and_resume().
- New patch: Drop s_stream re-entrancy in CCS driver.
- New patch: Rename ccs_create_subdev() as ccs_init_subdev.
- New patch: CCS driver rework: move sub-device initialisation earlier in probe to address initialisation ordering issues later on in embedded data support. This introduces minor changes to the patch adding sub-device state support.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | media: Documentation: Align numbered list, make it a proper ReSTDocumentation/ | +24 | 0 replies | |
| 2/19 | media: ccs: Fix driver quirk struct documentationdrivers/ | +1 | 0 replies | |
| 3/19 | media: ccs: Correctly initialise try compose rectangledrivers/ | +1 | 0 replies | |
| 4/19 | media: ccs: Correct error handling in ccs_register_subdevdrivers/ | +10 | 0 replies | |
| 5/19 | media: ccs: Switch to init_cfgdrivers/ | +6 | 0 replies | |
| 6/19 | media: ccs: Rename ccs_create_subdev as ccs_init_subdevdrivers/ | +9 | 0 replies | |
| 7/19 | media: ccs: Move media_entity_pads_init to init from registerdrivers/ | +36 | 0 replies | |
| 8/19 | media: ccs: Obtain media bus formats before initialising up sub-devicesdrivers/ | +6 | 0 replies | |
| 9/19 | media: ccs: Use sub-device active statedrivers/ drivers/ | +104 | 0 replies | |
| 10/19 | media: ccs: Partially revert "media: i2c: Use pm_runtime_resume_and_get()"drivers/ | +3 | 0 replies | |
| 11/19 | media: ccs: Drop re-entrant s_stream supportdrivers/ | +0 | 0 replies | |
| 12/19 | media: ov2740: Enable runtime PM before registering the async subdevdrivers/ | +8 | 0 replies | |
| 13/19 | media: ov2740: Use sub-device active statedrivers/ | +42 | 0 replies | |
| 14/19 | media: ov2740: Return -EPROBE_DEFER if no endpoint is founddrivers/ | +1 | 0 replies | |
| 15/19 | media: v4l: subdev: Clear frame descriptor before get_frame_descdrivers/ drivers/ drivers/ +2 more | +9 | 0 replies | |
| 16/19 | media: v4l: subdev: Print debug information on frame descriptordrivers/ | +30 | 0 replies | |
| 17/19 | media: mc: Check pad flag validitydrivers/ | +14 | 5 replies | |
| 18/19 | media: Add MIPI CSI-2 generic long packet type definitioninclude/ | +1 | 0 replies | |
| 19/19 | media: Documentation: Split camera sensor documentationDocumentation/ Documentation/ Documentation/ +1 more | +147 | 0 replies |
Reviews trailers per patch
13 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Laurent Pinchart | Tomi Valkeinen | Jacopo Mondi |
|---|---|---|---|
| 1/19 | R-b | ||
| 2/19 | R-b | ||
| 3/19 | R-b | ||
| 4/19 | R-b | ||
| 5/19 | R-b | ||
| 6/19 | |||
| 7/19 | |||
| 8/19 | |||
| 9/19 | |||
| 10/19 | |||
| 11/19 | |||
| 12/19 | R-b | ||
| 13/19 | R-b | ||
| 14/19 | R-b | ||
| 15/19 | R-b | R-b | |
| 16/19 | R-b | ||
| 17/19 | R-b | ||
| 18/19 | R-b | ||
| 19/19 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v7 00/19] Small fixes and cleanups (ov2740 and ccs)
Hi folks,
This small set contains fixes and cleanups, mainly for the ccs and ov2740 drivers. I wrote these while working on the metadata set, but these could and should be merged earlier.
since v6:
- New patch: In scope of the CCS driver, revert the patch moving CCS to use pm_runtime_get_and_resume().
- New patch: Drop s_stream re-entrancy in CCS driver.
- New patch: Rename ccs_create_subdev() as ccs_init_subdev.
- New patch: CCS driver rework: move sub-device initialisation earlier in probe to address initialisation ordering issues later on in embedded data support. This introduces minor changes to the patch adding sub-device state support.
since v5:
- Send right patches (was v3 + an additional patch)!
since v4:
- Fix CCS driver active state patch --- media entity was initialised too late.
- Rebase on Laurent's ov2740 cleanups.
- Add a new patch for MIPI CSI-2 long packet types.
since v3:
- Don't print frame descriptor entry flags as strings but in a numeric form.
- Add a WARN_ON() for string truncation in printing the frame descriptor.
- Use 0 flag in printing hexadecimal values in frame descriptor instead of specifying precision.
- Add curly braces around a loop (11th patch).
since v2:
- Wrap init_cfg callback long line.
- Remove "pad_" from variable names in ccs_init_cfg.
- Fix media_entity_pads_init() error handling bug (was introduced in the last patch).
- Print frame descriptor in less verbose way.
since v1:
- Add a comment on ov2740 active state patch on serialising sensor access.
- Improved commit message of ov2740 patch enabling runtime PM earlier.
- Added patches for printing and zeroing frame descriptor, (debug) printing of frame descriptor, switching ccs to init_cfg and sub-device state and checking pad flag validity.
Sakari Ailus (19):
media: Documentation: Align numbered list, make it a proper ReST
media: ccs: Fix driver quirk struct documentation
media: ccs: Correctly initialise try compose rectangle
media: ccs: Correct error handling in ccs_register_subdev
media: ccs: Switch to init_cfg
media: ccs: Rename ccs_create_subdev as ccs_init_subdev
media: ccs: Move media_entity_pads_init to init from register
media: ccs: Obtain media bus formats before initialising up
sub-devices
media: ccs: Use sub-device active state
media: ccs: Partially revert "media: i2c: Use
pm_runtime_resume_and_get()"
media: ccs: Drop re-entrant s_stream support
media: ov2740: Enable runtime PM before registering the async subdev
media: ov2740: Use sub-device active state
media: ov2740: Return -EPROBE_DEFER if no endpoint is found
media: v4l: subdev: Clear frame descriptor before get_frame_desc
media: v4l: subdev: Print debug information on frame descriptor
media: mc: Check pad flag validity
media: Add MIPI CSI-2 generic long packet type definition
media: Documentation: Split camera sensor documentation
.../driver-api/media/camera-sensor.rst | 131 ++---- .../media/drivers/camera-sensor.rst | 104 +++++ .../userspace-api/media/drivers/index.rst | 1 + .../userspace-api/media/v4l/control.rst | 4 + .../userspace-api/media/v4l/dev-subdev.rst | 49 ++- drivers/media/i2c/ccs/ccs-core.c | 374 +++++++----------- drivers/media/i2c/ccs/ccs-quirk.h | 4 +- drivers/media/i2c/ccs/ccs.h | 4 +- drivers/media/i2c/ds90ub913.c | 2 - drivers/media/i2c/ds90ub953.c | 2 - drivers/media/i2c/ds90ub960.c | 2 - drivers/media/i2c/ov2740.c | 125 +++--- drivers/media/mc/mc-entity.c | 15 +- drivers/media/platform/nxp/imx-mipi-csis.c | 2 - drivers/media/v4l2-core/v4l2-subdev.c | 38 ++ include/media/mipi-csi2.h | 1 + 16 files changed, 422 insertions(+), 436 deletions(-) create mode 100644 Documentation/userspace-api/media/drivers/camera-sensor.rst
Signature · 1 line
2.39.2