Skip to content

Treewide: enable -Wmissing-prototypes

Arnd Bergmann linux-alpha linux-arch linux-kbuild linux-mips linux-mtd linux-sh linux-usb lkml sparclinux 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 2 repliesIn review 5 of 6 applied
  2. v120 of 22 patches 26 repliesApplied

Patches in v3 5 of 6 applied

#Subject and filesSizeRepliesApplied
1/6ida: make 'ida_dump' staticlib/test_ida.c+1 -10 repliesApplied
2/6jffs2: mark __jffs2_dbg_superblock_counts() staticfs/jffs2/debug.c+1 -10 repliesApplied
3/6sched: fair: move unused stub functions to headerkernel/sched/fair.c kernel/sched/sched.h+11 -130 repliesApplied
4/6x86: sta2x11: include header for sta2x11_get_instance() prototypearch/x86/pci/sta2x11-fixup.c+1 -00 repliesApplied
5/6usb: fsl-mph-dr-of: mark fsl_usb2_mpc5121_init() staticdrivers/usb/host/fsl-mph-dr-of.c+1 -10 repliesApplied
6/6Makefile.extrawarn: turn on missing-prototypes globallyscripts/Makefile.extrawarn+2 -22 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchTudor AmbarusZhihao ChengGreg Kroah-HartmanKees CookPalmer Dabbelt
1/6
2/6R-b R-b
3/6
4/6
5/6A-b
6/6R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/6] Treewide: enable -Wmissing-prototypes

From: Arnd Bergmann <[email protected]>

Hi Andrew,

I think all other patches I have sent for -Wmissing-prototypes have made it into linux-next by now, these ones either got an Ack from the respective maintainers, or never got a reply. I just merged a few patches from my previous series into the asm-generic tree, these are not in linux-next today but should be for the next next. I also resent the powerpc patches to make sure they get merged soon.

Can you pick these six up into -mm for v6.8?

Quoting from my description to patch 6/6:
"At this point, there are five architectures with a number of known
regressions: alpha, nios2, mips, sh and sparc. In the previous version of this patch, I had turned off the missing prototype warnings for the 15 architectures that still had issues, but since there are only five left, I think we can leave the rest to the maintainers (Cc'd here) as well."

The series is also likely to cause occasional build regressions on linux-next as developers add new code that misses prototypes. Hopefully this should be resolved by the time the patches make it into a release and everyone gets the warnings right away.

Arnd

Arnd Bergmann (6):
ida: make 'ida_dump' static
jffs2: mark __jffs2_dbg_superblock_counts() static
sched: fair: move unused stub functions to header
x86: sta2x11: include header for sta2x11_get_instance() prototype
usb: fsl-mph-dr-of: mark fsl_usb2_mpc5121_init() static Makefile.extrawarn: turn on missing-prototypes globally

 arch/x86/pci/sta2x11-fixup.c     |  1 +
 drivers/usb/host/fsl-mph-dr-of.c |  2 +-
 fs/jffs2/debug.c                 |  2 +-
 kernel/sched/fair.c              | 13 -------------
 kernel/sched/sched.h             | 11 +++++++++++
 lib/test_ida.c                   |  2 +-
 scripts/Makefile.extrawarn       |  4 ++--
 7 files changed, 17 insertions(+), 18 deletions(-)
Signature · 31 lines
2.39.2

Cc: "David S. Miller" <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Dinh Nguyen <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Ivan Kokshaysky <[email protected]>
Cc: John Paul Adrian Glaubitz <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: Matt Turner <[email protected]>
Cc: Nathan Chancellor <[email protected]>
Cc: Nicolas Schier <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Rich Felker <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Richard Weinberger <[email protected]>
Cc: Stephen Rothwell <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Cc: Tudor Ambarus <[email protected]>
Cc: Yoshinori Sato <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]