Skip to content

hw/riscv: fix leak, add more g_autofree

Daniel Henrique Barboza qemu-devel qemu-riscv 1 version Applied

Status from this message: Applied to riscv-to-apply.next

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 11 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7hw/riscv/virt-acpi-build.c: fix leak in build_rhct()hw/riscv/virt-acpi-build.c+1 -11 reply
2/7hw/riscv/numa.c: use g_autofree in socket_fdt_write_distance_matrix()hw/riscv/numa.c+2 -21 reply
3/7hw/riscv/virt.c: use g_autofree in create_fdt_socket_cpus()hw/riscv/virt.c+5 -72 replies
4/7hw/riscv/virt.c: use g_autofree in create_fdt_sockets()hw/riscv/virt.c+3 -61 reply
5/7hw/riscv/virt.c: use g_autofree in create_fdt_virtio()hw/riscv/virt.c+2 -32 replies
6/7hw/riscv/virt.c: use g_autofree in virt_machine_init()hw/riscv/virt.c+2 -32 replies
7/7hw/riscv/virt.c: use g_autofree in create_fdt_*hw/riscv/virt.c+22 -561 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéAlistair Francis
1/7R-b
2/7R-b
3/7R-b R-b
4/7R-b
5/7R-b R-b
6/7R-b R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] hw/riscv: fix leak, add more g_autofree

Hi,

First patch fixes a leak found when using Valgrind. The root cause is a missing g_free() in a string.

In fact, I found while doing reviews that we keep repeating the same pattern:

====
char *name;
name = g_strdup_printf(...);
(...)
g_free(name);
====

With this in mind, I ended up making this rather trivial series to introduce more string/array autocleaning in the 'virt' machine code. The advantage of doing 'g_autofree' is that we'll guarantee that we'll clean ourselves up when the variable goes out of scope, avoiding leaks like the one patch 1 fixes. We want to enforce this autoclean style in reviews, and for that we need to get rid of at least some of the uses we do it right now.

I didn't bother changing the 'spike' and the 'sifive' boards for now because the bulk of new patches is done on top of the 'virt' machine, so it's more important to tidy this board first.

Daniel Henrique Barboza (7):
hw/riscv/virt-acpi-build.c: fix leak in build_rhct() hw/riscv/numa.c: use g_autofree in socket_fdt_write_distance_matrix() hw/riscv/virt.c: use g_autofree in create_fdt_socket_cpus() hw/riscv/virt.c: use g_autofree in create_fdt_sockets() hw/riscv/virt.c: use g_autofree in create_fdt_virtio() hw/riscv/virt.c: use g_autofree in virt_machine_init() hw/riscv/virt.c: use g_autofree in create_fdt_*

 hw/riscv/numa.c            |   4 +-
 hw/riscv/virt-acpi-build.c |   2 +-
 hw/riscv/virt.c            | 109 ++++++++++++-------------------------
 3 files changed, 37 insertions(+), 78 deletions(-)
Signature · 1 line
2.43.0