Skip to content

riscv: named features riscv,isa, 'svade' rework

Andrew Jones qemu-devel qemu-riscv 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 patches 3 repliesIn review

Changes in v2 from the cover letter

- Ensure svade is off by default even for the max cpu type

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6target/riscv/tcg: set 'mmu' with 'satp' in cpu_set_profile()target/riscv/tcg/tcg-cpu.c+1 -01 reply
2/6target/riscv: add riscv,isa to named featurestarget/riscv/cpu.c target/riscv/cpu_cfg.h target/riscv/tcg/tcg-cpu.c+23 -161 reply
3/6target/riscv: add remaining named featurestarget/riscv/cpu.c target/riscv/cpu_cfg.h target/riscv/tcg/tcg-cpu.c+59 -101 reply
4/6target/riscv: Reset henvcfg to zerotarget/riscv/cpu.c target/riscv/csr.c+2 -30 replies
5/6target/riscv: Gate hardware A/D PTE bit updatingtarget/riscv/cpu.c target/riscv/cpu_helper.c target/riscv/tcg/tcg-cpu.c+20 -160 replies
6/6target/riscv: Promote svade to a normal extensiontarget/riscv/cpu.c target/riscv/tcg/tcg-cpu.c+9 -50 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDaniel Henrique BarbozaAndrew JonesAlistair Francis
1/6R-b
2/6R-b R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] riscv: named features riscv,isa, 'svade' rework

Hi,

This is a bundle of fixes based on discoveries that were made in the last week or so:

- what we call "named features" are actually real extensions, which are considered to be ratified by the profile spec that defines them. This means that we need to add riscv,isa strings for them. More info can be found on the commit msg of patch 2;

- the design behind 'svade' and 'svadu' is wrong. 'svade' does not mean 'we do not have svadu'. In fact they can coexist. Patch 5 gives more details about it.

After this series, 'svade' is promoted to a regular extension and all the named features QEMU implements are now being displayed in riscv,isa.

v2:
- Ensure svade is off by default even for the max cpu type

Andrew Jones (3):
target/riscv: Reset henvcfg to zero target/riscv: Gate hardware A/D PTE bit updating target/riscv: Promote svade to a normal extension

Daniel Henrique Barboza (3):
target/riscv/tcg: set 'mmu' with 'satp' in cpu_set_profile() target/riscv: add riscv,isa to named features target/riscv: add remaining named features

 target/riscv/cpu.c         | 63 ++++++++++++++++++++++++++++----------
 target/riscv/cpu_cfg.h     | 15 +++++++--
 target/riscv/cpu_helper.c  | 18 ++++++++---
 target/riscv/csr.c         |  2 +-
 target/riscv/tcg/tcg-cpu.c | 48 +++++++++++++++++++----------
 5 files changed, 105 insertions(+), 41 deletions(-)
Signature · 1 line
2.43.0