Skip to content

RISC-V: Modularize common match conditions for trigger

Alvin Chang via qemu-devel qemu-riscv 8 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 3/33 patches 0 repliesNew
  2. v6 posting 2/33 patches 0 repliesSuperseded
  3. v6 posting 1/33 patches 3 repliesApplied
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v54 patches4 repliesApplied
v44 patches6 repliesSuperseded
v34 patches2 repliesSuperseded
v24 patches5 repliesSuperseded
v14 patches7 repliesSuperseded

Changes in v6 from the cover letter

- Merge first two commits to avoid build error

Patches in v6 posting 3/3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3target/riscv: Add functions for common matching conditions of triggertarget/riscv/debug.c+78 -230 replies
2/3target/riscv: Apply modularized matching conditions for watchpointtarget/riscv/debug.c+6 -200 replies
3/3target/riscv: Apply modularized matching conditions for icount triggertarget/riscv/debug.c+1 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAlistair Francis
1/3R-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] RISC-V: Modularize common match conditions for trigger

According to RISC-V Debug specification ratified version 0.13 [1] (also applied to version 1.0 [2] but it has not been ratified yet), the enabled privilege levels of the trigger is common match conditions for all the types of the trigger.

This series modularize the code for checking the privilege levels of type 2/3/6 triggers by implementing functions trigger_common_match() and trigger_priv_match().

Additional match conditions, such as CSR tcontrol and textra, can be further implemented into trigger_common_match() in the future.

[1]: https://github.com/riscv/riscv-debug-spec/releases/tag/task_group_vote
[2]: https://github.com/riscv/riscv-debug-spec/releases/tag/1.0.0-rc1-asciidoc

Changes from v5:
- Merge first two commits to avoid build error

Changes from v4:
- Rebasing on riscv-to-apply.next

Changes from v3:
- Change this series to target Debug Spec. version 0.13

Changes from v2:
- Explicitly mention the targeting version of RISC-V Debug Spec.

Changes from v1:
- Fix typo
- Add commit description for changing behavior of looping the triggers when we check type 2 triggers.

Alvin Chang (3):
target/riscv: Add functions for common matching conditions of trigger target/riscv: Apply modularized matching conditions for watchpoint target/riscv: Apply modularized matching conditions for icount trigger

 target/riscv/debug.c | 129 ++++++++++++++++++++++++++++---------------
 1 file changed, 85 insertions(+), 44 deletions(-)
Signature · 1 line
2.34.1