Skip to content

Add AST2700 support

Jamin Lin via qemu-arm qemu-devel 4 versions – Applied

Status from this message: Applied to aspeed-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 of 17 patches 5 repliesApplied
  2. v411 of 16 patches 39 repliesSuperseded
  3. v21 of 9 patches 12 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 of 9 patches0 repliesSuperseded

Changes in v5 from the cover letter

- support 64 bits dma dram address associated with review issues
- support dma start length and 1 byte length unit associated with review issues
- refactor intc model to fix serial console stuck issue and associated with review issues

10 of 17 patches are in this archive. The cover letter announces 17.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/17aspeed/wdt: Add AST2700 supporthw/watchdog/wdt_aspeed.c include/hw/watchdog/wdt_aspeed.h+26 -10 replies
2/17aspeed/sli: Add AST2700 supporthw/misc/aspeed_sli.c hw/misc/meson.build hw/misc/trace-events +1 more+213 -10 replies
4/17aspeed/sdmc: fix coding stylehw/misc/aspeed_sdmc.c+7 -40 replies
6/17aspeed/smc: correct device descriptionhw/ssi/aspeed_smc.c+3 -30 replies
7/17aspeed/smc: support dma start length and 1 byte length unithw/ssi/aspeed_smc.c include/hw/ssi/aspeed_smc.h+36 -80 replies
8/17aspeed/smc: support 64 bits dma dram addresshw/ssi/aspeed_smc.c hw/ssi/trace-events+44 -90 replies
12/17aspeed/intc: Add AST2700 supporthw/intc/aspeed_intc.c hw/intc/meson.build hw/intc/trace-events +1 more+418 -01 reply
14/17aspeed: Add an AST2700 eval boardhw/arm/aspeed.c+32 -00 replies
15/17aspeed/soc: fix incorrect dram size for AST2700hw/arm/aspeed_ast27x0.c include/hw/arm/aspeed_soc.h+88 -11 reply
16/17test/avocado/machine_aspeed.py: Add AST2700 test casetests/avocado/machine_aspeed.py+62 -00 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCédric Le Goater
SeriesR-b R-b R-b R-b R-b R-b R-b
1/17R-b
2/17R-b
4/17R-b
6/17R-b
7/17R-b
8/17R-b
12/17R-b
14/17R-b
15/17R-b
16/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/17] Add AST2700 support

Changes from v1:
The patch series supports WDT, SDMC, SMC, SCU, SLI and INTC for AST2700 SoC.

Changes from v2:
- replace is_aarch64 with is_bus64bit for sdmc patch review.
- fix incorrect dram size for AST2700

Changes from v3:
- Add AST2700 Evaluation board in ASPEED document
- Add avocado test cases for AST2700 Evaluation board
- Fix reviewers review issues and add reviewers suggestions
- Implement INTC model GICINT 128 to GICINT136 for AST2700

Changes from v4:
- support 64 bits dma dram address associated with review issues
- support dma start length and 1 byte length unit associated with review issues
- refactor intc model to fix serial console stuck issue and associated with review issues

Changes from v5:
- sdmc: incrementing the version of vmstate to 2.
- smc: support different memory region ops for SMC flash region introduce a new "const MemoryRegionOps *" attribute in AspeedSMCClass and use it in aspeed_smc_flash_realize function.
- intc: fix associated with review issues
- dram size detect: change to use address space API and simplify with write transaction on the DRAM memory region of the SoC.
- ast27x0_soc: update aspeed_soc_ast2700_gic function associated with review issues and rename to aspeed_soc_ast2700_gic_realize

Test Version:
qemu commit:
https://github.com/qemu/qemu/commit/74abb45dac6979e7ff76172b7f0a24e869405184
applied patch:
https://patchew.org/QEMU/[email protected]/

Test steps:
1. Download the latest openbmc image for AST2700 from AspeedTech-BMC/openbmc repository, https://github.com/AspeedTech-BMC/openbmc/releases/tag/v09.01

2. untar ast2700-default-obmc.tar.gz

   ```
   tar -xf ast2700-default-obmc.tar.gz
   ```

3. Run and the contents of scripts as following IMGDIR=ast2700-default
UBOOT_SIZE=$(stat --format=%s -L ${IMGDIR}/u-boot-nodtb.bin) UBOOT_DTB_ADDR=$((0x400000000 + ${UBOOT_SIZE}))

qemu-system-aarch64 -M ast2700-evb -nographic\
-device loader,addr=0x400000000,file=${IMGDIR}/u-boot-nodtb.bin,force-raw=on\
-device loader,addr=${UBOOT_DTB_ADDR},file=${IMGDIR}/u-boot.dtb,force-raw=on\
-device loader,addr=0x430000000,file=${IMGDIR}/bl31.bin,force-raw=on\
-device loader,addr=0x430080000,file=${IMGDIR}/optee/tee-raw.bin,force-raw=on\
-device loader,addr=0x430000000,cpu-num=0\
-device loader,addr=0x430000000,cpu-num=1\
-device loader,addr=0x430000000,cpu-num=2\
-device loader,addr=0x430000000,cpu-num=3\
-smp 4\
-drive file=${IMGDIR}/image-bmc,format=raw,if=mtd\
-serial mon:stdio\
-snapshot

Jamin Lin (17):
aspeed/wdt: Add AST2700 support
aspeed/sli: Add AST2700 support
aspeed/sdmc: remove redundant macros
aspeed/sdmc: fix coding style
aspeed/sdmc: Add AST2700 support
aspeed/smc: correct device description
aspeed/smc: support dma start length and 1 byte length unit aspeed/smc: support 64 bits dma dram address
aspeed/smc: support different memory region ops for SMC flash region aspeed/smc: Add AST2700 support
aspeed/scu: Add AST2700 support
aspeed/intc: Add AST2700 support
aspeed/soc: Add AST2700 support
aspeed: Add an AST2700 eval board
aspeed/soc: fix incorrect dram size for AST2700 test/avocado/machine_aspeed.py: Add AST2700 test case docs:aspeed: Add AST2700 Evaluation board

 docs/system/arm/aspeed.rst       |  39 +-
 hw/arm/aspeed.c                  |  32 ++
 hw/arm/aspeed_ast27x0.c          | 648 +++++++++++++++++++++++++++++++
 hw/arm/meson.build               |   1 +
 hw/intc/aspeed_intc.c            | 360 +++++++++++++++++
 hw/intc/meson.build              |   1 +
 hw/intc/trace-events             |  13 +
 hw/misc/aspeed_scu.c             | 306 ++++++++++++++-
 hw/misc/aspeed_sdmc.c            | 220 +++++++++--
 hw/misc/aspeed_sli.c             | 177 +++++++++
 hw/misc/meson.build              |   3 +-
 hw/misc/trace-events             |  11 +
 hw/ssi/aspeed_smc.c              | 346 ++++++++++++++++-
 hw/ssi/trace-events              |   2 +-
 hw/watchdog/wdt_aspeed.c         |  24 ++
 include/hw/arm/aspeed_soc.h      |  30 +-
 include/hw/intc/aspeed_intc.h    |  44 +++
 include/hw/misc/aspeed_scu.h     |  47 ++-
 include/hw/misc/aspeed_sdmc.h    |   5 +-
 include/hw/misc/aspeed_sli.h     |  27 ++
 include/hw/ssi/aspeed_smc.h      |   2 +
 include/hw/watchdog/wdt_aspeed.h |   3 +-
 tests/avocado/machine_aspeed.py  |  62 +++
 23 files changed, 2345 insertions(+), 58 deletions(-)
 create mode 100644 hw/arm/aspeed_ast27x0.c
 create mode 100644 hw/intc/aspeed_intc.c
 create mode 100644 hw/misc/aspeed_sli.c
 create mode 100644 include/hw/intc/aspeed_intc.h
 create mode 100644 include/hw/misc/aspeed_sli.h
Signature · 1 line
2.25.1