Skip to content

spi: Add more consistency to CS handle

Andy Shevchenko linux-spi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3spi: Consistently use BIT for cs_index_maskdrivers/spi/spi.c+11 -240 replies
2/3spi: Fix types of the last chip select storage variablesinclude/linux/spi/spi.h+6 -60 replies
3/3spi: Introduce SPI_INVALID_CS and is_valid_cs()drivers/spi/spi.c+23 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/3] spi: Add more consistency to CS handle

There are the following issues with the current code:
- inconsistent use of 0xFF and -1 for invalid chip select pin
- inconsistent plain or BIT() use with a hard-to-understand comment
- wrong types used for last_cs_* fields

Fix all of these here.

Andy Shevchenko (3):
spi: Consistently use BIT for cs_index_mask
spi: Fix types of the last chip select storage variables
spi: Introduce SPI_INVALID_CS and is_valid_cs()

 drivers/spi/spi.c       | 74 +++++++++++++++++++----------------------
 include/linux/spi/spi.h | 12 +++----
 2 files changed, 40 insertions(+), 46 deletions(-)
Signature · 1 line
2.43.0.rc1.1.gbec44491f096