Skip to content

Add RK816 PMIC support

Alex Bee linux-arm-kernel linux-devicetree linux-gpio linux-rockchip lkml 4 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 11 repliesApplied
  2. v35 patches 3 repliesSuperseded
  3. v25 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches2 repliesSuperseded

Changes in v4 from the cover letter

- integrated Krzysztof's feedback to the bindings of v3
- integrated Lee's feedback to the mfd part of v3

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: mfd: Add rk816 bindingDocumentation/devicetree/bindings/mfd/rockchip,rk816.yaml+274 -00 replies
2/5mfd: rk8xx: Add RK816 supportdrivers/mfd/Kconfig drivers/mfd/rk8xx-core.c drivers/mfd/rk8xx-i2c.c +1 more+294 -30 replies
3/5pinctrl: rk805: Add rk816 pinctrl supportdrivers/pinctrl/pinctrl-rk805.c+69 -03 replies
4/5regulator: rk808: Support apply_bit for rk808_set_suspend_voltage_rangedrivers/regulator/rk808-regulator.c+13 -31 reply
5/5regulator: rk808: Add RK816 supportdrivers/regulator/rk808-regulator.c+201 -11 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiLinus WalleijMark Brown
1/5R-b
2/5
3/5R-b
4/5A-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] Add RK816 PMIC support

This series aims to add support for Rockchip RK816 PMIC series. As per datasheet it's targeted for RK3126/RK3128 (RK816-1), RK1108 (RK816-2) and PX3-SE (RK816-3) but might be used for other SoCs as well. The MFD consists of an integrated RTC, a GPIO controller, two 32k clock outputs, a power key, 3 buck- and 6 ldo regulators, 3 regulator-switches, and charger with integrated fuel gauge. Charger and fuel gauge are not part of this series. Two of the switches (otg/boost) are part of the binding, but not of the driver. They must only ever be enabled if no battery charging is happening, but it will be enabled automatically if a battery is attached and an external power source is connected. Thus that needs some incorporation of a yet to be added charger driver.
Integration in the existing rk8xx-infrastructure was pretty straightforward and only needed very little tweaking. In order to not further bloat the driver(s) too much with additional #defines I tried to re-use existing ones wherever possible.

The patches are loosely based on the vendor's implementation, verified against the datasheet and tested/measured on a RK3126 board.

I'd like to gently ping pinctrl and regulator maintainers: please have a look at this series. I've now added Sebastian Reichel to the recipients, as he recently added RK806 support and re-worked parts of the rk8xx drivers.

changes since v1:
- integrated Krzysztof's feedback for the bindings and the resulting driver changes
- fixed a sparse warning

link to v1:
https://lore.kernel.org/lkml/[email protected]/

changes since v2:
- integrated Krzysztof's feedback to v2 of the bindings and the resulting driver changes

link to v2:
https://lore.kernel.org/lkml/[email protected]/

changes since v3:
- integrated Krzysztof's feedback to the bindings of v3
- integrated Lee's feedback to the mfd part of v3

link to v3:
https://lore.kernel.org/lkml/[email protected]/

Please see individual patches for details about the changes.

Alex Bee (5):
dt-bindings: mfd: Add rk816 binding
mfd: rk8xx: Add RK816 support
pinctrl: rk805: Add rk816 pinctrl support
regulator: rk808: Support apply_bit for
rk808_set_suspend_voltage_range
regulator: rk808: Add RK816 support

 .../bindings/mfd/rockchip,rk816.yaml          | 274 ++++++++++++++++++
 drivers/mfd/Kconfig                           |   4 +-
 drivers/mfd/rk8xx-core.c                      | 104 +++++++
 drivers/mfd/rk8xx-i2c.c                       |  45 ++-
 drivers/pinctrl/pinctrl-rk805.c               |  69 +++++
 drivers/regulator/rk808-regulator.c           | 218 +++++++++++++-
 include/linux/mfd/rk808.h                     | 144 +++++++++
 7 files changed, 851 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml
Signature · 1 line
2.43.2