Skip to content

add shellcheck support

Nicholas Piggin kvm kvm-riscv kvmarm linux-s390 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 9 repliesIn review
  2. v2 RFC14 patches 9 repliesSuperseded
  3. v1 RFC17 patches 25 repliesSuperseded

Changes in v3 from the cover letter

- Rebased to upstream with some patches merged.
- Just a few comment typos and small issues (e.g., quoting make shellcheck in docs) that people picked up from the last round.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Add initial shellcheck checking.shellcheckrc Makefile README.md +1 more+41 -10 replies
2/5shellcheck: Fix SC2155scripts/arch-run.bash scripts/runtime.bash+10 -40 replies
3/5shellcheck: Fix SC2124scripts/arch-run.bash+3 -30 replies
4/5shellcheck: Fix SC2294scripts/arch-run.bash+3 -30 replies
5/5shellcheck: Suppress various messagesconfigure run_tests.sh scripts/arch-run.bash +2 more+24 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAndrew Jones
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [kvm-unit-tests PATCH v3 0/5] add shellcheck support

This is based on upstream directly now, not ahead of the powerpc series.

Since v2:
- Rebased to upstream with some patches merged.
- Just a few comment typos and small issues (e.g., quoting make shellcheck in docs) that people picked up from the last round.

make shellcheck passes with no warnings for me after this series. (You should be able to put patch 1 at the end without conflicts if you prefer to only introduce the shellcheck Makefile target when the tree is clean.)

Thanks,
Nick

Nicholas Piggin (5):
Add initial shellcheck checking
shellcheck: Fix SC2155
shellcheck: Fix SC2124
shellcheck: Fix SC2294
shellcheck: Suppress various messages

 .shellcheckrc           | 30 ++++++++++++++++++++++++++++++
 Makefile                |  4 ++++
 README.md               |  3 +++
 configure               |  2 ++
 run_tests.sh            |  3 +++
 scripts/arch-run.bash   | 33 ++++++++++++++++++++++++++-------
 scripts/common.bash     |  5 ++++-
 scripts/mkstandalone.sh |  2 ++
 scripts/runtime.bash    |  6 +++++-
 9 files changed, 79 insertions(+), 9 deletions(-)
 create mode 100644 .shellcheckrc
Signature · 1 line
2.43.0