Skip to content

ice: support devlink subfunction

Michal Swiatkowski intel-wired-lan netdev 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest15 patches 21 repliesIn review
  2. v4 posting 2/215 patches 2 repliesSuperseded
  3. v3 posting 2/215 patches 15 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v2 posting 2/215 patches13 repliesSuperseded
v4 posting 1/28 patches16 repliesSuperseded
v3 posting 1/27 patches12 repliesSuperseded
v2 posting 1/27 patches0 repliesSuperseded
v17 patches2 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15ice: add new VSI type for subfunctionsdrivers/net/ethernet/intel/ice/ice_base.c drivers/net/ethernet/intel/ice/ice_dcb_lib.c drivers/net/ethernet/intel/ice/ice_lib.c +3 more+35 -61 reply
2/15ice: export ice ndo_ops functionsdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_lib.h +1 more+37 -311 reply
3/15ice: add basic devlink subfunctions supportdrivers/net/ethernet/intel/ice/devlink/devlink.c drivers/net/ethernet/intel/ice/devlink/devlink_port.c drivers/net/ethernet/intel/ice/devlink/devlink_port.h +4 more+341 -21 reply
4/15ice: treat subfunction VSI the same as PF VSIdrivers/net/ethernet/intel/ice/ice_main.c+3 -23 replies
5/15ice: allocate devlink for subfunctiondrivers/net/ethernet/intel/ice/devlink/devlink.c drivers/net/ethernet/intel/ice/devlink/devlink.h drivers/net/ethernet/intel/ice/devlink/devlink_port.c +2 more+98 -02 replies
6/15ice: base subfunction aux driverdrivers/net/ethernet/intel/ice/Makefile drivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_main.c +2 more+165 -11 reply
7/15ice: implement netdev for subfunctiondrivers/net/ethernet/intel/ice/ice_sf_eth.c+84 -13 replies
8/15ice: make representor code genericdrivers/net/ethernet/intel/ice/devlink/devlink_port.h drivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_eswitch.h +4 more+122 -771 reply
9/15ice: create port representor for SFdrivers/net/ethernet/intel/ice/devlink/devlink_port.c drivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_eswitch.h +2 more+111 -41 reply
10/15ice: don't set target VSI for subfunctiondrivers/net/ethernet/intel/ice/ice_txrx.c+1 -11 reply
11/15ice: check if SF is ready in ethtool opsdrivers/net/ethernet/intel/ice/ice_ethtool.c drivers/net/ethernet/intel/ice/ice_repr.c drivers/net/ethernet/intel/ice/ice_repr.h+16 -41 reply
12/15ice: implement netdevice ops for SF representordrivers/net/ethernet/intel/ice/ice_repr.c+43 -142 replies
13/15ice: support subfunction devlink Tx topologydrivers/net/ethernet/intel/ice/devlink/devlink.c drivers/net/ethernet/intel/ice/devlink/devlink_port.c drivers/net/ethernet/intel/ice/ice_repr.c+20 -51 reply
14/15ice: basic support for VLAN in subfunctionsdrivers/net/ethernet/intel/ice/Makefile drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.c drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.h +1 more+39 -01 reply
15/15ice: allow to activate and deactivate subfunctiondrivers/net/ethernet/intel/ice/devlink/devlink_port.c drivers/net/ethernet/intel/ice/devlink/devlink_port.h drivers/net/ethernet/intel/ice/ice_sf_eth.c +1 more+290 -01 reply

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchSimon HormanPrzemek KitszelWojciech DrewekJiri PirkoRafal Romanowski
1/15R-b R-b R-b T-b
2/15R-b R-b R-b T-b
3/15R-b R-b T-b
4/15R-b T-b
5/15R-b R-b T-b
6/15R-b R-b T-b
7/15R-b R-b T-b
8/15R-b R-b T-b
9/15R-b T-b
10/15R-b T-b
11/15R-b R-b T-b
12/15R-b R-b R-b T-b
13/15R-b R-b R-b T-b
14/15R-b R-b T-b
15/15R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [iwl-next v5 00/15] ice: support devlink subfunction

Hi,

Currently ice driver does not allow creating more than one networking device per physical function. The only way to have more hardware backed netdev is to use SR-IOV.

Following patchset adds support for devlink port API. For each new pcisf type port, driver allocates new VSI, configures all resources needed, including dynamically MSIX vectors, program rules and registers new netdev.

This series supports only one Tx/Rx queue pair per subfunction.

Example commands:
devlink port add pci/0000:31:00.1 flavour pcisf pfnum 1 sfnum 1000 devlink port function set pci/0000:31:00.1/1 hw_addr 00:00:00:00:03:14 devlink port function set pci/0000:31:00.1/1 state active devlink port function del pci/0000:31:00.1/1

Make the port representor and eswitch code generic to support subfunction representor type.

VSI configuration is slightly different between VF and SF. It needs to be reflected in the code.

v4 --> v5: [7]
* use devlink_alloc() instead of devlink_alloc_ns() during subfunction devlink creation

v3 --> v4: [6]
* fix comment in ice_allocate_sf()
* return ERR_PTR instead of NULL in ice_allocate_sf()

v2 --> v3: [5]
* fix misspealing in commit tilte
* add missing doc entries in ice_dynamic_port
* drop dev_err where extack is available
* fix RCT in declaration

v1 --> v2: [4]
* allow changing SF MAC address only when port isn't attached
* split patch with port representor creation into two (first making code generic and than adding support for SF representor)
* fix warning massege in case of SF device creation
* remove double space
* add verb in commit message

Changelog for previous patchset version (not containing port representor for SF support).

v3 --> v4: [3]
* get rid of unnecessary checks
* fix cosmetic issues (whitespaces, wording)
* move unrelated chunks to separate patch
* move implementing activation/deactivation to last patch

v2 --> v3: [2]
* fix building issue between the patches; allocating devlink for subfunction need to include base subfunction header
* fix kdoc issues

v1 --> v2: [1]
* use correct parameters in ice_devlink_alloc() thanks to Mateusz

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/netdev/[email protected]/
[3] https://lore.kernel.org/netdev/[email protected]/
[4] https://lore.kernel.org/netdev/[email protected]/
[5] https://lore.kernel.org/netdev/[email protected]/
[6] https://lore.kernel.org/netdev/[email protected]/
[7] https://lore.kernel.org/netdev/[email protected]/

Michal Swiatkowski (8):
ice: treat subfunction VSI the same as PF VSI
ice: make representor code generic
ice: create port representor for SF
ice: don't set target VSI for subfunction
ice: check if SF is ready in ethtool ops
ice: implement netdevice ops for SF representor
ice: support subfunction devlink Tx topology
ice: basic support for VLAN in subfunctions

Piotr Raczynski (7):
ice: add new VSI type for subfunctions
ice: export ice ndo_ops functions
ice: add basic devlink subfunctions support
ice: allocate devlink for subfunction
ice: base subfunction aux driver
ice: implement netdev for subfunction
ice: allow to activate and deactivate subfunction

 drivers/net/ethernet/intel/ice/Makefile       |   2 +
 .../net/ethernet/intel/ice/devlink/devlink.c  |  47 ++
 .../net/ethernet/intel/ice/devlink/devlink.h  |   1 +
 .../ethernet/intel/ice/devlink/devlink_port.c | 503 ++++++++++++++++++
 .../ethernet/intel/ice/devlink/devlink_port.h |  46 ++
 drivers/net/ethernet/intel/ice/ice.h          |  19 +-
 drivers/net/ethernet/intel/ice/ice_base.c     |   5 +-
 drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   1 +
 drivers/net/ethernet/intel/ice/ice_eswitch.c  | 113 +++-
 drivers/net/ethernet/intel/ice/ice_eswitch.h  |  22 +-
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |   7 +-
 drivers/net/ethernet/intel/ice/ice_lib.c      |  52 +-
 drivers/net/ethernet/intel/ice/ice_lib.h      |   3 +
 drivers/net/ethernet/intel/ice/ice_main.c     |  66 ++-
 drivers/net/ethernet/intel/ice/ice_repr.c     | 211 ++++++--
 drivers/net/ethernet/intel/ice/ice_repr.h     |  22 +-
 drivers/net/ethernet/intel/ice/ice_sf_eth.c   | 329 ++++++++++++
 drivers/net/ethernet/intel/ice/ice_sf_eth.h   |  33 ++
 .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.c  |  21 +
 .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.h  |  13 +
 drivers/net/ethernet/intel/ice/ice_sriov.c    |   4 +-
 drivers/net/ethernet/intel/ice/ice_txrx.c     |   2 +-
 drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   |   4 +-
 .../net/ethernet/intel/ice/ice_vsi_vlan_ops.c |   4 +
 drivers/net/ethernet/intel/ice/ice_xsk.c      |   2 +-
 26 files changed, 1395 insertions(+), 138 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_eth.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_eth.h
 create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.h
Signature · 1 line
2.42.0