Skip to content

Add parents to struct pmu -> dev

Jonathan Cameron linux-arm-kernel linux-fpga lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest30 patches 7 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/30perf/hisi-pcie: Assign parent for event_source devicedrivers/perf/hisilicon/hisi_pcie_pmu.c+1 -00 replies
2/30Documentation: hisi-pmu: Drop reference to /sys/devices pathDocumentation/admin-guide/perf/hisi-pmu.rst+0 -10 replies
3/30perf/hisi-uncore: Assign parents for event_source devicesdrivers/perf/hisilicon/hisi_uncore_pmu.c+1 -00 replies
4/30Documentation: hns-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/hns3-pmu.rst+4 -40 replies
5/30perf/hisi-hns3: Assign parents for event_source devicedrivers/perf/hisilicon/hns3_pmu.c+1 -00 replies
6/30perf/amlogic: Assign parents for event_source devicesdrivers/perf/amlogic/meson_ddr_pmu_core.c+1 -00 replies
7/30perf/arm_cspmu: Assign parents for event_source devicesdrivers/perf/arm_cspmu/arm_cspmu.c+1 -00 replies
8/30Documentation: xgene-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/xgene-pmu.rst+1 -10 replies
9/30perf/xgene: Assign parents for event_source devicesdrivers/perf/xgene_pmu.c+1 -00 replies
10/30Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/thunderx2-pmu.rst+1 -10 replies
11/30perf/thunderx2: Assign parents for event_source devicesdrivers/perf/thunderx2_pmu.c+1 -00 replies
12/30perf/riscv: Assign parents for event_source devicesdrivers/perf/riscv_pmu_legacy.c drivers/perf/riscv_pmu_sbi.c+2 -00 replies
13/30Documentation: qcom-pmu: Use /sys/bus/event_source/devices pathsDocumentation/admin-guide/perf/qcom_l2_pmu.rst Documentation/admin-guide/perf/qcom_l3_pmu.rst+2 -20 replies
14/30perf/qcom: Assign parents for event_source devicesdrivers/perf/qcom_l2_pmu.c drivers/perf/qcom_l3_pmu.c+2 -00 replies
15/30perf/imx_ddr: Assign parents for event_source devicesdrivers/perf/fsl_imx8_ddr_perf.c+1 -00 replies
16/30perf/arm_pmu: Assign parents for event_source devicesdrivers/perf/arm_pmu_platform.c+1 -01 reply
17/30perf/alibaba_uncore: Assign parents for event_source devicedrivers/perf/alibaba_uncore_drw_pmu.c+1 -00 replies
18/30perf/arm-cci: Assign parents for event_source devicedrivers/perf/arm-cci.c+1 -00 replies
19/30perf/arm-ccn: Assign parents for event_source devicedrivers/perf/arm-ccn.c+1 -00 replies
20/30perf/arm-dmc620: Assign parents for event_source devicedrivers/perf/arm_dmc620_pmu.c+1 -00 replies
21/30perf/arm-dsu: Assign parents for event_source devicedrivers/perf/arm_dsu_pmu.c+1 -00 replies
22/30perf/arm-smmuv3: Assign parents for event_source devicedrivers/perf/arm_smmuv3_pmu.c+1 -00 replies
23/30perf/arm-spe: Assign parents for event_source devicedrivers/perf/arm_spe_pmu.c+1 -00 replies
24/30arc: Assign parents for event_source devicesarch/arc/kernel/perf_event.c+1 -00 replies
25/30ARM: imx: Assign parents for mmdc event_source devicesarch/arm/mach-imx/mmdc.c+1 -01 reply
26/30dmaengine: idxd: Assign parent for event_source devicedrivers/dma/idxd/perfmon.c+1 -02 replies
27/30fpga: dfl: Assign parent for event_source devicedrivers/fpga/dfl-fme-perf.c+1 -00 replies
28/30drivers/nvdimm: Assign parent for event_source devicedrivers/nvdimm/nd_perf.c+1 -00 replies
29/30Documentation: ABI + trace: hisi_ptt: update paths to bus/event_sourceDocumentation/ABI/testing/sysfs-bus-event_source-devices-hisi_ptt Documentation/trace/hisi-ptt.rst MAINTAINERS+9 -90 replies
30/30hwtracing: hisi_ptt: Assign parent for event_source devicedrivers/hwtracing/ptt/hisi_ptt.c+1 -01 reply

Reviews trailers per patch

17 of 30 patches have a Reviewed-by or Acked-by.

PatchYicong YangGreg Kroah-HartmanJiucheng XuSuzuki K PouloseShuai XueXu YilunDan WilliamsDave JiangFenghua Yu
1/30R-b R-b
2/30R-b R-b
3/30R-b R-b
4/30R-b
5/30
6/30R-b
7/30R-b
8/30
9/30
10/30
11/30
12/30
13/30
14/30
15/30
16/30R-b
17/30R-b
18/30R-b
19/30A-b
20/30
21/30R-b
22/30
23/30A-b
24/30
25/30
26/30R-b R-b
27/30R-b
28/30R-b
29/30R-b
30/30R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/30] Add parents to struct pmu -> dev

Robin posted a patch for the cmn and that reminded me that I never sent a v2.

v2: Drop first patch that added a parent to struct pmu as that has been
upstream for a year.
Drop the arm-cmn change as Robin has dealt with that one. Gathered tags.

Updated cover letter:

These are the low hanging fruit following GregKH's feedback that all the devices registered via perf_pmu_register() should have parents.

Note that this causes potential ABI breakage.

It may fall in the category of it isn't breakage if no one notices but I can't be certain of that. Whilst it is arguable that no one should be been accessing PMUs except via the event_source bus, there was documentation suggesting /sys/devices/ for particular PMUs (because it was a shorter path?)

Addressing all the other instances of struct pmu not covered by this series is likely to be a more complex discussion but unlikely to have an affect on what is proposed here.

Documentation updates deliberately 'fixed' in separate patches before changing the path to highlight that using /sys/bus/event_source/devices path is unchanged by this series and that is presumed to be the most common way these files are accessed.

Jonathan Cameron (30):
perf/hisi-pcie: Assign parent for event_source device
Documentation: hisi-pmu: Drop reference to /sys/devices path perf/hisi-uncore: Assign parents for event_source devices
Documentation: hns-pmu: Use /sys/bus/event_source/devices paths perf/hisi-hns3: Assign parents for event_source device perf/amlogic: Assign parents for event_source devices perf/arm_cspmu: Assign parents for event_source devices
Documentation: xgene-pmu: Use /sys/bus/event_source/devices paths perf/xgene: Assign parents for event_source devices
Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices paths perf/thunderx2: Assign parents for event_source devices perf/riscv: Assign parents for event_source devices
Documentation: qcom-pmu: Use /sys/bus/event_source/devices paths perf/qcom: Assign parents for event_source devices perf/imx_ddr: Assign parents for event_source devices perf/arm_pmu: Assign parents for event_source devices perf/alibaba_uncore: Assign parents for event_source device perf/arm-cci: Assign parents for event_source device perf/arm-ccn: Assign parents for event_source device perf/arm-dmc620: Assign parents for event_source device perf/arm-dsu: Assign parents for event_source device perf/arm-smmuv3: Assign parents for event_source device perf/arm-spe: Assign parents for event_source device
arc: Assign parents for event_source devices
ARM: imx: Assign parents for mmdc event_source devices
dmaengine: idxd: Assign parent for event_source device
fpga: dfl: Assign parent for event_source device drivers/nvdimm: Assign parent for event_source device
Documentation: ABI + trace: hisi_ptt: update paths to bus/event_source
hwtracing: hisi_ptt: Assign parent for event_source device

 ...i_ptt => sysfs-bus-event_source-devices-hisi_ptt} | 12 ++++++------
 Documentation/admin-guide/perf/hisi-pmu.rst          |  1 -
 Documentation/admin-guide/perf/hns3-pmu.rst          |  8 ++++----
 Documentation/admin-guide/perf/qcom_l2_pmu.rst       |  2 +-
 Documentation/admin-guide/perf/qcom_l3_pmu.rst       |  2 +-
 Documentation/admin-guide/perf/thunderx2-pmu.rst     |  2 +-
 Documentation/admin-guide/perf/xgene-pmu.rst         |  2 +-
 Documentation/trace/hisi-ptt.rst                     |  4 ++--
 MAINTAINERS                                          |  2 +-
 arch/arc/kernel/perf_event.c                         |  1 +
 arch/arm/mach-imx/mmdc.c                             |  1 +
 drivers/dma/idxd/perfmon.c                           |  1 +
 drivers/fpga/dfl-fme-perf.c                          |  1 +
 drivers/hwtracing/ptt/hisi_ptt.c                     |  1 +
 drivers/nvdimm/nd_perf.c                             |  1 +
 drivers/perf/alibaba_uncore_drw_pmu.c                |  1 +
 drivers/perf/amlogic/meson_ddr_pmu_core.c            |  1 +
 drivers/perf/arm-cci.c                               |  1 +
 drivers/perf/arm-ccn.c                               |  1 +
 drivers/perf/arm_cspmu/arm_cspmu.c                   |  1 +
 drivers/perf/arm_dmc620_pmu.c                        |  1 +
 drivers/perf/arm_dsu_pmu.c                           |  1 +
 drivers/perf/arm_pmu_platform.c                      |  1 +
 drivers/perf/arm_smmuv3_pmu.c                        |  1 +
 drivers/perf/arm_spe_pmu.c                           |  1 +
 drivers/perf/fsl_imx8_ddr_perf.c                     |  1 +
 drivers/perf/hisilicon/hisi_pcie_pmu.c               |  1 +
 drivers/perf/hisilicon/hisi_uncore_pmu.c             |  1 +
 drivers/perf/hisilicon/hns3_pmu.c                    |  1 +
 drivers/perf/qcom_l2_pmu.c                           |  1 +
 drivers/perf/qcom_l3_pmu.c                           |  1 +
 drivers/perf/riscv_pmu_legacy.c                      |  1 +
 drivers/perf/riscv_pmu_sbi.c                         |  1 +
 drivers/perf/thunderx2_pmu.c                         |  1 +
 drivers/perf/xgene_pmu.c                             |  1 +
 35 files changed, 43 insertions(+), 18 deletions(-)
 rename Documentation/ABI/testing/{sysfs-devices-hisi_ptt => sysfs-bus-event_source-devices-hisi_ptt} (90%)
Signature · 1 line
2.39.2