Skip to content

include/exec: Rework (part 2)

Philippe Mathieu-Daudé qemu-arm qemu-devel qemu-riscv 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 33 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24exec: Declare MMUAccessType type in 'mmu-access-type.h' headerinclude/exec/cpu_ldst.h include/exec/exec-all.h include/exec/mmu-access-type.h +1 more+21 -71 reply
2/24exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' headerinclude/exec/breakpoint.h include/hw/core/cpu.h target/arm/internals.h +2 more+28 -153 replies
3/24hw/core: Avoid including the full 'hw/core/cpu.h' in 'tcg-cpu-ops.h'include/hw/core/tcg-cpu-ops.h+5 -11 reply
4/24exec: Restrict TCG specific declarations of 'cputlb.h'include/exec/cputlb.h+5 -01 reply
5/24exec: Restrict 'cpu_ldst.h' to TCG acceleratorinclude/exec/cpu_ldst.h+5 -11 reply
6/24exec: Have guest_addr_valid() methods take abi_ptr/size_t argumentsinclude/exec/cpu_ldst.h+2 -21 reply
7/24exec: Un-inline tlb_vaddr_to_host() and declare it in 'exec/cputlb.h'accel/tcg/user-exec.c include/exec/cpu_ldst.h include/exec/cputlb.h +3 more+28 -243 replies
8/24physmem: Move TCG CPU IOTLB methods aroundsystem/physmem.c+25 -251 reply
9/24physmem: Restrict TCG CPU IOTLB code to TCG accelinclude/exec/cputlb.h include/exec/exec-all.h system/physmem.c+29 -231 reply
10/24exec: Reduce tlb_set_dirty() declaration scopeaccel/stubs/tcg-stub.c accel/tcg/cputlb.c include/exec/exec-all.h+1 -61 reply
11/24exec: Move tlb_reset_dirty*() declarations to 'exec/cputlb.h'include/exec/cputlb.h include/exec/exec-all.h include/exec/ram_addr.h +1 more+14 -41 reply
12/24exec: Move CPUTLBEntry helpers to cputlb.caccel/tcg/cputlb.c include/exec/cpu_ldst.h+51 -551 reply
13/24target/sparc: Replace abi_ulong by uint32_t for TARGET_ABI32target/sparc/gdbstub.c+1 -11 reply
14/24exec: Rename 'exec/user/guest-base.h' as 'user/guest-base.h'include/exec/cpu-all.h include/user/guest-base.h tcg/tcg.c+4 -42 replies
15/24exec: Restrict inclusion of 'user/guest-base.h'bsd-user/main.c include/exec/cpu-all.h include/exec/cpu_ldst.h +3 more+11 -31 reply
16/24exec: Move GUEST_ADDR_MAX definition to 'cpu_ldst.h'accel/tcg/cpu-exec.c include/exec/cpu-all.h include/exec/cpu_ldst.h+31 -341 reply
17/24exec: Include missing 'qemu/log-for-trace.h' header in 'exec/log.h'include/exec/log.h+1 -03 replies
18/24plugins: Include missing 'qemu/bitmap.h' headerinclude/qemu/plugin.h+1 -02 replies
19/24gdbstub: Avoid including 'cpu.h' in 'gdbstub/helpers.h'include/gdbstub/helpers.h target/avr/gdbstub.c target/tricore/gdbstub.c+4 -11 reply
20/24hw/xtensa: Include missing 'exec/cpu-common.h' in 'bootparam.h'hw/xtensa/bootparam.h+2 -01 reply
21/24plugins: Un-inline qemu_plugin_disable_mem_helpers()include/qemu/plugin.h plugins/core.c+6 -51 reply
22/24exec: Remove 'exec/tswap.h' from 'exec/cpu-all.h'accel/tcg/translator.c hw/arm/boot.c hw/arm/npcm7xx.c +10 more+12 -11 reply
23/24exec: Remove 'disas/disas.h' from 'exec/log.h'include/exec/log.h target/avr/translate.c target/hexagon/translate.c +3 more+5 -11 reply
24/24exec: Remove unnecessary inclusions of 'hw/core/cpu.h'include/exec/cpu-all.h include/exec/cpu-defs.h include/hw/boards.h +2 more+0 -51 reply

Reviews trailers per patch

19 of 24 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonHarsh Prateek BoraAnton JohanssonPierrick Bouvier
1/24R-b
2/24R-b R-b
3/24R-b
4/24R-b
5/24R-b
6/24
7/24R-b
8/24R-b
9/24R-b
10/24R-b
11/24
12/24R-b
13/24R-b
14/24R-b
15/24R-b R-b
16/24R-b
17/24
18/24R-b R-b
19/24R-b
20/24R-b
21/24
22/24R-b
23/24
24/24R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/24] include/exec: Rework (part 2)

Reordering exec/, second round. Mostly splitting:
- TCG LDST API (to "exec/cpu_ldst.h")
- CPU TLB APIs (to "exec/cputlb.h")
from "exec/cpu-all.h" and "exec/exec-all.h", and
reducing inclusions of "hw/core/cpu.h".

Based-on: <[email protected]> or https://gitlab.com/philmd/qemu/-/commits/exec-next

Philippe Mathieu-Daudé (24):
exec: Declare MMUAccessType type in 'mmu-access-type.h' header
exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h'
header
hw/core: Avoid including the full 'hw/core/cpu.h' in 'tcg-cpu-ops.h'
exec: Restrict TCG specific declarations of 'cputlb.h'
exec: Restrict 'cpu_ldst.h' to TCG accelerator
exec: Have guest_addr_valid() methods take abi_ptr/size_t arguments
exec: Un-inline tlb_vaddr_to_host() and declare it in 'exec/cputlb.h'
physmem: Move TCG CPU IOTLB methods around
physmem: Restrict TCG CPU IOTLB code to TCG accel
exec: Reduce tlb_set_dirty() declaration scope
exec: Move tlb_reset_dirty*() declarations to 'exec/cputlb.h'
exec: Move CPUTLBEntry helpers to cputlb.c
target/sparc: Replace abi_ulong by uint32_t for TARGET_ABI32
exec: Rename 'exec/user/guest-base.h' as 'user/guest-base.h'
exec: Restrict inclusion of 'user/guest-base.h'
exec: Move GUEST_ADDR_MAX definition to 'cpu_ldst.h'
exec: Include missing 'qemu/log-for-trace.h' header in 'exec/log.h'
plugins: Include missing 'qemu/bitmap.h' header
gdbstub: Avoid including 'cpu.h' in 'gdbstub/helpers.h' hw/xtensa: Include missing 'exec/cpu-common.h' in 'bootparam.h'
plugins: Un-inline qemu_plugin_disable_mem_helpers()
exec: Remove 'exec/tswap.h' from 'exec/cpu-all.h'
exec: Remove 'disas/disas.h' from 'exec/log.h'
exec: Remove unnecessary inclusions of 'hw/core/cpu.h'

 hw/xtensa/bootparam.h            |   3 +
 include/exec/breakpoint.h        |  23 ++++++
 include/exec/cpu-all.h           |  39 +---------
 include/exec/cpu-defs.h          |   1 -
 include/exec/cpu_ldst.h          | 122 ++++++++++---------------------
 include/exec/cputlb.h            |  58 ++++++++++++++-
 include/exec/exec-all.h          |  26 +------
 include/exec/log.h               |   2 +-
 include/exec/mmu-access-type.h   |  18 +++++
 include/exec/ram_addr.h          |   1 +
 include/exec/user/guest-base.h   |  12 ---
 include/gdbstub/helpers.h        |   3 +-
 include/hw/boards.h              |   1 -
 include/hw/core/cpu.h            |  24 +-----
 include/hw/core/tcg-cpu-ops.h    |   6 +-
 include/hw/ppc/openpic.h         |   1 -
 include/qemu/plugin.h            |   7 +-
 include/sysemu/hw_accel.h        |   1 -
 include/user/guest-base.h        |  18 +++++
 target/arm/internals.h           |   1 +
 target/ppc/internal.h            |   1 +
 target/riscv/debug.h             |   2 +
 accel/stubs/tcg-stub.c           |   4 -
 accel/tcg/cpu-exec.c             |   1 -
 accel/tcg/cputlb.c               |  53 +++++++++++++-
 accel/tcg/translator.c           |   1 +
 accel/tcg/user-exec.c            |   7 ++
 bsd-user/main.c                  |   1 +
 hw/arm/boot.c                    |   1 +
 hw/arm/npcm7xx.c                 |   1 +
 hw/mips/fuloong2e.c              |   1 +
 hw/mips/malta.c                  |   1 +
 hw/ppc/sam460ex.c                |   1 +
 hw/ppc/spapr.c                   |   1 +
 hw/ppc/virtex_ml507.c            |   1 +
 hw/sh4/r2d.c                     |   1 +
 linux-user/elfload.c             |   1 +
 linux-user/main.c                |   1 +
 plugins/core.c                   |   5 ++
 system/physmem.c                 |  58 ++++++++-------
 target/arm/gdbstub.c             |   1 +
 target/arm/tcg/helper-a64.c      |   1 +
 target/avr/gdbstub.c             |   1 +
 target/avr/translate.c           |   1 +
 target/hexagon/translate.c       |   1 +
 target/loongarch/tcg/translate.c |   1 +
 target/riscv/vector_helper.c     |   1 +
 target/rx/translate.c            |   1 +
 target/sparc/gdbstub.c           |   2 +-
 target/sparc/mmu_helper.c        |   1 +
 target/tricore/gdbstub.c         |   1 +
 target/xtensa/xtensa-semi.c      |   1 +
 tcg/tcg.c                        |   3 +-
 53 files changed, 300 insertions(+), 226 deletions(-)
 create mode 100644 include/exec/breakpoint.h
 create mode 100644 include/exec/mmu-access-type.h
 delete mode 100644 include/exec/user/guest-base.h
 create mode 100644 include/user/guest-base.h
Signature · 1 line
2.41.0