include/exec: Rework (part 2)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest24 patches 33 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | exec: Declare MMUAccessType type in 'mmu-access-type.h' headerinclude/ include/ include/ +1 more | +21 | 1 reply | |
| 2/24 | exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' headerinclude/ include/ target/ +2 more | +28 | 3 replies | |
| 3/24 | hw/core: Avoid including the full 'hw/core/cpu.h' in 'tcg-cpu-ops.h'include/ | +5 | 1 reply | |
| 4/24 | exec: Restrict TCG specific declarations of 'cputlb.h'include/ | +5 | 1 reply | |
| 5/24 | exec: Restrict 'cpu_ldst.h' to TCG acceleratorinclude/ | +5 | 1 reply | |
| 6/24 | exec: Have guest_addr_valid() methods take abi_ptr/size_t argumentsinclude/ | +2 | 1 reply | |
| 7/24 | exec: Un-inline tlb_vaddr_to_host() and declare it in 'exec/cputlb.h'accel/ include/ include/ +3 more | +28 | 3 replies | |
| 8/24 | physmem: Move TCG CPU IOTLB methods aroundsystem/ | +25 | 1 reply | |
| 9/24 | physmem: Restrict TCG CPU IOTLB code to TCG accelinclude/ include/ system/ | +29 | 1 reply | |
| 10/24 | exec: Reduce tlb_set_dirty() declaration scopeaccel/ accel/ include/ | +1 | 1 reply | |
| 11/24 | exec: Move tlb_reset_dirty*() declarations to 'exec/cputlb.h'include/ include/ include/ +1 more | +14 | 1 reply | |
| 12/24 | exec: Move CPUTLBEntry helpers to cputlb.caccel/ include/ | +51 | 1 reply | |
| 13/24 | target/sparc: Replace abi_ulong by uint32_t for TARGET_ABI32target/ | +1 | 1 reply | |
| 14/24 | exec: Rename 'exec/user/guest-base.h' as 'user/guest-base.h'include/ include/ tcg/ | +4 | 2 replies | |
| 15/24 | exec: Restrict inclusion of 'user/guest-base.h'bsd-user/ include/ include/ +3 more | +11 | 1 reply | |
| 16/24 | exec: Move GUEST_ADDR_MAX definition to 'cpu_ldst.h'accel/ include/ include/ | +31 | 1 reply | |
| 17/24 | exec: Include missing 'qemu/log-for-trace.h' header in 'exec/log.h'include/ | +1 | 3 replies | |
| 18/24 | plugins: Include missing 'qemu/bitmap.h' headerinclude/ | +1 | 2 replies | |
| 19/24 | gdbstub: Avoid including 'cpu.h' in 'gdbstub/helpers.h'include/ target/ target/ | +4 | 1 reply | |
| 20/24 | hw/xtensa: Include missing 'exec/cpu-common.h' in 'bootparam.h'hw/ | +2 | 1 reply | |
| 21/24 | plugins: Un-inline qemu_plugin_disable_mem_helpers()include/ plugins/ | +6 | 1 reply | |
| 22/24 | exec: Remove 'exec/tswap.h' from 'exec/cpu-all.h'accel/ hw/ hw/ +10 more | +12 | 1 reply | |
| 23/24 | exec: Remove 'disas/disas.h' from 'exec/log.h'include/ target/ target/ +3 more | +5 | 1 reply | |
| 24/24 | exec: Remove unnecessary inclusions of 'hw/core/cpu.h'include/ include/ include/ +2 more | +0 | 1 reply |
Reviews trailers per patch
19 of 24 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson | Harsh Prateek Bora | Anton Johansson | Pierrick Bouvier |
|---|---|---|---|---|
| 1/24 | R-b | |||
| 2/24 | R-b | R-b | ||
| 3/24 | R-b | |||
| 4/24 | R-b | |||
| 5/24 | R-b | |||
| 6/24 | ||||
| 7/24 | R-b | |||
| 8/24 | R-b | |||
| 9/24 | R-b | |||
| 10/24 | R-b | |||
| 11/24 | ||||
| 12/24 | R-b | |||
| 13/24 | R-b | |||
| 14/24 | R-b | |||
| 15/24 | R-b | R-b | ||
| 16/24 | R-b | |||
| 17/24 | ||||
| 18/24 | R-b | R-b | ||
| 19/24 | R-b | |||
| 20/24 | R-b | |||
| 21/24 | ||||
| 22/24 | R-b | |||
| 23/24 | ||||
| 24/24 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 00/24] include/exec: Rework (part 2)
Reordering exec/, second round. Mostly splitting:
- TCG LDST API (to "exec/cpu_ldst.h")
- CPU TLB APIs (to "exec/cputlb.h")
from "exec/cpu-all.h" and "exec/exec-all.h", and
reducing inclusions of "hw/core/cpu.h".
Based-on: <[email protected]> or https://gitlab.com/philmd/qemu/-/commits/exec-next
Philippe Mathieu-Daudé (24):
exec: Declare MMUAccessType type in 'mmu-access-type.h' header
exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h'
header
hw/core: Avoid including the full 'hw/core/cpu.h' in 'tcg-cpu-ops.h'
exec: Restrict TCG specific declarations of 'cputlb.h'
exec: Restrict 'cpu_ldst.h' to TCG accelerator
exec: Have guest_addr_valid() methods take abi_ptr/size_t arguments
exec: Un-inline tlb_vaddr_to_host() and declare it in 'exec/cputlb.h'
physmem: Move TCG CPU IOTLB methods around
physmem: Restrict TCG CPU IOTLB code to TCG accel
exec: Reduce tlb_set_dirty() declaration scope
exec: Move tlb_reset_dirty*() declarations to 'exec/cputlb.h'
exec: Move CPUTLBEntry helpers to cputlb.c
target/sparc: Replace abi_ulong by uint32_t for TARGET_ABI32
exec: Rename 'exec/user/guest-base.h' as 'user/guest-base.h'
exec: Restrict inclusion of 'user/guest-base.h'
exec: Move GUEST_ADDR_MAX definition to 'cpu_ldst.h'
exec: Include missing 'qemu/log-for-trace.h' header in 'exec/log.h'
plugins: Include missing 'qemu/bitmap.h' header
gdbstub: Avoid including 'cpu.h' in 'gdbstub/helpers.h' hw/xtensa: Include missing 'exec/cpu-common.h' in 'bootparam.h'
plugins: Un-inline qemu_plugin_disable_mem_helpers()
exec: Remove 'exec/tswap.h' from 'exec/cpu-all.h'
exec: Remove 'disas/disas.h' from 'exec/log.h'
exec: Remove unnecessary inclusions of 'hw/core/cpu.h'
hw/xtensa/bootparam.h | 3 + include/exec/breakpoint.h | 23 ++++++ include/exec/cpu-all.h | 39 +--------- include/exec/cpu-defs.h | 1 - include/exec/cpu_ldst.h | 122 ++++++++++--------------------- include/exec/cputlb.h | 58 ++++++++++++++- include/exec/exec-all.h | 26 +------ include/exec/log.h | 2 +- include/exec/mmu-access-type.h | 18 +++++ include/exec/ram_addr.h | 1 + include/exec/user/guest-base.h | 12 --- include/gdbstub/helpers.h | 3 +- include/hw/boards.h | 1 - include/hw/core/cpu.h | 24 +----- include/hw/core/tcg-cpu-ops.h | 6 +- include/hw/ppc/openpic.h | 1 - include/qemu/plugin.h | 7 +- include/sysemu/hw_accel.h | 1 - include/user/guest-base.h | 18 +++++ target/arm/internals.h | 1 + target/ppc/internal.h | 1 + target/riscv/debug.h | 2 + accel/stubs/tcg-stub.c | 4 - accel/tcg/cpu-exec.c | 1 - accel/tcg/cputlb.c | 53 +++++++++++++- accel/tcg/translator.c | 1 + accel/tcg/user-exec.c | 7 ++ bsd-user/main.c | 1 + hw/arm/boot.c | 1 + hw/arm/npcm7xx.c | 1 + hw/mips/fuloong2e.c | 1 + hw/mips/malta.c | 1 + hw/ppc/sam460ex.c | 1 + hw/ppc/spapr.c | 1 + hw/ppc/virtex_ml507.c | 1 + hw/sh4/r2d.c | 1 + linux-user/elfload.c | 1 + linux-user/main.c | 1 + plugins/core.c | 5 ++ system/physmem.c | 58 ++++++++------- target/arm/gdbstub.c | 1 + target/arm/tcg/helper-a64.c | 1 + target/avr/gdbstub.c | 1 + target/avr/translate.c | 1 + target/hexagon/translate.c | 1 + target/loongarch/tcg/translate.c | 1 + target/riscv/vector_helper.c | 1 + target/rx/translate.c | 1 + target/sparc/gdbstub.c | 2 +- target/sparc/mmu_helper.c | 1 + target/tricore/gdbstub.c | 1 + target/xtensa/xtensa-semi.c | 1 + tcg/tcg.c | 3 +- 53 files changed, 300 insertions(+), 226 deletions(-) create mode 100644 include/exec/breakpoint.h create mode 100644 include/exec/mmu-access-type.h delete mode 100644 include/exec/user/guest-base.h create mode 100644 include/user/guest-base.h
Signature · 1 line
2.41.0