Skip to content

ice: prepare representor for SF support

Michal Swiatkowski intel-wired-lan netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 6 repliesIn review
  2. v24 patches 5 repliesSuperseded
  3. v14 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ice: store representor ID in bridge portdrivers/net/ethernet/intel/ice/ice_eswitch_br.c drivers/net/ethernet/intel/ice/ice_eswitch_br.h drivers/net/ethernet/intel/ice/ice_repr.c +1 more+7 -61 reply
2/4ice: move devlink locking outside the port creationdrivers/net/ethernet/intel/ice/devlink/devlink.c drivers/net/ethernet/intel/ice/devlink/devlink_port.c drivers/net/ethernet/intel/ice/ice_eswitch.c +1 more+9 -81 reply
3/4ice: move VSI configuration outside repr setupdrivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_eswitch.h drivers/net/ethernet/intel/ice/ice_repr.c+57 -152 replies
4/4ice: update representor when VSI is readydrivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_eswitch.h drivers/net/ethernet/intel/ice/ice_vf_lib.c+17 -102 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchWojciech DrewekSimon Horman
1/4R-b R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [iwl-next v3 0/4] ice: prepare representor for SF support

Hi,

This is a series to prepare port representor for supporting also subfunctions. We need correct devlink locking and the possibility to update parent VSI after port representor is created.

Refactor how devlink lock is taken to suite the subfunction use case.

VSI configuration needs to be done after port representor is created. Port representor needs only allocated VSI. It doesn't need to be configured before.

VSI needs to be reconfigured when update function is called.

The code for this patchset was split from (too big) patchset [1].

v2 --> v3 [3]:
* delete ice_repr_get_by_vsi() from header
* rephrase commit message in moving devlink locking

v1 --> v2 [2]:
* add returns for kdoc in ice_eswitch_cfg_vsi

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/netdev/[email protected]/
[3] https://lore.kernel.org/netdev/[email protected]/

Michal Swiatkowski (4):
ice: store representor ID in bridge port
ice: move devlink locking outside the port creation
ice: move VSI configuration outside repr setup
ice: update representor when VSI is ready

 .../net/ethernet/intel/ice/devlink/devlink.c  |  2 -
 .../ethernet/intel/ice/devlink/devlink_port.c |  4 +-
 drivers/net/ethernet/intel/ice/ice_eswitch.c  | 85 +++++++++++++------
 drivers/net/ethernet/intel/ice/ice_eswitch.h  | 14 ++-
 .../net/ethernet/intel/ice/ice_eswitch_br.c   |  4 +-
 .../net/ethernet/intel/ice/ice_eswitch_br.h   |  1 +
 drivers/net/ethernet/intel/ice/ice_repr.c     | 16 ++--
 drivers/net/ethernet/intel/ice/ice_repr.h     |  1 +
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  2 +-
 9 files changed, 90 insertions(+), 39 deletions(-)
Signature · 1 line
2.42.0