Skip to content

RISC-V: ACPI: Namespace updates

Sunil V L qemu-devel qemu-riscv 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 0 repliesNew
  2. v39 patches 4 repliesSuperseded
  3. v29 patches 17 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches7 repliesSuperseded

Changes in v4 from the cover letter

1) Provided link to PDF of the BRS spec instead of source file + commit id.
2) Updated tags.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIChw/riscv/virt-acpi-build.c+32 -00 replies
2/9hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UARThw/riscv/virt-acpi-build.c+1 -10 replies
3/9tests/acpi: Allow DSDT acpi table changes for aarch64tests/qtest/bios-tables-test-allowed-diff.h+6 -00 replies
4/9acpi/gpex: Create PCI link devices outside PCI root bridgehw/pci-host/gpex-acpi.c+7 -60 replies
5/9tests/acpi: update expected DSDT blob for aarch64 and microvmtests/data/acpi/aarch64/virt/DSDT tests/data/acpi/aarch64/virt/DSDT.acpihmatvirt tests/data/acpi/aarch64/virt/DSDT.memhp +4 more+0 -60 replies
6/9tests/qtest/bios-tables-test.c: Remove the fall back pathtests/qtest/bios-tables-test.c+0 -140 replies
7/9tests/acpi: Add empty ACPI data files for RISC-Vtests/data/acpi/riscv64/virt/APIC tests/data/acpi/riscv64/virt/DSDT tests/data/acpi/riscv64/virt/FACP +4 more+6 -00 replies
8/9tests/qtest/bios-tables-test.c: Enable basic testing for RISC-Vtests/qtest/bios-tables-test.c+26 -00 replies
9/9tests/acpi: Add expected ACPI AML files for RISC-Vtests/data/acpi/riscv64/virt/APIC tests/data/acpi/riscv64/virt/DSDT tests/data/acpi/riscv64/virt/FACP +4 more+0 -60 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchIgor MammedovAlistair Francis
1/9A-b A-b
2/9R-b A-b
3/9R-b
4/9A-b
5/9
6/9R-b A-b
7/9R-b A-b
8/9R-b R-b
9/9A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] RISC-V: ACPI: Namespace updates

This series adds few updates to RISC-V ACPI namespace for virt platform. Additionally, it has patches to enable ACPI table testing for RISC-V.

1) PCI Link devices need to be created outside the scope of the PCI root complex to ensure correct probe ordering by the OS. This matches the example given in ACPI spec as well.

2) Add PLIC and APLIC as platform devices as well to ensure probing order as per BRS spec [1] requirement.

3) BRS spec requires RISC-V to use new ACPI ID for the generic UART. So, update the HID of the UART.

4) Enabled ACPI tables tests for RISC-V which were originally part of
[2] but couldn't get merged due to updates required in the expected AML files. I think combining those patches with this series makes it easier to merge since expected AML files are updated.

[1] - https://github.com/riscv-non-isa/riscv-brs/releases/download/v0.0.2/riscv-brs-spec.pdf (Chapter 6)
[2] - https://lists.gnu.org/archive/html/qemu-devel/2024-06/msg04734.html

Changes since v3:
1) Provided link to PDF of the BRS spec instead of source file + commit id.
2) Updated tags.

Changes since v2:
1) Updated commit message with exact requirement in the BRS.
2) Addressed Igor's comments.
3) Rebased and updated tags.

Changes since v1:
1) Made changes in gpex-acpi.c generic as per feedback from Michael. This changes the DSDT for aarch64/virt and microvm machines. Hence, few patches are added to update the expected DSDT files for those machine so that CI tests don't fail.
2) Added patches to enable ACPI tables tests for RISC-V including a patch to remove the fallback path to search for expected AML files.
3) Rebased and added tags.

Sunil V L (9):
hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART tests/acpi: Allow DSDT acpi table changes for aarch64 acpi/gpex: Create PCI link devices outside PCI root bridge tests/acpi: update expected DSDT blob for aarch64 and microvm tests/qtest/bios-tables-test.c: Remove the fall back path tests/acpi: Add empty ACPI data files for RISC-V tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V tests/acpi: Add expected ACPI AML files for RISC-V

 hw/pci-host/gpex-acpi.c                       |  13 +++---
 hw/riscv/virt-acpi-build.c                    |  34 ++++++++++++++-
 tests/data/acpi/aarch64/virt/DSDT             | Bin 5196 -> 5196 bytes
 .../data/acpi/aarch64/virt/DSDT.acpihmatvirt  | Bin 5282 -> 5282 bytes
 tests/data/acpi/aarch64/virt/DSDT.memhp       | Bin 6557 -> 6557 bytes
 tests/data/acpi/aarch64/virt/DSDT.pxb         | Bin 7679 -> 7679 bytes
 tests/data/acpi/aarch64/virt/DSDT.topology    | Bin 5398 -> 5398 bytes
 tests/data/acpi/riscv64/virt/APIC             | Bin 0 -> 116 bytes
 tests/data/acpi/riscv64/virt/DSDT             | Bin 0 -> 3576 bytes
 tests/data/acpi/riscv64/virt/FACP             | Bin 0 -> 276 bytes
 tests/data/acpi/riscv64/virt/MCFG             | Bin 0 -> 60 bytes
 tests/data/acpi/riscv64/virt/RHCT             | Bin 0 -> 332 bytes
 tests/data/acpi/riscv64/virt/SPCR             | Bin 0 -> 80 bytes
 tests/data/acpi/x86/microvm/DSDT.pcie         | Bin 3023 -> 3023 bytes
 tests/qtest/bios-tables-test.c                |  40 ++++++++++++------
 15 files changed, 66 insertions(+), 21 deletions(-)
 create mode 100644 tests/data/acpi/riscv64/virt/APIC
 create mode 100644 tests/data/acpi/riscv64/virt/DSDT
 create mode 100644 tests/data/acpi/riscv64/virt/FACP
 create mode 100644 tests/data/acpi/riscv64/virt/MCFG
 create mode 100644 tests/data/acpi/riscv64/virt/RHCT
 create mode 100644 tests/data/acpi/riscv64/virt/SPCR
Signature · 1 line
2.43.0