Skip to content

vdpa: support set mac address from vdpa tool

Cindy Lu lkml netdev virtualization 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest3 patches 3 repliesIn review
  2. v73 patches 6 repliesSuperseded
  3. v63 patches 7 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v53 patches12 repliesSuperseded
v43 patches11 repliesSuperseded
v32 patches12 repliesSuperseded
v22 patches3 repliesSuperseded
v12 patches25 repliesSuperseded

Changes in v8 from the cover letter

- Change the fail return value to -EOPNOTSUPP
- Improve the error log
- remove the unnecessary memcpy

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3vdpa: support set mac address from vdpa tooldrivers/vdpa/vdpa.c include/linux/vdpa.h include/uapi/linux/vdpa.h+89 -01 reply
2/3vdpa_sim_net: Add the support of set mac addressdrivers/vdpa/vdpa_sim/vdpa_sim_net.c+20 -11 reply
3/3vdpa/mlx5: Add the support of set mac addressdrivers/vdpa/mlx5/net/mlx5_vnet.c+28 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJason Wang
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/3] vdpa: support set mac address from vdpa tool

Add support for setting the MAC address using the VDPA tool. This feature will allow setting the MAC address using the VDPA tool. For example, in vdpa_sim_net, the implementation sets the MAC address to the config space. However, for other drivers, they can implement their own function, not limited to the config space.

Changelog v2
- Changed the function name to prevent misunderstanding
- Added check for blk device
- Addressed the comments
Changelog v3
- Split the function of the net device from vdpa_nl_cmd_dev_attr_set_doit
- Add a lock for the network device's dev_set_attr operation
- Address the comments
Changelog v4
- Address the comments
- Add a lock for the vdap_sim?_net device's dev_set_attr operation
Changelog v5
- Address the comments
Changelog v6
- Replace all the memcpy of mac address with ether_addr_copy()
- Remove the check for VIRTIO_NET_F_MAC in vdpa_dev_net_device_attr_set
- Remove unnecessary check
- Enhance the error log
Changelog v7
- change the code to reverse-xmas tree style
- make all patches pass the check of ./scripts/checkpatch.pl --strict
- Address other comments
Changelog v8
- Change the fail return value to -EOPNOTSUPP
- Improve the error log
- remove the unnecessary memcpy

Cindy Lu (3):
vdpa: support set mac address from vdpa tool
vdpa_sim_net: Add the support of set mac address vdpa/mlx5: Add the support of set mac address

 drivers/vdpa/mlx5/net/mlx5_vnet.c    | 28 ++++++++++
 drivers/vdpa/vdpa.c                  | 79 ++++++++++++++++++++++++++++
 drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 21 +++++++-
 include/linux/vdpa.h                 |  9 ++++
 include/uapi/linux/vdpa.h            |  1 +
 5 files changed, 137 insertions(+), 1 deletion(-)
Signature · 1 line
2.45.0